In /usr/bin/hwloc-compress-dir line 21: echo $@ 2>&1 ^-- SC2068: Double quote array expansions to avoid re-splitting elements. In /usr/bin/hwloc-compress-dir line 63: test x`echo $inputdir | sed -e 's/^\///'` = x$inputdir && inputdir="$PWD/$inputdir" ^-- SC2046: Quote this to prevent word splitting. ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^-------^ SC2086: Double quote to prevent globbing and word splitting. ^-------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: test x$(echo "$inputdir" | sed -e 's/^\///') = x"$inputdir" && inputdir="$PWD/$inputdir" In /usr/bin/hwloc-compress-dir line 65: test x`echo $outputdir | sed -e 's/^\///'` = x$outputdir && outputdir="$PWD/$outputdir" ^-- SC2046: Quote this to prevent word splitting. ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^--------^ SC2086: Double quote to prevent globbing and word splitting. ^--------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: test x$(echo "$outputdir" | sed -e 's/^\///') = x"$outputdir" && outputdir="$PWD/$outputdir" In /usr/bin/hwloc-compress-dir line 80: inputs=`ls -1 "$inputdir"` ^-----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: inputs=$(ls -1 "$inputdir") In /usr/bin/hwloc-compress-dir line 82: name=`echo $input | sed -e 's/.xml$//'` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: name=$(echo "$input" | sed -e 's/.xml$//') In /usr/bin/hwloc-compress-dir line 90: alreadynoncompressed=`expr $alreadynoncompressed + 1` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: alreadynoncompressed=$(expr $alreadynoncompressed + 1) In /usr/bin/hwloc-compress-dir line 95: alreadycompressed=`expr $alreadycompressed + 1` ^---------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: alreadycompressed=$(expr $alreadycompressed + 1) In /usr/bin/hwloc-compress-dir line 100: outputs=`ls -1 "$outputdir"` ^------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: outputs=$(ls -1 "$outputdir") In /usr/bin/hwloc-compress-dir line 102: outputname=`echo $output | sed -e 's/.xml$//' | sed -e 's/.diff$//'` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^-----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: outputname=$(echo "$output" | sed -e 's/.xml$//' | sed -e 's/.diff$//') In /usr/bin/hwloc-compress-dir line 107: newlycompressed=`expr $newlycompressed + 1` ^-------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: newlycompressed=$(expr $newlycompressed + 1) In /usr/bin/hwloc-compress-dir line 115: newlynoncompressed=`expr $newlynoncompressed + 1` ^----------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: newlynoncompressed=$(expr $newlynoncompressed + 1) In /usr/bin/hwloc-compress-dir line 130: inputs=`ls -1 "$inputdir"` ^-----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: inputs=$(ls -1 "$inputdir") In /usr/bin/hwloc-compress-dir line 133: name=`echo $input | sed -e 's/.xml$//' | sed -e 's/.diff$//'` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: name=$(echo "$input" | sed -e 's/.xml$//' | sed -e 's/.diff$//') In /usr/bin/hwloc-compress-dir line 141: alreadyuncompressed=`expr $alreadyuncompressed + 1` ^-----------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: alreadyuncompressed=$(expr $alreadyuncompressed + 1) In /usr/bin/hwloc-compress-dir line 149: newlynoncompressed=`expr $newlynoncompressed + 1` ^----------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: newlynoncompressed=$(expr $newlynoncompressed + 1) In /usr/bin/hwloc-compress-dir line 152: if (cd $outputdir && $localhwlocpatch refname "$inputdir/${name}.diff.xml" "${name}.xml"); then ^--------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if (cd "$outputdir" && $localhwlocpatch refname "$inputdir/${name}.diff.xml" "${name}.xml"); then In /usr/bin/hwloc-compress-dir line 154: newlyuncompressed=`expr $newlyuncompressed + 1` ^---------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2003: expr is antiquated. Consider rewriting this using $((..)), ${} or [[ ]]. Did you mean: newlyuncompressed=$(expr $newlyuncompressed + 1) For more information: https://www.shellcheck.net/wiki/SC2068 -- Double quote array expansions to ... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt... https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...