In /usr/bin/jh_depends line 3: MINJARWRAPPERVER=0.5 ^--------------^ SC2034: MINJARWRAPPERVER appears unused. Verify use (or export if used externally). In /usr/bin/jh_depends line 5: . /usr/share/javahelper/jh_lib.sh ^-----------------------------^ SC1091: Not following: /usr/share/javahelper/jh_lib.sh was not specified as input (see shellcheck -x). In /usr/bin/jh_depends line 37: for i in `find "$classes" -name "*.class"`; do ^-- SC2044: For loops over find output are fragile. Use find -exec or a while read loop. ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: for i in $(find "$classes" -name "*.class"); do In /usr/bin/jh_depends line 39: if (( $current < $new )); then ^------^ SC2004: $/${} is unnecessary on arithmetic variables. ^--^ SC2004: $/${} is unnecessary on arithmetic variables. In /usr/bin/jh_depends line 43: echo $current ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "$current" In /usr/bin/jh_depends line 71: if echo $JHOME | grep headless >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep headless >/dev/null; then In /usr/bin/jh_depends line 74: if echo $JHOME | grep default >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep default >/dev/null; then In /usr/bin/jh_depends line 77: if echo $JHOME | grep 6-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 6-openjdk >/dev/null; then In /usr/bin/jh_depends line 80: if echo $JHOME | grep 7-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 7-openjdk >/dev/null; then In /usr/bin/jh_depends line 83: if echo $JHOME | grep 8-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 8-openjdk >/dev/null; then In /usr/bin/jh_depends line 86: if echo $JHOME | grep 9-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 9-openjdk >/dev/null; then In /usr/bin/jh_depends line 89: if echo $JHOME | grep 10-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 10-openjdk >/dev/null; then In /usr/bin/jh_depends line 92: if echo $JHOME | grep 11-openjdk >/dev/null; then ^----^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if echo "$JHOME" | grep 11-openjdk >/dev/null; then In /usr/bin/jh_depends line 100: VERBOSE="`getarg v verbose`" ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: VERBOSE="$(getarg v verbose)" In /usr/bin/jh_depends line 104: TEMPDIR=`mktemp -d` ^---------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: TEMPDIR=$(mktemp -d) In /usr/bin/jh_depends line 105: OLDDIR=`pwd` ^---^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: OLDDIR=$(pwd) In /usr/bin/jh_depends line 109: EXCLUDES="`getarg X exclude`" ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: EXCLUDES="$(getarg X exclude)" In /usr/bin/jh_depends line 111: PACKAGES=`findpackages` ^------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: PACKAGES=$(findpackages) In /usr/bin/jh_depends line 114: PACKAGEDIR="`getarg P tmpdir`" ^---------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: PACKAGEDIR="$(getarg P tmpdir)" In /usr/bin/jh_depends line 116: PACKAGEDIR="`pwd`/debian/$p" ^---^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: PACKAGEDIR="$(pwd)/debian/$p" In /usr/bin/jh_depends line 118: PACKAGEDIR="`readlink -f $PACKAGEDIR`" ^-----------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: PACKAGEDIR="$(readlink -f "$PACKAGEDIR")" In /usr/bin/jh_depends line 131: JARS=`find $PACKAGEDIR -type f -a -name '*.jar'` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: JARS=$(find "$PACKAGEDIR" -type f -a -name '*.jar') In /usr/bin/jh_depends line 134: echo "Searching" $JARS ^---^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "Searching" "$JARS" In /usr/bin/jh_depends line 137: [ -n "$TEMPDIR" ] && rm -rf "$TEMPDIR/"* ^----------^ SC2115: Use "${var:?}" to ensure this never expands to /* . In /usr/bin/jh_depends line 147: classversion=`getclassversion $classversion .` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: classversion=$(getclassversion $classversion .) In /usr/bin/jh_depends line 148: JARDEPS="$JARDEPS `extractline META-INF/MANIFEST.MF Class-Path`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: JARDEPS="$JARDEPS $(extractline META-INF/MANIFEST.MF Class-Path)" In /usr/bin/jh_depends line 150: JHOME="`extractline META-INF/MANIFEST.MF Debian-Java-Home`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: JHOME="$(extractline META-INF/MANIFEST.MF Debian-Java-Home)" In /usr/bin/jh_depends line 151: JVM="`home-to-jvm "$JHOME"`" ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: JVM="$(home-to-jvm "$JHOME")" In /usr/bin/jh_depends line 153: [ -n "$TEMPDIR" ] && rm -rf "$TEMPDIR/"* ^----------^ SC2115: Use "${var:?}" to ensure this never expands to /* . In /usr/bin/jh_depends line 155: JARDEPS=`echo $JARDEPS | xargs -n1 | LC_ALL=C sort -u` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: JARDEPS=$(echo "$JARDEPS" | xargs -n1 | LC_ALL=C sort -u) In /usr/bin/jh_depends line 158: echo "Found Jars:" $JARDEPS ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "Found Jars:" "$JARDEPS" In /usr/bin/jh_depends line 168: realjar="`readlink -f "$i"`" ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: realjar="$(readlink -f "$i")" In /usr/bin/jh_depends line 170: realjar="`readlink -f "/usr/share/java/$i"`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: realjar="$(readlink -f "/usr/share/java/$i")" In /usr/bin/jh_depends line 178: echo "Checking: " $OLDDIR/debian/$j$realjar ^-----^ SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "Checking: " "$OLDDIR"/debian/"$j""$realjar" In /usr/bin/jh_depends line 180: if [ -f $OLDDIR/debian/$j$realjar ]; then ^-----^ SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ -f "$OLDDIR"/debian/"$j""$realjar" ]; then In /usr/bin/jh_depends line 194: DEBDEPS="$DEBDEPS `dpkg -S $NEWJARDEPS 2>/dev/null | grep -v ^$p: | cut -d: -f1 | LC_ALL=C sort -u`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^---------^ SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. Did you mean: DEBDEPS="$DEBDEPS $(dpkg -S "$NEWJARDEPS" 2>/dev/null | grep -v ^"$p": | cut -d: -f1 | LC_ALL=C sort -u)" In /usr/bin/jh_depends line 208: echo "Found Debs:" $DEBDEPS ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "Found Debs:" "$DEBDEPS" In /usr/bin/jh_depends line 214: if [ -n "`getarg j jvm`" ]; then ^------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg j jvm)" ]; then In /usr/bin/jh_depends line 215: JVM="`getarg j jvm`" ^------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: JVM="$(getarg j jvm)" In /usr/bin/jh_depends line 220: JVM="`home-to-jvm "$JAVA_HOME"`" ^------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: JVM="$(home-to-jvm "$JAVA_HOME")" In /usr/bin/jh_depends line 229: JVM=`echo $JVM | sed s/headless//g` ^-----------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^---------------------------^ SC2001: See if you can use ${variable//search/replace} instead. Did you mean: JVM=$(echo $JVM | sed s/headless//g) In /usr/bin/jh_depends line 231: [ -z "`echo $JVM | sed s/\s*//g`" ] && JVM="default" ^------------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^----------------------^ SC2001: See if you can use ${variable//search/replace} instead. ^--^ SC2086: Double quote to prevent globbing and word splitting. ^-- SC1001: This \s will be a regular 's' in this context. Did you mean: [ -z "$(echo "$JVM" | sed s/\s*//g)" ] && JVM="default" In /usr/bin/jh_depends line 234: alternateversiondeps=`getalternatedepends $classversion $headless` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: alternateversiondeps=$(getalternatedepends "$classversion" $headless) In /usr/bin/jh_depends line 277: API=`find "$PACKAGEDIR/usr/share/doc" -type f -name 'package-list' -exec dirname {} \;` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: API=$(find "$PACKAGEDIR/usr/share/doc" -type f -name 'package-list' -exec dirname {} \;) In /usr/bin/jh_depends line 278: DOC_REC=`/usr/share/javahelper/jh_scanjavadoc $API` ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^--^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: DOC_REC=$(/usr/share/javahelper/jh_scanjavadoc "$API") In /usr/bin/jh_depends line 285: echo "Adding substvars:" "java:Depends=$JVMDEPS`echo $DEBDEPS | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//'`" \ ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "Adding substvars:" "java:Depends=$JVMDEPS$(echo "$DEBDEPS" | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//')" \ In /usr/bin/jh_depends line 289: if [ -z "`getarg n no-act`" ]; then ^---------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -z "$(getarg n no-act)" ]; then In /usr/bin/jh_depends line 290: echo "java:Depends=$JVMDEPS`echo $DEBDEPS | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//'`" >> debian/$p.substvars ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^------^ SC2086: Double quote to prevent globbing and word splitting. ^-- SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "java:Depends=$JVMDEPS$(echo "$DEBDEPS" | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//')" >> debian/"$p".substvars In /usr/bin/jh_depends line 291: echo "java:Recommends=$DOC_REC" >> debian/$p.substvars ^-- SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "java:Recommends=$DOC_REC" >> debian/"$p".substvars In /usr/bin/jh_depends line 293: echo "java:Depends=$JVMDEPS`echo $DEBDEPS | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//'`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "java:Depends=$JVMDEPS$(echo "$DEBDEPS" | sed 's/\([a-zA-Z0-9_.+-]*\( *([^)]*)\)\{0,1\}\)/\1, /g;s/, *$//')" For more information: https://www.shellcheck.net/wiki/SC2034 -- MINJARWRAPPERVER appears unused. ... https://www.shellcheck.net/wiki/SC2044 -- For loops over find output are fr... https://www.shellcheck.net/wiki/SC2115 -- Use "${var:?}" to ensure this nev...