In /usr/bin/jh_makepkg line 12: . /usr/share/javahelper/jh_lib.sh ^-----------------------------^ SC1091: Not following: /usr/share/javahelper/jh_lib.sh was not specified as input (see shellcheck -x). In /usr/bin/jh_makepkg line 50: BUILDDIR="`pwd`" ^---^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: BUILDDIR="$(pwd)" In /usr/bin/jh_makepkg line 52: if [ -z "`getarg v upstream`" ]; then ^-----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -z "$(getarg v upstream)" ]; then In /usr/bin/jh_makepkg line 53: VERSION="`basename "$BUILDDIR" | sed -n 's/^.*-//p'`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: VERSION="$(basename "$BUILDDIR" | sed -n 's/^.*-//p')" In /usr/bin/jh_makepkg line 55: VERSION="`getarg v upstream`" ^-----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: VERSION="$(getarg v upstream)" In /usr/bin/jh_makepkg line 57: if [ -z "`getarg p package`" ]; then ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -z "$(getarg p package)" ]; then In /usr/bin/jh_makepkg line 58: PACKAGE="`basename "$BUILDDIR" | sed -n 's/\(-.*\)\{0,1\}$//p'`" ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: PACKAGE="$(basename "$BUILDDIR" | sed -n 's/\(-.*\)\{0,1\}$//p')" In /usr/bin/jh_makepkg line 60: PACKAGE="`getarg p package`" ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: PACKAGE="$(getarg p package)" In /usr/bin/jh_makepkg line 64: echo "Can't determine version from directory name `basename "$BUILDDIR"`, maybe it is not in the form package-version?" ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: echo "Can't determine version from directory name $(basename "$BUILDDIR"), maybe it is not in the form package-version?" In /usr/bin/jh_makepkg line 69: echo "Can't determine package name from directory name `basename "$BUILDDIR"`, maybe it is not in the form package-version?" ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: echo "Can't determine package name from directory name $(basename "$BUILDDIR"), maybe it is not in the form package-version?" In /usr/bin/jh_makepkg line 73: if [ ! -f ../${PACKAGE}_${VERSION}.orig.tar.gz ]; then ^--------^ SC2086: Double quote to prevent globbing and word splitting. ^--------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if [ ! -f ../"${PACKAGE}"_"${VERSION}".orig.tar.gz ]; then In /usr/bin/jh_makepkg line 75: if [ -n "`getarg c clean`" ]; then ^--------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg c clean)" ]; then In /usr/bin/jh_makepkg line 81: for doctree in `find . -name allclasses-frame.html`; do ^-- SC2044: For loops over find output are fragile. Use find -exec or a while read loop. ^-- SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: for doctree in $(find . -name allclasses-frame.html); do In /usr/bin/jh_makepkg line 82: TREE="`dirname $doctree`" ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: TREE="$(dirname "$doctree")" In /usr/bin/jh_makepkg line 83: rm -rf "$TREE"/* ^-------^ SC2115: Use "${var:?}" to ensure this never expands to /* . In /usr/bin/jh_makepkg line 85: find * -type d -print0 | xargs -0 rmdir -p --ignore-fail-on-non-empty ^-- SC2035: Use ./*glob* or -- *glob* so names with dashes won't become options. In /usr/bin/jh_makepkg line 94: tar zcf "${PACKAGE}_${VERSION}.orig.tar.gz" "`basename "$BUILDDIR"`" ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: tar zcf "${PACKAGE}_${VERSION}.orig.tar.gz" "$(basename "$BUILDDIR")" In /usr/bin/jh_makepkg line 99: if [ -n "`getarg e email`" ]; then ^--------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg e email)" ]; then In /usr/bin/jh_makepkg line 100: DEBEMAIL="`getarg e email`" ^--------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: DEBEMAIL="$(getarg e email)" In /usr/bin/jh_makepkg line 108: DEBEMAIL="`whoami`@`cat /etc/mailname`" ^------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^-----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: DEBEMAIL="$(whoami)@$(cat /etc/mailname)" In /usr/bin/jh_makepkg line 112: DEBEMAIL="`whoami`@`hostname --fqdn`" ^------^ SC2006: Use $(...) notation instead of legacy backticked `...`. ^---------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: DEBEMAIL="$(whoami)@$(hostname --fqdn)" In /usr/bin/jh_makepkg line 115: if [ -n "`getarg m maintainer`" ]; then ^-------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg m maintainer)" ]; then In /usr/bin/jh_makepkg line 116: DEBFULLNAME="`getarg m maintainer`" ^-------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: DEBFULLNAME="$(getarg m maintainer)" In /usr/bin/jh_makepkg line 124: DEBFULLNAME="$(getent passwd $(whoami) | cut -d: -f5 | cut -d, -f1)" ^-------^ SC2046: Quote this to prevent word splitting. In /usr/bin/jh_makepkg line 130: if [ -n "`getarg a app`" ]; then ^------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg a app)" ]; then In /usr/bin/jh_makepkg line 132: elif [ -n "`getarg l library`" ]; then ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg l library)" ]; then In /usr/bin/jh_makepkg line 140: read t ^--^ SC2162: read without -r will mangle backslashes. In /usr/bin/jh_makepkg line 163: if ! echo $BINPACKAGE | grep "^lib" >/dev/null; then ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if ! echo "$BINPACKAGE" | grep "^lib" >/dev/null; then In /usr/bin/jh_makepkg line 166: if ! echo $BINPACKAGE | grep -- "-java$" >/dev/null; then ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: if ! echo "$BINPACKAGE" | grep -- "-java$" >/dev/null; then In /usr/bin/jh_makepkg line 172: if [ -n "`getarg t ant`" ]; then ^------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg t ant)" ]; then In /usr/bin/jh_makepkg line 174: elif [ -n "`getarg k makefiles`" ]; then ^------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg k makefiles)" ]; then In /usr/bin/jh_makepkg line 176: elif [ -n "`getarg n none`" ]; then ^-------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg n none)" ]; then In /usr/bin/jh_makepkg line 185: read t ^--^ SC2162: read without -r will mangle backslashes. In /usr/bin/jh_makepkg line 212: if [ -n "`getarg d default`" ]; then ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: if [ -n "$(getarg d default)" ]; then In /usr/bin/jh_makepkg line 214: elif [ -n "`getarg o openjdk`" ]; then ^----------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o openjdk)" ]; then In /usr/bin/jh_makepkg line 216: elif [ -n "`getarg o7 openjdk7`" ]; then ^------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o7 openjdk7)" ]; then In /usr/bin/jh_makepkg line 218: elif [ -n "`getarg o8 openjdk8`" ]; then ^------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o8 openjdk8)" ]; then In /usr/bin/jh_makepkg line 220: elif [ -n "`getarg o9 openjdk9`" ]; then ^------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o9 openjdk9)" ]; then In /usr/bin/jh_makepkg line 222: elif [ -n "`getarg o10 openjdk10`" ]; then ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o10 openjdk10)" ]; then In /usr/bin/jh_makepkg line 224: elif [ -n "`getarg o11 openjdk11`" ]; then ^--------------------^ SC2006: Use $(...) notation instead of legacy backticked `...`. Did you mean: elif [ -n "$(getarg o11 openjdk11)" ]; then In /usr/bin/jh_makepkg line 237: read t ^--^ SC2162: read without -r will mangle backslashes. In /usr/bin/jh_makepkg line 304: JVM=open11 ^-^ SC2034: JVM appears unused. Verify use (or export if used externally). In /usr/bin/jh_makepkg line 368: EDITOR=true DEBFULLNAME="$DEBFULLNAME" DEBEMAIL="$DEBEMAIL" dch --create --package $SRCPACKAGE --newversion ${VERSION}-1 --distribution unstable --urgency low ^---------^ SC2086: Double quote to prevent globbing and word splitting. ^--------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: EDITOR=true DEBFULLNAME="$DEBFULLNAME" DEBEMAIL="$DEBEMAIL" dch --create --package "$SRCPACKAGE" --newversion "${VERSION}"-1 --distribution unstable --urgency low In /usr/bin/jh_makepkg line 389: echo ${SRCPACKAGE}.jar src > debian/javabuild ^-----------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "${SRCPACKAGE}".jar src > debian/javabuild In /usr/bin/jh_makepkg line 395: echo "$SRCPACKAGE.jar usr/share/$BINPACKAGE" > debian/$BINPACKAGE.install ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "$SRCPACKAGE.jar usr/share/$BINPACKAGE" > debian/"$BINPACKAGE".install In /usr/bin/jh_makepkg line 396: cat >> debian/$BINPACKAGE.manifest <<END ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: cat >> debian/"$BINPACKAGE".manifest <<END In /usr/bin/jh_makepkg line 401: echo "usr/share/$BINPACKAGE/$SRCPACKAGE.jar usr/bin/$SRCPACKAGE" > debian/$BINPACKAGE.links ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "usr/share/$BINPACKAGE/$SRCPACKAGE.jar usr/bin/$SRCPACKAGE" > debian/"$BINPACKAGE".links In /usr/bin/jh_makepkg line 404: echo "$SRCPACKAGE.jar" > debian/$BINPACKAGE.jlibs ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "$SRCPACKAGE.jar" > debian/"$BINPACKAGE".jlibs In /usr/bin/jh_makepkg line 406: echo "internal" > debian/$BINPACKAGE-doc.javadoc ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "internal" > debian/"$BINPACKAGE"-doc.javadoc In /usr/bin/jh_makepkg line 408: echo "<javadoc build dir here>" > debian/$BINPACKAGE-doc.javadoc ^---------^ SC2086: Double quote to prevent globbing and word splitting. Did you mean: echo "<javadoc build dir here>" > debian/"$BINPACKAGE"-doc.javadoc For more information: https://www.shellcheck.net/wiki/SC2034 -- JVM appears unused. Verify use (o... https://www.shellcheck.net/wiki/SC2044 -- For loops over find output are fr... https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...