Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/aldo-0.7.8/src/astream.cc Examining data/aldo-0.7.8/src/audioworkspace.cc Examining data/aldo-0.7.8/src/blocks.cc Examining data/aldo-0.7.8/src/blocks_exc.cc Examining data/aldo-0.7.8/src/check.cc Examining data/aldo-0.7.8/src/datafile.cc Examining data/aldo-0.7.8/src/keyer.cc Examining data/aldo-0.7.8/src/koch.cc Examining data/aldo-0.7.8/src/koch_exc.cc Examining data/aldo-0.7.8/src/main.cc Examining data/aldo-0.7.8/src/menu.cc Examining data/aldo-0.7.8/src/option.cc Examining data/aldo-0.7.8/src/qrz.cc Examining data/aldo-0.7.8/src/qrz_exc.cc Examining data/aldo-0.7.8/src/random.cc Examining data/aldo-0.7.8/src/section.cc Examining data/aldo-0.7.8/src/textfile.cc Examining data/aldo-0.7.8/src/textfile_exc.cc Examining data/aldo-0.7.8/src/wave.cc Examining data/aldo-0.7.8/src/setup.cc FINAL RESULTS: data/aldo-0.7.8/src/datafile.cc:36:46: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. Datafile::Datafile(const string& name, const access& a = Read): m_opened(false), m_filename(name), m_access(a) data/aldo-0.7.8/src/blocks_exc.cc:46:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/koch_exc.cc:45:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/main.cc:115:31: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. std::string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/qrz_exc.cc:45:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/random.cc:39:5: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(m_seed); data/aldo-0.7.8/src/setup.cc:49:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/setup.cc:205:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/textfile_exc.cc:42:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. string fileconf_name(getenv("HOME")); data/aldo-0.7.8/src/datafile.cc:40:6: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). open(); data/aldo-0.7.8/src/datafile.cc:54:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). void Datafile::open() data/aldo-0.7.8/src/setup.cc:107:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). tmpint = (unsigned int)atoi(tmpstr.c_str()); data/aldo-0.7.8/src/blocks_exc.cc:73:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). cout<<msg_strlen<<strlen<<endl; data/aldo-0.7.8/src/blocks_exc.cc:79:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). libexercises::Blocks blocks_exc(strnum, skill, strlen); data/aldo-0.7.8/src/koch_exc.cc:73:48: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). libexercises::Koch koch_exc(chars, strnum, strlen, skill, next_difficulty); data/aldo-0.7.8/src/koch_exc.cc:108:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). koch_sec->option("StringLength")->set(koch_exc.strlen()); data/aldo-0.7.8/src/qrz.cc:84:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). out << exc.get_string().substr(i* strlen, strlen); data/aldo-0.7.8/src/qrz.cc:84:44: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). out << exc.get_string().substr(i* strlen, strlen); ANALYSIS SUMMARY: Hits = 18 Lines analyzed = 3127 in approximately 0.10 seconds (32597 lines/second) Physical Source Lines of Code (SLOC) = 1917 Hits@level = [0] 0 [1] 6 [2] 3 [3] 8 [4] 1 [5] 0 Hits@level+ = [0+] 18 [1+] 18 [2+] 12 [3+] 9 [4+] 1 [5+] 0 Hits/KSLOC@level+ = [0+] 9.38967 [1+] 9.38967 [2+] 6.25978 [3+] 4.69484 [4+] 0.521648 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.