Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_apicheck.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_apicheck.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_cpp.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_cpp.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_cpp_common.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_cpp_common.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_java.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_java.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_ndk.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_to_ndk.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_typenames.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_typenames.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_cpp.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_cpp.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_cpp_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_java.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_java.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/ast_java_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/code_writer.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/code_writer.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/code_writer_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_aidl_mappings.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_aidl_mappings.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_java.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_java.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_java_binder.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_ndk.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/generate_ndk.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/import_resolver.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/import_resolver.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/line_reader.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/line_reader.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/logging.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/main.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/main_cpp.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/options.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/options_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/os.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_defaultimpl.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_defaultimpl.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_file_descriptors.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_file_descriptors.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_nullables.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_nullables.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_parcelables.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_parcelables.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_primitives.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_primitives.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_service_exceptions.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_service_exceptions.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_utf8_strings.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_utf8_strings.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_sentinel_searcher.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_service.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/end_to_end_tests.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/fake_io_delegate.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/fake_io_delegate.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/main.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/simple_parcelable.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/simple_parcelable.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_data.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_data_example_interface.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_data_ping_responder.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_data_string_constants.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_helpers.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_util.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/tests/test_util.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_cpp.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_cpp.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_cpp_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_java.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_java.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_java_unittest.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_namespace.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/type_namespace.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/options.cpp
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.h
Examining data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.cpp
FINAL RESULTS:
data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.cpp:660:21: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define YYFPRINTF fprintf
data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.cpp:118:16: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
return (0 == access(path.c_str(), R_OK));
data/android-platform-system-tools-aidl-10.0.0+r36/options.cpp:180:19: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
const int c = getopt_long(argc, const_cast<char* const*>(argv),
data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.cpp:2766:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char const *yyarg[YYERROR_VERBOSE_ARGS_MAXIMUM];
data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.cpp:49:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.cpp:71:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/android-platform-system-tools-aidl-10.0.0+r36/line_reader.cpp:38:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
input_stream_.open(file_path, ifstream::in | ifstream::binary);
data/android-platform-system-tools-aidl-10.0.0+r36/options.cpp:276:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int ver = atoi(ver_str.c_str());
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_sentinel_searcher.cpp:77:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
const int timeout_seconds = atoi(timeout_as_str.c_str());
data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.cpp:816:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return strlen (yystr);
data/android-platform-system-tools-aidl-10.0.0+r36/aidl_language_y.cpp:2844:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t yysz = yysize + strlen (yyformat);
data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.cpp:1030:26: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
unique_ptr<MethodDecl> read(new MethodDecl(kAndroidStatusLiteral, "readFromParcel",
data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.cpp:1033:37: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
parcel_class->AddPublic(std::move(read));
data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.cpp:1046:26: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
unique_ptr<MethodImpl> read{new MethodImpl{kAndroidStatusLiteral, parcel.GetName(),
data/android-platform-system-tools-aidl-10.0.0+r36/generate_cpp.cpp:1103:34: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
file_decls.push_back(std::move(read));
data/android-platform-system-tools-aidl-10.0.0+r36/io_delegate.cpp:99:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
in.read(&(*contents)[0], file_size);
data/android-platform-system-tools-aidl-10.0.0+r36/options.cpp:321:73: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
output_file_ = output_file_.substr(0, output_file_.length() - strlen(".aidl"));
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_client_file_descriptors.cpp:81:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((got = read(fd.get(), &buf[0], length)) < 0 && errno == EINTR);
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_service.cpp:300:48: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
Status RepeatFileDescriptor(const unique_fd& read,
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_service.cpp:303:35: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
*_aidl_return = unique_fd(dup(read.get()));
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_service.cpp:319:65: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
Status RepeatParcelFileDescriptor(const ParcelFileDescriptor& read,
data/android-platform-system-tools-aidl-10.0.0+r36/tests/aidl_test_service.cpp:322:39: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
_aidl_return->reset(unique_fd(dup(read.get())));
data/android-platform-system-tools-aidl-10.0.0+r36/type_cpp.cpp:168:33: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
const std::string& read)
data/android-platform-system-tools-aidl-10.0.0+r36/type_cpp.cpp:170:64: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
{GetCppHeader(interface)}, GetCppName(interface), read, "writeStrongBinder",
ANALYSIS SUMMARY:
Hits = 24
Lines analyzed = 28643 in approximately 0.82 seconds (34882 lines/second)
Physical Source Lines of Code (SLOC) = 17538
Hits@level = [0] 5 [1] 15 [2] 6 [3] 1 [4] 2 [5] 0
Hits@level+ = [0+] 29 [1+] 24 [2+] 9 [3+] 3 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 1.65355 [1+] 1.36846 [2+] 0.513171 [3+] 0.171057 [4+] 0.114038 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.