Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/aribb24-1.0.3/src/aribb24.c Examining data/aribb24-1.0.3/src/aribb24/aribb24.h Examining data/aribb24-1.0.3/src/aribb24/bits.h Examining data/aribb24-1.0.3/src/aribb24/decoder.h Examining data/aribb24-1.0.3/src/aribb24/parser.h Examining data/aribb24-1.0.3/src/aribb24_private.h Examining data/aribb24-1.0.3/src/convtable.h Examining data/aribb24-1.0.3/src/decoder.c Examining data/aribb24-1.0.3/src/decoder_macro.h Examining data/aribb24-1.0.3/src/decoder_private.h Examining data/aribb24-1.0.3/src/drcs.c Examining data/aribb24-1.0.3/src/drcs.h Examining data/aribb24-1.0.3/src/md5.c Examining data/aribb24-1.0.3/src/md5.h Examining data/aribb24-1.0.3/src/parser.c Examining data/aribb24-1.0.3/src/parser_private.h FINAL RESULTS: data/aribb24-1.0.3/src/md5.h:64:13: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf( &psz[2*i], "%02"PRIx8, md5_s->buf[i] ); data/aribb24-1.0.3/src/aribb24_private.h:40:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char drcs_hash_table[188][32 + 1]; data/aribb24-1.0.3/src/drcs.c:180:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *fp = fopen( psz_conv_file, "r" ); data/aribb24-1.0.3/src/drcs.c:188:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[256] = { 0 }; data/aribb24-1.0.3/src/drcs.c:213:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hash[32 + 1]; data/aribb24-1.0.3/src/drcs.c:275:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). int fd = open( psz_image_file, flags, mode ); data/aribb24-1.0.3/src/drcs.h:27:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hash[32+1]; data/aribb24-1.0.3/src/md5.c:101:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy( correct_words, data, 64 ); data/aribb24-1.0.3/src/parser.c:71:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy( p_parser->psz_subtitle_data + p_parser->i_subtitle_data_size, data/aribb24-1.0.3/src/drcs.c:208:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if( psz_code == NULL || strlen( psz_code ) < 2 || strlen( psz_code ) > 8 ) data/aribb24-1.0.3/src/drcs.c:208:59: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if( psz_code == NULL || strlen( psz_code ) < 2 || strlen( psz_code ) > 8 ) data/aribb24-1.0.3/src/drcs.c:214:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( hash, buf, 32 ); data/aribb24-1.0.3/src/drcs.c:228:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( p_next->hash, hash, 32 ); data/aribb24-1.0.3/src/drcs.c:414:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy( p_instance->p->drcs_hash_table[p_instance->p->i_drcs_num], psz_hash, 32 ); ANALYSIS SUMMARY: Hits = 14 Lines analyzed = 4938 in approximately 0.17 seconds (28878 lines/second) Physical Source Lines of Code (SLOC) = 4105 Hits@level = [0] 0 [1] 5 [2] 8 [3] 0 [4] 1 [5] 0 Hits@level+ = [0+] 14 [1+] 14 [2+] 9 [3+] 1 [4+] 1 [5+] 0 Hits/KSLOC@level+ = [0+] 3.41048 [1+] 3.41048 [2+] 2.19245 [3+] 0.243605 [4+] 0.243605 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.