Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/awesome-4.3/xwindow.h
Examining data/awesome-4.3/xwindow.c
Examining data/awesome-4.3/xrdb.h
Examining data/awesome-4.3/xrdb.c
Examining data/awesome-4.3/xkb.h
Examining data/awesome-4.3/xkb.c
Examining data/awesome-4.3/tests/test-gravity.c
Examining data/awesome-4.3/systray.h
Examining data/awesome-4.3/systray.c
Examining data/awesome-4.3/strut.h
Examining data/awesome-4.3/strut.c
Examining data/awesome-4.3/stack.h
Examining data/awesome-4.3/stack.c
Examining data/awesome-4.3/spawn.h
Examining data/awesome-4.3/spawn.c
Examining data/awesome-4.3/selection.h
Examining data/awesome-4.3/selection.c
Examining data/awesome-4.3/root.c
Examining data/awesome-4.3/property.h
Examining data/awesome-4.3/property.c
Examining data/awesome-4.3/objects/screen.h
Examining data/awesome-4.3/objects/screen.c
Examining data/awesome-4.3/objects/drawable.h
Examining data/awesome-4.3/objects/drawable.c
Examining data/awesome-4.3/objects/button.c
Examining data/awesome-4.3/objects/button.h
Examining data/awesome-4.3/objects/client.c
Examining data/awesome-4.3/objects/client.h
Examining data/awesome-4.3/objects/drawin.c
Examining data/awesome-4.3/objects/drawin.h
Examining data/awesome-4.3/objects/key.c
Examining data/awesome-4.3/objects/key.h
Examining data/awesome-4.3/objects/tag.c
Examining data/awesome-4.3/objects/tag.h
Examining data/awesome-4.3/objects/window.c
Examining data/awesome-4.3/objects/window.h
Examining data/awesome-4.3/mousegrabber.h
Examining data/awesome-4.3/mousegrabber.c
Examining data/awesome-4.3/mouse.h
Examining data/awesome-4.3/mouse.c
Examining data/awesome-4.3/keygrabber.h
Examining data/awesome-4.3/keygrabber.c
Examining data/awesome-4.3/globalconf.h
Examining data/awesome-4.3/ewmh.h
Examining data/awesome-4.3/ewmh.c
Examining data/awesome-4.3/event.h
Examining data/awesome-4.3/event.c
Examining data/awesome-4.3/draw.h
Examining data/awesome-4.3/draw.c
Examining data/awesome-4.3/dbus.h
Examining data/awesome-4.3/dbus.c
Examining data/awesome-4.3/config.h
Examining data/awesome-4.3/common/xutil.h
Examining data/awesome-4.3/common/xutil.c
Examining data/awesome-4.3/common/xembed.h
Examining data/awesome-4.3/common/xembed.c
Examining data/awesome-4.3/common/xcursor.h
Examining data/awesome-4.3/common/xcursor.c
Examining data/awesome-4.3/common/version.h
Examining data/awesome-4.3/common/version.c
Examining data/awesome-4.3/common/util.h
Examining data/awesome-4.3/common/util.c
Examining data/awesome-4.3/common/signal.h
Examining data/awesome-4.3/common/luaobject.h
Examining data/awesome-4.3/common/luaobject.c
Examining data/awesome-4.3/common/luaclass.h
Examining data/awesome-4.3/common/luaclass.c
Examining data/awesome-4.3/common/buffer.h
Examining data/awesome-4.3/common/buffer.c
Examining data/awesome-4.3/common/backtrace.h
Examining data/awesome-4.3/common/backtrace.c
Examining data/awesome-4.3/common/atoms.h
Examining data/awesome-4.3/common/atoms.c
Examining data/awesome-4.3/common/array.h
Examining data/awesome-4.3/common/lualib.c
Examining data/awesome-4.3/common/lualib.h
Examining data/awesome-4.3/color.h
Examining data/awesome-4.3/color.c
Examining data/awesome-4.3/build-utils/lgi-check.c
Examining data/awesome-4.3/banning.h
Examining data/awesome-4.3/banning.c
Examining data/awesome-4.3/awesome.h
Examining data/awesome-4.3/awesome.c
Examining data/awesome-4.3/awesome-version-internal.h
Examining data/awesome-4.3/luaa.c
Examining data/awesome-4.3/luaa.h
FINAL RESULTS:
data/awesome-4.3/awesome.c:503:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(awesome_argv[0], awesome_argv);
data/awesome-4.3/common/buffer.c:82:11: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = vsnprintf(buf->s + buf->len, buf->size - buf->len, fmt, args);
data/awesome-4.3/common/buffer.c:91:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buf->s + buf->len, buf->size - buf->len, fmt, ap);
data/awesome-4.3/common/buffer.h:192:27: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__((format(printf, 2, 0)));
data/awesome-4.3/common/buffer.h:195:27: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__((format(printf, 2, 3)));
data/awesome-4.3/common/util.c:57:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, fmt, ap);
data/awesome-4.3/common/util.c:71:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, fmt, ap);
data/awesome-4.3/common/util.c:140:5: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp(shell, shell, "-c", cmd, NULL);
data/awesome-4.3/common/util.h:314:55: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((noreturn)) __attribute__ ((format(printf, 3, 4)));
data/awesome-4.3/common/util.h:320:28: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format(printf, 3, 4)));
data/awesome-4.3/luaa.h:55:43: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
static inline void __attribute__ ((format(printf, 2, 3)))
data/awesome-4.3/luaa.h:63:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, fmt, ap);
data/awesome-4.3/tests/test-gravity.c:97:28: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format(printf, 2, 3)));
data/awesome-4.3/tests/test-gravity.c:99:28: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format(printf, 1, 2)));
data/awesome-4.3/tests/test-gravity.c:110:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, ap);
data/awesome-4.3/tests/test-gravity.c:127:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stdout, format, ap);
data/awesome-4.3/awesome.c:590:18: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while((opt = getopt_long(argc, argv, "vhkc:ar",
data/awesome-4.3/build-utils/lgi-check.c:56:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv(env) == NULL)
data/awesome-4.3/common/util.c:137:28: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if(!shell && !(shell = getenv("SHELL")))
data/awesome-4.3/awesome.c:476:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/awesome-4.3/color.c:215:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[1 + 4*2 + 1];
data/awesome-4.3/common/array.h:91:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(arr->tab + pos, items, count * sizeof(*items)); \
data/awesome-4.3/common/buffer.c:35:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer_slop[1];
data/awesome-4.3/common/buffer.c:64:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new_area, buf->s, buf->len + 1);
data/awesome-4.3/common/buffer.h:43:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char buffer_slop[1];
data/awesome-4.3/common/buffer.h:154:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf->s + pos, data, dlen);
data/awesome-4.3/common/util.c:36:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char buffer[25];
data/awesome-4.3/common/util.c:96:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, src, dlen);
data/awesome-4.3/common/util.c:122:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, src, dlen);
data/awesome-4.3/common/util.h:133:12: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
return memcpy(xmalloc(size), src, size);
data/awesome-4.3/common/xutil.h:50:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(value, xcb_get_property_value(reply), len);
data/awesome-4.3/keygrabber.c:83:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAX(MB_LEN_MAX, 32)];
data/awesome-4.3/luaa.c:651:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[256] = "";
data/awesome-4.3/objects/key.c:107:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
key->keycode = atoi(str + 1);
data/awesome-4.3/objects/key.c:309:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[12];
data/awesome-4.3/objects/screen.c:347:27: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
output.name = memcpy(p_new(char *, len + 1), name, len);
data/awesome-4.3/objects/screen.c:427:26: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
char *name = memcpy(p_new(char *, len + 1), xcb_randr_get_output_info_name(output_info_r), len);
data/awesome-4.3/property.c:370:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&c->protocols, &protocols, sizeof(protocols));
data/awesome-4.3/awesome.c:477:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t result = read(sigchld_pipe[0], &buffer[0], sizeof(buffer));
data/awesome-4.3/common/util.h:146:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return s ? strlen(s) : 0;
data/awesome-4.3/keygrabber.c:56:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1000);
data/awesome-4.3/mousegrabber.c:62:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(1000);
data/awesome-4.3/tests/test-gravity.c:355:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
XCB_ATOM_WM_NAME, XCB_ATOM_STRING, 8, strlen(name), name);
data/awesome-4.3/tests/test-gravity.c:540:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
xcb_intern_atom(c, 0, strlen(str), str), NULL);
ANALYSIS SUMMARY:
Hits = 44
Lines analyzed = 23965 in approximately 0.66 seconds (36338 lines/second)
Physical Source Lines of Code (SLOC) = 14502
Hits@level = [0] 34 [1] 6 [2] 19 [3] 3 [4] 16 [5] 0
Hits@level+ = [0+] 78 [1+] 44 [2+] 38 [3+] 19 [4+] 16 [5+] 0
Hits/KSLOC@level+ = [0+] 5.37857 [1+] 3.03406 [2+] 2.62033 [3+] 1.31016 [4+] 1.1033 [5+] 0
Dot directories skipped = 3 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.