Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/b43-fwcutter-019/md5.h Examining data/b43-fwcutter-019/md5.c Examining data/b43-fwcutter-019/fwcutter_list.h Examining data/b43-fwcutter-019/fwcutter.h Examining data/b43-fwcutter-019/fwcutter.c FINAL RESULTS: data/b43-fwcutter-019/fwcutter.c:648:3: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(V4_FW_DIRNAME "\t\t"); data/b43-fwcutter-019/fwcutter.c:650:3: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(V3_FW_DIRNAME "\t"); data/b43-fwcutter-019/fwcutter.c:657:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (filename, file->name); data/b43-fwcutter-019/fwcutter.c:329:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nbuf[4096]; data/b43-fwcutter-019/fwcutter.c:357:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(nbuf, "w"); data/b43-fwcutter-019/fwcutter.c:473:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nbuf[4096]; data/b43-fwcutter-019/fwcutter.c:495:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(nbuf, "w"); data/b43-fwcutter-019/fwcutter.c:508:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(nbuf, "w"); data/b43-fwcutter-019/fwcutter.c:516:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nbuf[4096]; data/b43-fwcutter-019/fwcutter.c:527:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). f = fopen(nbuf, "a"); data/b43-fwcutter-019/fwcutter.c:540:6: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). h = fopen(nbuf, "a"); data/b43-fwcutter-019/fwcutter.c:644:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename[30]; data/b43-fwcutter-019/fwcutter.c:645:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char shortname[30]; data/b43-fwcutter-019/fwcutter.c:693:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buffer[16384], signature[16]; data/b43-fwcutter-019/fwcutter.c:695:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char md5sig[33]; data/b43-fwcutter-019/fwcutter.c:906:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = fopen(cmdargs.infile, "rb"); data/b43-fwcutter-019/md5.c:179:6: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, buf, len); data/b43-fwcutter-019/md5.c:182:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, buf, t); data/b43-fwcutter-019/md5.c:191:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ctx->u.in, buf, 64); data/b43-fwcutter-019/md5.c:200:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(ctx->u.in, buf, len); data/b43-fwcutter-019/md5.c:244:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(digest, ctx->buf, 16); data/b43-fwcutter-019/md5.h:10:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char in[64]; data/b43-fwcutter-019/fwcutter.c:652:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(file->name) > 20) { data/b43-fwcutter-019/fwcutter.c:653:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(shortname, file->name, 20); data/b43-fwcutter-019/fwcutter.c:660:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(filename) < 8) printf("\t"); data/b43-fwcutter-019/fwcutter.c:661:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(filename) < 16) printf("\t"); data/b43-fwcutter-019/fwcutter.c:664:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(file->ucode_version) < 8) printf("\t"); data/b43-fwcutter-019/fwcutter.c:765:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). arg_len = strlen(arg); data/b43-fwcutter-019/fwcutter.c:766:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). template_len = strlen(template); ANALYSIS SUMMARY: Hits = 29 Lines analyzed = 2407 in approximately 0.34 seconds (7156 lines/second) Physical Source Lines of Code (SLOC) = 1929 Hits@level = [0] 57 [1] 7 [2] 19 [3] 0 [4] 3 [5] 0 Hits@level+ = [0+] 86 [1+] 29 [2+] 22 [3+] 3 [4+] 3 [5+] 0 Hits/KSLOC@level+ = [0+] 44.5827 [1+] 15.0337 [2+] 11.4049 [3+] 1.55521 [4+] 1.55521 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.