Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/biblesync-1.2.0/src/biblesync.cc Examining data/biblesync-1.2.0/test/send-test.c FINAL RESULTS: data/biblesync-1.2.0/src/biblesync.cc:1059:6: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(name, route_info.ifName); data/biblesync-1.2.0/src/biblesync.cc:1134:14: [4] (shell) popen: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. if ((c = popen(ADDRESS, "r")) != NULL) data/biblesync-1.2.0/test/send-test.c:137:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(mptr, body); data/biblesync-1.2.0/test/send-test.c:139:7: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(mptr, argv[3]); data/biblesync-1.2.0/src/biblesync.cc:347:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dump[DEBUG_LENGTH]; data/biblesync-1.2.0/src/biblesync.cc:701:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(dump, _("[no dump ready]")); // initial, pre-read filler data/biblesync-1.2.0/src/biblesync.cc:779:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((void *)&bsp.uuid, (const void *)&uuid, sizeof(uuid_t)); data/biblesync-1.2.0/src/biblesync.cc:917:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ifName[IF_NAMESIZE]; data/biblesync-1.2.0/src/biblesync.cc:1014:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msgBuf[4096]; data/biblesync-1.2.0/src/biblesync.cc:1078:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char gw_if[IF_NAMESIZE]; // default gateway interface. data/biblesync-1.2.0/src/biblesync.cc:1136:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char addr_string[32]; data/biblesync-1.2.0/test/send-test.c:32:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char databuf[1024]; data/biblesync-1.2.0/test/send-test.c:56:10: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char message[1281], data/biblesync-1.2.0/test/send-test.c:135:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(message, header, 32); data/biblesync-1.2.0/test/send-test.c:136:16: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). message[5] = atoi(argv[2]); data/biblesync-1.2.0/src/biblesync.cc:793:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(bsp.body, body.c_str(), BSP_MAX_PAYLOAD); data/biblesync-1.2.0/src/biblesync.cc:1138:2: [1] (buffer) fscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. fscanf(c, "%30s", addr_string); data/biblesync-1.2.0/test/send-test.c:141:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (sendto(sd, message, 32+strlen(mptr), 0, ANALYSIS SUMMARY: Hits = 18 Lines analyzed = 1347 in approximately 0.05 seconds (26866 lines/second) Physical Source Lines of Code (SLOC) = 942 Hits@level = [0] 4 [1] 3 [2] 11 [3] 0 [4] 4 [5] 0 Hits@level+ = [0+] 22 [1+] 18 [2+] 15 [3+] 4 [4+] 4 [5+] 0 Hits/KSLOC@level+ = [0+] 23.3546 [1+] 19.1083 [2+] 15.9236 [3+] 4.24628 [4+] 4.24628 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.