Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/biff-0.17.pre20000412/biff/biff.c Examining data/biff-0.17.pre20000412/version.h Examining data/biff-0.17.pre20000412/comsat/comsat.c FINAL RESULTS: data/biff-0.17.pre20000412/biff/biff.c:96:8: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. if (chmod(tty, stb.st_mode|0100) == -1) data/biff-0.17.pre20000412/biff/biff.c:102:8: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. if (chmod(tty, stb.st_mode&~0100) == -1) data/biff-0.17.pre20000412/comsat/comsat.c:70:28: [4] (format) syslog: If syslog's format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant format string for syslog. #define dsyslog if (debug) syslog data/biff-0.17.pre20000412/comsat/comsat.c:74:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char hostname[MAXHOSTNAMELEN]; data/biff-0.17.pre20000412/comsat/comsat.c:85:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char msgbuf[100]; /* network input buffer */ data/biff-0.17.pre20000412/comsat/comsat.c:330:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tty[sizeof(utp->ut_line)+sizeof(_PATH_DEV)+1]; /* full tty path */ data/biff-0.17.pre20000412/comsat/comsat.c:331:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[sizeof(utp->ut_name) + 1]; /* user name */ data/biff-0.17.pre20000412/comsat/comsat.c:332:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[sizeof(utp->ut_line) + 1]; /* tty name */ data/biff-0.17.pre20000412/comsat/comsat.c:416:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((tp = fopen(tty, "w")) == NULL) { data/biff-0.17.pre20000412/comsat/comsat.c:457:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[BUFSIZ]; data/biff-0.17.pre20000412/comsat/comsat.c:481:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fi = fopen(filename, "r"); data/biff-0.17.pre20000412/comsat/comsat.c:347:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(line, utp->ut_line, sizeof(utp->ut_line)); data/biff-0.17.pre20000412/comsat/comsat.c:350:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(name, utp->ut_name, sizeof(utp->ut_name)); ANALYSIS SUMMARY: Hits = 13 Lines analyzed = 643 in approximately 0.03 seconds (22000 lines/second) Physical Source Lines of Code (SLOC) = 298 Hits@level = [0] 14 [1] 2 [2] 8 [3] 0 [4] 1 [5] 2 Hits@level+ = [0+] 27 [1+] 13 [2+] 11 [3+] 3 [4+] 3 [5+] 2 Hits/KSLOC@level+ = [0+] 90.604 [1+] 43.6242 [2+] 36.9128 [3+] 10.0671 [4+] 10.0671 [5+] 6.71141 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.