Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/birdtray-1.9.0+ds/src/autoupdater.cpp
Examining data/birdtray-1.9.0+ds/src/autoupdater.h
Examining data/birdtray-1.9.0+ds/src/birdtrayapp.cpp
Examining data/birdtray-1.9.0+ds/src/birdtrayapp.h
Examining data/birdtray-1.9.0+ds/src/birdtrayeventfilter.cpp
Examining data/birdtray-1.9.0+ds/src/birdtrayeventfilter.h
Examining data/birdtray-1.9.0+ds/src/colorbutton.cpp
Examining data/birdtray-1.9.0+ds/src/colorbutton.h
Examining data/birdtray-1.9.0+ds/src/dialogaddeditnewemail.cpp
Examining data/birdtray-1.9.0+ds/src/dialogaddeditnewemail.h
Examining data/birdtray-1.9.0+ds/src/dialoglogoutput.cpp
Examining data/birdtray-1.9.0+ds/src/dialoglogoutput.h
Examining data/birdtray-1.9.0+ds/src/dialogsettings.cpp
Examining data/birdtray-1.9.0+ds/src/dialogsettings.h
Examining data/birdtray-1.9.0+ds/src/log.cpp
Examining data/birdtray-1.9.0+ds/src/log.h
Examining data/birdtray-1.9.0+ds/src/mailaccountdialog.cpp
Examining data/birdtray-1.9.0+ds/src/mailaccountdialog.h
Examining data/birdtray-1.9.0+ds/src/main.cpp
Examining data/birdtray-1.9.0+ds/src/modelaccounttree.cpp
Examining data/birdtray-1.9.0+ds/src/modelaccounttree.h
Examining data/birdtray-1.9.0+ds/src/modelnewemails.cpp
Examining data/birdtray-1.9.0+ds/src/modelnewemails.h
Examining data/birdtray-1.9.0+ds/src/morkparser.cpp
Examining data/birdtray-1.9.0+ds/src/morkparser.h
Examining data/birdtray-1.9.0+ds/src/processhandle.cpp
Examining data/birdtray-1.9.0+ds/src/processhandle.h
Examining data/birdtray-1.9.0+ds/src/setting_newemail.cpp
Examining data/birdtray-1.9.0+ds/src/setting_newemail.h
Examining data/birdtray-1.9.0+ds/src/settings.cpp
Examining data/birdtray-1.9.0+ds/src/settings.h
Examining data/birdtray-1.9.0+ds/src/trayicon.cpp
Examining data/birdtray-1.9.0+ds/src/trayicon.h
Examining data/birdtray-1.9.0+ds/src/unreadmonitor.cpp
Examining data/birdtray-1.9.0+ds/src/unreadmonitor.h
Examining data/birdtray-1.9.0+ds/src/updatedialog.cpp
Examining data/birdtray-1.9.0+ds/src/updatedialog.h
Examining data/birdtray-1.9.0+ds/src/updatedownloaddialog.cpp
Examining data/birdtray-1.9.0+ds/src/updatedownloaddialog.h
Examining data/birdtray-1.9.0+ds/src/utils.cpp
Examining data/birdtray-1.9.0+ds/src/utils.h
Examining data/birdtray-1.9.0+ds/src/version.h
Examining data/birdtray-1.9.0+ds/src/windowtools.cpp
Examining data/birdtray-1.9.0+ds/src/windowtools.h
Examining data/birdtray-1.9.0+ds/src/windowtools_win.cpp
Examining data/birdtray-1.9.0+ds/src/windowtools_win.h
Examining data/birdtray-1.9.0+ds/src/windowtools_x11.cpp
Examining data/birdtray-1.9.0+ds/src/windowtools_x11.h
Examining data/birdtray-1.9.0+ds/tests/src/TestResources.cpp
Examining data/birdtray-1.9.0+ds/tests/src/TestResources.h
Examining data/birdtray-1.9.0+ds/tests/src/test_morkparser.cpp
Examining data/birdtray-1.9.0+ds/tests/src/test_utils.cpp
FINAL RESULTS:
data/birdtray-1.9.0+ds/src/birdtrayapp.cpp:75:77: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
Log::debug("Failed to load translation for %s", qPrintable(QLocale::system().name()));
data/birdtray-1.9.0+ds/src/birdtrayapp.cpp:111:81: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
Log::debug("Failed to load translation for %s", qPrintable(QLocale::system().name()));
data/birdtray-1.9.0+ds/src/birdtrayapp.cpp:131:31: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QLocale locale = QLocale::system();
data/birdtray-1.9.0+ds/src/log.cpp:76:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf( buf, sizeof(buf) - 1, fmt, vl );
data/birdtray-1.9.0+ds/src/autoupdater.cpp:129:35: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
while (!installerFile.open(QFile::WriteOnly)) {
data/birdtray-1.9.0+ds/src/dialogsettings.cpp:330:25: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
translatorsListFile.open(QFile::ReadOnly);
data/birdtray-1.9.0+ds/src/log.cpp:29:36: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
opened = self->mOutputFile.open( stderr, QIODevice::OpenModeFlag::WriteOnly );
data/birdtray-1.9.0+ds/src/log.cpp:34:36: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
opened = self->mOutputFile.open(QIODevice::OpenModeFlag::WriteOnly);
data/birdtray-1.9.0+ds/src/log.cpp:59:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( file.open(QFile::WriteOnly) )
data/birdtray-1.9.0+ds/src/log.cpp:73:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[4096];
data/birdtray-1.9.0+ds/src/morkparser.cpp:77:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
bool MorkParser::open( const QString &path )
data/birdtray-1.9.0+ds/src/morkparser.cpp:84:42: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( !MorkFile.exists() || !MorkFile.open( QIODevice::ReadOnly ) )
data/birdtray-1.9.0+ds/src/morkparser.cpp:786:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( !p.open( filename ) )
data/birdtray-1.9.0+ds/src/morkparser.h:91:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
bool open( const QString &path );
data/birdtray-1.9.0+ds/src/settings.cpp:149:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( !file.open(QIODevice::WriteOnly | QIODevice::Truncate) )
data/birdtray-1.9.0+ds/src/settings.cpp:169:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ( file.open(QIODevice::ReadOnly ) )
data/birdtray-1.9.0+ds/src/unreadmonitor.cpp:173:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!parser.open(path)) {
data/birdtray-1.9.0+ds/src/utils.cpp:135:5: [2] (buffer) TCHAR:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
TCHAR buffer[MAX_PATH];
data/birdtray-1.9.0+ds/src/utils.cpp:297:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
buffer.open(QIODevice::WriteOnly);
data/birdtray-1.9.0+ds/src/windowtools_x11.cpp:222:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *) & ev.xclient.data, (const char *) data, size);
data/birdtray-1.9.0+ds/tests/src/test_morkparser.cpp:23:21: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!parser.open(path)) {
data/birdtray-1.9.0+ds/src/morkparser.cpp:280:66: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (morkData_.mid(morkPos_ - 1, static_cast<int>(strlen(MorkDictColumnMeta)))
data/birdtray-1.9.0+ds/src/morkparser.cpp:283:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
morkPos_ += static_cast<int>(strlen(MorkDictColumnMeta)) - 1;
ANALYSIS SUMMARY:
Hits = 23
Lines analyzed = 7842 in approximately 0.25 seconds (30754 lines/second)
Physical Source Lines of Code (SLOC) = 5250
Hits@level = [0] 8 [1] 2 [2] 17 [3] 0 [4] 4 [5] 0
Hits@level+ = [0+] 31 [1+] 23 [2+] 21 [3+] 4 [4+] 4 [5+] 0
Hits/KSLOC@level+ = [0+] 5.90476 [1+] 4.38095 [2+] 4 [3+] 0.761905 [4+] 0.761905 [5+] 0
Dot directories skipped = 3 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.