Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-auth-pam.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-auth.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-gdk-event-filter-x11.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-gdk-event-filter.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-notification-watcher.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-notification-watcher.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-screen-x11.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-screen.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/setuid.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/setuid.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/subprocs.c
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/subprocs.h
Examining data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c
Examining data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c
FINAL RESULTS:
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:95:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_FAILURE);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:102:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_SUCCESS);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:109:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_CANCELLED);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:118:9: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_BUSY_TRUE);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:122:9: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_BUSY_FALSE);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:131:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (CS_PAM_AUTH_SET_PROMPT_ "%s_\n", msg);
data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c:102:13: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("RUNNING_UNDER_MDM")) {
data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-auth-pam.c:764:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[255];
data/cinnamon-screensaver-4.6.0/libcscreensaver/cs-screen-x11.c:328:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char hints[16];
data/cinnamon-screensaver-4.6.0/libcscreensaver/subprocs.c:36:16: [2] (race) vfork:
On some old systems, vfork() permits race conditions, and it's very
difficult to use correctly (CWE-362). Use fork() instead.
# define fork vfork
data/cinnamon-screensaver-4.6.0/libcscreensaver/subprocs.c:112:25: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf [1024];
data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c:141:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf [255];
data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c:166:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (pass [strlen (pass) - 1] == '\n') {
data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c:167:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pass [strlen (pass) - 1] = 0;
data/cinnamon-screensaver-4.6.0/libcscreensaver/test-passwd.c:172:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset (pass, '\b', strlen (pass));
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:174:21: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep (100 * 1000);
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:194:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset (password_ptr, '\b', strlen (password_ptr));
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:314:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (input [strlen (input) - 1] == '\n')
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:316:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
input [strlen (input) - 1] = 0;
data/cinnamon-screensaver-4.6.0/src/pamhelper/cinnamon-screensaver-pam-helper.c:320:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset (input, '\b', strlen (input));
ANALYSIS SUMMARY:
Hits = 20
Lines analyzed = 3616 in approximately 0.15 seconds (23997 lines/second)
Physical Source Lines of Code (SLOC) = 2477
Hits@level = [0] 11 [1] 8 [2] 5 [3] 1 [4] 6 [5] 0
Hits@level+ = [0+] 31 [1+] 20 [2+] 12 [3+] 7 [4+] 6 [5+] 0
Hits/KSLOC@level+ = [0+] 12.5151 [1+] 8.07428 [2+] 4.84457 [3+] 2.826 [4+] 2.42229 [5+] 0
Dot directories skipped = 3 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.