Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/connman-ui-0~20150623/gdbus/polkit.c Examining data/connman-ui-0~20150623/gdbus/object.c Examining data/connman-ui-0~20150623/gdbus/mainloop.c Examining data/connman-ui-0~20150623/gdbus/client.c Examining data/connman-ui-0~20150623/gdbus/watch.c Examining data/connman-ui-0~20150623/gdbus/gdbus.h Examining data/connman-ui-0~20150623/src/settings.c Examining data/connman-ui-0~20150623/src/right-menu.c Examining data/connman-ui-0~20150623/src/theme.c Examining data/connman-ui-0~20150623/src/connman-ui-gtk.h Examining data/connman-ui-0~20150623/src/gtkservice.c Examining data/connman-ui-0~20150623/src/main.c Examining data/connman-ui-0~20150623/src/utils.c Examining data/connman-ui-0~20150623/src/gtktechnology.c Examining data/connman-ui-0~20150623/src/agent_dialogs.c Examining data/connman-ui-0~20150623/src/gtktechnology.h Examining data/connman-ui-0~20150623/src/tray.c Examining data/connman-ui-0~20150623/src/left-menu.c Examining data/connman-ui-0~20150623/src/gtkservice.h Examining data/connman-ui-0~20150623/lib/service.c Examining data/connman-ui-0~20150623/lib/agent.c Examining data/connman-ui-0~20150623/lib/cui-dbus.h Examining data/connman-ui-0~20150623/lib/manager.c Examining data/connman-ui-0~20150623/lib/connman-interface.h Examining data/connman-ui-0~20150623/lib/interface.c Examining data/connman-ui-0~20150623/lib/utils.c Examining data/connman-ui-0~20150623/lib/connman-private.h Examining data/connman-ui-0~20150623/lib/technology.c Examining data/connman-ui-0~20150623/lib/dbus.c FINAL RESULTS: data/connman-ui-0~20150623/gdbus/gdbus.h:238:28: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 4, 5))); data/connman-ui-0~20150623/gdbus/gdbus.h:245:28: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 3, 4))); data/connman-ui-0~20150623/gdbus/gdbus.h:255:29: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. __attribute__((format(printf, 4, 5))); data/connman-ui-0~20150623/gdbus/object.c:1457:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(str, sizeof(str), format, args); data/connman-ui-0~20150623/gdbus/object.c:1538:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(str, sizeof(str), format, args); data/connman-ui-0~20150623/gdbus/client.c:622:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char type_as_str[2]; data/connman-ui-0~20150623/gdbus/object.c:1455:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[1024]; data/connman-ui-0~20150623/gdbus/object.c:1536:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[1024]; data/connman-ui-0~20150623/gdbus/watch.c:168:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rule[DBUS_MAXIMUM_MATCH_RULE_LENGTH]; data/connman-ui-0~20150623/gdbus/watch.c:190:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rule[DBUS_MAXIMUM_MATCH_RULE_LENGTH]; data/connman-ui-0~20150623/src/settings.c:228:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char value[6]; data/connman-ui-0~20150623/src/settings.c:397:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char value[6]; data/connman-ui-0~20150623/src/settings.c:577:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). ipv6->prefix = atoi(prefix); data/connman-ui-0~20150623/gdbus/object.c:731:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strlen(parent_path)) data/connman-ui-0~20150623/lib/dbus.c:469:37: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strncmp(param->key_name, name, strlen(param->key_name)) == 0) { ANALYSIS SUMMARY: Hits = 15 Lines analyzed = 13160 in approximately 0.26 seconds (49856 lines/second) Physical Source Lines of Code (SLOC) = 9565 Hits@level = [0] 22 [1] 2 [2] 8 [3] 0 [4] 5 [5] 0 Hits@level+ = [0+] 37 [1+] 15 [2+] 13 [3+] 5 [4+] 5 [5+] 0 Hits/KSLOC@level+ = [0+] 3.86827 [1+] 1.56822 [2+] 1.35912 [3+] 0.522739 [4+] 0.522739 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.