Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/coolmail-1.3/system/X11/colors.c Examining data/coolmail-1.3/system/X11/colors.h Examining data/coolmail-1.3/system/X11/display_list.c Examining data/coolmail-1.3/display_list.h Examining data/coolmail-1.3/mailbox.h Examining data/coolmail-1.3/r1_sub.c Examining data/coolmail-1.3/render1.c Examining data/coolmail-1.3/render1.h Examining data/coolmail-1.3/audio.c Examining data/coolmail-1.3/coolmail.c FINAL RESULTS: data/coolmail-1.3/coolmail.c:112:4: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(mailfile_str, uid->pw_name); data/coolmail-1.3/coolmail.c:492:7: [4] (shell) system: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. system(command); data/coolmail-1.3/system/X11/display_list.c:164:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(command_str, str); data/coolmail-1.3/system/X11/display_list.c:166:4: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(mailfile_str, str); data/coolmail-1.3/audio.c:84:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char pad[2]; data/coolmail-1.3/audio.c:122:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char buf[256]; data/coolmail-1.3/audio.c:137:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). audiofd = open( "/dev/audio", O_WRONLY | O_NDELAY ); data/coolmail-1.3/audio.c:145:17: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( (mixer_fd=open(DEV_MIXER, O_RDWR, 0)) < 0 ) { data/coolmail-1.3/audio.c:179:11: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). filefd = open(sndfile, O_RDONLY); data/coolmail-1.3/coolmail.c:58:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char command_str[1024] = DEFAULT_COMMAND; data/coolmail-1.3/coolmail.c:59:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mailfile_str[1024] = DEFAULT_MAIL_DIR; data/coolmail-1.3/coolmail.c:642:9: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open (filename, O_RDONLY, 0); data/coolmail-1.3/audio.c:187:7: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rn = read(filefd, buf, sizeof(Audio_filehdr)); data/coolmail-1.3/audio.c:204:9: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). len = read(filefd, buf, len); data/coolmail-1.3/audio.c:209:8: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rn = read(filefd, buf, sizeof(buf)); data/coolmail-1.3/audio.c:226:4: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(1000); data/coolmail-1.3/coolmail.c:360:10: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(mailfile_str, argv[i], 1023); data/coolmail-1.3/coolmail.c:365:10: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(command_str, argv[i], 1023); ANALYSIS SUMMARY: Hits = 18 Lines analyzed = 2569 in approximately 0.12 seconds (21241 lines/second) Physical Source Lines of Code (SLOC) = 1524 Hits@level = [0] 56 [1] 6 [2] 8 [3] 0 [4] 4 [5] 0 Hits@level+ = [0+] 74 [1+] 18 [2+] 12 [3+] 4 [4+] 4 [5+] 0 Hits/KSLOC@level+ = [0+] 48.5564 [1+] 11.811 [2+] 7.87402 [3+] 2.62467 [4+] 2.62467 [5+] 0 Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.