Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/criterion-2.3.3git1/test/full/other-crashes.cc
Examining data/criterion-2.3.3git1/test/full/exception.cc
Examining data/criterion-2.3.3git1/test/full/theories_regression.cc
Examining data/criterion-2.3.3git1/test/full/flood.c
Examining data/criterion-2.3.3git1/test/full/exit.cc
Examining data/criterion-2.3.3git1/test/full/theories_regression.c
Examining data/criterion-2.3.3git1/test/full/with-time.c
Examining data/criterion-2.3.3git1/test/full/failmessages.c
Examining data/criterion-2.3.3git1/test/full/long-messages.c
Examining data/criterion-2.3.3git1/test/full/long-messages.cc
Examining data/criterion-2.3.3git1/test/full/failmessages.cc
Examining data/criterion-2.3.3git1/test/full/exit.c
Examining data/criterion-2.3.3git1/test/full/other-crashes.c
Examining data/criterion-2.3.3git1/test/unit/path.c
Examining data/criterion-2.3.3git1/test/unit/alloc.cc
Examining data/criterion-2.3.3git1/test/unit/redirect.cc
Examining data/criterion-2.3.3git1/test/unit/asprintf.c
Examining data/criterion-2.3.3git1/test/unit/ordered-set.c
Examining data/criterion-2.3.3git1/dependencies/debugbreak/debugbreak.h
Examining data/criterion-2.3.3git1/dependencies/klib/khash.h
Examining data/criterion-2.3.3git1/dependencies/klib/kvec.h
Examining data/criterion-2.3.3git1/dependencies/valgrind/include/valgrind/valgrind.h
Examining data/criterion-2.3.3git1/src/csptr/smalloc.h
Examining data/criterion-2.3.3git1/src/csptr/config.h
Examining data/criterion-2.3.3git1/src/csptr/array.c
Examining data/criterion-2.3.3git1/src/csptr/mman.h
Examining data/criterion-2.3.3git1/src/csptr/csptr.h
Examining data/criterion-2.3.3git1/src/csptr/smart_ptr.h
Examining data/criterion-2.3.3git1/src/csptr/array.h
Examining data/criterion-2.3.3git1/src/csptr/common.h
Examining data/criterion-2.3.3git1/src/csptr/mman.c
Examining data/criterion-2.3.3git1/src/atomic.h
Examining data/criterion-2.3.3git1/src/log/logging.h
Examining data/criterion-2.3.3git1/src/log/normal.c
Examining data/criterion-2.3.3git1/src/log/logging.c
Examining data/criterion-2.3.3git1/src/capi/stream.c
Examining data/criterion-2.3.3git1/src/capi/specifiers.c
Examining data/criterion-2.3.3git1/src/compat/strtok.c
Examining data/criterion-2.3.3git1/src/compat/time.c
Examining data/criterion-2.3.3git1/src/compat/time.h
Examining data/criterion-2.3.3git1/src/compat/kill.c
Examining data/criterion-2.3.3git1/src/compat/section.h
Examining data/criterion-2.3.3git1/src/compat/internal.h
Examining data/criterion-2.3.3git1/src/compat/kill.h
Examining data/criterion-2.3.3git1/src/compat/path.c
Examining data/criterion-2.3.3git1/src/compat/section-elf.c
Examining data/criterion-2.3.3git1/src/compat/mockfile.c
Examining data/criterion-2.3.3git1/src/compat/pipe.h
Examining data/criterion-2.3.3git1/src/compat/section-pe.c
Examining data/criterion-2.3.3git1/src/compat/process.h
Examining data/criterion-2.3.3git1/src/compat/setjmp.h
Examining data/criterion-2.3.3git1/src/compat/posix.h
Examining data/criterion-2.3.3git1/src/compat/alloc.h
Examining data/criterion-2.3.3git1/src/compat/strtok.h
Examining data/criterion-2.3.3git1/src/compat/alloc.c
Examining data/criterion-2.3.3git1/src/compat/pipe.c
Examining data/criterion-2.3.3git1/src/compat/pipe-internal.h
Examining data/criterion-2.3.3git1/src/compat/processor.h
Examining data/criterion-2.3.3git1/src/compat/section-mach-o.c
Examining data/criterion-2.3.3git1/src/compat/off_t.h
Examining data/criterion-2.3.3git1/src/compat/process.c
Examining data/criterion-2.3.3git1/src/compat/path.h
Examining data/criterion-2.3.3git1/src/compat/section.c
Examining data/criterion-2.3.3git1/src/compat/processor.c
Examining data/criterion-2.3.3git1/src/err.h
Examining data/criterion-2.3.3git1/src/mutex.h
Examining data/criterion-2.3.3git1/src/string/fmt.h
Examining data/criterion-2.3.3git1/src/string/xxd.c
Examining data/criterion-2.3.3git1/src/string/brz.c
Examining data/criterion-2.3.3git1/src/string/diff.c
Examining data/criterion-2.3.3git1/src/string/fmt.c
Examining data/criterion-2.3.3git1/src/string/extglobmatch.h
Examining data/criterion-2.3.3git1/src/string/xxd.h
Examining data/criterion-2.3.3git1/src/string/diff.h
Examining data/criterion-2.3.3git1/src/string/brz.h
Examining data/criterion-2.3.3git1/src/string/i18n.h
Examining data/criterion-2.3.3git1/src/string/i18n.c
Examining data/criterion-2.3.3git1/src/string/diff-stubs.c
Examining data/criterion-2.3.3git1/src/string/extglobmatch.c
Examining data/criterion-2.3.3git1/src/err.c
Examining data/criterion-2.3.3git1/src/core/report.c
Examining data/criterion-2.3.3git1/src/core/test.c
Examining data/criterion-2.3.3git1/src/core/report.h
Examining data/criterion-2.3.3git1/src/core/runner_coroutine.h
Examining data/criterion-2.3.3git1/src/core/stats.c
Examining data/criterion-2.3.3git1/src/core/client.c
Examining data/criterion-2.3.3git1/src/core/theories.c
Examining data/criterion-2.3.3git1/src/core/runner.h
Examining data/criterion-2.3.3git1/src/core/runner.c
Examining data/criterion-2.3.3git1/src/core/abort.h
Examining data/criterion-2.3.3git1/src/core/assert.c
Examining data/criterion-2.3.3git1/src/core/stats.h
Examining data/criterion-2.3.3git1/src/core/runner_coroutine.c
Examining data/criterion-2.3.3git1/src/core/coroutine.h
Examining data/criterion-2.3.3git1/src/core/client.h
Examining data/criterion-2.3.3git1/src/core/abort.c
Examining data/criterion-2.3.3git1/src/core/ordered-set.c
Examining data/criterion-2.3.3git1/src/protocol/messages.h
Examining data/criterion-2.3.3git1/src/protocol/protocol.c
Examining data/criterion-2.3.3git1/src/protocol/connect.c
Examining data/criterion-2.3.3git1/src/protocol/criterion.pb.c
Examining data/criterion-2.3.3git1/src/protocol/connect.h
Examining data/criterion-2.3.3git1/src/protocol/criterion.pb.h
Examining data/criterion-2.3.3git1/src/protocol/messages.c
Examining data/criterion-2.3.3git1/src/protocol/protocol.h
Examining data/criterion-2.3.3git1/src/io/file.c
Examining data/criterion-2.3.3git1/src/io/event.c
Examining data/criterion-2.3.3git1/src/io/xml.c
Examining data/criterion-2.3.3git1/src/io/redirect.c
Examining data/criterion-2.3.3git1/src/io/output.c
Examining data/criterion-2.3.3git1/src/io/tap.c
Examining data/criterion-2.3.3git1/src/io/event.h
Examining data/criterion-2.3.3git1/src/io/json.c
Examining data/criterion-2.3.3git1/src/io/output.h
Examining data/criterion-2.3.3git1/src/common.h
Examining data/criterion-2.3.3git1/src/entry/params.c
Examining data/criterion-2.3.3git1/src/entry/options.c
Examining data/criterion-2.3.3git1/src/entry/entry.c
Examining data/criterion-2.3.3git1/src/mutex.c
Examining data/criterion-2.3.3git1/dev/cmake/test/test.c
Examining data/criterion-2.3.3git1/dev/cmake/src/foo.c
Examining data/criterion-2.3.3git1/dev/cmake/include/foo.h
Examining data/criterion-2.3.3git1/dev/autotools/simple.c
Examining data/criterion-2.3.3git1/include/criterion/theories.h
Examining data/criterion-2.3.3git1/include/criterion/logging.h
Examining data/criterion-2.3.3git1/include/criterion/embedded.h
Examining data/criterion-2.3.3git1/include/criterion/abort.h
Examining data/criterion-2.3.3git1/include/criterion/internal/theories.h
Examining data/criterion-2.3.3git1/include/criterion/internal/deprecation.h
Examining data/criterion-2.3.3git1/include/criterion/internal/asprintf-compat.h
Examining data/criterion-2.3.3git1/include/criterion/internal/test.h
Examining data/criterion-2.3.3git1/include/criterion/internal/capabilities.h
Examining data/criterion-2.3.3git1/include/criterion/internal/preprocess.h
Examining data/criterion-2.3.3git1/include/criterion/internal/ordered-set.h
Examining data/criterion-2.3.3git1/include/criterion/internal/new_asserts.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert.h
Examining data/criterion-2.3.3git1/include/criterion/internal/designated-initializer-compat.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/op.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/tag.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/ieee.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/tostr.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/stream.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/memory.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/types.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/complex.h
Examining data/criterion-2.3.3git1/include/criterion/internal/assert/exceptions.h
Examining data/criterion-2.3.3git1/include/criterion/internal/parameterized.h
Examining data/criterion-2.3.3git1/include/criterion/internal/common.h
Examining data/criterion-2.3.3git1/include/criterion/internal/hooks.h
Examining data/criterion-2.3.3git1/include/criterion/internal/redirect.h
Examining data/criterion-2.3.3git1/include/criterion/assert.h
Examining data/criterion-2.3.3git1/include/criterion/types.h
Examining data/criterion-2.3.3git1/include/criterion/alloc.h
Examining data/criterion-2.3.3git1/include/criterion/options.h
Examining data/criterion-2.3.3git1/include/criterion/stats.h
Examining data/criterion-2.3.3git1/include/criterion/criterion.h
Examining data/criterion-2.3.3git1/include/criterion/parameterized.h
Examining data/criterion-2.3.3git1/include/criterion/new/stream.h
Examining data/criterion-2.3.3git1/include/criterion/new/memory.h
Examining data/criterion-2.3.3git1/include/criterion/new/assert.h
Examining data/criterion-2.3.3git1/include/criterion/event.h
Examining data/criterion-2.3.3git1/include/criterion/output.h
Examining data/criterion-2.3.3git1/include/criterion/hooks.h
Examining data/criterion-2.3.3git1/include/criterion/redirect.h
Examining data/criterion-2.3.3git1/samples/parameterized.c
Examining data/criterion-2.3.3git1/samples/report.c
Examining data/criterion-2.3.3git1/samples/description.cc
Examining data/criterion-2.3.3git1/samples/log.c
Examining data/criterion-2.3.3git1/samples/asserts.cc
Examining data/criterion-2.3.3git1/samples/more-suites.c
Examining data/criterion-2.3.3git1/samples/skip.cc
Examining data/criterion-2.3.3git1/samples/simple.c
Examining data/criterion-2.3.3git1/samples/theories.c
Examining data/criterion-2.3.3git1/samples/suites.cc
Examining data/criterion-2.3.3git1/samples/signal.c
Examining data/criterion-2.3.3git1/samples/asserts.c
Examining data/criterion-2.3.3git1/samples/fixtures.c
Examining data/criterion-2.3.3git1/samples/redirect.c
Examining data/criterion-2.3.3git1/samples/simple.cc
Examining data/criterion-2.3.3git1/samples/redirect.cc
Examining data/criterion-2.3.3git1/samples/signal.cc
Examining data/criterion-2.3.3git1/samples/fixtures.cc
Examining data/criterion-2.3.3git1/samples/skip.c
Examining data/criterion-2.3.3git1/samples/log.cc
Examining data/criterion-2.3.3git1/samples/timeout.c
Examining data/criterion-2.3.3git1/samples/parameterized.cc
Examining data/criterion-2.3.3git1/samples/more-suites.cc
Examining data/criterion-2.3.3git1/samples/report.cc
Examining data/criterion-2.3.3git1/samples/theories.cc
Examining data/criterion-2.3.3git1/samples/description.c
Examining data/criterion-2.3.3git1/samples/suites.c
FINAL RESULTS:
data/criterion-2.3.3git1/src/compat/section-elf.c:91:18: [5] (race) readlink:
This accepts filename arguments; if an attacker can move those files or
change the link content, a race condition results. Also, it does not
terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach.
ssize_t rc = readlink(self, fullpath, PATH_MAX);
data/criterion-2.3.3git1/src/core/theories.c:193:5: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(*msg, arg, BUFSIZE - 1);
data/criterion-2.3.3git1/dev/cmake/test/test.c:21:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
Test(strcpy, empty)
data/criterion-2.3.3git1/dev/cmake/test/test.c:29:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
Test(strcpy, return)
data/criterion-2.3.3git1/dev/cmake/test/test.c:37:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
Test(strcpy, larger_dest)
data/criterion-2.3.3git1/include/criterion/internal/asprintf-compat.h:47:28: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define CRI_PRINTF_FORMAT printf
data/criterion-2.3.3git1/include/criterion/logging.h:61:11: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
CR_FORMAT(printf, 2, 3)
data/criterion-2.3.3git1/samples/parameterized.c:101:9: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(ptr, str);
data/criterion-2.3.3git1/src/atomic.h:45:44: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
# error Atomics are not supported on your system
data/criterion-2.3.3git1/src/core/theories.c:162:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(*arg, sizeof (*arg) - 1, fmt, *(short *) data);
data/criterion-2.3.3git1/src/core/theories.c:165:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(*arg, sizeof (*arg) - 1, fmt, *(int *) data);
data/criterion-2.3.3git1/src/core/theories.c:171:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(*arg, sizeof (*arg) - 1, fmt, *(long *) data);
data/criterion-2.3.3git1/src/core/theories.c:176:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(*arg, sizeof (*arg) - 1, fmt, *(long long *) data);
data/criterion-2.3.3git1/src/entry/params.c:101:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, USAGE, progname);
data/criterion-2.3.3git1/src/err.c:36:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, str, vl);
data/criterion-2.3.3git1/src/err.h:31:11: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
CR_FORMAT(printf, 1, 2)
data/criterion-2.3.3git1/src/io/json.c:120:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_TEMPLATE_BEGIN,
data/criterion-2.3.3git1/src/io/json.c:131:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_CRASH_MSG_ENTRY);
data/criterion-2.3.3git1/src/io/json.c:133:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TIMEOUT_MSG_ENTRY);
data/criterion-2.3.3git1/src/io/json.c:135:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_FAILED_TEMPLATE_BEGIN);
data/criterion-2.3.3git1/src/io/json.c:150:17: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_FAILURE_MSG_ENTRY,
data/criterion-2.3.3git1/src/io/json.c:161:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_FAILED_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/json.c:164:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/json.c:169:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_BASE_TEMPLATE_BEGIN,
data/criterion-2.3.3git1/src/io/json.c:176:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TESTSUITE_LIST_TEMPLATE_BEGIN);
data/criterion-2.3.3git1/src/io/json.c:178:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TESTSUITE_TEMPLATE_BEGIN,
data/criterion-2.3.3git1/src/io/json.c:186:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_LIST_TEMPLATE_BEGIN);
data/criterion-2.3.3git1/src/io/json.c:189:13: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, ts->next ? ",\n" : "\n");
data/criterion-2.3.3git1/src/io/json.c:191:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TEST_LIST_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/json.c:193:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TESTSUITE_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/json.c:194:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, ss->next ? ",\n" : "\n");
data/criterion-2.3.3git1/src/io/json.c:196:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_TESTSUITE_LIST_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/json.c:198:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, JSON_BASE_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/tap.c:55:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, format,
data/criterion-2.3.3git1/src/io/xml.c:121:14: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
result = vfprintf(stream, format, args);
data/criterion-2.3.3git1/src/io/xml.c:139:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TEST_SKIPPED);
data/criterion-2.3.3git1/src/io/xml.c:141:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_CRASH_MSG_ENTRY);
data/criterion-2.3.3git1/src/io/xml.c:143:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TIMEOUT_MSG_ENTRY);
data/criterion-2.3.3git1/src/io/xml.c:146:13: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TEST_FAILED_TEMPLATE_BEGIN, ts->failed_asserts);
data/criterion-2.3.3git1/src/io/xml.c:154:21: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_FAILURE_MSG_ENTRY,
data/criterion-2.3.3git1/src/io/xml.c:161:25: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, " %s" LF, line);
data/criterion-2.3.3git1/src/io/xml.c:165:13: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TEST_FAILED_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/xml.c:169:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TEST_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/xml.c:183:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_BASE_TEMPLATE_BEGIN,
data/criterion-2.3.3git1/src/io/xml.c:204:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_TESTSUITE_TEMPLATE_END);
data/criterion-2.3.3git1/src/io/xml.c:207:5: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(f, XML_BASE_TEMPLATE_END);
data/criterion-2.3.3git1/src/log/logging.c:79:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, _(ERROR_FORMAT),
data/criterion-2.3.3git1/src/log/logging.c:88:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, _(LOG_FORMAT),
data/criterion-2.3.3git1/src/log/logging.c:106:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(formatted_msg, sizeof formatted_msg, msg, args);
data/criterion-2.3.3git1/src/log/logging.c:110:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, _(ERROR_FORMAT),
data/criterion-2.3.3git1/src/log/logging.c:119:9: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(stderr, _(LOG_FORMAT),
data/criterion-2.3.3git1/src/log/logging.c:141:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, msg, args);
data/criterion-2.3.3git1/src/log/logging.h:92:11: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
CR_FORMAT(printf, 3, 4)
data/criterion-2.3.3git1/src/log/logging.h:95:11: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
CR_FORMAT(printf, 2, 3)
data/criterion-2.3.3git1/src/string/brz.c:59:34: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# define print_glob_v(g) do { printf(#g " "); (g)->print(g), puts(""); } while (0)
data/criterion-2.3.3git1/src/string/fmt.c:56:16: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int size = vsnprintf(0, 0, fmt, vl);
data/criterion-2.3.3git1/src/string/fmt.c:72:5: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(&nb[*offset], size + 1, fmt, ap);
data/criterion-2.3.3git1/test/unit/asprintf.c:51:23: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
int rc_expected = snprintf(expected, sizeof (expected), fmt->format, *fmt->val);
data/criterion-2.3.3git1/src/core/runner.c:211:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("BXFI_MAP")) {
data/criterion-2.3.3git1/src/core/runner.c:377:9: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv("BXFI_MAP")) {
data/criterion-2.3.3git1/src/entry/params.c:232:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
&& strcmp("dumb", DEF(getenv("TERM"), "dumb")) != 0;
data/criterion-2.3.3git1/src/entry/params.c:298:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_always_succeed = getenv("CRITERION_ALWAYS_SUCCEED");
data/criterion-2.3.3git1/src/entry/params.c:299:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_fail_fast = getenv("CRITERION_FAIL_FAST");
data/criterion-2.3.3git1/src/entry/params.c:300:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_use_ascii = getenv("CRITERION_USE_ASCII");
data/criterion-2.3.3git1/src/entry/params.c:301:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_jobs = getenv("CRITERION_JOBS");
data/criterion-2.3.3git1/src/entry/params.c:302:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_logging_threshold = getenv("CRITERION_VERBOSITY_LEVEL");
data/criterion-2.3.3git1/src/entry/params.c:303:35: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_short_filename = getenv("CRITERION_SHORT_FILENAME");
data/criterion-2.3.3git1/src/entry/params.c:305:45: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
bool is_term_dumb = !strcmp("dumb", DEF(getenv("TERM"), "dumb"));
data/criterion-2.3.3git1/src/entry/params.c:325:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *env_pattern = getenv("CRITERION_TEST_PATTERN");
data/criterion-2.3.3git1/src/entry/params.c:329:43: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
opt->measure_time = !!strcmp("1", DEF(getenv("CRITERION_DISABLE_TIME_MEASUREMENTS"), "0"));
data/criterion-2.3.3git1/src/entry/params.c:335:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (!strcmp("1", DEF(getenv("CRITERION_ENABLE_TAP"), "0"))) {
data/criterion-2.3.3git1/src/entry/params.c:344:27: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *outputs = getenv("CRITERION_OUTPUTS");
data/criterion-2.3.3git1/src/entry/params.c:369:22: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
for (int c; (c = getopt_long(argc, argv, "hvlfj:SqO:wt:", opts, NULL)) != -1;) {
data/criterion-2.3.3git1/src/mutex.c:70:5: [3] (misc) InitializeCriticalSection:
Exceptions can be thrown in low-memory situations. Use
InitializeCriticalSectionAndSpinCount instead.
InitializeCriticalSection(&mutex->mutex);
data/criterion-2.3.3git1/src/mutex.c:85:5: [3] (misc) EnterCriticalSection:
On some versions of Windows, exceptions can be thrown in low-memory
situations. Use InitializeCriticalSectionAndSpinCount instead.
EnterCriticalSection(&mutex->mutex);
data/criterion-2.3.3git1/dependencies/klib/kvec.h:68:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((v1).a, (v0).a, sizeof(type) * (v0).n); \
data/criterion-2.3.3git1/dev/cmake/test/test.c:31:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char dst[4];
data/criterion-2.3.3git1/include/criterion/new/stream.h:39:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[CR_STREAM_BUFSIZE];
data/criterion-2.3.3git1/include/criterion/options.h:205:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char encoding[64];
data/criterion-2.3.3git1/samples/asserts.c:133:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, (char *) arr->buf + arr->off, rem);
data/criterion-2.3.3git1/samples/asserts.cc:134:10: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer, (char *) arr->buf + arr->off, rem);
data/criterion-2.3.3git1/samples/redirect.c:36:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/criterion-2.3.3git1/src/compat/mockfile.c:87:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, mf->mem + mf->cur, count);
data/criterion-2.3.3git1/src/compat/mockfile.c:119:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(mf->mem + mf->cur, buf, count);
data/criterion-2.3.3git1/src/compat/mockfile.c:203:12: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
return tmpfile();
data/criterion-2.3.3git1/src/compat/pipe.c:119:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pipe_name[256] = { 0 };
data/criterion-2.3.3git1/src/compat/pipe.c:365:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
h->fd = open(path, O_RDWR);
data/criterion-2.3.3git1/src/compat/section-elf.c:75:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char self[PATH_MAX];
data/criterion-2.3.3git1/src/compat/section-elf.c:90:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fullpath[PATH_MAX];
data/criterion-2.3.3git1/src/compat/section-elf.c:106:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
return open(fullpath, O_RDONLY);
data/criterion-2.3.3git1/src/compat/section-elf.c:160:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(name, O_RDONLY);
data/criterion-2.3.3git1/src/core/client.c:396:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[32];
data/criterion-2.3.3git1/src/core/client.c:403:13: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[32];
data/criterion-2.3.3git1/src/core/client.c:410:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[32];
data/criterion-2.3.3git1/src/core/client.c:416:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char id[32];
data/criterion-2.3.3git1/src/core/ordered-set.c:56:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newset, &data, sizeof (struct criterion_ordered_set));
data/criterion-2.3.3git1/src/core/ordered-set.c:81:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new + 1, ptr, size);
data/criterion-2.3.3git1/src/core/runner.c:336:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char url[sizeof ("ipc://" NN_SOCKET_PATH "criterion_.sock") + 21];
data/criterion-2.3.3git1/src/core/stats.c:208:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dup, data, sizeof (s_assert_stats));
data/criterion-2.3.3git1/src/core/theories.c:144:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static void format_arg(char (*arg)[1024], struct criterion_datapoints *dp, void *data)
data/criterion-2.3.3git1/src/core/theories.c:186:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static void concat_arg(char (*msg)[BUFSIZE], struct criterion_datapoints *dps, size_t *indices, size_t i)
data/criterion-2.3.3git1/src/core/theories.c:188:20: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void *data = ((char *) dps[i].arr) + dps[i].size * indices[i];
data/criterion-2.3.3git1/src/core/theories.c:190:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char arg[1024];
data/criterion-2.3.3git1/src/core/theories.c:242:27: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
((char *) dps[i].arr) + dps[i].size * indices[i]);
data/criterion-2.3.3git1/src/core/theories.c:250:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msg[BUFSIZE];
data/criterion-2.3.3git1/src/csptr/mman.c:119:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newptr, ptr, size);
data/criterion-2.3.3git1/src/csptr/mman.c:167:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(shifted, args->meta.data, args->meta.size);
data/criterion-2.3.3git1/src/csptr/mman.c:192:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char new_meta[size];
data/criterion-2.3.3git1/src/csptr/mman.c:199:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(arr_meta + 1, args->meta.data, args->meta.size);
data/criterion-2.3.3git1/src/csptr/smart_ptr.h:65:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(var, &args.value, sizeof (Type)); \
data/criterion-2.3.3git1/src/csptr/smart_ptr.h:85:13: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(var, &args.value, sizeof (Type)); \
data/criterion-2.3.3git1/src/entry/params.c:159:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int res = atoi(str);
data/criterion-2.3.3git1/src/entry/params.c:451:9: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(criterion_options.encoding, "ANSI_X3.4-1968");
data/criterion-2.3.3git1/src/io/file.c:7:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[512];
data/criterion-2.3.3git1/src/io/file.c:39:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf1[512];
data/criterion-2.3.3git1/src/io/file.c:40:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf2[512];
data/criterion-2.3.3git1/src/io/output.c:131:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(output_path, "w");
data/criterion-2.3.3git1/src/io/output.c:142:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(path, "w");
data/criterion-2.3.3git1/src/log/logging.c:104:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char formatted_msg[1024];
data/criterion-2.3.3git1/src/string/xxd.c:56:20: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
written += sprintf(&out[written], "%0*" PRIx64 ":", offwidth, (uint64_t) (i + start));
data/criterion-2.3.3git1/src/string/xxd.c:62:24: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
written += sprintf(&out[written], "%02hhx", c[i + j]);
data/criterion-2.3.3git1/test/full/failmessages.c:44:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, (char *) arr->buf + arr->off, rem);
data/criterion-2.3.3git1/test/full/failmessages.cc:36:10: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer, (char *) arr->buf + arr->off, rem);
data/criterion-2.3.3git1/test/unit/asprintf.c:49:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char expected[32];
data/criterion-2.3.3git1/test/unit/redirect.cc:31:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char contents[sizeof ("Hello")] = { 0 };
data/criterion-2.3.3git1/dev/cmake/test/test.c:6:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Test(strlen, empty)
data/criterion-2.3.3git1/dev/cmake/test/test.c:11:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Test(strlen, simple)
data/criterion-2.3.3git1/dev/cmake/test/test.c:16:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
Test(strlen, longer)
data/criterion-2.3.3git1/include/criterion/internal/common.h:68:28: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
__pragma(section(Name, read)) \
data/criterion-2.3.3git1/include/criterion/new/stream.h:44:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int (*read)(void *cookie, void *buf, size_t *size);
data/criterion-2.3.3git1/include/criterion/new/stream.h:50:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int (*read)(void *cookie, void *buf, size_t *size),
data/criterion-2.3.3git1/include/criterion/new/stream.h:57:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read = other.read;
data/criterion-2.3.3git1/include/criterion/new/stream.h:94:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int (*read)(void *cookie, void *buf, size_t *size),
data/criterion-2.3.3git1/include/criterion/new/stream.h:97:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
, read(read)
data/criterion-2.3.3git1/include/criterion/new/stream.h:97:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
, read(read)
data/criterion-2.3.3git1/samples/parameterized.c:99:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *ptr = cr_malloc(strlen(str) + 1);
data/criterion-2.3.3git1/samples/redirect.c:38:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size_t read;
data/criterion-2.3.3git1/samples/redirect.c:41:32: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
for (size_t i = 0; i < read; ++i)
data/criterion-2.3.3git1/samples/redirect.c:43:24: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
fwrite(buf, 1, read, stdout);
data/criterion-2.3.3git1/src/capi/stream.c:55:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (m1->read(m1->cookie, m1->cri_data->buffer, &r1) != 0) {
data/criterion-2.3.3git1/src/capi/stream.c:60:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (m2->read(m2->cookie, m2->cri_data->buffer, &r2) != 0) {
data/criterion-2.3.3git1/src/compat/path.c:87:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
|| (strlen(path) > 3 && path[1] == ':' && path[2] == '\\');
data/criterion-2.3.3git1/src/compat/path.c:193:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t idx = strlen(str);
data/criterion-2.3.3git1/src/compat/pipe.c:324:60: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (!ReadFile(pipe->fh, (char *) buf + off, size, &read, NULL))
data/criterion-2.3.3git1/src/compat/pipe.c:326:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size -= read;
data/criterion-2.3.3git1/src/compat/pipe.c:327:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
off += read;
data/criterion-2.3.3git1/src/compat/pipe.c:333:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t res = read(pipe->fd, buf, size);
data/criterion-2.3.3git1/src/compat/section-elf.c:94:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(fullpath, self, PATH_MAX);
data/criterion-2.3.3git1/src/core/assert.c:129:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t expected_len = strlen(tree->params[0].data);
data/criterion-2.3.3git1/src/core/assert.c:130:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t actual_len = strlen(tree->params[1].data);
data/criterion-2.3.3git1/src/core/assert.c:230:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(fmt) == 1)
data/criterion-2.3.3git1/src/core/client.c:521:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
param->size = strlen(entry->data.str);
data/criterion-2.3.3git1/src/core/runner_coroutine.c:92:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
test->name, strlen(test->name) + 1);
data/criterion-2.3.3git1/src/core/runner_coroutine.c:95:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
test->category, strlen(test->category) + 1);
data/criterion-2.3.3git1/src/core/runner_coroutine.c:110:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
suite->name, strlen(suite->name) + 1);
data/criterion-2.3.3git1/src/core/runner_coroutine.c:283:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(ctx->url) + 1;
data/criterion-2.3.3git1/src/core/theories.c:255:21: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat(result.msg, ", ", sizeof (result.msg) - 1);
data/criterion-2.3.3git1/src/core/theories.c:258:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
result.len = strlen(result.msg) + 1;
data/criterion-2.3.3git1/src/entry/params.c:176:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *val = dup + strlen(transport) + 1;
data/criterion-2.3.3git1/src/entry/params.c:218:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(criterion_options.encoding, encoding, maxlen);
data/criterion-2.3.3git1/src/io/file.c:5:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(str);
data/criterion-2.3.3git1/src/io/file.c:8:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size_t read;
data/criterion-2.3.3git1/src/io/file.c:12:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
matches = !strncmp(buf, str, read);
data/criterion-2.3.3git1/src/io/file.c:13:25: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (!matches || read > len) {
data/criterion-2.3.3git1/src/io/file.c:18:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
len -= read;
data/criterion-2.3.3git1/src/io/file.c:19:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
str += read;
data/criterion-2.3.3git1/src/io/file.c:23:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read)
data/criterion-2.3.3git1/src/log/normal.c:282:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bexpected.size = strlen(bexpected.ptr) + 1;
data/criterion-2.3.3git1/src/log/normal.c:287:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
bactual.size = strlen(bactual.ptr) + 1;
data/criterion-2.3.3git1/src/protocol/messages.c:35:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read;
data/criterion-2.3.3git1/src/protocol/messages.c:40:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
} while (read < 0 && errno == EINTR);
data/criterion-2.3.3git1/src/protocol/messages.c:42:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read <= 0)
data/criterion-2.3.3git1/src/protocol/messages.c:45:55: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
pb_istream_t stream = pb_istream_from_buffer(buf, read);
data/criterion-2.3.3git1/src/protocol/messages.c:55:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return read;
data/criterion-2.3.3git1/src/protocol/messages.c:121:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int read;
data/criterion-2.3.3git1/src/protocol/messages.c:125:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
} while (read < 0 && errno == EINTR);
data/criterion-2.3.3git1/src/protocol/messages.c:134:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read <= 0) {
data/criterion-2.3.3git1/src/protocol/messages.c:140:55: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
pb_istream_t stream = pb_istream_from_buffer(buf, read);
data/criterion-2.3.3git1/src/string/brz.c:109:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(string) == 0) {
data/criterion-2.3.3git1/test/unit/redirect.cc:85:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::string read;
data/criterion-2.3.3git1/test/unit/redirect.cc:86:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::cin >> read;
data/criterion-2.3.3git1/test/unit/redirect.cc:88:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
cr_expect_eq(read, "Foo");
ANALYSIS SUMMARY:
Hits = 182
Lines analyzed = 30202 in approximately 0.98 seconds (30775 lines/second)
Physical Source Lines of Code (SLOC) = 19102
Hits@level = [0] 89 [1] 57 [2] 50 [3] 17 [4] 56 [5] 2
Hits@level+ = [0+] 271 [1+] 182 [2+] 125 [3+] 75 [4+] 58 [5+] 2
Hits/KSLOC@level+ = [0+] 14.187 [1+] 9.5278 [2+] 6.54382 [3+] 3.92629 [4+] 3.03633 [5+] 0.104701
Dot directories skipped = 2 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.