Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/cronie-1.5.5/anacron/global.h
Examining data/cronie-1.5.5/anacron/gregor.c
Examining data/cronie-1.5.5/anacron/gregor.h
Examining data/cronie-1.5.5/anacron/lock.c
Examining data/cronie-1.5.5/anacron/log.c
Examining data/cronie-1.5.5/anacron/main.c
Examining data/cronie-1.5.5/anacron/matchrx.c
Examining data/cronie-1.5.5/anacron/matchrx.h
Examining data/cronie-1.5.5/anacron/readtab.c
Examining data/cronie-1.5.5/anacron/runjob.c
Examining data/cronie-1.5.5/src/database.c
Examining data/cronie-1.5.5/src/do_command.c
Examining data/cronie-1.5.5/src/job.c
Examining data/cronie-1.5.5/src/popen.c
Examining data/cronie-1.5.5/src/user.c
Examining data/cronie-1.5.5/src/bitstring.h
Examining data/cronie-1.5.5/src/env.c
Examining data/cronie-1.5.5/src/externs.h
Examining data/cronie-1.5.5/src/funcs.h
Examining data/cronie-1.5.5/src/globals.h
Examining data/cronie-1.5.5/src/misc.c
Examining data/cronie-1.5.5/src/pw_dup.c
Examining data/cronie-1.5.5/src/structs.h
Examining data/cronie-1.5.5/src/cronnext.c
Examining data/cronie-1.5.5/src/crontab.c
Examining data/cronie-1.5.5/src/cron.c
Examining data/cronie-1.5.5/src/security.c
Examining data/cronie-1.5.5/src/entry.c
Examining data/cronie-1.5.5/src/pathnames.h
Examining data/cronie-1.5.5/src/macros.h
Examining data/cronie-1.5.5/cronie_common.h
Examining data/cronie-1.5.5/anacron-paths.h
FINAL RESULTS:
data/cronie-1.5.5/src/crontab.c:907:6: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
if (chown(TempFilename, file_owner, (gid_t)-1) < OK) {
data/cronie-1.5.5/src/misc.c:275:8: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
if (chown(SPOOL_DIR, -1, grp->gr_gid) == -1) {
data/cronie-1.5.5/src/misc.c:281:8: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
if (chmod(SPOOL_DIR, 01730) == -1) {
data/cronie-1.5.5/anacron/global.h:125:28: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format (printf, n, m)))
data/cronie-1.5.5/anacron/log.c:81:11: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = vsnprintf(msg, sizeof(msg), fmt, args);
data/cronie-1.5.5/anacron/log.c:88:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(msg + sizeof(msg) - sizeof(truncated), truncated);
data/cronie-1.5.5/anacron/readtab.c:150:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(er->assign, env_var);
data/cronie-1.5.5/anacron/readtab.c:152:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(er->assign + var_len + 1, value);
data/cronie-1.5.5/anacron/readtab.c:193:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(jr->ident, ident);
data/cronie-1.5.5/anacron/readtab.c:199:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(jr->command, command);
data/cronie-1.5.5/anacron/readtab.c:254:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(jr->ident, ident);
data/cronie-1.5.5/anacron/readtab.c:260:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(jr->command, command);
data/cronie-1.5.5/anacron/runjob.c:136:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(val, s + eq_index + 1);
data/cronie-1.5.5/anacron/runjob.c:179:5: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl("/bin/sh", "/bin/sh", "-c", jr->command, (char *)NULL);
data/cronie-1.5.5/anacron/runjob.c:251:2: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl(SENDMAIL, SENDMAIL, "-FAnacron", "-odi",
data/cronie-1.5.5/src/cron.c:302:45: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (!SyslogOutput && MailCmd[0] == '\0' && access("/usr/sbin/sendmail", X_OK) != 0) {
data/cronie-1.5.5/src/cron.c:506:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(REBOOT_LOCK, F_OK) == 0) {
data/cronie-1.5.5/src/cronnext.c:118:32: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
printf(" system: %d\n", u->system);
data/cronie-1.5.5/src/cronnext.c:241:31: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (!(flags & SYSTEM) && u->system)
data/cronie-1.5.5/src/crontab.c:226:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(User, pw->pw_name);
data/cronie-1.5.5/src/crontab.c:227:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(RealUser, User);
data/cronie-1.5.5/src/crontab.c:265:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(User, optarg);
data/cronie-1.5.5/src/crontab.c:332:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(Host, argv[optind]);
data/cronie-1.5.5/src/crontab.c:345:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
(void) strcpy(Filename, argv[optind]);
data/cronie-1.5.5/src/crontab.c:489:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(hostname, safename);
data/cronie-1.5.5/src/crontab.c:645:3: [4] (shell) execlp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execlp(_PATH_BSHELL, _PATH_BSHELL, "-c", q, (char *) 0);
data/cronie-1.5.5/src/do_command.c:255:5: [4] (shell) execle:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execle(shell, shell, "-c", e->cmd, (char *) 0, jobenv);
data/cronie-1.5.5/src/do_command.c:432:12: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
len = snprintf(mailcmd, sizeof mailcmd, MAILFMT, MAILARG, mailfrom);
data/cronie-1.5.5/src/do_command.c:558:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf,
data/cronie-1.5.5/src/macros.h:99:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf message
data/cronie-1.5.5/src/misc.c:323:4: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "can't open or create %s", pidfile);
data/cronie-1.5.5/src/misc.c:643:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
(void) sprintf(ret, "%s, %2d %s %2d %02d:%02d:%02d %.2d%.2d (%s)",
data/cronie-1.5.5/src/security.c:129:11: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if ((!u->system || e->pwd->pw_uid != 0) && (ret = cron_start_pam(e->pwd)) != 0) {
data/cronie-1.5.5/src/structs.h:70:7: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
int system; /* is it a system crontab */
data/cronie-1.5.5/src/user.c:120:35: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (!skip_comments(file) && !u->system) {
data/cronie-1.5.5/src/user.c:139:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (!u->system && entries > MAX_USER_ENTRIES) {
data/cronie-1.5.5/src/user.c:153:13: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (!u->system && envs > MAX_USER_ENVS) {
data/cronie-1.5.5/anacron/main.c:108:19: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "sfundqt:TS:Vh")) != EOF)
data/cronie-1.5.5/anacron/main.c:450:5: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom((unsigned int)(getpid() + tv.tv_usec));
data/cronie-1.5.5/anacron/readtab.c:280:14: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
rn = random() / divisor;
data/cronie-1.5.5/anacron/runjob.c:51:11: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
dir = getenv("TMPDIR");
data/cronie-1.5.5/anacron/runjob.c:298:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
mailto = getenv("MAILTO");
data/cronie-1.5.5/anacron/runjob.c:304:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
mailfrom = getenv("MAILFROM");
data/cronie-1.5.5/src/cron.c:312:2: [3] (random) srandom:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srandom((unsigned int)(pid + tv.tv_usec));
data/cronie-1.5.5/src/cron.c:313:24: [3] (random) random:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
RandomScale = (double)random() / (double)RAND_MAX;
data/cronie-1.5.5/src/cron.c:559:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
orig_tz = getenv("TZ");
data/cronie-1.5.5/src/cron.c:694:24: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while (-1 != (argch = getopt(argc, argv, "hnpsiPx:m:cV"))) {
data/cronie-1.5.5/src/cronnext.c:348:22: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while (-1 != (opt = getopt(argn, argv, "i:e:ast:q:j:lcfhV"))) {
data/cronie-1.5.5/src/crontab.c:232:24: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while (-1 != (argch = getopt(argc, argv, getoptargs))) {
data/cronie-1.5.5/src/crontab.c:467:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
tmpdir = getenv("TMPDIR");
data/cronie-1.5.5/src/crontab.c:614:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (((editor = getenv("VISUAL")) == NULL || *editor == '\0') &&
data/cronie-1.5.5/src/crontab.c:615:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
((editor = getenv("EDITOR")) == NULL || *editor == '\0')) {
data/cronie-1.5.5/src/entry.c:357:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
defpath = getenv("PATH");
data/cronie-1.5.5/src/externs.h:60:5: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
int getopt(int, char * const *, const char *);
data/cronie-1.5.5/anacron/lock.c:43:24: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
jr->timestamp_fd = open(jr->ident, O_RDWR | O_CREAT, S_IRUSR | S_IWUSR);
data/cronie-1.5.5/anacron/lock.c:82:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char timestamp[9];
data/cronie-1.5.5/anacron/lock.c:199:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char stamp[10];
data/cronie-1.5.5/anacron/log.c:50:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char msg[MAX_MSG + 1];
data/cronie-1.5.5/anacron/main.c:187:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
rfd = open(file_name, flags);
data/cronie-1.5.5/anacron/main.c:465:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((cwd = open ("./", O_RDONLY)) == -1) {
data/cronie-1.5.5/anacron/readtab.c:320:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
range_start = atoi(from);
data/cronie-1.5.5/anacron/readtab.c:321:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
range_stop = atoi(to);
data/cronie-1.5.5/anacron/readtab.c:333:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
random_number = (int)unbiased_rand(atoi(value));
data/cronie-1.5.5/anacron/readtab.c:341:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
preferred_hour = atoi(pref_hour);
data/cronie-1.5.5/anacron/readtab.c:395:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
tab = fopen(anacrontab, "r");
data/cronie-1.5.5/anacron/runjob.c:46:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char template[PATH_MAX+1];
data/cronie-1.5.5/anacron/runjob.c:61:13: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
fdout = mkstemp(template);
data/cronie-1.5.5/anacron/runjob.c:64:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fdin = open(template, O_RDONLY, S_IRUSR | S_IWUSR);
data/cronie-1.5.5/anacron/runjob.c:286:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[512];
data/cronie-1.5.5/anacron/runjob.c:292:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (hostname,"unknown machine");
data/cronie-1.5.5/src/cron.c:93:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *watchpaths[NUM_WATCHES] = {SPOOL_DIR, SYS_CROND_DIR, SYSCRONTAB};
data/cronie-1.5.5/src/cron.c:97:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *watchpaths[NUM_WATCHES] = {SPOOL_DIR, SYS_CROND_DIR};
data/cronie-1.5.5/src/cron.c:210:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/cronie-1.5.5/src/cron.c:268:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(cron_default_mail_charset, "US-ASCII");
data/cronie-1.5.5/src/cron.c:286:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(_PATH_DEVNULL, O_RDWR, 0)) >= 0) {
data/cronie-1.5.5/src/cronnext.c:282:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(*additional, O_RDONLY);
data/cronie-1.5.5/src/cronnext.c:363:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
start = atoi(optarg) / 60 * 60;
data/cronie-1.5.5/src/cronnext.c:366:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
end = atoi(optarg) / 60 * 60;
data/cronie-1.5.5/src/crontab.c:94:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char User[MAX_UNAME], RealUser[MAX_UNAME];
data/cronie-1.5.5/src/crontab.c:95:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char Filename[MAX_FNAME], TempFilename[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:96:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char Host[MAXHOSTNAMELEN];
data/cronie-1.5.5/src/crontab.c:368:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(NewCrontab = fopen(Filename, "r"))) {
data/cronie-1.5.5/src/crontab.c:395:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:406:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(n, "r"))) {
data/cronie-1.5.5/src/crontab.c:433:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME] = "";
data/cronie-1.5.5/src/crontab.c:480:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char safename[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:481:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:500:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME], q[MAX_TEMPSTR];
data/cronie-1.5.5/src/crontab.c:514:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(n, "r"))) {
data/cronie-1.5.5/src/crontab.c:520:13: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(_PATH_DEVNULL, "r"))) {
data/cronie-1.5.5/src/crontab.c:540:17: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if (-1 == (t = mkstemp(Filename))) {
data/cronie-1.5.5/src/crontab.c:710:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(NewCrontab = fopen(Filename, "r+"))) {
data/cronie-1.5.5/src/crontab.c:763:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME], envstr[MAX_ENVSTR];
data/cronie-1.5.5/src/crontab.c:781:12: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if ((fd = mkstemp(TempFilename)) == -1 || !(tmp = fdopen(fd, "w+"))) {
data/cronie-1.5.5/src/crontab.c:950:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:966:12: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if ((fd = mkstemp(TempFilename)) == -1 || !(tmp = fdopen(fd, "w"))) {
data/cronie-1.5.5/src/crontab.c:1019:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char n[MAX_FNAME];
data/cronie-1.5.5/src/crontab.c:1027:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(f = fopen(n, "r"))) {
data/cronie-1.5.5/src/database.c:76:4: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(tabname, O_RDONLY | O_NONBLOCK, 0)) == -1) {
data/cronie-1.5.5/src/database.c:287:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[NAME_MAX+1];
data/cronie-1.5.5/src/database.c:290:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[MAXHOSTNAMELEN], myhostname[MAXHOSTNAMELEN];
data/cronie-1.5.5/src/database.c:309:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f = fopen(filename, "r"))) {
data/cronie-1.5.5/src/database.c:335:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[BUF_LEN];
data/cronie-1.5.5/src/database.c:384:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tabname[NAME_MAX + 1];
data/cronie-1.5.5/src/database.c:402:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[NAME_MAX + 1], tabname[NAME_MAX + 1];
data/cronie-1.5.5/src/database.c:534:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tabname[NAME_MAX + 1];
data/cronie-1.5.5/src/database.c:561:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fname[NAME_MAX + 1], tabname[NAME_MAX + 1];
data/cronie-1.5.5/src/database.c:670:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tabname[NAME_MAX + 1];
data/cronie-1.5.5/src/do_command.c:375:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char logbuf[1024];
data/cronie-1.5.5/src/do_command.c:421:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mailcmd[MAX_COMMAND+1]; /* +1 for terminator */
data/cronie-1.5.5/src/do_command.c:422:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hostname[MAXHOSTNAMELEN];
data/cronie-1.5.5/src/do_command.c:556:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAX_TEMPSTR];
data/cronie-1.5.5/src/entry.c:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[MAX_COMMAND];
data/cronie-1.5.5/src/entry.c:99:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char envstr[MAX_ENVSTR];
data/cronie-1.5.5/src/entry.c:575:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char temp[MAX_TEMPSTR], *pc;
data/cronie-1.5.5/src/entry.c:593:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*numptr = atoi(temp);
data/cronie-1.5.5/src/env.c:292:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char envstr[MAX_ENVSTR];
data/cronie-1.5.5/src/externs.h:42:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char *tzname[2];
data/cronie-1.5.5/src/globals.h:80:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
XTRN char MailCmd[MAX_COMMAND+1]; /* +1 for terminator */
data/cronie-1.5.5/src/globals.h:81:6: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
XTRN char cron_default_mail_charset[MAX_ENVSTR];
data/cronie-1.5.5/src/misc.c:299:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[3 * MAX_FNAME];
data/cronie-1.5.5/src/misc.c:321:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(pidfile, O_RDWR | O_CREAT, 0600)) == -1) {
data/cronie-1.5.5/src/misc.c:360:2: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf, "%ld\n", (long) pid);
data/cronie-1.5.5/src/misc.c:486:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
LogFD = open(LOG_FILE, O_WRONLY | O_APPEND | O_CREAT, 0600);
data/cronie-1.5.5/src/misc.c:563:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char retbuf[2][MAX_TEMPSTR + 1]; /* sure wish C had GC */
data/cronie-1.5.5/src/misc.c:611:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(dst, "\\%03o", ch);
data/cronie-1.5.5/src/misc.c:641:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char ret[64]; /* zone name might be >3 chars */
data/cronie-1.5.5/src/popen.c:68:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *argv[MAX_ARGS];
data/cronie-1.5.5/src/popen.c:70:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[PIPE_BUF];
data/cronie-1.5.5/src/pw_dup.c:89:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(newpw, pw, sizeof(struct passwd));
data/cronie-1.5.5/src/pw_dup.c:92:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_name, nsize);
data/cronie-1.5.5/src/pw_dup.c:97:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_passwd, psize);
data/cronie-1.5.5/src/pw_dup.c:103:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_class, csize);
data/cronie-1.5.5/src/pw_dup.c:109:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_gecos, gsize);
data/cronie-1.5.5/src/pw_dup.c:114:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_dir, dsize);
data/cronie-1.5.5/src/pw_dup.c:119:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
(void)memcpy(cp, pw->pw_shell, ssize);
data/cronie-1.5.5/src/security.c:179:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[256];
data/cronie-1.5.5/src/security.c:684:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[MAX_TEMPSTR];
data/cronie-1.5.5/src/security.c:713:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/cronie-1.5.5/src/security.c:718:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(allow_file, "r")) != NULL) {
data/cronie-1.5.5/src/security.c:728:17: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
else if ((fp = fopen(deny_file, "r")) != NULL) {
data/cronie-1.5.5/src/user.c:66:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char envstr[MAX_ENVSTR];
data/cronie-1.5.5/anacron/lock.c:89:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
b = read(jr->timestamp_fd, timestamp, 8);
data/cronie-1.5.5/anacron/log.c:83:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120). Risk is low because the source is a
constant string.
strncpy(msg, "(vsnprintf failed)", sizeof(msg));
data/cronie-1.5.5/anacron/readtab.c:94:6: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(tab);
data/cronie-1.5.5/anacron/readtab.c:135:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
var_len = (int)strlen(env_var);
data/cronie-1.5.5/anacron/readtab.c:136:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
val_len = (int)strlen(value);
data/cronie-1.5.5/anacron/readtab.c:169:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ident_len = (int)strlen(ident);
data/cronie-1.5.5/anacron/readtab.c:170:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
command_len = (int)strlen(command);
data/cronie-1.5.5/anacron/readtab.c:219:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ident_len = (int)strlen(ident);
data/cronie-1.5.5/anacron/readtab.c:220:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
command_len = (int)strlen(command);
data/cronie-1.5.5/anacron/runjob.c:129:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
val = malloc((strlen(s) - eq_index) * sizeof(char));
data/cronie-1.5.5/anacron/runjob.c:134:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(name, s, eq_index);
data/cronie-1.5.5/anacron/runjob.c:188:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (write(fd, string, strlen(string)) == -1)
data/cronie-1.5.5/src/cron.c:266:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(cron_default_mail_charset, cs, MAX_ENVSTR-1);
data/cronie-1.5.5/src/cron.c:716:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(MailCmd, optarg, MAX_COMMAND);
data/cronie-1.5.5/src/cronnext.c:204:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t l = strlen(user_name);
data/cronie-1.5.5/src/crontab.c:222:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(pw->pw_name) >= sizeof User) {
data/cronie-1.5.5/src/crontab.c:263:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(optarg) >= sizeof User)
data/cronie-1.5.5/src/crontab.c:330:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(argv[optind]) >= sizeof Host)
data/cronie-1.5.5/src/crontab.c:343:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(argv[optind]) >= sizeof Filename)
data/cronie-1.5.5/src/database.c:353:25: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((retval = (int)read(old_db->ifd, buf, sizeof (buf))) == -1 &&
data/cronie-1.5.5/src/database.c:407:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(fname, dp->d_name, NAME_MAX + 1);
data/cronie-1.5.5/src/database.c:566:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(fname, dp->d_name, NAME_MAX + 1);
data/cronie-1.5.5/src/database.c:641:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(dp->d_name);
data/cronie-1.5.5/src/do_command.c:195:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *x = mkprints((u_char *) e->cmd, strlen(e->cmd));
data/cronie-1.5.5/src/do_command.c:368:12: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
int ch = getc(in);
data/cronie-1.5.5/src/do_command.c:443:6: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(mailcmd, MailCmd, MAX_COMMAND+1);
data/cronie-1.5.5/src/do_command.c:468:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t ctlen = strlen(content_type);
data/cronie-1.5.5/src/do_command.c:478:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t ctlen = strlen(content_transfer_encoding);
data/cronie-1.5.5/src/do_command.c:508:24: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while (EOF != (ch = getc(in))) {
data/cronie-1.5.5/src/entry.c:310:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(e->pwd->pw_passwd, 0, strlen(e->pwd->pw_passwd));
data/cronie-1.5.5/src/env.c:150:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
namelen = strlen(*name);
data/cronie-1.5.5/src/env.c:279:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(name);
data/cronie-1.5.5/src/misc.c:334:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((num = read(fd, buf, sizeof (buf) - 1)) > 0 &&
data/cronie-1.5.5/src/misc.c:362:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = (ssize_t)strlen(buf);
data/cronie-1.5.5/src/misc.c:380:7: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ch = getc(file);
data/cronie-1.5.5/src/misc.c:475:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
msg = malloc(msg_size = (strlen(username)
data/cronie-1.5.5/src/misc.c:476:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
+ strlen(event)
data/cronie-1.5.5/src/misc.c:477:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
+ strlen(detail)
data/cronie-1.5.5/src/misc.c:507:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (LogFD < OK || write(LogFD, msg, strlen(msg)) < OK) {
data/cronie-1.5.5/src/misc.c:511:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(STDERR, msg, strlen(msg));
data/cronie-1.5.5/src/misc.c:686:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ret += strlen(str);
data/cronie-1.5.5/src/popen.c:145:24: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while (0 != (out = read(STDIN, buf, PIPE_BUF))) {
data/cronie-1.5.5/src/pw_dup.c:56:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
nsize = strlen(pw->pw_name) + 1;
data/cronie-1.5.5/src/pw_dup.c:60:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
psize = strlen(pw->pw_passwd) + 1;
data/cronie-1.5.5/src/pw_dup.c:65:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
csize = strlen(pw->pw_class) + 1;
data/cronie-1.5.5/src/pw_dup.c:70:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gsize = strlen(pw->pw_gecos) + 1;
data/cronie-1.5.5/src/pw_dup.c:74:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
dsize = strlen(pw->pw_dir) + 1;
data/cronie-1.5.5/src/pw_dup.c:78:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ssize = strlen(pw->pw_shell) + 1;
data/cronie-1.5.5/src/security.c:691:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
endp = &line[strlen(line) - 1];
ANALYSIS SUMMARY:
Hits = 191
Lines analyzed = 9652 in approximately 0.44 seconds (22011 lines/second)
Physical Source Lines of Code (SLOC) = 6689
Hits@level = [0] 208 [1] 49 [2] 88 [3] 17 [4] 34 [5] 3
Hits@level+ = [0+] 399 [1+] 191 [2+] 142 [3+] 54 [4+] 37 [5+] 3
Hits/KSLOC@level+ = [0+] 59.6502 [1+] 28.5543 [2+] 21.2289 [3+] 8.07296 [4+] 5.53147 [5+] 0.448498
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.