Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/dbus-c++-0.9.0/test/generator/dbuscxx_test_generator-server.h
Examining data/dbus-c++-0.9.0/test/generator/dbuscxx_test_generator-client.cpp
Examining data/dbus-c++-0.9.0/test/generator/dbuscxx_test_generator-client.h
Examining data/dbus-c++-0.9.0/test/generator/dbuscxx_test_generator-server.cpp
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestAppIntroProviderPrivate.h
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestAppIntroPrivate.h
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestAppMain.cpp
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestAppIntro.h
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestApp.cpp
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestApp.h
Examining data/dbus-c++-0.9.0/test/functional/Test1/TestAppIntroProvider.h
Examining data/dbus-c++-0.9.0/tools/generate_proxy.h
Examining data/dbus-c++-0.9.0/tools/generator_utils.cpp
Examining data/dbus-c++-0.9.0/tools/introspect.h
Examining data/dbus-c++-0.9.0/tools/introspect.cpp
Examining data/dbus-c++-0.9.0/tools/generate_proxy.cpp
Examining data/dbus-c++-0.9.0/tools/xml.cpp
Examining data/dbus-c++-0.9.0/tools/generate_adaptor.h
Examining data/dbus-c++-0.9.0/tools/xml.h
Examining data/dbus-c++-0.9.0/tools/xml2cpp.cpp
Examining data/dbus-c++-0.9.0/tools/generate_adaptor.cpp
Examining data/dbus-c++-0.9.0/tools/generator_utils.h
Examining data/dbus-c++-0.9.0/tools/xml2cpp.h
Examining data/dbus-c++-0.9.0/examples/echo/echo-client.cpp
Examining data/dbus-c++-0.9.0/examples/echo/echo-server.h
Examining data/dbus-c++-0.9.0/examples/echo/echo-client.h
Examining data/dbus-c++-0.9.0/examples/echo/echo-server.cpp
Examining data/dbus-c++-0.9.0/examples/echo/xgethostname.c
Examining data/dbus-c++-0.9.0/examples/echo/xgethostname.h
Examining data/dbus-c++-0.9.0/examples/hal/hal-listen.h
Examining data/dbus-c++-0.9.0/examples/hal/hal-listen.cpp
Examining data/dbus-c++-0.9.0/examples/ecore/dbus_ecore.cpp
Examining data/dbus-c++-0.9.0/examples/ecore/dbus_ecore.h
Examining data/dbus-c++-0.9.0/examples/glib/dbus-browser.cpp
Examining data/dbus-c++-0.9.0/examples/glib/dbus-browser.h
Examining data/dbus-c++-0.9.0/examples/echo_ecore/echo-client.cpp
Examining data/dbus-c++-0.9.0/examples/echo_ecore/echo-server.h
Examining data/dbus-c++-0.9.0/examples/echo_ecore/echo-client.h
Examining data/dbus-c++-0.9.0/examples/echo_ecore/echo-server.cpp
Examining data/dbus-c++-0.9.0/examples/echo_ecore/xgethostname.c
Examining data/dbus-c++-0.9.0/examples/echo_ecore/xgethostname.h
Examining data/dbus-c++-0.9.0/examples/properties/propsgs-server.h
Examining data/dbus-c++-0.9.0/examples/properties/propsgs-client.h
Examining data/dbus-c++-0.9.0/examples/properties/propsgs-server.cpp
Examining data/dbus-c++-0.9.0/examples/properties/propsgs-client.cpp
Examining data/dbus-c++-0.9.0/src/server_p.h
Examining data/dbus-c++-0.9.0/src/integration/ecore/ecore-integration.cpp
Examining data/dbus-c++-0.9.0/src/integration/glib/glib-integration.cpp
Examining data/dbus-c++-0.9.0/src/eventloop.cpp
Examining data/dbus-c++-0.9.0/src/error.cpp
Examining data/dbus-c++-0.9.0/src/debug.cpp
Examining data/dbus-c++-0.9.0/src/property.cpp
Examining data/dbus-c++-0.9.0/src/connection_p.h
Examining data/dbus-c++-0.9.0/src/message_p.h
Examining data/dbus-c++-0.9.0/src/server.cpp
Examining data/dbus-c++-0.9.0/src/pendingcall.cpp
Examining data/dbus-c++-0.9.0/src/introspection.cpp
Examining data/dbus-c++-0.9.0/src/dispatcher_p.h
Examining data/dbus-c++-0.9.0/src/dispatcher.cpp
Examining data/dbus-c++-0.9.0/src/pendingcall_p.h
Examining data/dbus-c++-0.9.0/src/types.cpp
Examining data/dbus-c++-0.9.0/src/connection.cpp
Examining data/dbus-c++-0.9.0/src/message.cpp
Examining data/dbus-c++-0.9.0/src/internalerror.h
Examining data/dbus-c++-0.9.0/src/interface.cpp
Examining data/dbus-c++-0.9.0/src/object.cpp
Examining data/dbus-c++-0.9.0/src/eventloop-integration.cpp
Examining data/dbus-c++-0.9.0/src/pipe.cpp
Examining data/dbus-c++-0.9.0/include/dbus-c++/ecore-integration.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/interface.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/api.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/introspection.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/refptr_impl.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/util.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/types.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/message.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/server.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/eventloop-integration.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/connection.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/object.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/pipe.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/error.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/debug.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/glib-integration.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/dbus.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/eventloop.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/pendingcall.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/property.h
Examining data/dbus-c++-0.9.0/include/dbus-c++/dispatcher.h
FINAL RESULTS:
data/dbus-c++-0.9.0/examples/echo/echo-server.cpp:69:22: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
info["username"] = getlogin();
data/dbus-c++-0.9.0/examples/echo_ecore/echo-server.cpp:69:22: [4] (misc) getlogin:
It's often easy to fool getlogin. Sometimes it does not work at all,
because some program messed up the utmp file. Often, it gives only the
first 8 characters of the login name. The user currently logged in on the
controlling tty of our program need not be the user who started it. Avoid
getlogin() for security-related purposes (CWE-807). Use getpwuid(geteuid())
and extract the desired information instead.
info["username"] = getlogin();
data/dbus-c++-0.9.0/src/debug.cpp:46:5: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, args);
data/dbus-c++-0.9.0/src/introspection.cpp:71:21: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
std::string access;
data/dbus-c++-0.9.0/src/introspection.cpp:78:32: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
<< " access=\"" << access << "\"/>";
data/dbus-c++-0.9.0/src/debug.cpp:38:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
static int debug_env = getenv("DBUSXX_VERBOSE") ? 1 : 0;
data/dbus-c++-0.9.0/examples/echo/echo-client.cpp:40:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char idstr[16];
data/dbus-c++-0.9.0/examples/echo/echo-server.cpp:40:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *handle = fopen(file.c_str(), "rb");
data/dbus-c++-0.9.0/examples/echo_ecore/echo-client.cpp:44:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char idstr[16];
data/dbus-c++-0.9.0/examples/echo_ecore/echo-server.cpp:40:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE *handle = fopen(file.c_str(), "rb");
data/dbus-c++-0.9.0/include/dbus-c++/message.h:151:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char _iter[sizeof(void *) * 3 + sizeof(int) * 11];
data/dbus-c++-0.9.0/src/eventloop-integration.cpp:107:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024]; // TODO: should be max pipe size
data/dbus-c++-0.9.0/src/message.cpp:337:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char value[8];
data/dbus-c++-0.9.0/examples/echo/echo-client.cpp:45:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
thread_pipe_list[i]->write(idstr, strlen(idstr) + 1);
data/dbus-c++-0.9.0/examples/echo_ecore/echo-client.cpp:49:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
thread_pipe_list[i]->write(idstr, strlen(idstr) + 1);
data/dbus-c++-0.9.0/include/dbus-c++/interface.h:42:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
bool read;
data/dbus-c++-0.9.0/include/dbus-c++/introspection.h:51:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
const bool read;
data/dbus-c++-0.9.0/include/dbus-c++/pipe.h:47:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t read(void *buffer, unsigned int &nbytes);
data/dbus-c++-0.9.0/src/eventloop-integration.cpp:110:25: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while (read_pipe->read(buffer, nbytes) > 0)
data/dbus-c++-0.9.0/src/eventloop-integration.cpp:125:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int ret = write(_fdunlock[1], "exit", strlen("exit"));
data/dbus-c++-0.9.0/src/interface.cpp:88:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (!pti->second.read)
data/dbus-c++-0.9.0/src/introspection.cpp:73:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (p->read) access += "read";
data/dbus-c++-0.9.0/src/pipe.cpp:73:15: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t Pipe::read(void *buffer, unsigned int &nbytes)
data/dbus-c++-0.9.0/src/pipe.cpp:77:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
::read(_fd_read, &nbytes, sizeof(nbytes));
data/dbus-c++-0.9.0/src/pipe.cpp:80:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return ::read(_fd_read, buffer, nbytes);
ANALYSIS SUMMARY:
Hits = 25
Lines analyzed = 12587 in approximately 0.33 seconds (37759 lines/second)
Physical Source Lines of Code (SLOC) = 7857
Hits@level = [0] 8 [1] 12 [2] 7 [3] 1 [4] 5 [5] 0
Hits@level+ = [0+] 33 [1+] 25 [2+] 13 [3+] 6 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 4.20008 [1+] 3.18188 [2+] 1.65458 [3+] 0.76365 [4+] 0.636375 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.