Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/desproxy-0.1.0~pre3/src/desproxy-inetd.c
Examining data/desproxy-0.1.0~pre3/src/util.c
Examining data/desproxy-0.1.0~pre3/src/desproxy.c
Examining data/desproxy-0.1.0~pre3/src/util.h
Examining data/desproxy-0.1.0~pre3/src/socket2socket.c
Examining data/desproxy-0.1.0~pre3/src/desproxy-dns.c
Examining data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c
Examining data/desproxy-0.1.0~pre3/src/desproxy.h
FINAL RESULTS:
data/desproxy-0.1.0~pre3/src/util.c:64:11: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
n = vprintf (fmt, ap);
data/desproxy-0.1.0~pre3/src/util.c:389:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, remote_host);
data/desproxy-0.1.0~pre3/src/util.c:391:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, remote_port);
data/desproxy-0.1.0~pre3/src/util.c:393:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, remote_host);
data/desproxy-0.1.0~pre3/src/util.c:395:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, remote_port);
data/desproxy-0.1.0~pre3/src/util.c:405:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, User_Agent);
data/desproxy-0.1.0~pre3/src/util.c:413:7: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat (string, proxy_authorization_base64);
data/desproxy-0.1.0~pre3/src/util.c:644:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (username, get_console_line ());
data/desproxy-0.1.0~pre3/src/util.c:653:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (password, get_console_line ());
data/desproxy-0.1.0~pre3/src/util.c:397:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("USER_AGENT") != NULL)
data/desproxy-0.1.0~pre3/src/util.c:399:29: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strncpy (User_Agent, getenv ("USER_AGENT"), 255);
data/desproxy-0.1.0~pre3/src/util.c:406:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (getenv ("PROXY_USER") != NULL)
data/desproxy-0.1.0~pre3/src/util.c:410:28: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
strncpy (proxy_user, getenv ("PROXY_USER"), 255);
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:22:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char UDP_buffer[MAXREQUESTLEN];
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:27:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[MAXREQUESTLEN];
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:59:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAXREQUESTLEN + 2];
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:65:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&buffer[2], UDP_buffer, size);
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:67:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (buffer, &htons_size, 2);
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:72:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (buffer, requests[connection].buffer, size + 2);
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:256:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&requests[connection].
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:17:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char remote_host[256], remote_port[6];
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:18:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char nmethods[MAX_CONNECTIONS];
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:19:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char methods[MAX_CONNECTIONS][256];
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:145:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (remote_host, "%d.%d.%d.%d", buffer[2], buffer[3], buffer[4],
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:147:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (remote_port, "%d", buffer[0] * 256 + buffer[1]);
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:219:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (remote_host, "%d.%d.%d.%d", buffer[0], buffer[1], buffer[2],
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:221:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (remote_port, "%d", buffer[4] * 256 + buffer[5]);
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:251:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (remote_port, "%d", buffer[0] * 256 + buffer[1]);
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:398:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
request_socket = listen_in_TCP_port (atoi (local_port));
data/desproxy-0.1.0~pre3/src/desproxy.c:153:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
request_socket = listen_in_TCP_port (atoi (local_port));
data/desproxy-0.1.0~pre3/src/desproxy.h:83:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char username[256], password[256];
data/desproxy-0.1.0~pre3/src/desproxy.h:84:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char console_line[256];
data/desproxy-0.1.0~pre3/src/desproxy.h:85:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char HTTP_return_code[4];
data/desproxy-0.1.0~pre3/src/desproxy.h:86:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char string[256];
data/desproxy-0.1.0~pre3/src/desproxy.h:87:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[BUFFER_SIZE];
data/desproxy-0.1.0~pre3/src/desproxy.h:88:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char client_socket_is_free[MAX_CONNECTIONS];
data/desproxy-0.1.0~pre3/src/socket2socket.c:18:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char client_socket_is_free[MAX_CONNECTIONS];
data/desproxy-0.1.0~pre3/src/socket2socket.c:72:5: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open (outfilename, O_CREAT | O_WRONLY, S_IREAD | S_IWRITE)) == -1)
data/desproxy-0.1.0~pre3/src/socket2socket.c:86:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
server.sin_port = htons (atoi (local_port));
data/desproxy-0.1.0~pre3/src/socket2socket.c:97:47: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
printf (gettext ("Listening in port %d\n"), atoi (local_port));
data/desproxy-0.1.0~pre3/src/socket2socket.c:162:8: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&remote.sin_addr, remote_hostent->h_addr,
data/desproxy-0.1.0~pre3/src/socket2socket.c:164:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
remote.sin_port = htons (atoi (remote_port));
data/desproxy-0.1.0~pre3/src/util.c:247:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (HTTP_return_code, "XXX");
data/desproxy-0.1.0~pre3/src/util.c:256:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (HTTP_return_code, &buffer[count + 1], 3);
data/desproxy-0.1.0~pre3/src/util.c:337:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proxy_user[256];
data/desproxy-0.1.0~pre3/src/util.c:338:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char User_Agent[256];
data/desproxy-0.1.0~pre3/src/util.c:377:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (&proxy.sin_addr, proxy_hostent->h_addr, proxy_hostent->h_length);
data/desproxy-0.1.0~pre3/src/util.c:378:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
proxy.sin_port = htons (atoi (proxy_port));
data/desproxy-0.1.0~pre3/src/util.c:388:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (string, "CONNECT ");
data/desproxy-0.1.0~pre3/src/util.c:392:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (string, " HTTP/1.1\r\nHost: ");
data/desproxy-0.1.0~pre3/src/util.c:396:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (string, "\r\nUser-Agent: ");
data/desproxy-0.1.0~pre3/src/util.c:403:8: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy (User_Agent, "Mozilla/4.0 (compatible; MSIE 5.5; Windows 98)");
data/desproxy-0.1.0~pre3/src/util.c:408:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char proxy_authorization_base64[257];
data/desproxy-0.1.0~pre3/src/util.c:412:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (string, "\r\nProxy-authorization: Basic ");
data/desproxy-0.1.0~pre3/src/util.c:417:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat (string, "\r\n\r\n");
data/desproxy-0.1.0~pre3/src/util.c:552:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((desproxy_conf = fopen ("desproxy.conf", "r")) == NULL)
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:97:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (proxy_socket[connection], buffer, 2)) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:105:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (proxy_socket[connection], &buffer[2], size)) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-dns.c:246:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (client_socket[connection], buffer,
data/desproxy-0.1.0~pre3/src/desproxy-inetd.c:23:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (0, buffer, sizeof (buffer))) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-inetd.c:47:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (proxy_socket[0], buffer, sizeof (buffer))) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:48:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:87:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:116:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:136:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 6) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:151:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:186:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 4) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:210:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 6) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:225:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:232:7: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy (remote_host, "");
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:235:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 1) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:241:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat (remote_host, (char*)buffer, 1);
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:243:7: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is low because the source is a
constant string.
strncat (remote_host, "\x00", 1);
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:245:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read (client_socket[connection], buffer, 2) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:281:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:321:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (client_socket[connection], buffer, sizeof (buffer))) == -1)
data/desproxy-0.1.0~pre3/src/desproxy-socksserver.c:483:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (proxy_socket[connection], buffer,
data/desproxy-0.1.0~pre3/src/desproxy.c:26:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (client_socket[connection], buffer, sizeof (buffer))) == -1)
data/desproxy-0.1.0~pre3/src/desproxy.c:54:16: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((count = read (proxy_socket[connection], buffer, sizeof (buffer))) == -1)
data/desproxy-0.1.0~pre3/src/socket2socket.c:189:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (remote_socket[index], buffer,
data/desproxy-0.1.0~pre3/src/socket2socket.c:233:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (client_socket[index], buffer,
data/desproxy-0.1.0~pre3/src/util.c:30:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen (s);
data/desproxy-0.1.0~pre3/src/util.c:83:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (count = 0; count < strlen (console_line); count++)
data/desproxy-0.1.0~pre3/src/util.c:99:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (count = 0; count < strlen (string); count++)
data/desproxy-0.1.0~pre3/src/util.c:178:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (count = 0; count < 25 - strlen (PROGRAM_NAME); count++)
data/desproxy-0.1.0~pre3/src/util.c:180:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (count = 0; count < 10 - strlen (PROGRAM_VERSION); count++)
data/desproxy-0.1.0~pre3/src/util.c:229:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strnsend (fd, string, strlen (string));
data/desproxy-0.1.0~pre3/src/util.c:284:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (fd, &buffer[count], 1);
data/desproxy-0.1.0~pre3/src/util.c:390:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (string, ":");
data/desproxy-0.1.0~pre3/src/util.c:394:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat (string, ":");
data/desproxy-0.1.0~pre3/src/util.c:399:8: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (User_Agent, getenv ("USER_AGENT"), 255);
data/desproxy-0.1.0~pre3/src/util.c:410:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (proxy_user, getenv ("PROXY_USER"), 255);
data/desproxy-0.1.0~pre3/src/util.c:437:23: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((count = read (proxy_socket[connection],
data/desproxy-0.1.0~pre3/src/util.c:639:3: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy (console_line, "");
ANALYSIS SUMMARY:
Hits = 94
Lines analyzed = 2383 in approximately 0.13 seconds (18704 lines/second)
Physical Source Lines of Code (SLOC) = 1753
Hits@level = [0] 73 [1] 38 [2] 43 [3] 4 [4] 9 [5] 0
Hits@level+ = [0+] 167 [1+] 94 [2+] 56 [3+] 13 [4+] 9 [5+] 0
Hits/KSLOC@level+ = [0+] 95.2653 [1+] 53.6224 [2+] 31.9452 [3+] 7.41586 [4+] 5.13406 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.