Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/dvtm-0.15+40.g311a8c0/bstack.c
Examining data/dvtm-0.15+40.g311a8c0/dvtm-editor.c
Examining data/dvtm-0.15+40.g311a8c0/dvtm.c
Examining data/dvtm-0.15+40.g311a8c0/fibonacci.c
Examining data/dvtm-0.15+40.g311a8c0/forkpty-aix.c
Examining data/dvtm-0.15+40.g311a8c0/forkpty-sunos.c
Examining data/dvtm-0.15+40.g311a8c0/fullscreen.c
Examining data/dvtm-0.15+40.g311a8c0/grid.c
Examining data/dvtm-0.15+40.g311a8c0/tile.c
Examining data/dvtm-0.15+40.g311a8c0/tstack.c
Examining data/dvtm-0.15+40.g311a8c0/vstack.c
Examining data/dvtm-0.15+40.g311a8c0/vt.h
Examining data/dvtm-0.15+40.g311a8c0/vt.c
Examining data/dvtm-0.15+40.g311a8c0/config.def.h
FINAL RESULTS:
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:32:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, msg, ap);
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:128:3: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(editor, (char* const*)editor_argv);
data/dvtm-0.15+40.g311a8c0/dvtm.c:256:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, errstr, ap);
data/dvtm-0.15+40.g311a8c0/dvtm.c:264:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, errstr, ap);
data/dvtm-0.15+40.g311a8c0/dvtm.c:925:6: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(shell, X_OK))
data/dvtm-0.15+40.g311a8c0/vt.c:1647:3: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp(p, (char *const *)argv);
data/dvtm-0.15+40.g311a8c0/vt.c:1927:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
esclen = sprintf(s, "\033[0%s%s%s%s%s%sm",
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:43:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *editor = getenv("DVTM_EDITOR");
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:45:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
editor = getenv("VISUAL");
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:47:12: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
editor = getenv("EDITOR");
data/dvtm-0.15+40.g311a8c0/dvtm.c:558:19: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (t && (term = getenv("TERM")) && !strstr(term, "linux")) {
data/dvtm-0.15+40.g311a8c0/dvtm.c:932:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *shell = getenv("SHELL");
data/dvtm-0.15+40.g311a8c0/dvtm.c:1032:9: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
return realpath(buf, NULL);
data/dvtm-0.15+40.g311a8c0/dvtm.c:1751:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (!getenv("ESCDELAY"))
data/dvtm-0.15+40.g311a8c0/dvtm.c:1801:18: [3] (buffer) realpath:
This function does not protect against buffer overflows, and some
implementations can overflow internally (CWE-120/CWE-785!). Ensure that the
destination buffer is at least of size MAXPATHLEN, andto protect against
implementation problems, the input argument should also be checked to
ensure it is no larger than MAXPATHLEN.
if (!(fifo = realpath(argv[arg], NULL)))
data/dvtm-0.15+40.g311a8c0/vt.c:1854:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char *term = getenv("DVTM_TERM");
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:52:19: [2] (tmpfile) mkstemp:
Potential for temporary file vulnerability in some circumstances. Some
older Unix-like systems create temp files with permission to write by all
by default, so be sure to set the umask to override this. Also, some older
Unix systems might fail to use O_EXCL when opening the file, so make sure
that O_EXCL is used by the library (CWE-377).
if ((tmp_write = mkstemp(tempname)) == -1) {
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:63:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[2048];
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:98:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int tty = open("/dev/tty", O_RDWR);
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:121:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *editor_argv[argc+2];
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:147:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
int tmp_read = open(tempname, O_RDONLY);
data/dvtm-0.15+40.g311a8c0/dvtm.c:71:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char title[255];
data/dvtm-0.15+40.g311a8c0/dvtm.c:116:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[3];
data/dvtm-0.15+40.g311a8c0/dvtm.c:146:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char text[512];
data/dvtm-0.15+40.g311a8c0/dvtm.c:164:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *argv[4];
data/dvtm-0.15+40.g311a8c0/dvtm.c:364:2: [2] (buffer) wchar_t:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
wchar_t wbuf[sizeof bar.text];
data/dvtm-0.15+40.g311a8c0/dvtm.c:813:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
const int win_id = atoi(args[0]);
data/dvtm-0.15+40.g311a8c0/dvtm.c:875:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8] = { '\e' };
data/dvtm-0.15+40.g311a8c0/dvtm.c:1030:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[32];
data/dvtm-0.15+40.g311a8c0/dvtm.c:1037:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *pargs[4] = { shell, NULL };
data/dvtm-0.15+40.g311a8c0/dvtm.c:1038:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[8], *cwd = NULL;
data/dvtm-0.15+40.g311a8c0/dvtm.c:1070:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[PATH_MAX];
data/dvtm-0.15+40.g311a8c0/dvtm.c:1113:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *argv[3] = { args[0], NULL, NULL };
data/dvtm-0.15+40.g311a8c0/dvtm.c:1114:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char argline[32];
data/dvtm-0.15+40.g311a8c0/dvtm.c:1153:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (c->order == atoi(args[0])) {
data/dvtm-0.15+40.g311a8c0/dvtm.c:1167:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
const int win_id = atoi(args[0]);
data/dvtm-0.15+40.g311a8c0/dvtm.c:1324:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (!args[0] || atoi(args[0]) < 0)
data/dvtm-0.15+40.g311a8c0/dvtm.c:1540:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *p, *s, cmdbuf[512], c;
data/dvtm-0.15+40.g311a8c0/dvtm.c:1560:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *args[MAX_ARGS], *arg;
data/dvtm-0.15+40.g311a8c0/dvtm.c:1720:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(name, O_RDWR|O_NONBLOCK)) == -1) {
data/dvtm-0.15+40.g311a8c0/dvtm.c:1782:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
set_escdelay(atoi(argv[++arg]));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1789:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
screen.history = atoi(argv[++arg]);
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:33:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((*master = open("/dev/ptc", O_RDWR|O_NOCTTY)) == -1)
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:38:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((slave = open(path, O_RDWR|O_NOCTTY)) == -1)
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:47:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(_PATH_TTY, O_RDWR|O_NOCTTY);
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:55:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(_PATH_TTY, O_RDWR|O_NOCTTY);
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:59:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(path, O_RDWR);
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:64:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open("/dev/tty", O_WRONLY);
data/dvtm-0.15+40.g311a8c0/forkpty-aix.c:72:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(tio2.c_cc, tio->c_cc, sizeof tio2.c_cc);
data/dvtm-0.15+40.g311a8c0/forkpty-sunos.c:35:17: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((*master = open("/dev/ptmx", O_RDWR|O_NOCTTY)) == -1)
data/dvtm-0.15+40.g311a8c0/forkpty-sunos.c:46:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((slave = open(path, O_RDWR|O_NOCTTY)) == -1)
data/dvtm-0.15+40.g311a8c0/vt.c:90:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char vt_term[32];
data/dvtm-0.15+40.g311a8c0/vt.c:190:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rbuf[BUFSIZ];
data/dvtm-0.15+40.g311a8c0/vt.c:191:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char ebuf[BUFSIZ];
data/dvtm-0.15+40.g311a8c0/vt.c:194:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char title[256]; /* xterm style window title */
data/dvtm-0.15+40.g311a8c0/vt.c:200:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static const char *keytable[KEY_MAX+1] = {
data/dvtm-0.15+40.g311a8c0/vt.c:289:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[count * sizeof(Row)];
data/dvtm-0.15+40.g311a8c0/vt.c:290:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buf, start, count * sizeof(Row));
data/dvtm-0.15+40.g311a8c0/vt.c:292:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(end - count, buf, count * sizeof(Row));
data/dvtm-0.15+40.g311a8c0/vt.c:1540:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MB_CUR_MAX + 1];
data/dvtm-0.15+40.g311a8c0/vt.c:1691:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char keyseq[16];
data/dvtm-0.15+40.g311a8c0/vt.c:1706:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char keyseq[3] = { '\e', (t->curskeymode ? 'O' : '['), keytable[keycode][0] };
data/dvtm-0.15+40.g311a8c0/vt.c:1726:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char seq[6] = { '\e', '[', 'M' }, state = 0, button = 0;
data/dvtm-0.15+40.g311a8c0/vt.c:1939:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
esclen = sprintf(s, "\033[39m");
data/dvtm-0.15+40.g311a8c0/vt.c:1941:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
esclen = sprintf(s, "\033[38;5;%dm", cell->fg);
data/dvtm-0.15+40.g311a8c0/vt.c:1947:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
esclen = sprintf(s, "\033[49m");
data/dvtm-0.15+40.g311a8c0/vt.c:1949:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
esclen = sprintf(s, "\033[48;5;%dm", cell->bg);
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:65:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((bytes = read(STDIN_FILENO, buffer, sizeof(buffer))) > 0) {
data/dvtm-0.15+40.g311a8c0/dvtm-editor.c:163:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((bytes = read(tmp_read, buffer, sizeof(buffer))) > 0) {
data/dvtm-0.15+40.g311a8c0/dvtm.c:625:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(c->title, title, sizeof(c->title) - 1);
data/dvtm-0.15+40.g311a8c0/dvtm.c:1071:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(name, args[0], sizeof(name));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1073:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(c->title, basename(name), sizeof(c->title));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1079:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(c->title, args[1], sizeof(c->title));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1147:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vt_write(sel->editor, args[1], strlen(args[1]));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1336:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vt_write(sel->term, args[0], strlen(args[0]));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1543:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
r = read(cmdfifo.fd, cmdbuf, sizeof cmdbuf - 1);
data/dvtm-0.15+40.g311a8c0/dvtm.c:1661:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
switch (r = read(bar.fd, bar.text, sizeof bar.text - 1)) {
data/dvtm-0.15+40.g311a8c0/dvtm.c:1663:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(bar.text, strerror(errno), sizeof bar.text - 1);
data/dvtm-0.15+40.g311a8c0/dvtm.c:1676:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(bar.text, p + 1, strlen(p));
data/dvtm-0.15+40.g311a8c0/dvtm.c:1687:17: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t len = read(c->editor_fds[1], copyreg.data + copyreg.len, copyreg.size - copyreg.len);
data/dvtm-0.15+40.g311a8c0/vt.c:1414:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
res = read(t->pty, t->rbuf + t->rlen, sizeof(t->rbuf) - t->rlen);
data/dvtm-0.15+40.g311a8c0/vt.c:1693:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vt_write(t, keyseq, strlen(keyseq));
data/dvtm-0.15+40.g311a8c0/vt.c:1711:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
vt_write(t, keytable[keycode], strlen(keytable[keycode]));
ANALYSIS SUMMARY:
Hits = 83
Lines analyzed = 4913 in approximately 0.15 seconds (31738 lines/second)
Physical Source Lines of Code (SLOC) = 4111
Hits@level = [0] 16 [1] 16 [2] 51 [3] 9 [4] 7 [5] 0
Hits@level+ = [0+] 99 [1+] 83 [2+] 67 [3+] 16 [4+] 7 [5+] 0
Hits/KSLOC@level+ = [0+] 24.0817 [1+] 20.1897 [2+] 16.2977 [3+] 3.892 [4+] 1.70275 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.