Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/ecdsautils-0.3.2+git20151018/src/sha256sum.c
Examining data/ecdsautils-0.3.2+git20151018/src/random.c
Examining data/ecdsautils-0.3.2+git20151018/src/hmac_sha256.c
Examining data/ecdsautils-0.3.2+git20151018/src/array.h
Examining data/ecdsautils-0.3.2+git20151018/src/ecdsa.c
Examining data/ecdsautils-0.3.2+git20151018/src/sha256sum.h
Examining data/ecdsautils-0.3.2+git20151018/src/array.c
Examining data/ecdsautils-0.3.2+git20151018/src/hmac_sha256.h
Examining data/ecdsautils-0.3.2+git20151018/src/sha256_file.c
Examining data/ecdsautils-0.3.2+git20151018/src/ecdsa.h
Examining data/ecdsautils-0.3.2+git20151018/src/random.h
Examining data/ecdsautils-0.3.2+git20151018/src/hexutil.c
Examining data/ecdsautils-0.3.2+git20151018/src/version.h
Examining data/ecdsautils-0.3.2+git20151018/src/sign.c
Examining data/ecdsautils-0.3.2+git20151018/src/sha256_file.h
Examining data/ecdsautils-0.3.2+git20151018/src/error.h
Examining data/ecdsautils-0.3.2+git20151018/src/hexutil.h
Examining data/ecdsautils-0.3.2+git20151018/src/version.c
Examining data/ecdsautils-0.3.2+git20151018/src/keygen.c
Examining data/ecdsautils-0.3.2+git20151018/src/verify.c
FINAL RESULTS:
data/ecdsautils-0.3.2+git20151018/src/error.h:36:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, ap);
data/ecdsautils-0.3.2+git20151018/src/keygen.c:84:15: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((c = getopt(argc, argv, "sph")) != -1) {
data/ecdsautils-0.3.2+git20151018/src/verify.c:48:17: [3] (buffer) getopt:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
while ((opt = getopt(argc, argv, "s:p:n:")) != -1) {
data/ecdsautils-0.3.2+git20151018/src/array.c:77:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(array_index(array, array->size), el, len);
data/ecdsautils-0.3.2+git20151018/src/ecdsa.c:60:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r->p, signature, 32);
data/ecdsautils-0.3.2+git20151018/src/ecdsa.c:61:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(s->p, signature+32, 32);
data/ecdsautils-0.3.2+git20151018/src/keygen.c:42:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char secret_string[65];
data/ecdsautils-0.3.2+git20151018/src/random.c:38:8: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open("/dev/random", O_RDONLY);
data/ecdsautils-0.3.2+git20151018/src/sha256_file.c:40:10: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open(fname, O_RDONLY);
data/ecdsautils-0.3.2+git20151018/src/sha256_file.c:50:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[BLOCKSIZE];
data/ecdsautils-0.3.2+git20151018/src/sha256sum.c:177:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/ecdsautils-0.3.2+git20151018/src/sha256sum.c:400:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&sc->buffer.bytes[sc->bufferLength], data, bytesToCopy);
data/ecdsautils-0.3.2+git20151018/src/sha256sum.c:426:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&sc->buffer.bytes[sc->bufferLength], data, len);
data/ecdsautils-0.3.2+git20151018/src/sign.c:45:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(input, info, 32);
data/ecdsautils-0.3.2+git20151018/src/sign.c:61:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char secret_string[65];
data/ecdsautils-0.3.2+git20151018/src/verify.c:39:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char signature[64];
data/ecdsautils-0.3.2+git20151018/src/verify.c:85:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
min_good_signatures = atoi(optarg);
data/ecdsautils-0.3.2+git20151018/src/hexutil.c:31:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((strlen(string) & 1) == 1)
data/ecdsautils-0.3.2+git20151018/src/hexutil.c:35:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(string) != 2 * len)
data/ecdsautils-0.3.2+git20151018/src/random.c:46:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ssize_t ret = read(fd, buffer + read_bytes, len - read_bytes);
data/ecdsautils-0.3.2+git20151018/src/sha256_file.c:56:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
ret = read(fd, buffer, BLOCKSIZE);
ANALYSIS SUMMARY:
Hits = 21
Lines analyzed = 1684 in approximately 0.09 seconds (18353 lines/second)
Physical Source Lines of Code (SLOC) = 904
Hits@level = [0] 16 [1] 4 [2] 14 [3] 2 [4] 1 [5] 0
Hits@level+ = [0+] 37 [1+] 21 [2+] 17 [3+] 3 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 40.9292 [1+] 23.2301 [2+] 18.8053 [3+] 3.31858 [4+] 1.10619 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.