Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/entangle-3.0/src/backend/entangle-camera-automata.c
Examining data/entangle-3.0/src/backend/entangle-camera-automata.h
Examining data/entangle-3.0/src/backend/entangle-camera-file.c
Examining data/entangle-3.0/src/backend/entangle-camera-file.h
Examining data/entangle-3.0/src/backend/entangle-camera-list.c
Examining data/entangle-3.0/src/backend/entangle-camera-list.h
Examining data/entangle-3.0/src/backend/entangle-camera.c
Examining data/entangle-3.0/src/backend/entangle-camera.h
Examining data/entangle-3.0/src/backend/entangle-colour-profile.c
Examining data/entangle-3.0/src/backend/entangle-colour-profile.h
Examining data/entangle-3.0/src/backend/entangle-control-button.c
Examining data/entangle-3.0/src/backend/entangle-control-button.h
Examining data/entangle-3.0/src/backend/entangle-control-choice.c
Examining data/entangle-3.0/src/backend/entangle-control-choice.h
Examining data/entangle-3.0/src/backend/entangle-control-date.c
Examining data/entangle-3.0/src/backend/entangle-control-date.h
Examining data/entangle-3.0/src/backend/entangle-control-group.c
Examining data/entangle-3.0/src/backend/entangle-control-group.h
Examining data/entangle-3.0/src/backend/entangle-control-range.c
Examining data/entangle-3.0/src/backend/entangle-control-range.h
Examining data/entangle-3.0/src/backend/entangle-control-text.c
Examining data/entangle-3.0/src/backend/entangle-control-text.h
Examining data/entangle-3.0/src/backend/entangle-control-toggle.c
Examining data/entangle-3.0/src/backend/entangle-control-toggle.h
Examining data/entangle-3.0/src/backend/entangle-control.c
Examining data/entangle-3.0/src/backend/entangle-control.h
Examining data/entangle-3.0/src/backend/entangle-debug.c
Examining data/entangle-3.0/src/backend/entangle-debug.h
Examining data/entangle-3.0/src/backend/entangle-device-manager.c
Examining data/entangle-3.0/src/backend/entangle-device-manager.h
Examining data/entangle-3.0/src/backend/entangle-image-loader.c
Examining data/entangle-3.0/src/backend/entangle-image-loader.h
Examining data/entangle-3.0/src/backend/entangle-image.c
Examining data/entangle-3.0/src/backend/entangle-image.h
Examining data/entangle-3.0/src/backend/entangle-media.c
Examining data/entangle-3.0/src/backend/entangle-media.h
Examining data/entangle-3.0/src/backend/entangle-pixbuf-loader.c
Examining data/entangle-3.0/src/backend/entangle-pixbuf-loader.h
Examining data/entangle-3.0/src/backend/entangle-pixbuf.c
Examining data/entangle-3.0/src/backend/entangle-pixbuf.h
Examining data/entangle-3.0/src/backend/entangle-progress.c
Examining data/entangle-3.0/src/backend/entangle-progress.h
Examining data/entangle-3.0/src/backend/entangle-session.c
Examining data/entangle-3.0/src/backend/entangle-session.h
Examining data/entangle-3.0/src/backend/entangle-thumbnail-loader.c
Examining data/entangle-3.0/src/backend/entangle-thumbnail-loader.h
Examining data/entangle-3.0/src/backend/entangle-video.c
Examining data/entangle-3.0/src/backend/entangle-video.h
Examining data/entangle-3.0/src/entangle-main.c
Examining data/entangle-3.0/src/frontend/entangle-application.c
Examining data/entangle-3.0/src/frontend/entangle-application.h
Examining data/entangle-3.0/src/frontend/entangle-camera-manager.c
Examining data/entangle-3.0/src/frontend/entangle-camera-manager.h
Examining data/entangle-3.0/src/frontend/entangle-camera-picker.c
Examining data/entangle-3.0/src/frontend/entangle-camera-picker.h
Examining data/entangle-3.0/src/frontend/entangle-camera-preferences.c
Examining data/entangle-3.0/src/frontend/entangle-camera-preferences.h
Examining data/entangle-3.0/src/frontend/entangle-camera-support.c
Examining data/entangle-3.0/src/frontend/entangle-camera-support.h
Examining data/entangle-3.0/src/frontend/entangle-control-panel.c
Examining data/entangle-3.0/src/frontend/entangle-control-panel.h
Examining data/entangle-3.0/src/frontend/entangle-dpms.c
Examining data/entangle-3.0/src/frontend/entangle-dpms.h
Examining data/entangle-3.0/src/frontend/entangle-help-about.c
Examining data/entangle-3.0/src/frontend/entangle-help-about.h
Examining data/entangle-3.0/src/frontend/entangle-image-display.c
Examining data/entangle-3.0/src/frontend/entangle-image-display.h
Examining data/entangle-3.0/src/frontend/entangle-image-histogram.c
Examining data/entangle-3.0/src/frontend/entangle-image-histogram.h
Examining data/entangle-3.0/src/frontend/entangle-media-popup.c
Examining data/entangle-3.0/src/frontend/entangle-media-popup.h
Examining data/entangle-3.0/src/frontend/entangle-media-statusbar.c
Examining data/entangle-3.0/src/frontend/entangle-media-statusbar.h
Examining data/entangle-3.0/src/frontend/entangle-preferences-display.c
Examining data/entangle-3.0/src/frontend/entangle-preferences-display.h
Examining data/entangle-3.0/src/frontend/entangle-preferences.c
Examining data/entangle-3.0/src/frontend/entangle-preferences.h
Examining data/entangle-3.0/src/frontend/entangle-script-config.c
Examining data/entangle-3.0/src/frontend/entangle-script-config.h
Examining data/entangle-3.0/src/frontend/entangle-script-simple.c
Examining data/entangle-3.0/src/frontend/entangle-script-simple.h
Examining data/entangle-3.0/src/frontend/entangle-script.c
Examining data/entangle-3.0/src/frontend/entangle-script.h
Examining data/entangle-3.0/src/frontend/entangle-session-browser.c
Examining data/entangle-3.0/src/frontend/entangle-session-browser.h
FINAL RESULTS:
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:214:9: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod(thumbnametmp, 0600);
data/entangle-3.0/src/backend/entangle-session.c:445:9: [4] (race) access:
This usually indicates a security flaw. If an attacker can change anything
along the path between the call to access() and the file's actual use
(e.g., by moving files), the attacker can exploit the race condition
(CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
and try to open the file directly.
if (access(dstname, R_OK) == 0 || errno != ENOENT) {
data/entangle-3.0/src/frontend/entangle-preferences.c:791:16: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((dir = getenv("GSETTINGS_SCHEMA_DIR")) &&
data/entangle-3.0/src/frontend/entangle-preferences.c:813:17: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((path = getenv("GI_TYPELIB_PATH")) && strstr(path, GI_DIR)) {
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:167:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mtimeStr[21];
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:168:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char widthStr[21];
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:169:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char heightStr[21];
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:262:36: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
thismtime = thismtimeStr ? atol(thismtimeStr) : 0;
data/entangle-3.0/src/frontend/entangle-application.c:304:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char *accels[3];
data/entangle-3.0/src/frontend/entangle-camera-manager.c:2508:18: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
GtkMenuItem *open;
data/entangle-3.0/src/frontend/entangle-camera-manager.c:2556:34: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
GTK_WIDGET(open));
data/entangle-3.0/src/frontend/entangle-camera-manager.c:2557:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
g_signal_connect(open, "activate",
data/entangle-3.0/src/frontend/entangle-camera-manager.c:2610:41: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gtk_widget_set_sensitive(GTK_WIDGET(open),
data/entangle-3.0/src/backend/entangle-camera-automata.c:320:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gsize len = strlen(automata->deleteImageDup);
data/entangle-3.0/src/backend/entangle-control-text.c:89:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(newvalue);
data/entangle-3.0/src/backend/entangle-control.c:127:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(priv->label);
data/entangle-3.0/src/backend/entangle-session.c:259:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gint prefixlen = strlen(prefix);
data/entangle-3.0/src/backend/entangle-session.c:270:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
postfixlen = strlen(postfix);
data/entangle-3.0/src/backend/entangle-session.c:288:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name += strlen(session->directory);
data/entangle-3.0/src/backend/entangle-thumbnail-loader.c:123:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(uri));
ANALYSIS SUMMARY:
Hits = 20
Lines analyzed = 28016 in approximately 0.63 seconds (44365 lines/second)
Physical Source Lines of Code (SLOC) = 18742
Hits@level = [0] 0 [1] 7 [2] 9 [3] 2 [4] 1 [5] 1
Hits@level+ = [0+] 20 [1+] 20 [2+] 13 [3+] 4 [4+] 2 [5+] 1
Hits/KSLOC@level+ = [0+] 1.06712 [1+] 1.06712 [2+] 0.693629 [3+] 0.213424 [4+] 0.106712 [5+] 0.0533561
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.