Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/espeakup-0.80/queue.c
Examining data/espeakup-0.80/queue.h
Examining data/espeakup-0.80/stringhandling.c
Examining data/espeakup-0.80/stringhandling.h
Examining data/espeakup-0.80/signal.c
Examining data/espeakup-0.80/espeakup.c
Examining data/espeakup-0.80/cli.c
Examining data/espeakup-0.80/espeak.c
Examining data/espeakup-0.80/espeakup.h
Examining data/espeakup-0.80/softsynth.c
FINAL RESULTS:
data/espeakup-0.80/espeak.c:153:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(s->voice, voice);
data/espeakup-0.80/stringhandling.c:89:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(p + oldlen, t);
data/espeakup-0.80/cli.c:78:9: [3] (buffer) getopt_long:
Some older implementations do not protect against internal buffer overflows
(CWE-120, CWE-20). Check implementation on installation, or limit the size
of all string inputs.
opt = getopt_long(argc, argv, shortOptions, longOptions, NULL);
data/espeakup-0.80/espeak.c:55:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int mark = atoi(events[i].id.name);
data/espeakup-0.80/espeak.c:345:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char markbuff[50];
data/espeakup-0.80/espeakup.c:91:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[16];
data/espeakup-0.80/espeakup.c:94:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
pidFile = open(pidPath, O_RDWR | O_CREAT, 0666);
data/espeakup-0.80/espeakup.c:176:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
devnull = open("/dev/null", O_RDWR);
data/espeakup-0.80/espeakup.h:74:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char voice[20];
data/espeakup-0.80/softsynth.c:174:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char txtBuf[maxBufferSize];
data/espeakup-0.80/softsynth.c:247:11: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
softFD = open("/dev/softsynthu", O_RDWR | O_NONBLOCK);
data/espeakup-0.80/softsynth.c:250:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
softFD = open("/dev/softsynth", O_RDWR | O_NONBLOCK);
data/espeakup-0.80/softsynth.c:269:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[maxBufferSize];
data/espeakup-0.80/softsynth.c:341:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[16];
data/espeakup-0.80/stringhandling.c:110:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p + oldlen, t, cnt);
data/espeakup-0.80/espeak.c:365:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
error = espeak_Synth(markbuff, strlen(markbuff)+1, 0, POS_CHARACTER,
data/espeakup-0.80/espeakup.c:64:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(fds[0], &c, 1) < 0) {
data/espeakup-0.80/espeakup.c:106:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
n = read(pidFile, s, sizeof(s) - 1);
data/espeakup-0.80/signal.c:70:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write(PIPE_WRITE_FD, STOP_MSG, strlen(STOP_MSG));
data/espeakup-0.80/softsynth.c:184:4: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(txtBuf, buf + start, txtLen);
data/espeakup-0.80/softsynth.c:307:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
length = read(softFD, buf, maxBufferSize - 1);
data/espeakup-0.80/softsynth.c:321:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(buf, cp + 1, strlen(cp + 1) + 1);
data/espeakup-0.80/softsynth.c:322:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(buf);
data/espeakup-0.80/softsynth.c:343:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (write(softFD, buf, strlen(buf)) < 0)
data/espeakup-0.80/stringhandling.c:76:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newlen = oldlen + strlen(t);
ANALYSIS SUMMARY:
Hits = 25
Lines analyzed = 1621 in approximately 0.11 seconds (14978 lines/second)
Physical Source Lines of Code (SLOC) = 1180
Hits@level = [0] 36 [1] 10 [2] 12 [3] 1 [4] 2 [5] 0
Hits@level+ = [0+] 61 [1+] 25 [2+] 15 [3+] 3 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 51.6949 [1+] 21.1864 [2+] 12.7119 [3+] 2.54237 [4+] 1.69492 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.