Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/faac-1.30/common/Cfaac/CRegistry.cpp Examining data/faac-1.30/common/Cfaac/CRegistry.h Examining data/faac-1.30/common/Cfaac/CTag.cpp Examining data/faac-1.30/common/Cfaac/CTag.h Examining data/faac-1.30/common/Cfaac/Cfaac.cpp Examining data/faac-1.30/common/Cfaac/Cfaac.h Examining data/faac-1.30/common/Cfaac/Cfaad.cpp Examining data/faac-1.30/common/Cfaac/Cfaad.h Examining data/faac-1.30/common/Cfaac/DecDialog.cpp Examining data/faac-1.30/common/Cfaac/DecDialog.h Examining data/faac-1.30/common/Cfaac/EncDialog.cpp Examining data/faac-1.30/common/Cfaac/EncDialog.h Examining data/faac-1.30/common/Cfaac/TypeDef.h Examining data/faac-1.30/common/Cfaac/resource.h Examining data/faac-1.30/frontend/getopt.c Examining data/faac-1.30/frontend/getopt.h Examining data/faac-1.30/frontend/input.c Examining data/faac-1.30/frontend/input.h Examining data/faac-1.30/frontend/main.c Examining data/faac-1.30/frontend/maingui.c Examining data/faac-1.30/frontend/mp4write.c Examining data/faac-1.30/frontend/mp4write.h Examining data/faac-1.30/frontend/resource.h Examining data/faac-1.30/include/faac.h Examining data/faac-1.30/include/faaccfg.h Examining data/faac-1.30/libfaac/bitstream.c Examining data/faac-1.30/libfaac/bitstream.h Examining data/faac-1.30/libfaac/blockswitch.c Examining data/faac-1.30/libfaac/blockswitch.h Examining data/faac-1.30/libfaac/channels.c Examining data/faac-1.30/libfaac/channels.h Examining data/faac-1.30/libfaac/coder.h Examining data/faac-1.30/libfaac/fft.c Examining data/faac-1.30/libfaac/fft.h Examining data/faac-1.30/libfaac/filtbank.c Examining data/faac-1.30/libfaac/filtbank.h Examining data/faac-1.30/libfaac/frame.c Examining data/faac-1.30/libfaac/frame.h Examining data/faac-1.30/libfaac/huff2.c Examining data/faac-1.30/libfaac/huff2.h Examining data/faac-1.30/libfaac/huffdata.c Examining data/faac-1.30/libfaac/huffdata.h Examining data/faac-1.30/libfaac/kiss_fft/_kiss_fft_guts.h Examining data/faac-1.30/libfaac/kiss_fft/kiss_fft.c Examining data/faac-1.30/libfaac/kiss_fft/kiss_fft.h Examining data/faac-1.30/libfaac/kiss_fft/kiss_fftr.c Examining data/faac-1.30/libfaac/kiss_fft/kiss_fftr.h Examining data/faac-1.30/libfaac/quantize.c Examining data/faac-1.30/libfaac/quantize.h Examining data/faac-1.30/libfaac/stereo.c Examining data/faac-1.30/libfaac/stereo.h Examining data/faac-1.30/libfaac/tns.c Examining data/faac-1.30/libfaac/tns.h Examining data/faac-1.30/libfaac/util.c Examining data/faac-1.30/libfaac/util.h Examining data/faac-1.30/plugins/cooledit/Faac.cpp Examining data/faac-1.30/plugins/cooledit/Faad.cpp Examining data/faac-1.30/plugins/cooledit/Main.cpp Examining data/faac-1.30/plugins/cooledit/defines.h Examining data/faac-1.30/plugins/cooledit/filters.h Examining data/faac-1.30/plugins/winamp/filters.h Examining data/faac-1.30/project/msvc/unistd.h Examining data/faac-1.30/utils/win32/ac2ver.c FINAL RESULTS: data/faac-1.30/common/Cfaac/CTag.cpp:88:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"ReadCoverArtFile: can't open \"%s\"",pCoverArtFile); data/faac-1.30/common/Cfaac/CTag.cpp:143:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "FAAC v%s", (faacEncGetVersion(&faac_id_string, &faac_copyright_string)==FAAC_CFG_VERSION) ? faac_id_string : " wrong libfaac version"); data/faac-1.30/common/Cfaac/CTag.cpp:172:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"ReadMp4Tag: can't open \"%s\"",Filename); data/faac-1.30/common/Cfaac/CTag.cpp:235:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"WriteAacTag: can't open \"%s\"",Filename); data/faac-1.30/common/Cfaac/CTag.cpp:243:2: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "FAAC v%s", (faacEncGetVersion(&faac_id_string, &faac_copyright_string)==FAAC_CFG_VERSION) ? faac_id_string : " wrong libfaac version"); data/faac-1.30/common/Cfaac/CTag.cpp:264:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"image/%s",check_image_header(art.data)==2 ? "jpeg" : strlwr(ext+1)); data/faac-1.30/common/Cfaac/CTag.cpp:310:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"ReadAacTag: can't open \"%s\"",Filename); data/faac-1.30/common/Cfaac/Cfaac.cpp:253:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(dst,"%s%s.%s",path,pname,ext); data/faac-1.30/common/Cfaac/Cfaac.cpp:255:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(dst,"%s\\%s.%s",path,pname,ext); data/faac-1.30/common/Cfaac/Cfaac.cpp:261:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(dst,"%s.%s",pname,ext); data/faac-1.30/common/Cfaac/Cfaac.cpp:270:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"%s\nSource file=Destination file...aborting!\n\n\tSuppress this warning?",dst); data/faac-1.30/common/Cfaac/Cfaac.cpp:403:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"%s: ", ProcName); data/faac-1.30/common/Cfaac/Cfaac.cpp:404:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf,str); data/faac-1.30/common/Cfaac/Cfaac.cpp:471:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"Overwrite \"%s\" ?",OutFileName); data/faac-1.30/common/Cfaac/Cfaad.cpp:451:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"%s: ", ProcName); data/faac-1.30/common/Cfaac/Cfaad.cpp:453:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(buf,str); data/faac-1.30/common/Cfaac/EncDialog.cpp:208:3: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf(buf, data/faac-1.30/common/Cfaac/EncDialog.cpp:236:4: [4] (shell) ShellExecute: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. ShellExecute(hWndDlg, NULL, "http://www.audiocoding.com", NULL, NULL, SW_SHOW); data/faac-1.30/common/Cfaac/EncDialog.cpp:239:4: [4] (shell) ShellExecute: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. ShellExecute(hWndDlg, NULL, "http://www.mpeg4ip.net", NULL, NULL, SW_SHOW); data/faac-1.30/common/Cfaac/EncDialog.cpp:242:4: [4] (shell) ShellExecute: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. ShellExecute(hWndDlg, NULL, "http://id3lib.sourceforge.net", NULL, NULL, SW_SHOW); data/faac-1.30/common/Cfaac/EncDialog.cpp:245:4: [4] (shell) ShellExecute: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. ShellExecute(hWndDlg, NULL, "mailto:ntnfrn_email-temp@yahoo.it", NULL, NULL, SW_SHOW); data/faac-1.30/common/Cfaac/EncDialog.cpp:425:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(config_AACoutdir,cfg.OutDir); data/faac-1.30/frontend/main.c:312:5: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(usage, name); data/faac-1.30/frontend/main.c:416:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define fprintf if(verbose)fprintf data/faac-1.30/frontend/main.c:416:28: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define fprintf if(verbose)fprintf data/faac-1.30/frontend/main.c:494:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stderr, __FILE__ "(%d): wrong libfaac version\n", __LINE__); data/faac-1.30/frontend/main.c:780:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf(stderr, dieMessage, progName, progName, progName, progName); data/faac-1.30/frontend/main.c:1136:21: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(percent, "%.2f%% encoding %s", data/faac-1.30/frontend/main.c:1178:9: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(version_string + 5, faac_id_string); data/faac-1.30/frontend/maingui.c:229:21: [4] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). lstrcat(HeaderText,Percentage); data/faac-1.30/frontend/maingui.c:321:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(txt, "libfaac version %s", myFormat->name); data/faac-1.30/frontend/mp4write.c:869:10: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (!access(name, W_OK) && !over) data/faac-1.30/libfaac/bitstream.c:113:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(str, "libfaac %s", version); data/faac-1.30/plugins/cooledit/Faac.cpp:40:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf,"FilterGetOptions: %s", msg); data/faac-1.30/plugins/cooledit/Faad.cpp:75:3: [4] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). lstrcat(szString,mpeg4AudioNames[mi->type]); data/faac-1.30/plugins/cooledit/Faad.cpp:82:4: [4] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). lstrcat(szString,mpeg4AudioNames[mi->file_info.object_type]); data/faac-1.30/plugins/cooledit/Faad.cpp:93:3: [4] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). lstrcat(szString,mpeg4AudioNames[mi->file_info.object_type]); data/faac-1.30/plugins/cooledit/Main.cpp:101:2: [4] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. lstrcpy(cq->szName, APP_NAME); data/faac-1.30/plugins/cooledit/Main.cpp:102:2: [4] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. lstrcpy(cq->szCopyright, APP_NAME " codec"); data/faac-1.30/project/msvc/unistd.h:7:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. #define access _access data/faac-1.30/utils/win32/ac2ver.c:49:7: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. If the scanf format is influenceable by an attacker, it's exploitable. if(sscanf(line, format, version) == 1) data/faac-1.30/frontend/getopt.c:174:14: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. extern char *getenv(const char *name); data/faac-1.30/frontend/getopt.c:181:14: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. extern char *getenv (); data/faac-1.30/frontend/getopt.c:363:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. else if (getenv ("POSIXLY_CORRECT") != NULL) data/faac-1.30/frontend/getopt.c:662:1: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. getopt (argc, argv, optstring) data/faac-1.30/frontend/getopt.c:674:1: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. getopt_long (argc, argv, options, long_options, opt_index) data/faac-1.30/frontend/getopt.c:703:11: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt (argc, argv, "abc:d:0123456789"); data/faac-1.30/frontend/getopt.h:105:12: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt (int argc, char *const *argv, const char *shortopts); data/faac-1.30/frontend/getopt.h:107:12: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt_long (int argc, char *const *argv, const char *shortopts, data/faac-1.30/frontend/getopt.h:119:12: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. extern int getopt (int argc, char *const *argv, const char *shortopts); data/faac-1.30/frontend/main.c:548:13: [3] (buffer) getopt_long: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. c = getopt_long(argc, argv, "Hhb:m:o:rnc:q:PR:B:C:I:Xwv:", data/faac-1.30/common/Cfaac/CRegistry.cpp:357:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(*dest,defData,size); data/faac-1.30/common/Cfaac/CTag.cpp:85:15: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!(artFile=fopen(pCoverArtFile, "rb"))) data/faac-1.30/common/Cfaac/CTag.cpp:87:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[25+MAX_PATH+1]; data/faac-1.30/common/Cfaac/CTag.cpp:135:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[512], *faac_id_string, *faac_copyright_string; data/faac-1.30/common/Cfaac/CTag.cpp:171:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[25+MAX_PATH+1]; data/faac-1.30/common/Cfaac/CTag.cpp:228:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[512], *faac_id_string, *faac_copyright_string; data/faac-1.30/common/Cfaac/CTag.cpp:232:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if((file=fopen(Filename,"r"))==NULL) data/faac-1.30/common/Cfaac/CTag.cpp:234:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[25+MAX_PATH+1]; data/faac-1.30/common/Cfaac/CTag.cpp:250:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf,"%d",trackno); data/faac-1.30/common/Cfaac/CTag.cpp:259:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[_MAX_FNAME], ext[_MAX_EXT]; data/faac-1.30/common/Cfaac/CTag.cpp:263:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[15]; data/faac-1.30/common/Cfaac/CTag.cpp:309:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[25+MAX_PATH+1]; data/faac-1.30/common/Cfaac/CTag.cpp:324:11: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). trackno=atoi(buf); data/faac-1.30/common/Cfaac/CTag.cpp:335:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(art.data,Frame->Field(ID3FN_DATA).GetBinary(),art.size); data/faac-1.30/common/Cfaac/Cfaac.cpp:269:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_PATH+100]; data/faac-1.30/common/Cfaac/Cfaac.cpp:372:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(buf,bufi,size*sizeof(uint32_t)); data/faac-1.30/common/Cfaac/Cfaac.cpp:398:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[100]=""; data/faac-1.30/common/Cfaac/Cfaac.cpp:463:12: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. case 1: strcpy(OutFileName+fnLen-ExtPos,".mp4"); break; data/faac-1.30/common/Cfaac/Cfaac.cpp:464:12: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. case 2: strcpy(OutFileName+fnLen-ExtPos,".m4a"); break; data/faac-1.30/common/Cfaac/Cfaac.cpp:465:12: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. case 3: strcpy(OutFileName+fnLen-ExtPos,".m4b"); break; data/faac-1.30/common/Cfaac/Cfaac.cpp:467:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *f=fopen(OutFileName,"rb"); data/faac-1.30/common/Cfaac/Cfaac.cpp:470:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_PATH+20]; data/faac-1.30/common/Cfaac/Cfaac.cpp:599:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!(mo->aacFile=fopen(OutFileName, "wb"))) data/faac-1.30/common/Cfaac/Cfaad.cpp:128:18: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *hMP4File = fopen(lpstrFilename, "rb"); data/faac-1.30/common/Cfaac/Cfaad.cpp:445:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[100]=""; data/faac-1.30/common/Cfaac/Cfaad.cpp:524:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if(!(mi->aacFile=fopen(lpstrFilename,"rb"))) data/faac-1.30/common/Cfaac/Cfaad.cpp:557:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(mi->buffer,mi->buffer+tagsize,mi->bytes_into_buffer); data/faac-1.30/common/Cfaac/DecDialog.cpp:84:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[50]; data/faac-1.30/common/Cfaac/DecDialog.cpp:93:4: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf,"%lu",cfg.DecCfg.defSampleRate); data/faac-1.30/common/Cfaac/EncDialog.cpp:39:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern char config_AACoutdir[MAX_PATH]; data/faac-1.30/common/Cfaac/EncDialog.cpp:205:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[512]; data/faac-1.30/common/Cfaac/EncDialog.cpp:396:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[50]; data/faac-1.30/common/Cfaac/EncDialog.cpp:491:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf,"%lu",cfg.EncCfg.quantqual); data/faac-1.30/common/Cfaac/EncDialog.cpp:501:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf,"%lu",cfg.EncCfg.bitRate); data/faac-1.30/common/Cfaac/EncDialog.cpp:514:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(buf,"%lu",cfg.EncCfg.bandWidth); data/faac-1.30/common/Cfaac/EncDialog.cpp:570:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[50]; data/faac-1.30/common/Cfaac/EncDialog.cpp:631:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[MAX_PATH]; data/faac-1.30/common/Cfaac/EncDialog.cpp:767:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ArtFilename[MAX_PATH]=""; data/faac-1.30/common/Cfaac/EncDialog.cpp:793:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char path[MAX_PATH]; data/faac-1.30/frontend/input.c:95:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char SubFormat[16]; // guid data/faac-1.30/frontend/input.c:106:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char waveformat_pcm_guid[16] = data/faac-1.30/frontend/input.c:171:23: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). else if (!(wave_f = fopen(name, "rb"))) data/faac-1.30/frontend/input.c:274:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(tmp, buf + i * channels, sizeof(int32_t) * channels); data/faac-1.30/frontend/main.c:563:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(aacFileName, optarg, l); data/faac-1.30/frontend/main.c:662:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). genre = atoi(optarg); data/faac-1.30/frontend/main.c:683:33: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *artFile = fopen(optarg, "rb"); data/faac-1.30/frontend/main.c:724:24: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). shortctl = atoi(optarg); data/faac-1.30/frontend/main.c:727:27: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). mpegVersion = atoi(optarg); data/faac-1.30/frontend/main.c:748:23: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). verbose = atoi(optarg); data/faac-1.30/frontend/main.c:760:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). jointmode = atoi(optarg); data/faac-1.30/frontend/main.c:763:24: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pnslevel = atoi(optarg); data/faac-1.30/frontend/main.c:799:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(aacFileName, audioFileName, l); data/faac-1.30/frontend/main.c:800:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(aacFileName + l, aacFileExt, 4); data/faac-1.30/frontend/main.c:950:23: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outfile = fopen(aacFileName, "wb"); data/faac-1.30/frontend/main.c:1089:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char percent[MAX_PATH + 20]; data/faac-1.30/frontend/main.c:1177:9: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(version_string, "FAAC "); data/faac-1.30/frontend/maingui.c:35:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char inputFilename[_MAX_PATH], outputFilename[_MAX_PATH]; data/faac-1.30/frontend/maingui.c:91:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szTemp[64]; data/faac-1.30/frontend/maingui.c:111:23: [2] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Risk is low because the source is a constant string. if (pExt == NULL) lstrcat(outputFilename, ".aac"); data/faac-1.30/frontend/maingui.c:112:10: [2] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant string. else lstrcpy(pExt, ".aac"); data/faac-1.30/frontend/maingui.c:150:6: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szTemp[256]; data/faac-1.30/frontend/maingui.c:166:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). config->quantqual = atoi(szTemp); data/faac-1.30/frontend/maingui.c:170:33: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). config->bandWidth = atoi(szTemp); data/faac-1.30/frontend/maingui.c:189:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(szTemp, "%ld", config->quantqual); data/faac-1.30/frontend/maingui.c:192:6: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(szTemp, "%d", config->bandWidth); data/faac-1.30/frontend/maingui.c:208:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char HeaderText[50]; data/faac-1.30/frontend/maingui.c:209:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char Percentage[5]; data/faac-1.30/frontend/maingui.c:228:21: [2] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant string. lstrcpy(HeaderText,"FAAC GUI: "); data/faac-1.30/frontend/maingui.c:248:4: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(szTemp, "Playing time: %2.2i:%04.1f\tEncoding time: %2.2i:%04.1f\n" data/faac-1.30/frontend/maingui.c:320:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char txt[100]; data/faac-1.30/frontend/mp4write.c:874:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(g_fout = fopen(name, "wb"))) data/faac-1.30/libfaac/bitstream.c:109:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[200]; data/faac-1.30/libfaac/bitstream.c:1267:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char _crctable[256] = data/faac-1.30/libfaac/blockswitch.c:360:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transBuff, psyInfo->prevSamples, psyInfo->size * sizeof(double)); data/faac-1.30/libfaac/blockswitch.c:361:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transBuff + psyInfo->size, newSamples, psyInfo->size * sizeof(double)); data/faac-1.30/libfaac/blockswitch.c:368:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transBuffS, transBuff + (win * BLOCK_LEN_SHORT) + (BLOCK_LEN_LONG - BLOCK_LEN_SHORT) / 2, data/faac-1.30/libfaac/blockswitch.c:408:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(psyInfo->prevSamples, newSamples, psyInfo->size * sizeof(double)); data/faac-1.30/libfaac/fft.c:416:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(x + (1 << (logm - 1)), xi, (1 << (logm - 1)) * sizeof(*x)); data/faac-1.30/libfaac/filtbank.c:110:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf, p_overlap, FRAME_LEN*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:111:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf+BLOCK_LEN_LONG, p_in_data, FRAME_LEN*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:112:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_overlap, p_in_data, FRAME_LEN*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:114:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf, p_in_data, 2*FRAME_LEN*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:172:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_out_mdct+BLOCK_LEN_LONG,p_o_buf+BLOCK_LEN_LONG,NFLAT_LS*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:183:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_out_mdct+NFLAT_LS+BLOCK_LEN_SHORT,p_o_buf+NFLAT_LS+BLOCK_LEN_SHORT,NFLAT_LS*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:262:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(overlap_buf,p_overlap,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:268:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf, p_in_data,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:284:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf, p_in_data,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:291:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(o_buf+BLOCK_LEN_LONG,transf_buf+BLOCK_LEN_LONG,NFLAT_LS*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:303:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf, p_in_data,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:310:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(o_buf+BLOCK_LEN_SHORT+NFLAT_LS,transf_buf+BLOCK_LEN_SHORT+NFLAT_LS,NFLAT_LS*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:327:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(transf_buf,p_in_data,BLOCK_LEN_SHORT*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:351:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_out_data,o_buf,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:353:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_out_data,transf_buf,2*BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/filtbank.c:356:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p_overlap,o_buf+BLOCK_LEN_LONG,BLOCK_LEN_LONG*sizeof(double)); data/faac-1.30/libfaac/kiss_fft/kiss_fft.c:351:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(fout,tmpbuf,sizeof(kiss_fft_cpx)*st->nfft); data/faac-1.30/plugins/cooledit/Faac.cpp:39:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[100]; data/faac-1.30/plugins/cooledit/Faad.cpp:72:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(szString,"MPEG%d - %lu bps\n", mi->file_info.version ? 4 : 2, mi->file_info.bitrate); data/faac-1.30/plugins/cooledit/Faad.cpp:81:4: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(szString,"MPEG%d\nRaw\n", mi->file_info.version ? 4 : 2); data/faac-1.30/plugins/cooledit/Faad.cpp:86:4: [2] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Risk is low because the source is a constant string. lstrcat(szString,"ADIF\n"); data/faac-1.30/plugins/cooledit/Faad.cpp:89:4: [2] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Risk is low because the source is a constant string. lstrcat(szString,"ADTS\n"); data/faac-1.30/plugins/cooledit/Main.cpp:103:2: [2] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant string. lstrcpy(cq->szExt,"AAC"); data/faac-1.30/plugins/cooledit/Main.cpp:104:2: [2] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant string. lstrcpy(cq->szExt2,"MP4"); data/faac-1.30/plugins/cooledit/Main.cpp:105:2: [2] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant string. lstrcpy(cq->szExt3,"M4A"); data/faac-1.30/plugins/cooledit/filters.h:11:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szListType[8]; // Parent list type (usually "WAVE" or "INFO", or "adtl") data/faac-1.30/plugins/cooledit/filters.h:12:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szType[8]; // Usually a four character code for data, but can be up to 7 chars data/faac-1.30/plugins/cooledit/filters.h:42:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. {char szName[24]; data/faac-1.30/plugins/cooledit/filters.h:43:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szCopyright[80]; data/faac-1.30/plugins/cooledit/filters.h:61:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt[4]; data/faac-1.30/plugins/cooledit/filters.h:63:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt2[4]; data/faac-1.30/plugins/cooledit/filters.h:64:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt3[4]; data/faac-1.30/plugins/cooledit/filters.h:65:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt4[4]; data/faac-1.30/plugins/winamp/filters.h:11:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szListType[8]; // Parent list type (usually "WAVE" or "INFO", or "adtl") data/faac-1.30/plugins/winamp/filters.h:12:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szType[8]; // Usually a four character code for data, but can be up to 7 chars data/faac-1.30/plugins/winamp/filters.h:42:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. {char szName[24]; data/faac-1.30/plugins/winamp/filters.h:43:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szCopyright[80]; data/faac-1.30/plugins/winamp/filters.h:61:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt[4]; data/faac-1.30/plugins/winamp/filters.h:63:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt2[4]; data/faac-1.30/plugins/winamp/filters.h:64:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt3[4]; data/faac-1.30/plugins/winamp/filters.h:65:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char szExt4[4]; data/faac-1.30/utils/win32/ac2ver.c:38:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[BUFF_SIZE]; data/faac-1.30/utils/win32/ac2ver.c:65:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char format[128], version[BUFF_SIZE]; data/faac-1.30/utils/win32/ac2ver.c:95:3: [2] (buffer) wchar_t: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. wchar_t file_name[_MAX_FNAME], file_ext[_MAX_EXT]; data/faac-1.30/common/Cfaac/CRegistry.cpp:195:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). DWORD slen=strlen(valStr)+1; data/faac-1.30/common/Cfaac/CRegistry.cpp:329:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). Len=strlen(String)+1; data/faac-1.30/common/Cfaac/Cfaac.cpp:185:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l=strlen(mo->InFilename); data/faac-1.30/common/Cfaac/Cfaac.cpp:234:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). pname=pext=src+strlen(src); data/faac-1.30/common/Cfaac/Cfaac.cpp:249:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!(dst=(char *)malloc(strlen(path)+strlen(pname)+strlen(ext)+3))) // '\0','\\','.' data/faac-1.30/common/Cfaac/Cfaac.cpp:249:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!(dst=(char *)malloc(strlen(path)+strlen(pname)+strlen(ext)+3))) // '\0','\\','.' data/faac-1.30/common/Cfaac/Cfaac.cpp:249:54: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!(dst=(char *)malloc(strlen(path)+strlen(pname)+strlen(ext)+3))) // '\0','\\','.' data/faac-1.30/common/Cfaac/Cfaac.cpp:251:5: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). l=strlen(path); data/faac-1.30/common/Cfaac/Cfaac.cpp:259:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!(dst=(char *)malloc(strlen(pname)+strlen(ext)+2))) data/faac-1.30/common/Cfaac/Cfaac.cpp:259:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!(dst=(char *)malloc(strlen(pname)+strlen(ext)+2))) data/faac-1.30/common/Cfaac/Cfaac.cpp:583:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l=strlen(InFileName); data/faac-1.30/common/Cfaac/Cfaad.cpp:520:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). DWORD read, data/faac-1.30/common/Cfaac/Cfaad.cpp:542:19: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_read=read; data/faac-1.30/common/Cfaac/Cfaad.cpp:543:26: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_into_buffer=read; data/faac-1.30/common/Cfaac/Cfaad.cpp:573:21: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_read+=read; data/faac-1.30/common/Cfaac/Cfaad.cpp:574:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_into_buffer+=read; data/faac-1.30/common/Cfaac/Cfaad.cpp:673:6: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int read; data/faac-1.30/common/Cfaac/Cfaad.cpp:759:23: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_read+=read; data/faac-1.30/common/Cfaac/Cfaad.cpp:760:30: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). mi->bytes_into_buffer+=read; data/faac-1.30/frontend/getopt.c:167:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). #define my_strlen strlen data/faac-1.30/frontend/input.c:124:9: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). fgetc(f); data/faac-1.30/frontend/main.c:561:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l = strlen(optarg); data/faac-1.30/frontend/main.c:794:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l = t ? strlen(audioFileName) - strlen(t) : strlen(audioFileName); data/faac-1.30/frontend/main.c:794:45: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l = t ? strlen(audioFileName) - strlen(t) : strlen(audioFileName); data/faac-1.30/frontend/main.c:794:57: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int l = t ? strlen(audioFileName) - strlen(t) : strlen(audioFileName); data/faac-1.30/frontend/main.c:1172:39: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). char *version_string = malloc(strlen(faac_id_string) + 6); data/faac-1.30/frontend/maingui.c:107:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(outputFilename, inputFilename, sizeof(outputFilename) - 5); data/faac-1.30/frontend/maingui.c:230:21: [1] (buffer) lstrcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Risk is low because the source is a constant character. lstrcat(HeaderText,"%"); data/faac-1.30/frontend/mp4write.c:95:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return dataout(txt, strlen(txt)); data/faac-1.30/frontend/mp4write.c:528:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int txtsize = strlen(tagtxt); data/faac-1.30/frontend/mp4write.c:677:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). uint32_t len1 = 8 + strlen(mean) + 4; data/faac-1.30/frontend/mp4write.c:678:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). uint32_t len2 = 8 + strlen(name) + 4; data/faac-1.30/frontend/mp4write.c:679:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). uint32_t len3 = 8 + strlen(data) + 4 + 4; data/faac-1.30/libfaac/bitstream.c:115:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(str) + 1; data/faac-1.30/plugins/cooledit/Faad.cpp:64:3: [1] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. Risk is low because the source is a constant character. lstrcpy(szString,""); ANALYSIS SUMMARY: Hits = 208 Lines analyzed = 17302 in approximately 0.55 seconds (31590 lines/second) Physical Source Lines of Code (SLOC) = 12223 Hits@level = [0] 121 [1] 35 [2] 122 [3] 10 [4] 41 [5] 0 Hits@level+ = [0+] 329 [1+] 208 [2+] 173 [3+] 51 [4+] 41 [5+] 0 Hits/KSLOC@level+ = [0+] 26.9165 [1+] 17.0171 [2+] 14.1536 [3+] 4.17246 [4+] 3.35433 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.