Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection_p.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtformattedpreedit.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtformattedpreedit.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputcontextproxy.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputcontextproxy.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputmethoditem.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputmethoditem.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputmethodproxy.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtinputmethodproxy.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtkeyboardlayout.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtkeyboardlayout.h
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtkeyboardproxy.cpp
Examining data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtkeyboardproxy.h
Examining data/fcitx-qt5-1.2.5/guiwrapper/common.h
Examining data/fcitx-qt5-1.2.5/guiwrapper/main.cpp
Examining data/fcitx-qt5-1.2.5/guiwrapper/mainwindow.cpp
Examining data/fcitx-qt5-1.2.5/guiwrapper/mainwindow.h
Examining data/fcitx-qt5-1.2.5/guiwrapper/wrapperapp.cpp
Examining data/fcitx-qt5-1.2.5/guiwrapper/wrapperapp.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxinputcontextproxy.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxinputcontextproxy.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxqtdbustypes.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxqtdbustypes.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxwatcher.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/fcitxwatcher.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/main.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/main.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.h
Examining data/fcitx-qt5-1.2.5/platforminputcontext/qtkey.cpp
Examining data/fcitx-qt5-1.2.5/platforminputcontext/qtkey.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/batchdialog.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/batchdialog.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/common.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/editor.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/editor.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/editordialog.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/editordialog.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/filelistmodel.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/filelistmodel.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/main.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/main.h
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/model.cpp
Examining data/fcitx-qt5-1.2.5/quickphrase-editor/model.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguifactory.cpp
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguifactory.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguifactory_p.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguiplugin.cpp
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguiplugin.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguiwidget.cpp
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtconfiguiwidget.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtkeysequencewidget.cpp
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtkeysequencewidget.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/fcitxqtkeysequencewidget_p.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/qtkeytrans.cpp
Examining data/fcitx-qt5-1.2.5/widgetsaddons/qtkeytrans.h
Examining data/fcitx-qt5-1.2.5/widgetsaddons/qtkeytransdata.h
FINAL RESULTS:
data/fcitx-qt5-1.2.5/platforminputcontext/main.cpp:28:57: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QFcitxPlatformInputContextPlugin::create(const QString &system,
data/fcitx-qt5-1.2.5/platforminputcontext/main.cpp:31:9: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (system.compare(system, QStringLiteral("fcitx"), Qt::CaseInsensitive) ==
data/fcitx-qt5-1.2.5/platforminputcontext/main.cpp:31:24: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if (system.compare(system, QStringLiteral("fcitx"), Qt::CaseInsensitive) ==
data/fcitx-qt5-1.2.5/platforminputcontext/main.h:35:55: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
QFcitxPlatformInputContext *create(const QString &system,
data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.cpp:41:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *value = getenv(name);
data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.cpp:55:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char *locale = getenv("LC_ALL");
data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.cpp:57:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
locale = getenv("LC_CTYPE");
data/fcitx-qt5-1.2.5/platforminputcontext/qfcitxplatforminputcontext.cpp:59:18: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
locale = getenv("LANG");
data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection.cpp:203:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly))
data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection.cpp:208:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFSIZE];
data/fcitx-qt5-1.2.5/platforminputcontext/fcitxwatcher.cpp:163:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(QIODevice::ReadOnly))
data/fcitx-qt5-1.2.5/platforminputcontext/fcitxwatcher.cpp:168:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[BUFSIZE];
data/fcitx-qt5-1.2.5/quickphrase-editor/editor.cpp:157:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dialog->open();
data/fcitx-qt5-1.2.5/quickphrase-editor/editor.cpp:168:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dialog->open();
data/fcitx-qt5-1.2.5/quickphrase-editor/editor.cpp:200:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dialog->open();
data/fcitx-qt5-1.2.5/quickphrase-editor/editor.cpp:208:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
dialog->open();
data/fcitx-qt5-1.2.5/quickphrase-editor/model.cpp:160:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!file.open(fp, QFile::ReadOnly)) {
data/fcitx-qt5-1.2.5/quickphrase-editor/model.cpp:232:19: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!tempFile.open()) {
data/fcitx-qt5-1.2.5/dbusaddons/fcitxqtconnection.cpp:209:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size_t sz = file.read(buffer, BUFSIZE);
data/fcitx-qt5-1.2.5/platforminputcontext/fcitxwatcher.cpp:169:22: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
size_t sz = file.read(buffer, BUFSIZE);
data/fcitx-qt5-1.2.5/quickphrase-editor/filelistmodel.cpp:45:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t length = strlen(QUICK_PHRASE_CONFIG_DIR);
data/fcitx-qt5-1.2.5/quickphrase-editor/filelistmodel.cpp:48:61: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length - strlen(".mb") - 1);
ANALYSIS SUMMARY:
Hits = 22
Lines analyzed = 8890 in approximately 0.28 seconds (31813 lines/second)
Physical Source Lines of Code (SLOC) = 6512
Hits@level = [0] 0 [1] 4 [2] 10 [3] 4 [4] 4 [5] 0
Hits@level+ = [0+] 22 [1+] 22 [2+] 18 [3+] 8 [4+] 4 [5+] 0
Hits/KSLOC@level+ = [0+] 3.37838 [1+] 3.37838 [2+] 2.76413 [3+] 1.2285 [4+] 0.614251 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.