Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/fclib-3.1.0+dfsg/src/fclib.c Examining data/fclib-3.1.0+dfsg/src/tests/fctst.c Examining data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c Examining data/fclib-3.1.0+dfsg/src/fclib.h FINAL RESULTS: data/fclib-3.1.0+dfsg/src/fclib.h:381:5: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf (stderr, __VA_ARGS__);\ data/fclib-3.1.0+dfsg/src/tests/fctst.c:34:5: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf (stderr, __VA_ARGS__);\ data/fclib-3.1.0+dfsg/src/tests/fctst.c:47:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->comment, comment); data/fclib-3.1.0+dfsg/src/tests/fctst.c:116:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->title, title); data/fclib-3.1.0+dfsg/src/tests/fctst.c:118:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->description, desc); data/fclib-3.1.0+dfsg/src/tests/fctst.c:120:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->math_info, math); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:36:5: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. fprintf (stderr, __VA_ARGS__);\ data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:49:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->comment, comment); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:118:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->title, title); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:120:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->description, desc); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:122:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (info->math_info, math); data/fclib-3.1.0+dfsg/src/tests/fctst.c:412:3: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand ((unsigned int)time (NULL)); data/fclib-3.1.0+dfsg/src/fclib.h:748:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen (path, "r"))) /* HDF5 outputs lots of warnings when file does not exist */ data/fclib-3.1.0+dfsg/src/fclib.h:795:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen (path, "r"))) /* HDF5 outputs lots of warnings when file does not exist */ data/fclib-3.1.0+dfsg/src/fclib.h:867:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen (path, "r"))) /* HDF5 outputs lots of warnings when file does not exist */ data/fclib-3.1.0+dfsg/src/fclib.h:935:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen (path, "r"))) /* HDF5 outputs lots of warnings when file does not exist */ data/fclib-3.1.0+dfsg/src/fclib.h:974:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char num [128]; data/fclib-3.1.0+dfsg/src/fclib.h:977:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((f = fopen (path, "r"))) /* HDF5 outputs lots of warnings when file does not exist */ data/fclib-3.1.0+dfsg/src/fclib.h:1158:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char num [128]; data/fclib-3.1.0+dfsg/src/tests/fctst.c:46:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->comment = malloc (strlen (comment) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst.c:115:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->title = malloc (strlen (title) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst.c:117:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->description = malloc (strlen (desc) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst.c:119:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->math_info = malloc (strlen (math) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:48:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->comment = malloc (strlen (comment) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:117:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->title = malloc (strlen (title) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:119:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->description = malloc (strlen (desc) + 1)); data/fclib-3.1.0+dfsg/src/tests/fctst_merit.c:121:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). MM (info->math_info = malloc (strlen (math) + 1)); ANALYSIS SUMMARY: Hits = 27 Lines analyzed = 2379 in approximately 0.19 seconds (12444 lines/second) Physical Source Lines of Code (SLOC) = 1640 Hits@level = [0] 59 [1] 8 [2] 7 [3] 1 [4] 11 [5] 0 Hits@level+ = [0+] 86 [1+] 27 [2+] 19 [3+] 12 [4+] 11 [5+] 0 Hits/KSLOC@level+ = [0+] 52.439 [1+] 16.4634 [2+] 11.5854 [3+] 7.31707 [4+] 6.70732 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.