Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/filters-2.55/scramble.c Examining data/filters-2.55/nethackify.c FINAL RESULTS: data/filters-2.55/nethackify.c:58:5: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand((gettimeofday(&tv,NULL),tv.tv_usec)); data/filters-2.55/scramble.c:166:3: [3] (random) srand: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srand(time(NULL)); // needed for scramble_string() to actually be random data/filters-2.55/scramble.c:137:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). infile = fopen(argv[1], "r"); data/filters-2.55/scramble.c:148:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outfile = fopen(argv[2], "a"); data/filters-2.55/nethackify.c:32:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(i=0; i<strlen(str); i++) { data/filters-2.55/nethackify.c:33:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(c=0; c<strlen(normal); c++) { data/filters-2.55/nethackify.c:60:14: [1] (buffer) getchar: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while((ch = getchar()) != EOF) { data/filters-2.55/nethackify.c:61:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(c=0; c<strlen(normal); c++) { data/filters-2.55/scramble.c:35:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(string); data/filters-2.55/scramble.c:81:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(string); data/filters-2.55/scramble.c:101:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). len = strlen(string); data/filters-2.55/scramble.c:112:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(string); data/filters-2.55/scramble.c:171:7: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(infile); data/filters-2.55/scramble.c:207:9: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = fgetc(infile); ANALYSIS SUMMARY: Hits = 14 Lines analyzed = 295 in approximately 0.05 seconds (6096 lines/second) Physical Source Lines of Code (SLOC) = 217 Hits@level = [0] 11 [1] 10 [2] 2 [3] 2 [4] 0 [5] 0 Hits@level+ = [0+] 25 [1+] 14 [2+] 4 [3+] 2 [4+] 0 [5+] 0 Hits/KSLOC@level+ = [0+] 115.207 [1+] 64.5161 [2+] 18.4332 [3+] 9.21659 [4+] 0 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.