Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/francine-0.99.8+orig/src/md5crypt.c
Examining data/francine-0.99.8+orig/src/md5crypt.h
Examining data/francine-0.99.8+orig/src/speech.c
Examining data/francine-0.99.8+orig/src/speech.h
Examining data/francine-0.99.8+orig/src/definitions.h
Examining data/francine-0.99.8+orig/src/environment.h
Examining data/francine-0.99.8+orig/src/authenticated.h
Examining data/francine-0.99.8+orig/src/macros.h
Examining data/francine-0.99.8+orig/src/fancy.c
Examining data/francine-0.99.8+orig/src/fancy.h
Examining data/francine-0.99.8+orig/src/login.h
Examining data/francine-0.99.8+orig/src/signal_handle.c
Examining data/francine-0.99.8+orig/src/signal_handle.h
Examining data/francine-0.99.8+orig/src/conf.h
Examining data/francine-0.99.8+orig/src/emergency.c
Examining data/francine-0.99.8+orig/src/emergency.h
Examining data/francine-0.99.8+orig/src/config.h
Examining data/francine-0.99.8+orig/src/log_message.c
Examining data/francine-0.99.8+orig/src/log_message.h
Examining data/francine-0.99.8+orig/src/system_logon.c
Examining data/francine-0.99.8+orig/src/system_logon.h
Examining data/francine-0.99.8+orig/src/login_permissions.c
Examining data/francine-0.99.8+orig/src/login_permissions.h
Examining data/francine-0.99.8+orig/src/after_login.h
Examining data/francine-0.99.8+orig/src/limits.h
Examining data/francine-0.99.8+orig/src/authenticated.c
Examining data/francine-0.99.8+orig/src/after_login.c
Examining data/francine-0.99.8+orig/src/conf.c
Examining data/francine-0.99.8+orig/src/login.c
Examining data/francine-0.99.8+orig/src/pam_login.c
Examining data/francine-0.99.8+orig/src/pam_login.h
FINAL RESULTS:
data/francine-0.99.8+orig/src/login.c:94:3: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
chown (ttyname(0), 0, 0);
data/francine-0.99.8+orig/src/login.c:95:3: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod (ttyname(0), 0600);
data/francine-0.99.8+orig/src/system_logon.c:288:3: [5] (race) chown:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchown( ) instead.
chown (ttyname(0), user->pw_uid, grp->gr_gid);
data/francine-0.99.8+orig/src/system_logon.c:289:3: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
chmod (ttyname(0), 0620);
data/francine-0.99.8+orig/src/after_login.c:93:3: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf (oldlog->ll_time?"Last login was from %s, at %s\n":
data/francine-0.99.8+orig/src/after_login.c:142:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(newmail, "%s/new", mailbox);
data/francine-0.99.8+orig/src/after_login.c:153:19: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(MSG_NEWMAIL);
data/francine-0.99.8+orig/src/after_login.c:166:4: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(mailbox,MAILBOX_PATH);
data/francine-0.99.8+orig/src/after_login.c:167:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(mailbox,userinfo->pw_name);
data/francine-0.99.8+orig/src/after_login.c:170:6: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(MSG_NOMAIL);
data/francine-0.99.8+orig/src/after_login.c:174:8: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(MSG_SEENMAIL);
data/francine-0.99.8+orig/src/after_login.c:176:8: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(MSG_NEWMAIL);
data/francine-0.99.8+orig/src/authenticated.c:89:27: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
return (strcmp ((char *)crypt(clear, crypted), crypted)==0);
data/francine-0.99.8+orig/src/authenticated.c:101:24: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
if ((strcmp ((char *)crypt(clear, crypted), crypted) != 0))
data/francine-0.99.8+orig/src/authenticated.c:169:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "the account for %s has expired",
data/francine-0.99.8+orig/src/authenticated.c:207:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s is not known to the system!", username);
data/francine-0.99.8+orig/src/authenticated.c:238:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s is locked", passwd_entry->pw_name);
data/francine-0.99.8+orig/src/authenticated.c:254:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "according to /etc/usertty %s is not allowed to log on here.", passwd_entry->pw_name);
data/francine-0.99.8+orig/src/authenticated.c:269:7: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s logged in", passwd_entry->pw_name);
data/francine-0.99.8+orig/src/authenticated.c:294:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s logged in", passwd_entry->pw_name);
data/francine-0.99.8+orig/src/authenticated.c:299:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s expired",
data/francine-0.99.8+orig/src/authenticated.c:305:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(errormessage,"couldn't fetch struct spwd for %s."
data/francine-0.99.8+orig/src/authenticated.c:322:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s logged in", passwd_entry->pw_name);
data/francine-0.99.8+orig/src/authenticated.c:330:11: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (errormessage, "%s entered a wrong password",
data/francine-0.99.8+orig/src/conf.c:213:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp,new_intro_string);
data/francine-0.99.8+orig/src/conf.c:240:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp,new_speech_device);
data/francine-0.99.8+orig/src/conf.c:293:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tmp,new_theme_dir);
data/francine-0.99.8+orig/src/emergency.c:58:7: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl (EMERGENCY_LOGIN, EMERGENCY_LOGIN, NULL);
data/francine-0.99.8+orig/src/fancy.c:199:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(theme_config_file,theme_dir);
data/francine-0.99.8+orig/src/fancy.c:229:16: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(line+5," %s %s", normal_file, failed_file);
data/francine-0.99.8+orig/src/fancy.c:231:16: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(normal_ansi_file,theme_dir);
data/francine-0.99.8+orig/src/fancy.c:233:16: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(normal_ansi_file,normal_file);
data/francine-0.99.8+orig/src/fancy.c:235:16: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(failed_ansi_file,theme_dir);
data/francine-0.99.8+orig/src/fancy.c:237:16: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(failed_ansi_file,failed_file);
data/francine-0.99.8+orig/src/fancy.c:293:5: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", termname);
data/francine-0.99.8+orig/src/log_message.c:108:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
case 0: sprintf(message, "FATAL ERROR: %s", msg); break;
data/francine-0.99.8+orig/src/log_message.c:109:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
case 1: sprintf(message, "NON-FATAL ERROR: %s", msg); break;
data/francine-0.99.8+orig/src/log_message.c:110:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
case 2: sprintf(message, "FAILED LOGINS: %s", msg); break;
data/francine-0.99.8+orig/src/log_message.c:111:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
case 3: sprintf(message, "ACCESS GRANTED: %s", msg); break;
data/francine-0.99.8+orig/src/log_message.c:112:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
case 4: sprintf(message, "ACCESS DENIED: %s", msg); break;
data/francine-0.99.8+orig/src/log_message.c:143:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (line, "%s %d %s %s", msgtype, &msgarg, logtype, logarg);
data/francine-0.99.8+orig/src/log_message.c:177:15: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (chtime, ctime(&xxtime));
data/francine-0.99.8+orig/src/log_message.c:179:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (xmessage, "login from %s on %s: %s",
data/francine-0.99.8+orig/src/log_message.c:203:15: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf (xmessage, "from %s: %s",
data/francine-0.99.8+orig/src/login.c:83:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", wtmpentry->ut_line);
data/francine-0.99.8+orig/src/login_permissions.c:110:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", tty);
data/francine-0.99.8+orig/src/login_permissions.c:127:4: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (line, "%s", linec);
data/francine-0.99.8+orig/src/login_permissions.c:191:11: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (line, "%s", str);
data/francine-0.99.8+orig/src/login_permissions.c:209:11: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ch, "%s", section_first->sectionname);
data/francine-0.99.8+orig/src/login_permissions.c:226:15: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ch, "%s", sectionmember_first->membername);
data/francine-0.99.8+orig/src/login_permissions.c:257:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (line, "%s", str);
data/francine-0.99.8+orig/src/login_permissions.c:425:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (output, &(complete[i]));
data/francine-0.99.8+orig/src/login_permissions.c:585:5: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", terminal);
data/francine-0.99.8+orig/src/login_permissions.c:669:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", terminal);
data/francine-0.99.8+orig/src/login_permissions.c:672:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (username, user->pw_name);
data/francine-0.99.8+orig/src/md5crypt.c:466:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(passwd,magic);
data/francine-0.99.8+orig/src/pam_login.c:64:13: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((*resp)[i].resp, password);
data/francine-0.99.8+orig/src/pam_login.c:67:15: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(buf, msg[i]->msg);
data/francine-0.99.8+orig/src/pam_login.c:69:15: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((*resp)[i].resp, buf2);
data/francine-0.99.8+orig/src/system_logon.c:165:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ne[i++], "HOME=%s", user->pw_dir);
data/francine-0.99.8+orig/src/system_logon.c:166:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ne[i++], "SHELL=%s", user->pw_shell);
data/francine-0.99.8+orig/src/system_logon.c:167:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ne[i++], "USER=%s", user->pw_name);
data/francine-0.99.8+orig/src/system_logon.c:168:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ne[i++], "LOGNAME=%s", user->pw_name);
data/francine-0.99.8+orig/src/system_logon.c:169:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(ne[i++], "TERM=%s", getenv("TERM")?getenv("TERM"):"linux");
data/francine-0.99.8+orig/src/system_logon.c:204:3: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf (ttyname(0), "/dev/%s", lastlog.ll_line);
data/francine-0.99.8+orig/src/system_logon.c:207:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy (lastlog.ll_host, rmthost);
data/francine-0.99.8+orig/src/system_logon.c:262:7: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
sscanf(ttyname(0),"/dev/%s",line);
data/francine-0.99.8+orig/src/system_logon.c:323:7: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(login_shell,user->pw_shell);
data/francine-0.99.8+orig/src/system_logon.c:326:9: [4] (shell) execle:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execle(user->pw_shell, login_shell , NULL,
data/francine-0.99.8+orig/src/system_logon.c:332:11: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execl (user->pw_shell, login_shell , NULL);
data/francine-0.99.8+orig/src/after_login.c:134:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if ((mailbox = getenv("MAILDIR"))!=NULL)
data/francine-0.99.8+orig/src/system_logon.c:169:31: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(ne[i++], "TERM=%s", getenv("TERM")?getenv("TERM"):"linux");
data/francine-0.99.8+orig/src/system_logon.c:169:46: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
sprintf(ne[i++], "TERM=%s", getenv("TERM")?getenv("TERM"):"linux");
data/francine-0.99.8+orig/src/after_login.c:112:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((motd = fopen ("/etc/motd", "r")) != NULL) /* open the file */
data/francine-0.99.8+orig/src/authenticated.c:167:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errormessage[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/authenticated.c:196:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errormessage [__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/authenticated.c:223:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (errormessage, "accorting to /etc/securetty root is not allowed to log here");
data/francine-0.99.8+orig/src/fancy.c:84:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char normal_ansi_file[1024];
data/francine-0.99.8+orig/src/fancy.c:85:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char failed_ansi_file[1024];
data/francine-0.99.8+orig/src/fancy.c:165:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/fancy.c:166:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char normal_file[256];
data/francine-0.99.8+orig/src/fancy.c:167:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char failed_file[256];
data/francine-0.99.8+orig/src/fancy.c:200:3: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(theme_config_file,"/theme.fl");
data/francine-0.99.8+orig/src/fancy.c:202:10: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f=fopen(theme_config_file,"rt"))==NULL)
data/francine-0.99.8+orig/src/fancy.c:301:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(ansifile,"rt");
data/francine-0.99.8+orig/src/log_message.c:87:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char message[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:88:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char xmessage[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:89:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:90:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char msgtype[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:91:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char logtype[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:92:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char logarg[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:93:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chtime[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/log_message.c:113:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
default: sprintf(message, "OOPS #001");
data/francine-0.99.8+orig/src/log_message.c:121:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((logging = fopen (FILENAME_LOGIN_LOGGING,"r")) == NULL)
data/francine-0.99.8+orig/src/log_message.c:186:30: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((logfile = fopen (logarg, "at")) == NULL)
data/francine-0.99.8+orig/src/log_message.c:210:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
openlog ("francine", 0, atoi(logarg));
data/francine-0.99.8+orig/src/login.c:123:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char username[__LEN_USERNAME__+1]="";
data/francine-0.99.8+orig/src/login.c:124:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char password[__LEN_PASSWORD__+1]="";
data/francine-0.99.8+orig/src/login.c:125:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errormsg[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login.c:211:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (errormsg, "login failed %d times", cntwrong);
data/francine-0.99.8+orig/src/login_permissions.c:63:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sectionname [__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:70:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char membername[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:104:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:105:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char linec[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:106:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char tty[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:112:24: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((securetty = fopen(FILENAME_SECURETTY,"r")) == NULL)
data/francine-0.99.8+orig/src/login_permissions.c:172:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:173:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:247:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:248:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char str[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:390:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char output[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:415:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char output[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/login_permissions.c:441:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char terminal[__MAX_STR_LEN__] = {0};
data/francine-0.99.8+orig/src/login_permissions.c:490:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ipaddr[k]=ipaddress(atoi(last));
data/francine-0.99.8+orig/src/login_permissions.c:505:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
netmask[k]=ipaddress(atoi(last));
data/francine-0.99.8+orig/src/login_permissions.c:629:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char terminal[10];
data/francine-0.99.8+orig/src/login_permissions.c:630:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char username[20];
data/francine-0.99.8+orig/src/login_permissions.c:651:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((usertty = fopen(FILENAME_USERTTY,"r"))==NULL)
data/francine-0.99.8+orig/src/md5crypt.c:81:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char in[64];
data/francine-0.99.8+orig/src/md5crypt.c:87:24: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void MD5Final(unsigned char digest[16], struct MD5Context *context);
data/francine-0.99.8+orig/src/md5crypt.c:164:11: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, len);
data/francine-0.99.8+orig/src/md5crypt.c:167:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, buf, t);
data/francine-0.99.8+orig/src/md5crypt.c:179:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, 64);
data/francine-0.99.8+orig/src/md5crypt.c:187:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, len);
data/francine-0.99.8+orig/src/md5crypt.c:198:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
MD5Final(unsigned char digest[16], struct MD5Context *ctx)
data/francine-0.99.8+orig/src/md5crypt.c:245:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(digest, ctx->buf, 16);
data/francine-0.99.8+orig/src/md5crypt.c:390:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char passwd[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/md5crypt.c:396:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char final[16];
data/francine-0.99.8+orig/src/pam_login.c:50:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[128];
data/francine-0.99.8+orig/src/pam_login.c:51:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf2[128];
data/francine-0.99.8+orig/src/pam_login.c:86:18: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
username_log = fopen("/dev/null","wb");
data/francine-0.99.8+orig/src/speech.c:15:11: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
f = fopen(get_speech_device(),"a");
data/francine-0.99.8+orig/src/system_logon.c:102:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(utent.ut_user, "LOGIN");
data/francine-0.99.8+orig/src/system_logon.c:174:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ne[i++], "PATH=/sbin:/bin:/usr/sbin:/usr/bin");
data/francine-0.99.8+orig/src/system_logon.c:176:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(ne[i++], "PATH=/usr/local/bin:/bin:/usr/bin:.");
data/francine-0.99.8+orig/src/system_logon.c:197:23: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((lastlog_file = open (FILENAME_LASTLOG, O_RDWR)) == -1)
data/francine-0.99.8+orig/src/system_logon.c:338:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char errormessage[__MAX_STR_LEN__];
data/francine-0.99.8+orig/src/system_logon.c:340:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(errormessage,"couldn't fork off process for user-environment!");
data/francine-0.99.8+orig/src/after_login.c:114:19: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c = fgetc(motd)) != EOF) /* print the file */
data/francine-0.99.8+orig/src/after_login.c:137:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newmail = malloc(strlen(mailbox) + 5);
data/francine-0.99.8+orig/src/after_login.c:161:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mailbox = malloc(strlen(MAILBOX_PATH)+strlen(userinfo->pw_name)+1);
data/francine-0.99.8+orig/src/after_login.c:161:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mailbox = malloc(strlen(MAILBOX_PATH)+strlen(userinfo->pw_name)+1);
data/francine-0.99.8+orig/src/conf.c:202:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * tmp = malloc(strlen(new_intro_string)+1);
data/francine-0.99.8+orig/src/conf.c:232:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * tmp = malloc(strlen(new_speech_device)+1);
data/francine-0.99.8+orig/src/conf.c:285:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char * tmp = malloc(strlen(new_theme_dir)+1);
data/francine-0.99.8+orig/src/fancy.c:193:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
theme_config_file = malloc(strlen(theme_dir)+strlen("/theme.fl")+1);
data/francine-0.99.8+orig/src/fancy.c:193:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
theme_config_file = malloc(strlen(theme_dir)+strlen("/theme.fl")+1);
data/francine-0.99.8+orig/src/fancy.c:232:16: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(normal_ansi_file,"/");
data/francine-0.99.8+orig/src/fancy.c:236:16: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(failed_ansi_file,"/");
data/francine-0.99.8+orig/src/fancy.c:288:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
termname = malloc(strlen(ttyname(0))-5+1);
data/francine-0.99.8+orig/src/fancy.c:306:13: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((c=fgetc(f))!=EOF) /* for every character you find in */
data/francine-0.99.8+orig/src/fancy.c:313:13: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c=fgetc(f);
data/francine-0.99.8+orig/src/fancy.c:367:5: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
x=getchar();
data/francine-0.99.8+orig/src/fancy.c:383:7: [1] (buffer) getchar:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c=getchar();
data/francine-0.99.8+orig/src/log_message.c:178:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
chtime[strlen(chtime)-1] = '\0';
data/francine-0.99.8+orig/src/login_permissions.c:210:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ch += strlen (section_first->sectionname);
data/francine-0.99.8+orig/src/login_permissions.c:228:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ch += strlen (sectionmember_first->membername) + 1;
data/francine-0.99.8+orig/src/login_permissions.c:561:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i=strlen(tryorig),j=strlen(realname);
data/francine-0.99.8+orig/src/login_permissions.c:561:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i=strlen(tryorig),j=strlen(realname);
data/francine-0.99.8+orig/src/macros.h:9:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (i<strlen(value)) \
data/francine-0.99.8+orig/src/macros.h:16:11: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c=fgetc(f); \
data/francine-0.99.8+orig/src/macros.h:19:5: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c=fgetc(f); \
data/francine-0.99.8+orig/src/md5crypt.c:414:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!strncmp(sp,magic,strlen(magic)))
data/francine-0.99.8+orig/src/md5crypt.c:415:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sp += strlen(magic);
data/francine-0.99.8+orig/src/md5crypt.c:430:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:434:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx,magic,strlen(magic));
data/francine-0.99.8+orig/src/md5crypt.c:443:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx1,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:445:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx1,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:449:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (pl = strlen(pw); pl > 0; pl -= 16)
data/francine-0.99.8+orig/src/md5crypt.c:458:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (j=0,i = strlen(pw); i ; i >>= 1)
data/francine-0.99.8+orig/src/md5crypt.c:467:3: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(passwd,sp,sl);
data/francine-0.99.8+orig/src/md5crypt.c:468:3: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(passwd,"$");
data/francine-0.99.8+orig/src/md5crypt.c:484:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx1,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:492:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx1,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:497:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
MD5Update(&ctx1,pw,strlen(pw));
data/francine-0.99.8+orig/src/md5crypt.c:503:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p = passwd + strlen(passwd);
data/francine-0.99.8+orig/src/system_logon.c:99:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(utent.ut_line, line, sizeof utent.ut_line);
data/francine-0.99.8+orig/src/system_logon.c:101:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(utent.ut_id, utent.ut_line + 3, sizeof utent.ut_id);
data/francine-0.99.8+orig/src/system_logon.c:111:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(utent.ut_user, name, sizeof utent.ut_user);
data/francine-0.99.8+orig/src/system_logon.c:216:3: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
read (lastlog_file, oldlog, sizeof *oldlog);
data/francine-0.99.8+orig/src/system_logon.c:259:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line = malloc(strlen(ttyname(0))-5/* length of /dev/ */+1/* NUL-byte */);
data/francine-0.99.8+orig/src/system_logon.c:315:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
login_shell = malloc(strlen(user->pw_shell)+2);
data/francine-0.99.8+orig/src/system_logon.c:322:7: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(login_shell,"-");
ANALYSIS SUMMARY:
Hits = 183
Lines analyzed = 4343 in approximately 0.17 seconds (25208 lines/second)
Physical Source Lines of Code (SLOC) = 2393
Hits@level = [0] 23 [1] 45 [2] 65 [3] 3 [4] 66 [5] 4
Hits@level+ = [0+] 206 [1+] 183 [2+] 138 [3+] 73 [4+] 70 [5+] 4
Hits/KSLOC@level+ = [0+] 86.0844 [1+] 76.473 [2+] 57.6682 [3+] 30.5056 [4+] 29.252 [5+] 1.67154
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.