Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/frozen-bubble-2.212/server/game.c
Examining data/frozen-bubble-2.212/server/game.h
Examining data/frozen-bubble-2.212/server/net.h
Examining data/frozen-bubble-2.212/server/tools.h
Examining data/frozen-bubble-2.212/server/log.h
Examining data/frozen-bubble-2.212/server/tools.c
Examining data/frozen-bubble-2.212/server/log.c
FINAL RESULTS:
data/frozen-bubble-2.212/server/game.c:208:17: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(joined_msg, sizeof(joined_msg), ok_player_joined, nick);
data/frozen-bubble-2.212/server/game.c:278:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(can_start_msg, sizeof(can_start_msg), ok_can_start, mapping_str);
data/frozen-bubble-2.212/server/game.c:470:9: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(talk_msg, sizeof(talk_msg), ok_talk, msg);
data/frozen-bubble-2.212/server/game.c:903:33: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
snprintf(parted_msg, sizeof(parted_msg), reason ? reason : ok_player_parted, save_nick);
data/frozen-bubble-2.212/server/log.h:38:112: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
void l_(int wanted_output_type, char* file, long line, const char* func, char* fmt, ...) __attribute__((format(printf,5,6)));
data/frozen-bubble-2.212/server/tools.c:54:9: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(s, sizeof(s), msg, args);
data/frozen-bubble-2.212/server/game.c:95:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char list_game_str[8192] = "";
data/frozen-bubble-2.212/server/game.c:108:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char list_game_str[8192] = "";
data/frozen-bubble-2.212/server/game.c:124:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char list_games_str[16384] __attribute__((aligned(4096))) = "";
data/frozen-bubble-2.212/server/game.c:125:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char list_playing_geolocs_str[16384] __attribute__((aligned(4096))) = "";
data/frozen-bubble-2.212/server/game.c:204:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char joined_msg[1000];
data/frozen-bubble-2.212/server/game.c:266:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mapping_str[4096] = "";
data/frozen-bubble-2.212/server/game.c:267:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char can_start_msg[1000];
data/frozen-bubble-2.212/server/game.c:457:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char talk_msg[1000];
data/frozen-bubble-2.212/server/game.c:901:33: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char parted_msg[1000];
data/frozen-bubble-2.212/server/log.c:55:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char current_date[50];
data/frozen-bubble-2.212/server/log.c:59:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[25];
data/frozen-bubble-2.212/server/log.h:26:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char current_date[50];
data/frozen-bubble-2.212/server/tools.c:53:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[8192];
data/frozen-bubble-2.212/server/tools.c:105:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(r, src, size);
data/frozen-bubble-2.212/server/tools.c:210:22: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open("/dev/null", 0);
data/frozen-bubble-2.212/server/tools.c:243:35: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
FILE* f = fopen(pidfile, "w");
data/frozen-bubble-2.212/server/tools.c:295:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fd = open("/dev/null", 0);
data/frozen-bubble-2.212/server/game.c:102:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return memdup(list_game_str, strlen(list_game_str) + 1);
data/frozen-bubble-2.212/server/game.c:121:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return memdup(list_game_str, strlen(list_game_str) + 1);
data/frozen-bubble-2.212/server/game.c:269:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(mapping_str);
data/frozen-bubble-2.212/server/game.c:554:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(nick) > 10)
data/frozen-bubble-2.212/server/game.c:556:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen(nick); i++) {
data/frozen-bubble-2.212/server/game.c:578:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
|| strlen(msg) < 8) { // 8 stands for "FB/M.m f"(oo)
data/frozen-bubble-2.212/server/game.c:603:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
args = current_command + strlen(current_command) + 1;
data/frozen-bubble-2.212/server/game.c:615:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(args) > 10)
data/frozen-bubble-2.212/server/game.c:634:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(args) > 13) // sign, 4 digits, dot, colon, sign, 4 digits, dot
data/frozen-bubble-2.212/server/game.c:649:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(args) > 10)
data/frozen-bubble-2.212/server/game.c:673:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(nick) > 10)
data/frozen-bubble-2.212/server/game.c:696:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(args) > 10)
data/frozen-bubble-2.212/server/game.c:899:78: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
process_msg_prio_(fd, leave_player_prio_msg, strlen(leave_player_prio_msg), g);
data/frozen-bubble-2.212/server/tools.c:113:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *ptr = dst + strlen(dst);
data/frozen-bubble-2.212/server/tools.c:248:54: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (fwrite(pid_s, 1, strlen(pid_s), f) < strlen(pid_s))
data/frozen-bubble-2.212/server/tools.c:248:74: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (fwrite(pid_s, 1, strlen(pid_s), f) < strlen(pid_s))
ANALYSIS SUMMARY:
Hits = 39
Lines analyzed = 1522 in approximately 0.50 seconds (3025 lines/second)
Physical Source Lines of Code (SLOC) = 1200
Hits@level = [0] 8 [1] 16 [2] 17 [3] 0 [4] 6 [5] 0
Hits@level+ = [0+] 47 [1+] 39 [2+] 23 [3+] 6 [4+] 6 [5+] 0
Hits/KSLOC@level+ = [0+] 39.1667 [1+] 32.5 [2+] 19.1667 [3+] 5 [4+] 5 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.