Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gadmin-openvpn-client-0.1.9/src/widgets.c
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_buttons.c
Examining data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/functions.h
Examining data/gadmin-openvpn-client-0.1.9/src/widgets.h
Examining data/gadmin-openvpn-client-0.1.9/src/file_chooser.c
Examining data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c
Examining data/gadmin-openvpn-client-0.1.9/src/status_update.h
Examining data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.h
Examining data/gadmin-openvpn-client-0.1.9/src/delete_connection_clicked.c
Examining data/gadmin-openvpn-client-0.1.9/src/status_update.c
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_spinbuttons.c
Examining data/gadmin-openvpn-client-0.1.9/src/show_import_window.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_entries.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_combos.c
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_hseparators.h
Examining data/gadmin-openvpn-client-0.1.9/src/credits_window.h
Examining data/gadmin-openvpn-client-0.1.9/src/functions.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_client_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_conf_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_main_window.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_combos.h
Examining data/gadmin-openvpn-client-0.1.9/src/create_conf_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/create_log_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c
Examining data/gadmin-openvpn-client-0.1.9/src/clear_log_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/create_client_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/deactivate_button_clicked.h
Examining data/gadmin-openvpn-client-0.1.9/src/save_conf_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/save_conf_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/allocate.h
Examining data/gadmin-openvpn-client-0.1.9/src/support.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_progressbars.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_log_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_checkbuttons.c
Examining data/gadmin-openvpn-client-0.1.9/src/gettext.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_entries.c
Examining data/gadmin-openvpn-client-0.1.9/src/clear_log_tab.c
Examining data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/apply_button_clicked.h
Examining data/gadmin-openvpn-client-0.1.9/src/show_info.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_labels.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_checkbuttons.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_buttons.h
Examining data/gadmin-openvpn-client-0.1.9/src/support.c
Examining data/gadmin-openvpn-client-0.1.9/src/show_help.c
Examining data/gadmin-openvpn-client-0.1.9/src/allocate.c
Examining data/gadmin-openvpn-client-0.1.9/src/gadmin-openvpn.c
Examining data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.h
Examining data/gadmin-openvpn-client-0.1.9/src/activate_button_clicked.c
Examining data/gadmin-openvpn-client-0.1.9/src/set_version.h
Examining data/gadmin-openvpn-client-0.1.9/src/deactivate_button_clicked.c
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_hseparators.c
Examining data/gadmin-openvpn-client-0.1.9/src/create_client_settings.h
Examining data/gadmin-openvpn-client-0.1.9/src/commands.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_spinbuttons.h
Examining data/gadmin-openvpn-client-0.1.9/src/apply_button_clicked.c
Examining data/gadmin-openvpn-client-0.1.9/src/delete_connection_clicked.h
Examining data/gadmin-openvpn-client-0.1.9/src/populate_gadmin_openvpn.c
Examining data/gadmin-openvpn-client-0.1.9/src/set_version.c
Examining data/gadmin-openvpn-client-0.1.9/src/file_chooser.h
Examining data/gadmin-openvpn-client-0.1.9/src/activate_button_clicked.h
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_labels.c
Examining data/gadmin-openvpn-client-0.1.9/src/credits_window.c
Examining data/gadmin-openvpn-client-0.1.9/src/show_import_window.c
Examining data/gadmin-openvpn-client-0.1.9/src/make_settings_progressbars.h
Examining data/gadmin-openvpn-client-0.1.9/src/gadmin-openvpn.h
Examining data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.h
Examining data/gadmin-openvpn-client-0.1.9/src/populate_gadmin_openvpn.h
Examining data/gadmin-openvpn-client-0.1.9/src/show_help.h
Examining data/gadmin-openvpn-client-0.1.9/src/create_main_window.c
Examining data/gadmin-openvpn-client-0.1.9/src/commands.c
Examining data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c
Examining data/gadmin-openvpn-client-0.1.9/src/show_info.c
FINAL RESULTS:
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:194:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(extra_options, line);
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:242:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(remote_lines_buffer, conf_line);
data/gadmin-openvpn-client-0.1.9/src/commands.c:44:12: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if((fp=popen(command, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/commands.c:54:13: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(info, line);
data/gadmin-openvpn-client-0.1.9/src/commands.c:69:12: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if((fp=popen(command, "w"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/functions.c:65:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(newbuf, "%s", buf);
data/gadmin-openvpn-client-0.1.9/src/functions.c:100:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(rnd_string, arr[where]);
data/gadmin-openvpn-client-0.1.9/src/functions.c:106:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(salt, "$1$%s$", rnd_string);
data/gadmin-openvpn-client-0.1.9/src/functions.c:109:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(salt, "%s", &rnd_string[6]);
data/gadmin-openvpn-client-0.1.9/src/functions.c:114:12: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
return crypt(password, salt);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:125:17: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(tmp, line);
data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.c:61:9: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(new_buffy, old_buffy);
data/gadmin-openvpn-client-0.1.9/src/set_version.c:49:12: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if((fp=popen(command, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/status_update.c:90:21: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(line, buf);
data/gadmin-openvpn-client-0.1.9/src/functions.c:93:5: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand((unsigned)time(NULL));
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:63:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(FIRESTARTER_USER_PRE, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:98:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(FIRESTARTER_USER_PRE, "a"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:167:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_client_conf, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:546:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(pass_file, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:664:9: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(remote_lines_buffer, "remote-random\n");
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:672:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_client_conf, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:837:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(sysinit_script_path, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:864:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(upscript_path, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/clear_log_tab.c:43:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(log_path, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/commands.c:98:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(upscript_path, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/commands.c:240:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(infile, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/functions.c:83:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char salt[13]=""; /* The total salt length is 12 */
data/gadmin-openvpn-client-0.1.9/src/functions.c:117:39: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void make_dir_chmod(gchar *directory, char perm[128])
data/gadmin-openvpn-client-0.1.9/src/functions.c:128:34: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void chmod_file(gchar *filepath, char perm[128])
data/gadmin-openvpn-client-0.1.9/src/functions.h:30:39: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void make_dir_chmod(gchar *directory, char perm[128]);
data/gadmin-openvpn-client-0.1.9/src/functions.h:31:34: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void chmod_file(gchar *filepath, char perm[128]);
data/gadmin-openvpn-client-0.1.9/src/gadmin-openvpn.c:51:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char global_user_name[1024]="";
data/gadmin-openvpn-client-0.1.9/src/make_settings_buttons.c:32:31: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char icon_name[100],
data/gadmin-openvpn-client-0.1.9/src/make_settings_buttons.h:29:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char icon_name[100],
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:106:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(conf, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:131:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(conf, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:183:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(conf, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:395:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_client_conf, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:564:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp1=fopen(tmp, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:719:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(tmp);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:762:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(tmp);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:785:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
i = atoi(tmp);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:887:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_sysinit_script, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.c:46:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_client_conf, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.c:53:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(log_path, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/save_conf_tab.c:55:12: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(openvpn_client_conf, "w+"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/status_update.c:48:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2];
data/gadmin-openvpn-client-0.1.9/src/status_update.c:71:20: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if((fp=fopen(sub_proc_path, "r"))==NULL)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:47:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( input!=NULL && strlen(input) > 2 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:77:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line==NULL || strlen(line) < 10 || commented(line) )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:183:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line==NULL || strlen(line) < 10 || commented(line) )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:235:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( option1!=NULL && strlen(option1) > 0 ) /* With a comment */
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:241:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(conf_line) + strlen(remote_lines_buffer) < MAX_REMOTE_LINES_BUFFER -1 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:241:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(conf_line) + strlen(remote_lines_buffer) < MAX_REMOTE_LINES_BUFFER -1 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:319:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( connection_name == NULL || strlen(connection_name) < 3 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:327:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cacert) < 3 || strlen(cert) < 3 || strlen(key) < 3 ) // Ignore TA because its optional.
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:327:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cacert) < 3 || strlen(cert) < 3 || strlen(key) < 3 ) // Ignore TA because its optional.
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:327:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cacert) < 3 || strlen(cert) < 3 || strlen(key) < 3 ) // Ignore TA because its optional.
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:337:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( selected_connection == NULL || strlen(selected_connection) < 3 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:505:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( user!=NULL && strlen(user) > 0 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:510:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( pass!=NULL && strlen(pass) > 3 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:513:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( mountcmd!=NULL && strlen(mountcmd) > 7 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:524:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(info)-1; info[i]!='\0'; i--)
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:531:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(info) < 3 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:644:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( proxy_address!=NULL && strlen(proxy_address) > 0 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:658:5: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(remote_lines_buffer, "\n");
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:663:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( num_remote_lines > 1 && strlen(remote_lines_buffer) < MAX_REMOTE_LINES_BUFFER -15 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:666:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(remote_lines_buffer) < MAX_REMOTE_LINES_BUFFER -2 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:667:9: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(remote_lines_buffer, "\n");
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:694:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( takey!=NULL && strlen(takey) > 3 )
data/gadmin-openvpn-client-0.1.9/src/apply_client_settings.c:743:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(extra_options) > 7 )
data/gadmin-openvpn-client-0.1.9/src/commands.c:170:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cmd) > 4 )
data/gadmin-openvpn-client-0.1.9/src/commands.c:193:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cmd) > 4 )
data/gadmin-openvpn-client-0.1.9/src/commands.c:214:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cmd) > 4 )
data/gadmin-openvpn-client-0.1.9/src/commands.c:226:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(cmd) > 4 )
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:122:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(info, strlen(info), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:132:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *filename = allocate(strlen(path)+3);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:136:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(path)-1; i>0; i--)
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:139:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
snprintf(filename, strlen(path), "%s", &path[i+1]);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:183:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( connection_name == NULL || strlen(connection_name) < 3 )
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:446:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:450:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:460:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:464:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:468:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:472:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:477:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:481:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:485:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:489:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:533:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:537:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:541:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:545:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:554:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:558:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:567:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:571:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:580:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:584:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:593:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/create_client_settings.c:597:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(combo_text, strlen(combo_text), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/delete_connection_clicked.c:41:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( selected_connection == NULL || strlen(selected_connection) < 3 )
data/gadmin-openvpn-client-0.1.9/src/functions.c:60:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(buf) < 2 )
data/gadmin-openvpn-client-0.1.9/src/functions.c:63:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
newbuf = allocate(strlen(buf)+1);
data/gadmin-openvpn-client-0.1.9/src/functions.c:143:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line!=NULL && strlen(line) > 0 )
data/gadmin-openvpn-client-0.1.9/src/gadmin-openvpn.c:94:13: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(100000*10);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:199:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line==NULL || strlen(line) < 10 || strlen(line) > 70 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:199:56: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line==NULL || strlen(line) < 10 || strlen(line) > 70 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:212:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:212:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:213:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:214:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:214:57: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:215:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:218:50: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:246:62: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(namelist[x]->d_name, strlen(namelist[x]->d_name), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:377:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( selected_connection == NULL || strlen(selected_connection) < 3 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:385:35: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(info, strlen(info), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:413:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(line) > 1000 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:419:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prev_line_pos = ftell(fp) - strlen(line);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:432:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:432:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:433:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:434:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:434:49: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\r' || tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:435:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:437:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:445:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( commented(line) || strlen(line) < 4 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:474:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:480:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(line)-1; line[i]!='\0'; i--)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:486:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:487:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:491:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:531:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:554:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:555:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:558:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:580:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line1==NULL || strlen(line1) < 3 || commented(line1) )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:584:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp1[strlen(tmp1)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:585:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp1[strlen(tmp1)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:588:51: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp1, strlen(tmp1), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:714:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:715:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:740:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(tmp)-1; tmp[i]!='\0'; i--)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:746:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:752:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(i=strlen(line)-1; line[i]!='\0'; i--)
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:757:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:758:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:780:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:781:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:800:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:801:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:803:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:817:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:818:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:820:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:834:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:835:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:837:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:851:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( tmp[strlen(tmp)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:852:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tmp[strlen(tmp)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:860:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:877:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:905:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line==NULL || strlen(line) < 4 )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:914:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line == NULL || strlen(line) < 4 || commented(line) )
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:932:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line[strlen(line)-1]=='\n')
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:933:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line[strlen(line)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_client_settings.c:943:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(tmp, strlen(tmp), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.c:66:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(new_buffy, strlen(new_buffy), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/populate_conf_tab.c:68:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_text_buffer_set_text(conf_textbuffer, utf8, strlen(utf8));
data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.c:68:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( line[strlen(line)-1]=='\n' )
data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.c:69:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line[strlen(line)-1]='\0';
data/gadmin-openvpn-client-0.1.9/src/populate_log_tab.c:74:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(line, strlen(line), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/set_version.c:76:42: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(ver, strlen(ver)-1, NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/set_version.c:87:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(ver, strlen(ver), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/show_import_window.c:54:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( import_package_file!=NULL && strlen(import_package_file) > 3
data/gadmin-openvpn-client-0.1.9/src/show_import_window.c:55:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
&& import_config_file!=NULL && strlen(import_config_file) > 3 )
data/gadmin-openvpn-client-0.1.9/src/show_import_window.c:64:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( import_package_file!=NULL && strlen(import_package_file) > 3 )
data/gadmin-openvpn-client-0.1.9/src/show_import_window.c:69:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( import_config_file!=NULL || strlen(import_config_file) > 3 )
data/gadmin-openvpn-client-0.1.9/src/show_import_window.c:117:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( file_exists(path) && strlen(path) > 20 )
data/gadmin-openvpn-client-0.1.9/src/show_info.c:52:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if( strlen(content) < 5 )
data/gadmin-openvpn-client-0.1.9/src/show_info.c:112:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(content, strlen(content), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/show_info.c:115:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_text_buffer_set_text(text_buffer, utf8, strlen(utf8));
data/gadmin-openvpn-client-0.1.9/src/status_update.c:52:5: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(pid, "0");
data/gadmin-openvpn-client-0.1.9/src/status_update.c:124:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(info, strlen(info), NULL, NULL, NULL);
data/gadmin-openvpn-client-0.1.9/src/status_update.c:138:39: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
utf8 = g_locale_to_utf8(info, strlen(info), NULL, NULL, NULL);
ANALYSIS SUMMARY:
Hits = 187
Lines analyzed = 7645 in approximately 0.24 seconds (31696 lines/second)
Physical Source Lines of Code (SLOC) = 4532
Hits@level = [0] 45 [1] 139 [2] 33 [3] 1 [4] 14 [5] 0
Hits@level+ = [0+] 232 [1+] 187 [2+] 48 [3+] 15 [4+] 14 [5+] 0
Hits/KSLOC@level+ = [0+] 51.1915 [1+] 41.2621 [2+] 10.5914 [3+] 3.3098 [4+] 3.08914 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.