Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/gkrellmwireless-2.0.3/wireless.c Examining data/gkrellmwireless-2.0.3/wireless.h FINAL RESULTS: data/gkrellmwireless-2.0.3/wireless.c:122:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ifr.ifr_name,interfaces[i]); data/gkrellmwireless-2.0.3/wireless.c:151:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ifr.ifr_name,interfaces[i]); data/gkrellmwireless-2.0.3/wireless.c:197:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ifr.ifr_name,card->ifname); data/gkrellmwireless-2.0.3/wireless.c:229:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(ifr.ifr_name,card->ifname); data/gkrellmwireless-2.0.3/wireless.c:296:5: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. sscanf(procread,"%s: %*s %*f %*f %*f %*d %*d %*d", data/gkrellmwireless-2.0.3/wireless.c:630:7: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. if (sscanf(arg,"%s %d\n",ifname,&flags) == 2) { data/gkrellmwireless-2.0.3/wireless.c:287:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char iface[5],procread[256], *c; data/gkrellmwireless-2.0.3/wireless.c:289:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((procfile = fopen(WIRELESS,"r")) == NULL) return FALSE; data/gkrellmwireless-2.0.3/wireless.c:322:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char procread[256], *c; data/gkrellmwireless-2.0.3/wireless.c:324:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((procfile = fopen(WIRELESS,"r")) != NULL) { data/gkrellmwireless-2.0.3/wireless.c:384:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[sizeof(struct iw_range) * 2]; data/gkrellmwireless-2.0.3/wireless.c:391:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy((char *)range, buffer, sizeof(struct iw_range)); data/gkrellmwireless-2.0.3/wireless.c:535:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char text[50]; data/gkrellmwireless-2.0.3/wireless.c:553:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char amount_text[50]; data/gkrellmwireless-2.0.3/wireless.c:561:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char amount_text[50]; data/gkrellmwireless-2.0.3/wireless.c:333:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (!strncmp(c,card->ifname,strlen(card->ifname))) { data/gkrellmwireless-2.0.3/wireless.c:372:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pwrq->ifr_name, ifname, IFNAMSIZ); data/gkrellmwireless-2.0.3/wireless.c:542:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(text, amount_text, sizeof(text)); ANALYSIS SUMMARY: Hits = 18 Lines analyzed = 950 in approximately 0.04 seconds (21773 lines/second) Physical Source Lines of Code (SLOC) = 689 Hits@level = [0] 6 [1] 3 [2] 9 [3] 0 [4] 6 [5] 0 Hits@level+ = [0+] 24 [1+] 18 [2+] 15 [3+] 6 [4+] 6 [5+] 0 Hits/KSLOC@level+ = [0+] 34.8331 [1+] 26.1248 [2+] 21.7707 [3+] 8.70827 [4+] 8.70827 [5+] 0 Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.