Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager.h Examining data/globus-gram-job-manager-15.4/startup_socket.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c Examining data/globus-gram-job-manager-15.4/logging.c Examining data/globus-gram-job-manager-15.4/tg_gateway.c Examining data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_gsi.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_history_file.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c Examining data/globus-gram-job-manager-15.4/test/client/version-test.c Examining data/globus-gram-job-manager-15.4/test/client/stdio-size-test.c Examining data/globus-gram-job-manager-15.4/test/client/register-ping-test.c Examining data/globus-gram-job-manager-15.4/test/client/register-refresh-credentials-test.c Examining data/globus-gram-job-manager-15.4/test/client/status-test.c Examining data/globus-gram-job-manager-15.4/test/client/nonblocking-register-test.c Examining data/globus-gram-job-manager-15.4/test/client/restart-to-new-url-test.c Examining data/globus-gram-job-manager-15.4/test/client/stdio-update-test.c Examining data/globus-gram-job-manager-15.4/test/client/local-stdio-size-test.c Examining data/globus-gram-job-manager-15.4/test/client/failed-job-two-phase-commit.c Examining data/globus-gram-job-manager-15.4/test/client/register-cancel-test.c Examining data/globus-gram-job-manager-15.4/test/client/set-credentials-test.c Examining data/globus-gram-job-manager-15.4/test/client/ping-test.c Examining data/globus-gram-job-manager-15.4/test/client/refresh-credentials-test.c Examining data/globus-gram-job-manager-15.4/test/client/job-status-with-info-test.c Examining data/globus-gram-job-manager-15.4/test/client/register-test.c Examining data/globus-gram-job-manager-15.4/test/client/register-version-test.c Examining data/globus-gram-job-manager-15.4/test/client/stdio-update-after-failure-test.c Examining data/globus-gram-job-manager-15.4/test/client/cancel-test.c Examining data/globus-gram-job-manager-15.4/test/client/register-callback-test.c Examining data/globus-gram-job-manager-15.4/test/client/two-phase-commit-test.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c Examining data/globus-gram-job-manager-15.4/rvf/globus_i_rvf.h Examining data/globus-gram-job-manager-15.4/rvf/globus_rvf_parser.h Examining data/globus-gram-job-manager-15.4/rvf/globus_rvf_check.c Examining data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.h Examining data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c Examining data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_scanner.c Examining data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_scanner.h Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_contact.c Examining data/globus-gram-job-manager-15.4/lock_test.c Examining data/globus-gram-job-manager-15.4/globus_gram_streamer.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_staging.c Examining data/globus-gram-job-manager-15.4/main.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_auditing.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_validate.c Examining data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c FINAL RESULTS: data/globus-gram-job-manager-15.4/globus_gram_job_manager_auditing.c:124:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. rc = chmod(filename, 0750); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:535:9: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, format, ap); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:2370:14: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. If the scanf format is influenceable by an attacker, it's exploitable. if ((sscanf( entry->d_name, data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3211:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(pipe_cmd[0], X_OK) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3238:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(p, "%s/globus-job-manager-script.pl", tok); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3239:17: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(p, X_OK) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:873:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmp_str, "%s %s", &cp[1], cp2); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:879:10: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmp_str, "%s %s", &cp[1], cp2); data/globus-gram-job-manager-15.4/globus_gram_job_manager_contact.c:1193:14: [4] (buffer) fscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. rc = fscanf(fp, "%*d %s%*[\n]", contact->contact); data/globus-gram-job-manager-15.4/globus_gram_job_manager_history_file.c:132:8: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if(access(request->job_history_file, F_OK) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:640:13: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. else if(sscanf(args, "%d %s", &mask, url) != 2) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:1262:17: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. If the scanf format is influenceable by an attacker, it's exploitable. sscanf(after_signal, data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1620:10: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. n += vsprintf( buf + t, format, ap ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1842:14: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. If the scanf format is influenceable by an attacker, it's exploitable. rc = sscanf( data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:2888:23: [4] (tmpfile) mktemp: Temporary file race condition (CWE-377). *scratchdir = mktemp(scratchname); data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:725:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(tmp_rsl_str, "environment = (%s %s)", var, value); data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:924:5: [4] (format) sprintf: Potential format string problem (CWE-134). Make format string constant. sprintf(rsl_spec, format, value_string); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:948:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(job_contact_match, request->job_contact); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:2026:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(script_path, X_OK) < 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:2259:5: [4] (buffer) sscanf: The scanf() family's %s operation, without a limit specification, permits buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a different input function. sscanf(value, "%s %s", from, to); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:58:10: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if ((access(*state_file, R_OK) != 0) && errno == ENOENT) data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:117:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy( tmp_file, request->job_state_file ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_validate.c:322:8: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if(access(lrm_validation_filename, R_OK) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_validate.c:335:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(site_validation_filename, R_OK) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_validate.c:349:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(site_lrm_validation_filename, R_OK) == 0) data/globus-gram-job-manager-15.4/main.c:980:28: [4] (shell) popen: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. config_guess = popen(config_guess_path, "r"); data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:769:21: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. # define YYFPRINTF fprintf data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:602:14: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. rc = sprintf(state->path, data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:926:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(next_log, R_OK) == 0) data/globus-gram-job-manager-15.4/startup_socket.c:2221:18: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. rc = sprintf(p, "%s=%s", globus_l_gatekeeper_env[envno], tmpstr); data/globus-gram-job-manager-15.4/startup_socket.c:2234:18: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. rc = sprintf(p, "%s=%s", cert_chain_name, tmpstr); data/globus-gram-job-manager-15.4/test/client/job-status-with-info-test.c:24:9: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf message; \ data/globus-gram-job-manager-15.4/test/client/register-ping-test.c:76:9: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer.value, "X509_USER_PROXY=%s", argv[2]); data/globus-gram-job-manager-15.4/test/client/register-test.c:101:13: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buffer.value, "X509_USER_PROXY=%s", argv[3]); data/globus-gram-job-manager-15.4/test/client/register-version-test.c:24:9: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf message; \ data/globus-gram-job-manager-15.4/test/client/version-test.c:24:9: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf message; \ data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3216:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. path = getenv("PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3296:13: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. getenv("PATH")); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3297:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("PERL5LIB")) data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3301:17: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. getenv("PERL5LIB")); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3306:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("LD_LIBRARY_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3316:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("SHLIB_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3322:19: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. tmp_env = getenv("LD_LIBRARY_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3331:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("LD_LIBRARY_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3337:19: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. tmp_env = getenv("LD_LIBRARY_PATH_64"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3346:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("LIBPATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3355:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("DYLD_LIBRARY_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3364:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_env = getenv("LD_LIBRARY_PATH"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:326:36: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * tmp_user_name = getenv("LOGNAME"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:466:32: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. config->home = strdup(getenv("HOME")); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:482:21: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * ev = getenv("GLOBUS_TCP_PORT_RANGE"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:491:21: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * ev = getenv("GLOBUS_TCP_SOURCE_RANGE"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:514:30: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. config->logname = strdup(getenv("LOGNAME")); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:629:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. gatekeeper_contact = getenv("GLOBUS_GATEKEEPER_CONTACT_STRING"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1626:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((s = getenv( "JOBMANAGER_SYSLOG_ID" )) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1631:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((s = getenv( "JOBMANAGER_SYSLOG_FAC" )) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1639:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((s = getenv( "JOBMANAGER_SYSLOG_LVL" )) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1674:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!(gk_acct_fd = getenv( gk_acct_fd_var ))) data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:2621:23: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. val = getenv(var); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:522:38: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char * gk_jm_id = getenv(gk_jm_id_var); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:523:38: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char * gk_peer = getenv("GATEKEEPER_PEER"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:524:38: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char * globus_id = getenv("GLOBUS_ID"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1367:36: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char *gk_jm_id = getenv(gk_jm_id_var); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c:2003:17: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. gk_id = getenv("GATEKEEPER_JM_ID"); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:134:19: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((opt = getopt(argc, argv, "s:p:d:h")) != -1) data/globus-gram-job-manager-15.4/main.c:95:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((sleeptime_str = getenv("GLOBUS_JOB_MANAGER_SLEEP"))) data/globus-gram-job-manager-15.4/main.c:100:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("GATEWAY_INTERFACE")) data/globus-gram-job-manager-15.4/main.c:119:8: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if(getenv("PATH") == NULL) data/globus-gram-job-manager-15.4/main.c:173:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv("GRID_SECURITY_HTTP_BODY_FD") == NULL && !cgi_invoked) data/globus-gram-job-manager-15.4/main.c:247:34: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ((!debug_mode_service) && getenv("X509_USER_PROXY") != NULL) data/globus-gram-job-manager-15.4/main.c:249:16: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. remove(getenv("X509_USER_PROXY")); data/globus-gram-job-manager-15.4/main.c:274:25: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. char * fd_env = getenv("GRID_SECURITY_HTTP_BODY_FD"); data/globus-gram-job-manager-15.4/main.c:284:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. fd_env = getenv("GRID_SECURITY_CONTEXT_FD"); data/globus-gram-job-manager-15.4/main.c:850:14: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. fd_env = getenv("GRID_SECURITY_CONTEXT_FD"); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:213:17: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. scheduler = getenv(JOB_MANAGER_SEG_SCHEDULER); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:223:9: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (getenv(JOB_MANAGER_SEG_LOG_PATH)) data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:225:41: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. logfile_state->log_dir = strdup(getenv(JOB_MANAGER_SEG_LOG_PATH)); data/globus-gram-job-manager-15.4/startup_socket.c:990:26: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. content_length_str = getenv("CONTENT_LENGTH"); data/globus-gram-job-manager-15.4/startup_socket.c:2192:31: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char * tmpstr = getenv(globus_l_gatekeeper_env[envno]); data/globus-gram-job-manager-15.4/startup_socket.c:2205:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. tmpstr = getenv(cert_chain_name); data/globus-gram-job-manager-15.4/startup_socket.c:2217:31: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char * tmpstr = getenv(globus_l_gatekeeper_env[envno]); data/globus-gram-job-manager-15.4/startup_socket.c:2231:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. tmpstr = getenv(cert_chain_name); data/globus-gram-job-manager-15.4/test/client/cancel-test.c:49:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/job-status-with-info-test.c:199:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/local-stdio-size-test.c:58:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/refresh-credentials-test.c:48:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/register-cancel-test.c:56:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/register-refresh-credentials-test.c:59:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/register-version-test.c:201:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/restart-to-new-url-test.c:453:22: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. contact_string = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/set-credentials-test.c:50:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/status-test.c:55:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/stdio-size-test.c:57:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/stdio-update-after-failure-test.c:61:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/stdio-update-test.c:438:22: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. contact_string = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/test/client/version-test.c:153:18: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. rm_contact = getenv("CONTACT_STRING"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:980:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char gramid[64]; data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:1038:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char gramid[64]; data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3095:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(manager->cred_path, "r"); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3198:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * pipe_cmd[8]; data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3199:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * env[11]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_auditing.c:115:21: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). auditing_file = fopen(filename, "w"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_auditing.c:283:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[128]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_auditing.c:374:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tbuf[26]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:65:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char hostname[MAXHOSTNAMELEN]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:88:19: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(argv[2], "r")) == NULL) data/globus-gram-job-manager-15.4/globus_gram_job_manager_gsi.c:721:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open( data/globus-gram-job-manager-15.4/globus_gram_job_manager_gsi.c:1035:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char md[EVP_MAX_MD_SIZE+1]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_history_file.c:137:22: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). history_fp = fopen(request->job_history_file, "a+"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_history_file.c:163:27: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). else if((history_fp = fopen(request->job_history_file, "w")) == NULL) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:685:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:1256:39: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->commit_extend += atoi(after_signal); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1603:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024 * 128]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1608:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. n = t = sprintf( buf, "JMA %04d/%02d/%02d %02d:%02d:%02d ", data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1866:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(uniq1p, uuid.binary.bytes, 8); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:1867:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(uniq2p, uuid.binary.bytes+8, 8); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:3501:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(*remote_io_url_filep, "r"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:3549:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(*remote_io_url_filep, "w"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:3696:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). file = open( data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:827:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * grid_monitor_files[3] = { NULL, NULL, NULL }; data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:837:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[1024]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:838:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line_job_contact[1024]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:886:29: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). grid_monitor_file = fopen(grid_monitor_output, "r"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:934:31: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). status_file_last_update = atoi(line); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:978:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(line_job_contact, line, len); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1005:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). new_status = atoi(line_bit); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1268:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). script_status = atoi(value); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1310:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). script_status = atoi(value); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1522:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). script_status = atoi(value); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1536:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). script_status = atoi(value); data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:1337:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). pu.i.i = atoi(p + matches[7].rm_so); data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:1473:21: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). condor_log_fd = open(path, O_RDONLY); data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:1802:25: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. chars = sprintf(p, "%03d.%03d.%03d,", data/globus-gram-job-manager-15.4/globus_gram_job_manager_staging.c:319:17: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). tmpfd = open(evaled_to, O_WRONLY|O_CREAT|O_APPEND, S_IRUSR|S_IWUSR); data/globus-gram-job-manager-15.4/globus_gram_job_manager_staging.c:1108:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). tmp_list_size = atoi(buffer); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c:2000:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). file = fopen(fname,"w"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c:2041:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(request->remote_io_url_file, "w"); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c:2093:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char lengthbuf[4]; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:99:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmp_file[1024] = { 0 }; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:118:5: [2] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant string. strcat( tmp_file, ".tmp" ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:120:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen( tmp_file, "w" ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:501:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen( request->job_state_file, "r" ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:534:30: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->restart_state = atoi( buffer ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:543:17: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). atoi( buffer ), 0); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:549:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->failure_code = atoi( buffer ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:603:33: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->two_phase_commit = atoi(buffer); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:746:40: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->expected_terminal_state = atoi( buffer ); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:776:34: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). request->job_log_level = atoi(buffer); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:119:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char local_path[16]; data/globus-gram-job-manager-15.4/globus_gram_streamer.c:201:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(local_path, "stdout"); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:202:32: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). monitor.output_stream.fd = open(local_path, O_RDONLY); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:204:5: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(local_path, "stderr"); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:205:31: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). monitor.error_stream.fd = open(local_path, O_RDONLY); data/globus-gram-job-manager-15.4/globus_gram_streamer.c:729:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char scheme[16]; data/globus-gram-job-manager-15.4/lock_test.c:27:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(argv[1], O_RDWR|O_CREAT|O_TRUNC, S_IRUSR|S_IWUSR); data/globus-gram-job-manager-15.4/logging.c:227:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char now_str[9]; data/globus-gram-job-manager-15.4/logging.c:311:36: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). globus_l_gram_log_fp = fopen(last_path, "a"); data/globus-gram-job-manager-15.4/main.c:97:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). sleeptime = atoi(sleeptime_str); data/globus-gram-job-manager-15.4/main.c:580:28: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE * pidin = fopen(manager.pid_path, "r"); data/globus-gram-job-manager-15.4/main.c:880:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char gramid[64]; data/globus-gram-job-manager-15.4/main.c:967:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char config_guessbuf[32]; data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:1080:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char const *yyarg[YYERROR_VERBOSE_ARGS_MAXIMUM]; data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:1097:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char yyformat[sizeof yyunexpected data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:1349:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char yymsgbuf[128]; data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:2331:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE * f = fopen(path, "r"); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:248:29: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). logfile_state->fp = fopen(logfile_state->path, "r"); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:436:25: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). state->fp = fopen(state->path, "r"); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:570:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&state->start_timestamp, &tm_now, sizeof(struct tm)); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:574:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&tm_val, &state->start_timestamp, sizeof(struct tm)); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:650:21: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&state->start_timestamp, data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:722:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char jobid[129]; data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:723:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nl[2]; data/globus-gram-job-manager-15.4/startup_socket.c:163:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). lockfd = open(manager->lock_path, O_RDWR|O_CREAT, S_IRWXU); data/globus-gram-job-manager-15.4/startup_socket.c:299:21: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char byte[1]; data/globus-gram-job-manager-15.4/startup_socket.c:325:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(manager->pid_path, "w"); data/globus-gram-job-manager-15.4/startup_socket.c:742:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char byte[1]; data/globus-gram-job-manager-15.4/startup_socket.c:969:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char byte[1]; data/globus-gram-job-manager-15.4/startup_socket.c:977:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char cred_length_buffer[4]; data/globus-gram-job-manager-15.4/startup_socket.c:978:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char env_length_buffer[4]; data/globus-gram-job-manager-15.4/startup_socket.c:1203:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char message_length_buffer[4]; data/globus-gram-job-manager-15.4/startup_socket.c:1220:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char byte[1] = {0}; data/globus-gram-job-manager-15.4/startup_socket.c:1229:21: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char cred_buffer_value[GLOBUS_GRAM_PROTOCOL_MAX_MSG_SIZE+16*1024]; data/globus-gram-job-manager-15.4/startup_socket.c:2203:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(cert_chain_name, "SSL_CLIENT_CERT_CHAIN%d", envno); data/globus-gram-job-manager-15.4/startup_socket.c:2229:9: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(cert_chain_name, "SSL_CLIENT_CERT_CHAIN%d", envno); data/globus-gram-job-manager-15.4/startup_socket.c:2335:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char msg_length_buf[4]; data/globus-gram-job-manager-15.4/startup_socket.c:2458:41: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. iov[i].iov_base = ((char *) iov[i].iov_base) data/globus-gram-job-manager-15.4/startup_socket.c:2465:41: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. iov[i].iov_base = ((char *) iov[i].iov_base) + rc; data/globus-gram-job-manager-15.4/startup_socket.c:2558:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p, q+1, len-1); data/globus-gram-job-manager-15.4/test/client/failed-job-two-phase-commit.c:54:41: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). if (argc < 3 || ((monitor.timeout = atoi(argv[2])) < 0)) data/globus-gram-job-manager-15.4/test/client/nonblocking-register-test.c:148:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * callback_contact[3]; data/globus-gram-job-manager-15.4/test/client/nonblocking-register-test.c:399:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). test_num = atoi(argv[2]); data/globus-gram-job-manager-15.4/test/client/register-callback-test.c:137:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char * callback_contact[3]; data/globus-gram-job-manager-15.4/test/client/register-callback-test.c:387:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). test_num = atoi(argv[2]); data/globus-gram-job-manager-15.4/test/client/stdio-update-test.c:40:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char old_output[64]; data/globus-gram-job-manager-15.4/test/client/stdio-update-test.c:44:14: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char new_output[64]; data/globus-gram-job-manager-15.4/test/client/two-phase-commit-test.c:82:36: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). || ((monitor.timeout = atoi(argv[3])) < 0)) data/globus-gram-job-manager-15.4/tg_gateway.c:145:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(assertion_string, asn1_str->data, asn1_str->length); data/globus-gram-job-manager-15.4/tg_gateway.c:207:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(assertion_string, asn1_str->data, asn1_str->length); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:307:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). else if (strlen(manager->socket_path) > sizeof(s.sun_path)) data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:982:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(gramid, key, sizeof(gramid)); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:1043:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(gramid, key, sizeof(gramid)); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:2375:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). && (strlen(entry->d_name + lock) == 0)) data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3222:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p = malloc(strlen(path) + strlen("/globus-job-manager-script.pl")); data/globus-gram-job-manager-15.4/globus_gram_job_manager.c:3222:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p = malloc(strlen(path) + strlen("/globus-job-manager-script.pl")); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:869:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ( cp[0] == '\'' && cp[strlen(cp) - 1] != '\'' ) data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:872:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp_str = malloc((strlen(cp) + strlen(cp2) + 2)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:872:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp_str = malloc((strlen(cp) + strlen(cp2) + 2)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:875:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). else if ( cp[0] == '"' && cp[strlen(cp) - 1] != '"' ) data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:878:28: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp_str = malloc((strlen(cp) + strlen(cp2) + 2)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:878:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp_str = malloc((strlen(cp) + strlen(cp2) + 2)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:883:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (( cp[0] == '"' && cp[strlen(cp) - 1] == '"' ) || data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:884:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ( cp[0] == '\'' && cp[strlen(cp) - 1] == '\'' )) data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:886:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp_str = malloc(strlen(cp)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:887:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). x = strlen(cp)-2; data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:888:14: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(tmp_str, &cp[1], x); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:1025:11: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. char *equal; data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:1033:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). arglen = strlen(arg_str); data/globus-gram-job-manager-15.4/globus_gram_job_manager_config.c:1036:9: [1] (buffer) equal: Function does not check the second iterator for over-read conditions (CWE-126). This function is often discouraged by most C++ coding standards in favor of its safer alternatives provided since C++14. Consider using a form of this function that checks the second iterator before potentially overflowing it. if (equal && arglen > 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:634:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). url = malloc(strlen(args)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:669:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). else if (!url || strlen(url) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:826:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!after_signal || strlen(after_signal) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:881:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!after_signal || strlen(after_signal) == 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_query.c:1197:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((!after_signal) || (strlen(after_signal) == 0)) data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:3528:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). rc = strlen(tmp)-1; data/globus-gram-job-manager-15.4/globus_gram_job_manager_request.c:3579:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (rc < (1+strlen(remote_io_url))) data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:721:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen("environment = (%s %s)") + data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:722:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(var) + data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:723:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(value)); data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:916:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). rsl_spec = malloc(strlen(format) + strlen(value_string) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:916:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). rsl_spec = malloc(strlen(format) + strlen(value_string) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_rsl.c:1220:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (errno != 0 || strlen(end) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:809:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). memmove(first_end, second_begin, strlen(second_begin) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:929:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if( ! feof(grid_monitor_file) && line[strlen(line) - 1] != '\n') data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:947:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). job_contact_match = malloc(strlen(request->job_contact) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:965:47: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if( ! feof(grid_monitor_file) && line[strlen(line) - 1] != '\n') data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1343:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(value != NULL && strlen(value) > 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1364:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(value != NULL && strlen(value) > 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1369:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). char *buf = malloc(strlen(value) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:1911:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). new_param = malloc(strlen(param)*2+1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:2257:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). from = malloc(strlen(value)+1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:2258:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). to = malloc(strlen(value)+1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:2779:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). (*iov)[i].iov_len = strlen(str); data/globus-gram-job-manager-15.4/globus_gram_job_manager_script.c:3057:55: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return strncmp(scripts->client_addr, client_addr, strlen(scripts->client_addr)) == 0; data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:399:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). subjob_id_len = strlen(event->job_id); data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:427:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(subjob_id_ptr + subjob_id_len + 1) + 1); data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:889:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ((pid == ULONG_MAX && errno != 0) || strlen(end) != 0) data/globus-gram-job-manager-15.4/globus_gram_job_manager_seg.c:1630:24: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). read_res = read( data/globus-gram-job-manager-15.4/globus_gram_job_manager_state.c:1471:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = read(fd, buffer + amt_read, content_length - amt_read); data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:555:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:565:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:571:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:577:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:589:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:601:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:608:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:617:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:625:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:632:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:656:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:669:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = 0; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:676:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = 0; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:719:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:733:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = 0; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:752:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:763:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_job_manager_state_file.c:773:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/globus-gram-job-manager-15.4/globus_gram_streamer.c:617:26: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = read(stream->fd, data + amt, data_size - amt); data/globus-gram-job-manager-15.4/logging.c:166:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). outstr = malloc(2*strlen(instr) + 1); data/globus-gram-job-manager-15.4/main.c:137:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(path, default_path, pathlen); data/globus-gram-job-manager-15.4/main.c:908:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(gramid, key, sizeof(gramid)); data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_parser.c:961:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). # define yystrlen strlen data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_scanner.c:1138:14: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). (c = getc( yyin )) != EOF && c != '\n'; ++n ) \ data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_scanner.c:1550:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(yytext); data/globus-gram-job-manager-15.4/rvf/globus_i_rvf_scanner.c:2345:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return globus_i_rvf__scan_bytes(yystr,strlen(yystr) ,yyscanner); data/globus-gram-job-manager-15.4/seg/seg_job_manager_module.c:533:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). state->path = malloc(strlen(state->log_dir) + 10); data/globus-gram-job-manager-15.4/startup_socket.c:422:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(addr.sun_path, manager->socket_path, sizeof(addr.sun_path)-1); data/globus-gram-job-manager-15.4/startup_socket.c:473:17: [1] (access) umask: Ensure that umask is given most restrictive possible setting (e.g., 066 or 077) (CWE-732). old_umask = umask(S_IRWXG|S_IRWXO); data/globus-gram-job-manager-15.4/startup_socket.c:502:12: [1] (access) umask: Ensure that umask is given most restrictive possible setting (e.g., 066 or 077) (CWE-732). (void) umask(old_umask); data/globus-gram-job-manager-15.4/startup_socket.c:1551:18: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = read(newsock, byte, 1); data/globus-gram-job-manager-15.4/startup_socket.c:2126:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(addr.sun_path, manager->socket_path, sizeof(addr.sun_path)-1); data/globus-gram-job-manager-15.4/startup_socket.c:2196:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). iov->iov_len += strlen(globus_l_gatekeeper_env[envno]) + strlen(tmpstr) + 2; data/globus-gram-job-manager-15.4/startup_socket.c:2196:70: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). iov->iov_len += strlen(globus_l_gatekeeper_env[envno]) + strlen(tmpstr) + 2; data/globus-gram-job-manager-15.4/startup_socket.c:2208:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). iov->iov_len += strlen(cert_chain_name) + strlen(tmpstr) + 2; data/globus-gram-job-manager-15.4/startup_socket.c:2208:55: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). iov->iov_len += strlen(cert_chain_name) + strlen(tmpstr) + 2; data/globus-gram-job-manager-15.4/startup_socket.c:2281:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). BIO_write(b, cert_pem, strlen(cert_pem)); data/globus-gram-job-manager-15.4/startup_socket.c:2289:36: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). BIO_write(b, cert_pem, strlen(cert_pem)); data/globus-gram-job-manager-15.4/startup_socket.c:2296:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(p) + 1; data/globus-gram-job-manager-15.4/startup_socket.c:2506:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = read(fd, ((char *)buf)+amt_read, len-amt_read); data/globus-gram-job-manager-15.4/test/client/register-ping-test.c:74:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen("X509_USER_PROXY=") + data/globus-gram-job-manager-15.4/test/client/register-ping-test.c:75:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(argv[2]) + 1); data/globus-gram-job-manager-15.4/test/client/register-ping-test.c:77:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer.length = strlen(buffer.value); data/globus-gram-job-manager-15.4/test/client/register-test.c:99:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen("X509_USER_PROXY=") + data/globus-gram-job-manager-15.4/test/client/register-test.c:100:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen(argv[3]) + 1); data/globus-gram-job-manager-15.4/test/client/register-test.c:102:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer.length = strlen(buffer.value); ANALYSIS SUMMARY: Hits = 294 Lines analyzed = 44995 in approximately 0.98 seconds (46106 lines/second) Physical Source Lines of Code (SLOC) = 35088 Hits@level = [0] 322 [1] 96 [2] 102 [3] 60 [4] 35 [5] 1 Hits@level+ = [0+] 616 [1+] 294 [2+] 198 [3+] 96 [4+] 36 [5+] 1 Hits/KSLOC@level+ = [0+] 17.5559 [1+] 8.37893 [2+] 5.64295 [3+] 2.73598 [4+] 1.02599 [5+] 0.0284998 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.