Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gnome-breakout-0.5.3/src/anim.c
Examining data/gnome-breakout-0.5.3/src/anim.h
Examining data/gnome-breakout-0.5.3/src/animloc.h
Examining data/gnome-breakout-0.5.3/src/ball.c
Examining data/gnome-breakout-0.5.3/src/ball.h
Examining data/gnome-breakout-0.5.3/src/bat.c
Examining data/gnome-breakout-0.5.3/src/bat.h
Examining data/gnome-breakout-0.5.3/src/block.c
Examining data/gnome-breakout-0.5.3/src/block.h
Examining data/gnome-breakout-0.5.3/src/collision.c
Examining data/gnome-breakout-0.5.3/src/collision.h
Examining data/gnome-breakout-0.5.3/src/flags.h
Examining data/gnome-breakout-0.5.3/src/game.c
Examining data/gnome-breakout-0.5.3/src/game.h
Examining data/gnome-breakout-0.5.3/src/gui-preferences.h
Examining data/gnome-breakout-0.5.3/src/leveldata.h
Examining data/gnome-breakout-0.5.3/src/powerup.c
Examining data/gnome-breakout-0.5.3/src/powerup.h
Examining data/gnome-breakout-0.5.3/src/util.h
Examining data/gnome-breakout-0.5.3/src/util.c
Examining data/gnome-breakout-0.5.3/src/breakout.h
Examining data/gnome-breakout-0.5.3/src/gui.h
Examining data/gnome-breakout-0.5.3/src/flags.c
Examining data/gnome-breakout-0.5.3/src/gnome-breakout.c
Examining data/gnome-breakout-0.5.3/src/gui.c
Examining data/gnome-breakout-0.5.3/src/gui-callbacks.c
Examining data/gnome-breakout-0.5.3/src/gui-callbacks.h
Examining data/gnome-breakout-0.5.3/src/gui-preferences.c
Examining data/gnome-breakout-0.5.3/src/leveldata.c
FINAL RESULTS:
data/gnome-breakout-0.5.3/src/gui.c:471:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buffer, 1024, format, ap);
data/gnome-breakout-0.5.3/src/gui.c:495:2: [4] (format) vsnprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
vsnprintf(buffer, 1024, format, ap);
data/gnome-breakout-0.5.3/src/flags.c:62:33: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
file = g_build_filename(g_get_home_dir(), ".gnome2",
data/gnome-breakout-0.5.3/src/gnome-breakout.c:20:2: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand((unsigned int) clock());
data/gnome-breakout-0.5.3/src/flags.c:321:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newflags, flags, sizeof(Flags));
data/gnome-breakout-0.5.3/src/leveldata.c:217:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(new->blocks, blocks, sizeof(gchar) * BLOCKS_TOTAL);
data/gnome-breakout-0.5.3/src/leveldata.c:235:7: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(filename, "r");
data/gnome-breakout-0.5.3/src/leveldata.c:347:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/gnome-breakout-0.5.3/src/leveldata.c:365:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ret->blocks, blocks, sizeof(gchar) * BLOCKS_TOTAL);
data/gnome-breakout-0.5.3/src/leveldata.c:572:10: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
ret = atoi(value);
data/gnome-breakout-0.5.3/src/game.c:70:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(diff_t);
data/gnome-breakout-0.5.3/src/leveldata.c:268:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(!strncmp(buffer, "GLOBAL_AUTHOR", strlen("GLOBAL_AUTHOR"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:273:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (!strncmp(buffer, "GLOBAL_NAME", strlen("GLOBAL_NAME"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:278:52: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (!strncmp(buffer, "GLOBAL_DIFFICULTY", strlen("GLOBAL_DIFFICULTY"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:290:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if (!strncmp(buffer, "TITLE ", strlen("TITLE "))) {
data/gnome-breakout-0.5.3/src/leveldata.c:369:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if(!strncmp(buffer, "AUTHOR", strlen("AUTHOR"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:374:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if(!strncmp(buffer, "NAME", strlen("NAME"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:379:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
} else if(!strncmp(buffer, "DIFFICULTY", strlen("DIFFICULTY"))) {
data/gnome-breakout-0.5.3/src/leveldata.c:532:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
tag_len = strlen(tag);
data/gnome-breakout-0.5.3/src/leveldata.c:549:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if(strspn(string, valid) != strlen(string)) {
ANALYSIS SUMMARY:
Hits = 20
Lines analyzed = 5313 in approximately 0.20 seconds (26686 lines/second)
Physical Source Lines of Code (SLOC) = 3834
Hits@level = [0] 2 [1] 10 [2] 6 [3] 2 [4] 2 [5] 0
Hits@level+ = [0+] 22 [1+] 20 [2+] 10 [3+] 4 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 5.73813 [1+] 5.21648 [2+] 2.60824 [3+] 1.0433 [4+] 0.521648 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.