Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/gnome-phone-manager-0.69/gnome-bluetooth/phonemgr.c
Examining data/gnome-phone-manager-0.69/src/phonemgr-conf.h
Examining data/gnome-phone-manager-0.69/src/ui.c
Examining data/gnome-phone-manager-0.69/src/test-entry.c
Examining data/gnome-phone-manager-0.69/src/app.h
Examining data/gnome-phone-manager-0.69/src/icon.c
Examining data/gnome-phone-manager-0.69/src/main.c
Examining data/gnome-phone-manager-0.69/src/e-phone-entry.h
Examining data/gnome-phone-manager-0.69/src/menu.c
Examining data/gnome-phone-manager-0.69/src/phonemgr-object.c
Examining data/gnome-phone-manager-0.69/src/phonemgr-object.h
Examining data/gnome-phone-manager-0.69/src/connection.c
Examining data/gnome-phone-manager-0.69/src/phone-manager-interface.h
Examining data/gnome-phone-manager-0.69/src/e-phone-entry.c
Examining data/gnome-phone-manager-0.69/libgsm/glibgsmtest.c
Examining data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c
Examining data/gnome-phone-manager-0.69/libgsm/test-sdp-search.c
Examining data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.h
Examining data/gnome-phone-manager-0.69/libgsm/phonemgr-utils.h
Examining data/gnome-phone-manager-0.69/libgsm/phonemgr-utils.c
Examining data/gnome-phone-manager-0.69/telepathy/debug.c
Examining data/gnome-phone-manager-0.69/telepathy/main.c
Examining data/gnome-phone-manager-0.69/telepathy/connection.h
Examining data/gnome-phone-manager-0.69/telepathy/connection-manager.h
Examining data/gnome-phone-manager-0.69/telepathy/im-channel.h
Examining data/gnome-phone-manager-0.69/telepathy/im-channel.c
Examining data/gnome-phone-manager-0.69/telepathy/im-channel-factory.c
Examining data/gnome-phone-manager-0.69/telepathy/connection.c
Examining data/gnome-phone-manager-0.69/telepathy/im-channel-factory.h
Examining data/gnome-phone-manager-0.69/telepathy/connection-manager.c
Examining data/gnome-phone-manager-0.69/telepathy/debug.h
Examining data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/econtactentry-marshal.c
Examining data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c
Examining data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.h
Examining data/gnome-phone-manager-0.69/cut-n-paste/gconf-bridge/gconf-bridge.c
Examining data/gnome-phone-manager-0.69/cut-n-paste/gconf-bridge/gconf-bridge.h
FINAL RESULTS:
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1588:7: [3] (random) g_rand_boolean:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
if (g_rand_boolean (rand)) {
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:88:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
gboolean open;
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:396:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!lookup->open)
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:425:14: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (e->open != FALSE || e->status == E_BOOK_ERROR_OK) {
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:562:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (entry->priv->search_fields, fields, sizeof (EContactField) * (i + 1));
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:641:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (entry->priv->search_fields, fields, sizeof (fields));
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:93:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char network_code[10];
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1207:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
*index = atoi (s + 4);
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1509:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&aux, &entry, sizeof(gn_phonebook_entry));
data/gnome-phone-manager-0.69/src/ui.c:510:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char work[128];
data/gnome-phone-manager-0.69/cut-n-paste/e-contact-entry/e-contact-entry.c:769:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
guint str_len = strlen (str), word_start = 0, i;
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1129:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_strlcpy ((char *) sms.user_data[0].u.text, mstr, strlen (mstr) + 1);
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1130:28: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sms.user_data[0].length = strlen (mstr);
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1195:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s = strchr (dataid + strlen ("GPM-UUID-") + 1, '-');
data/gnome-phone-manager-0.69/libgsm/phonemgr-listener.c:1198:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(s) < 5)
data/gnome-phone-manager-0.69/libgsm/phonemgr-utils.c:739:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (string, s, sizeof (string)); \
data/gnome-phone-manager-0.69/src/connection.c:45:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!dev || strlen (dev) != 17) {
data/gnome-phone-manager-0.69/src/ui.c:565:47: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
gtk_text_buffer_set_text (buf, msg->message, strlen (msg->message));
ANALYSIS SUMMARY:
Hits = 18
Lines analyzed = 9400 in approximately 0.25 seconds (37123 lines/second)
Physical Source Lines of Code (SLOC) = 6678
Hits@level = [0] 0 [1] 8 [2] 9 [3] 1 [4] 0 [5] 0
Hits@level+ = [0+] 18 [1+] 18 [2+] 10 [3+] 1 [4+] 0 [5+] 0
Hits/KSLOC@level+ = [0+] 2.69542 [1+] 2.69542 [2+] 1.49745 [3+] 0.149745 [4+] 0 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.