Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/gnome-remote-desktop-0.1.9/src/grd-context.c Examining data/gnome-remote-desktop-0.1.9/src/grd-context.h Examining data/gnome-remote-desktop-0.1.9/src/grd-control.c Examining data/gnome-remote-desktop-0.1.9/src/grd-daemon.c Examining data/gnome-remote-desktop-0.1.9/src/grd-daemon.h Examining data/gnome-remote-desktop-0.1.9/src/grd-damage-utils.c Examining data/gnome-remote-desktop-0.1.9/src/grd-damage-utils.h Examining data/gnome-remote-desktop-0.1.9/src/grd-enums.h Examining data/gnome-remote-desktop-0.1.9/src/grd-pipewire-utils.c Examining data/gnome-remote-desktop-0.1.9/src/grd-pipewire-utils.h Examining data/gnome-remote-desktop-0.1.9/src/grd-private.h Examining data/gnome-remote-desktop-0.1.9/src/grd-prompt.c Examining data/gnome-remote-desktop-0.1.9/src/grd-prompt.h Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-pipewire-stream.c Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-pipewire-stream.h Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.h Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-server.c Examining data/gnome-remote-desktop-0.1.9/src/grd-rdp-server.h Examining data/gnome-remote-desktop-0.1.9/src/grd-session-rdp.c Examining data/gnome-remote-desktop-0.1.9/src/grd-session-rdp.h Examining data/gnome-remote-desktop-0.1.9/src/grd-session-vnc.c Examining data/gnome-remote-desktop-0.1.9/src/grd-session-vnc.h Examining data/gnome-remote-desktop-0.1.9/src/grd-session.c Examining data/gnome-remote-desktop-0.1.9/src/grd-session.h Examining data/gnome-remote-desktop-0.1.9/src/grd-settings.c Examining data/gnome-remote-desktop-0.1.9/src/grd-settings.h Examining data/gnome-remote-desktop-0.1.9/src/grd-stream.c Examining data/gnome-remote-desktop-0.1.9/src/grd-stream.h Examining data/gnome-remote-desktop-0.1.9/src/grd-types.h Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-cursor.c Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-cursor.h Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-pipewire-stream.c Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-pipewire-stream.h Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-server.c Examining data/gnome-remote-desktop-0.1.9/src/grd-vnc-server.h Examining data/gnome-remote-desktop-0.1.9/tests/test-client-vnc.c FINAL RESULTS: data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:48:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf (sam_string, "%s:::", username); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:74:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy (filename, path); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:75:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat (filename, grd_path); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:79:3: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat (filename, template); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:71:10: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. path = getenv ("XDG_RUNTIME_DIR"); data/gnome-remote-desktop-0.1.9/src/grd-rdp-pipewire-stream.c:332:11: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (((uint8_t *) frame->data) + y * dst_stride, data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:50:5: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (sam_string + strlen (sam_string), "%02" PRIx8 "", nt_hash[i]); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:51:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf (sam_string + strlen (sam_string), ":::"); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:81:22: [2] (tmpfile) mkstemp: Potential for temporary file vulnerability in some circumstances. Some older Unix-like systems create temp files with permission to write by all by default, so be sure to set the umask to override this. Also, some older Unix systems might fail to use O_EXCL when opening the file, so make sure that O_EXCL is used by the library (CWE-377). rdp_sam_file->fd = mkstemp (filename); data/gnome-remote-desktop-0.1.9/src/grd-session-vnc.c:499:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(challenge_encrypted, rfb_client->authChallenge, CHALLENGESIZE); data/gnome-remote-desktop-0.1.9/src/grd-vnc-pipewire-stream.c:329:11: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy (((uint8_t *) frame->data) + y * dst_stride, data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:41:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). username_length = strlen (username); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:42:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). password_length = strlen (password); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:50:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). sprintf (sam_string + strlen (sam_string), "%02" PRIx8 "", nt_hash[i]); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:51:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). sprintf (sam_string + strlen (sam_string), ":::"); data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:72:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). filename = g_malloc0 (strlen (path) + strlen (grd_path) + data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:72:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). filename = g_malloc0 (strlen (path) + strlen (grd_path) + data/gnome-remote-desktop-0.1.9/src/grd-rdp-sam.c:73:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strlen (template) + 1); data/gnome-remote-desktop-0.1.9/src/grd-session-vnc.c:493:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen (password) == 0) ANALYSIS SUMMARY: Hits = 19 Lines analyzed = 7240 in approximately 0.18 seconds (40516 lines/second) Physical Source Lines of Code (SLOC) = 5228 Hits@level = [0] 0 [1] 8 [2] 6 [3] 1 [4] 4 [5] 0 Hits@level+ = [0+] 19 [1+] 19 [2+] 11 [3+] 5 [4+] 4 [5+] 0 Hits/KSLOC@level+ = [0+] 3.63428 [1+] 3.63428 [2+] 2.10406 [3+] 0.956389 [4+] 0.765111 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.