Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/gsimplecal-2.1/src/Boxable.cpp Examining data/gsimplecal-2.1/src/Boxable.hpp Examining data/gsimplecal-2.1/src/Calendar.cpp Examining data/gsimplecal-2.1/src/Calendar.hpp Examining data/gsimplecal-2.1/src/Clock.cpp Examining data/gsimplecal-2.1/src/Clock.hpp Examining data/gsimplecal-2.1/src/Config.cpp Examining data/gsimplecal-2.1/src/Config.hpp Examining data/gsimplecal-2.1/src/MainWindow.cpp Examining data/gsimplecal-2.1/src/MainWindow.hpp Examining data/gsimplecal-2.1/src/Timezones.cpp Examining data/gsimplecal-2.1/src/Timezones.hpp Examining data/gsimplecal-2.1/src/Unique.cpp Examining data/gsimplecal-2.1/src/Unique.hpp Examining data/gsimplecal-2.1/src/gsimplecal.cpp FINAL RESULTS: data/gsimplecal-2.1/src/Unique.cpp:134:21: [5] (race) readlink: This accepts filename arguments; if an attacker can move those files or change the link content, a race condition results. Also, it does not terminate with ASCII NUL. (CWE-362, CWE-20). Reconsider approach. int bytes = readlink(*path, pathname, sizeof(*pathname) * PATH_MAX); data/gsimplecal-2.1/src/Calendar.cpp:14:13: [4] (shell) execl: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execl("/bin/sh", "/bin/sh", "-c", cmdline, NULL); data/gsimplecal-2.1/src/Clock.cpp:53:30: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const char* old_tz = getenv("TZ"); data/gsimplecal-2.1/src/Clock.cpp:69:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[64]; data/gsimplecal-2.1/src/Unique.cpp:16:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char pathname[PATH_MAX + 1]; data/gsimplecal-2.1/src/Calendar.cpp:12:9: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(cmdline)) { data/gsimplecal-2.1/src/Unique.cpp:104:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(pathname, path, PATH_MAX); ANALYSIS SUMMARY: Hits = 7 Lines analyzed = 1301 in approximately 0.09 seconds (15092 lines/second) Physical Source Lines of Code (SLOC) = 1083 Hits@level = [0] 0 [1] 2 [2] 2 [3] 1 [4] 1 [5] 1 Hits@level+ = [0+] 7 [1+] 7 [2+] 5 [3+] 3 [4+] 2 [5+] 1 Hits/KSLOC@level+ = [0+] 6.46353 [1+] 6.46353 [2+] 4.61681 [3+] 2.77008 [4+] 1.84672 [5+] 0.923361 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.