Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/guake-indicator-1.4/src/guake-indicator-notify.h
Examining data/guake-indicator-1.4/src/guake-indicator-read-json.c
Examining data/guake-indicator-1.4/src/guake-indicator-xml.h
Examining data/guake-indicator-1.4/src/guake-indicator-write-xml.c
Examining data/guake-indicator-1.4/src/guake-indicator.h
Examining data/guake-indicator-1.4/src/guake-indicator-write-json.c
Examining data/guake-indicator-1.4/src/guake-indicator-ayatana.c
Examining data/guake-indicator-1.4/src/guake-indicator-write-json.h
Examining data/guake-indicator-1.4/src/guake-indicator-edit-menu.h
Examining data/guake-indicator-1.4/src/guake3.h
Examining data/guake-indicator-1.4/src/guake-indicator-dbus.c
Examining data/guake-indicator-1.4/src/guake-indicator-edit-menu.c
Examining data/guake-indicator-1.4/src/guake-indicator-ayatana.h
Examining data/guake-indicator-1.4/src/guake-indicator-read-json.h
Examining data/guake-indicator-1.4/src/guake-indicator-notify.c
Examining data/guake-indicator-1.4/src/guake-indicator-dbus.h
Examining data/guake-indicator-1.4/src/guake-indicator.c
Examining data/guake-indicator-1.4/src/guake-indicator-read-xml.c

FINAL RESULTS:

data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:1599:3:  [4] (buffer) sprintf:
  Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
  vsnprintf.
		sprintf(msg,"Guake indicator detected a Guake version prior to 0.4.5 (dbus call to get_tab_count failed), it's very likely that this host will be opened in a new tab instead of reusing tab number %s.\nI suggest you upgrading Guake to version 0.4.5 or higher to use this feature",gtk_entry_get_text(GET_ENTRY_NTHGUAKETAB(dialog)));
data/guake-indicator-1.4/src/guake-indicator-read-xml.c:171:6:  [4] (race) access:
  This usually indicates a security flaw. If an attacker can change anything
  along the path between the call to access() and the file's actual use
  (e.g., by moving files), the attacker can exploit the race condition
  (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid())
  and try to open the file directly.
	if( access( filecfg, F_OK ) != -1 )
data/guake-indicator-1.4/src/guake-indicator.c:157:8:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
			if (system(systemstring->str)==-1)
data/guake-indicator-1.4/src/guake-indicator.c:346:14:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
        	if (system ("/usr/bin/python3 /usr/bin/guake &")==-1)
data/guake-indicator-1.4/src/guake-indicator.c:351:14:  [4] (shell) system:
  This causes a new program to execute and is difficult to use safely
  (CWE-78). try using a library call that implements the same functionality
  if available.
        	if (system ("guake &")==-1)
data/guake-indicator-1.4/src/guake-indicator-read-json.c:269:36:  [3] (buffer) getenv:
  Environment variables are untrustable input if they can be set by an
  attacker. They can have any content and length, and the same variable can
  be set more than once (CWE-807, CWE-20). Check environment variables
  carefully before using them.
	if (asprintf(&fulldirpath,"%s/%s",getenv("HOME"),GUAKE_INDICATOR_DEFAULT_DIR)==-1)
data/guake-indicator-1.4/src/guake-indicator-read-json.c:308:13:  [3] (buffer) getenv:
  Environment variables are untrustable input if they can be set by an
  attacker. They can have any content and length, and the same variable can
  be set more than once (CWE-807, CWE-20). Check environment variables
  carefully before using them.
	char* user=getenv("LOGNAME");
data/guake-indicator-1.4/src/guake-indicator-ayatana.c:120:13:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
        if (atol((char*)ptr->open_in_tab)==-1)
data/guake-indicator-1.4/src/guake-indicator-ayatana.c:211:25:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
                    if (atol((char*)ptr->open_in_tab)==-1)
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:376:32:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
					if (open_in_tab==NULL || (atol((char*)open_in_tab)<0 && named==FALSE))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:378:26:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
						if (open_in_tab && atol((char*)open_in_tab)==-1)
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:1598:3:  [2] (buffer) char:
  Statically-sized arrays can be improperly restricted, leading to potential
  overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
  functions that limit length, or ensure that the size is larger than the
  maximum possible length.
		char msg[1000];
data/guake-indicator-1.4/src/guake-indicator-read-json.c:71:5:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	fd=fopen(filecfg,"r");
data/guake-indicator-1.4/src/guake-indicator-write-json.c:135:12:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
	FILE * fd=fopen(filecfg,"w");
data/guake-indicator-1.4/src/guake-indicator-write-xml.c:42:13:  [2] (misc) fopen:
  Check when opening files - can an attacker redirect it (via symlinks),
  force the opening of special file type (e.g., device files), move things
  around to create a race condition, control its ancestors, or change its
  contents? (CWE-362).
		FILE * fd=fopen(filecfg,"w");
data/guake-indicator-1.4/src/guake-indicator.c:76:31:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
	else if (host.open_in_tab && atol((char*)host.open_in_tab)==-1)
data/guake-indicator-1.4/src/guake-indicator.c:80:82:  [2] (integer) atol:
  Unless checked, the resulting number can exceed the expected range
  (CWE-190). If source untrusted, check both minimum and maximum, even if the
  input had no minus sign (large numbers can roll over into negative number;
  consider saving to an unsigned value if that is intended).
	else if (host.open_in_tab==NULL || !strlen(host.open_in_tab) || ((long)numtabs<=atol((char*)host.open_in_tab) && host.open_in_tab_named==FALSE))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:278:10:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
					if (strlen((char*)gtk_entry_get_text(widget_data)))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:281:44:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
						if (!strncasecmp((char*)name,"empty",strlen("empty")))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:792:9:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			if (!strlen((char*)gtk_entry_get_text(GET_ENTRY_MENUNAME(dialog))))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:855:9:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			if (!strlen((char*)gtk_entry_get_text(GET_ENTRY_MENUNAME(dialog))))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:893:9:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
			if (!strlen((char*)gtk_entry_get_text(GET_ENTRY_MENUNAME(dialog))))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:1079:33:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	if (host->hostname == NULL || !strlen((char*)host->hostname))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.c:1081:47:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	else if (host->command_after_login==NULL || !strlen((char*)host->command_after_login))
data/guake-indicator-1.4/src/guake-indicator-edit-menu.h:65:106:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define TEXTVIEW_SET_TEXT(var,var2) gtk_text_buffer_set_text(gtk_text_view_get_buffer (var),var2?var2:"",strlen((char*)var2));
data/guake-indicator-1.4/src/guake-indicator-write-json.c:142:27:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	fwrite((const void*)data,strlen(data),1,fd);
data/guake-indicator-1.4/src/guake-indicator.c:80:38:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	else if (host.open_in_tab==NULL || !strlen(host.open_in_tab) || ((long)numtabs<=atol((char*)host.open_in_tab) && host.open_in_tab_named==FALSE))
data/guake-indicator-1.4/src/guake-indicator.c:128:23:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	if (host.tab_name && strlen((char*) host.tab_name)) guake_renamecurrenttab(host.tab_name);
data/guake-indicator-1.4/src/guake-indicator.c:131:30:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	if (host.hostname==NULL || !strlen((char*)host.hostname))
data/guake-indicator-1.4/src/guake-indicator.c:133:46:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	else if (host.command_after_login==NULL || !strlen((char*)host.command_after_login))
data/guake-indicator-1.4/src/guake-indicator.c:145:13:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	for (i=0;i<strlen((char*)cmd);i++)
data/guake-indicator-1.4/src/guake-indicator.c:309:16:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	if (argc>1 && strlen(argv[1])>0 && !strcasecmp(argv[1],"-guake3"))
data/guake-indicator-1.4/src/guake-indicator.c:320:21:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	else if (argc>1 && strlen(argv[1])>0 && !strcasecmp(argv[1],"-guake0"))
data/guake-indicator-1.4/src/guake-indicator.c:331:21:  [1] (buffer) strlen:
  Does not handle strings that are not \0-terminated; if given one it may
  perform an over-read (it could cause a crash if unprotected) (CWE-126).
	else if (argc>1 && strlen(argv[1])>0)

ANALYSIS SUMMARY:

Hits = 34
Lines analyzed = 4273 in approximately 0.14 seconds (29956 lines/second)
Physical Source Lines of Code (SLOC) = 3227
Hits@level = [0]   6 [1]  17 [2]  10 [3]   2 [4]   5 [5]   0
Hits@level+ = [0+]  40 [1+]  34 [2+]  17 [3+]   7 [4+]   5 [5+]   0
Hits/KSLOC@level+ = [0+] 12.3954 [1+] 10.5361 [2+] 5.26805 [3+] 2.1692 [4+] 1.54943 [5+]   0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.