Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/horst-5.1/average.c Examining data/horst-5.1/average.h Examining data/horst-5.1/batman_adv_header-14.h Examining data/horst-5.1/batman_adv_header-15.h Examining data/horst-5.1/batman_header.h Examining data/horst-5.1/capture-pcap.c Examining data/horst-5.1/capture.c Examining data/horst-5.1/capture.h Examining data/horst-5.1/ccan/build_assert/build_assert.h Examining data/horst-5.1/ccan/build_assert/test/compile_fail-expr.c Examining data/horst-5.1/ccan/build_assert/test/compile_fail.c Examining data/horst-5.1/ccan/build_assert/test/compile_ok.c Examining data/horst-5.1/ccan/build_assert/test/run-BUILD_ASSERT_OR_ZERO.c Examining data/horst-5.1/ccan/check_type/check_type.h Examining data/horst-5.1/ccan/check_type/test/compile_fail-check_type.c Examining data/horst-5.1/ccan/check_type/test/compile_fail-check_type_unsigned.c Examining data/horst-5.1/ccan/check_type/test/compile_fail-check_types_match.c Examining data/horst-5.1/ccan/check_type/test/run.c Examining data/horst-5.1/ccan/container_of/container_of.h Examining data/horst-5.1/ccan/container_of/test/compile_fail-bad-type.c Examining data/horst-5.1/ccan/container_of/test/compile_fail-types.c Examining data/horst-5.1/ccan/container_of/test/compile_fail-var-types.c Examining data/horst-5.1/ccan/container_of/test/run.c Examining data/horst-5.1/ccan/list/list.c Examining data/horst-5.1/ccan/list/list.h Examining data/horst-5.1/ccan/list/test/compile_ok-constant.c Examining data/horst-5.1/ccan/list/test/helper.c Examining data/horst-5.1/ccan/list/test/helper.h Examining data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c Examining data/horst-5.1/ccan/list/test/run-check-corrupt.c Examining data/horst-5.1/ccan/list/test/run-check-nonconst.c Examining data/horst-5.1/ccan/list/test/run-list_del_from-assert.c Examining data/horst-5.1/ccan/list/test/run-list_prev-list_next.c Examining data/horst-5.1/ccan/list/test/run-prepend_list.c Examining data/horst-5.1/ccan/list/test/run-single-eval.c Examining data/horst-5.1/ccan/list/test/run-with-debug.c Examining data/horst-5.1/ccan/list/test/run.c Examining data/horst-5.1/ccan/str/debug.c Examining data/horst-5.1/ccan/str/str.c Examining data/horst-5.1/ccan/str/str.h Examining data/horst-5.1/ccan/str/str_debug.h Examining data/horst-5.1/ccan/str/test/compile_fail-STR_MAX_CHARS.c Examining data/horst-5.1/ccan/str/test/compile_fail-isalnum.c Examining data/horst-5.1/ccan/str/test/compile_fail-isalpha.c Examining data/horst-5.1/ccan/str/test/compile_fail-isascii.c Examining data/horst-5.1/ccan/str/test/compile_fail-isblank.c Examining data/horst-5.1/ccan/str/test/compile_fail-iscntrl.c Examining data/horst-5.1/ccan/str/test/compile_fail-isdigit.c Examining data/horst-5.1/ccan/str/test/compile_fail-islower.c Examining data/horst-5.1/ccan/str/test/compile_fail-isprint.c Examining data/horst-5.1/ccan/str/test/compile_fail-ispunct.c Examining data/horst-5.1/ccan/str/test/compile_fail-isspace.c Examining data/horst-5.1/ccan/str/test/compile_fail-isupper.c Examining data/horst-5.1/ccan/str/test/compile_fail-isxdigit.c Examining data/horst-5.1/ccan/str/test/compile_fail-strchr.c Examining data/horst-5.1/ccan/str/test/compile_fail-strrchr.c Examining data/horst-5.1/ccan/str/test/compile_fail-strstr.c Examining data/horst-5.1/ccan/str/test/debug.c Examining data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c Examining data/horst-5.1/ccan/str/test/run.c Examining data/horst-5.1/channel.c Examining data/horst-5.1/channel.h Examining data/horst-5.1/conf_options.c Examining data/horst-5.1/conf_options.h Examining data/horst-5.1/config.h Examining data/horst-5.1/control.c Examining data/horst-5.1/control.h Examining data/horst-5.1/display-channel.c Examining data/horst-5.1/display-essid.c Examining data/horst-5.1/display-filter.c Examining data/horst-5.1/display-help.c Examining data/horst-5.1/display-history.c Examining data/horst-5.1/display-main.c Examining data/horst-5.1/display-spectrum.c Examining data/horst-5.1/display-statistics.c Examining data/horst-5.1/display.c Examining data/horst-5.1/display.h Examining data/horst-5.1/essid.c Examining data/horst-5.1/essid.h Examining data/horst-5.1/ieee80211_util.c Examining data/horst-5.1/ieee80211_util.h Examining data/horst-5.1/ifctrl-dummy.c Examining data/horst-5.1/ifctrl-ioctl.c Examining data/horst-5.1/ifctrl-nl80211.c Examining data/horst-5.1/ifctrl-wext.c Examining data/horst-5.1/ifctrl.h Examining data/horst-5.1/listsort.c Examining data/horst-5.1/listsort.h Examining data/horst-5.1/mach_clock_gettime.c Examining data/horst-5.1/mach_clock_gettime.h Examining data/horst-5.1/main.c Examining data/horst-5.1/main.h Examining data/horst-5.1/network.c Examining data/horst-5.1/network.h Examining data/horst-5.1/node.c Examining data/horst-5.1/node.h Examining data/horst-5.1/olsr_header.h Examining data/horst-5.1/prism_header.h Examining data/horst-5.1/protocol_parser.c Examining data/horst-5.1/protocol_parser.h Examining data/horst-5.1/radiotap/platform.h Examining data/horst-5.1/radiotap/radiotap.c Examining data/horst-5.1/radiotap/radiotap.h Examining data/horst-5.1/radiotap/radiotap_iter.h Examining data/horst-5.1/util.c Examining data/horst-5.1/util.h Examining data/horst-5.1/wlan80211.h Examining data/horst-5.1/wlan_parser.c Examining data/horst-5.1/wlan_util.c Examining data/horst-5.1/wlan_util.h FINAL RESULTS: data/horst-5.1/capture-pcap.c:29:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. void __attribute__ ((format (printf, 1, 2))) data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:13:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define fprintf my_fprintf data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:21:8: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. ret = vsprintf(printf_buffer, format, ap); data/horst-5.1/ccan/list/test/run-check-corrupt.c:12:9: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define fprintf my_fprintf data/horst-5.1/ccan/list/test/run-check-corrupt.c:20:8: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. ret = vsprintf(printf_buffer, format, ap); data/horst-5.1/ccan/str/test/run.c:34:4: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(strings[n++], "%s%s", data/horst-5.1/control.c:55:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. while (access(conf.control_pipe, F_OK) < 0) { data/horst-5.1/display.c:75:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. void __attribute__ ((format (printf, 4, 5))) data/horst-5.1/display.c:86:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(buf, cols, fmt, ap); data/horst-5.1/display.h:54:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. void __attribute__ ((format (printf, 4, 5))) data/horst-5.1/main.c:96:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. void __attribute__ ((format (printf, 1, 2))) data/horst-5.1/main.c:103:2: [4] (format) vsnprintf: If format strings can be influenced by an attacker, they can be exploited, and note that sprintf variations do not always \0-terminate (CWE-134). Use a constant for the format specification. vsnprintf(&buf[1], 127, fmt, ap); data/horst-5.1/main.h:39:41: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define DEBUG(...) do { if (conf.debug) printf(__VA_ARGS__); } while (0) data/horst-5.1/main.h:354:30: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. void __attribute__ ((format (printf, 1, 2))) data/horst-5.1/ccan/list/test/helper.c:24:5: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srandom((int)time(NULL)); data/horst-5.1/ccan/list/test/helper.c:28:25: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. blob->secret_offset = random() % (sizeof(blob->secret_drawer)); data/horst-5.1/conf_options.c:515:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, getopt_str)) > 0) { data/horst-5.1/conf_options.c:539:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, getopt_str)) > 0) { data/horst-5.1/conf_options.c:548:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c = getopt(argc, argv, getopt_str)) > 0) { data/horst-5.1/capture-pcap.c:51:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char error[PCAP_ERRBUF_SIZE]; data/horst-5.1/capture.c:51:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(mac, ifr.ifr_hwaddr.sa_data, 6); data/horst-5.1/capture.c:61:13: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE* PF = fopen("/proc/sys/net/core/rmem_max", "w"); data/horst-5.1/ccan/list/test/helper.c:14:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char secret_drawer[42]; data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:14:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char printf_buffer[1000]; data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:35:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char expect[100]; data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:47:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(expect, "run-CCAN_LIST_DEBUG.c:50: prev corrupt in node %p (0) of %p\n", data/horst-5.1/ccan/list/test/run-check-corrupt.c:13:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char printf_buffer[1000]; data/horst-5.1/ccan/list/test/run-check-corrupt.c:33:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char expect[100]; data/horst-5.1/ccan/list/test/run-check-corrupt.c:47:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(expect, "test message: prev corrupt in node %p (0) of %p\n", data/horst-5.1/ccan/list/test/run-check-corrupt.c:70:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(expect, "test message: prev corrupt in node %p (1) of %p\n", data/horst-5.1/ccan/list/test/run-check-corrupt.c:79:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(expect, "test message: prev corrupt in node %p (0) of %p\n", data/horst-5.1/ccan/str/test/compile_fail-STR_MAX_CHARS.c:19:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[STR_MAX_CHARS(val)]; data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:9:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char str[1000]; data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:27:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "0x%llx", (unsigned long long)types.u1byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:29:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "0x%llx", (unsigned long long)types.u2byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:31:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "0x%llx", (unsigned long long)types.u4byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:33:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "0x%llx", (unsigned long long)types.u8byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:37:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%u", types.u1byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:39:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%d", types.s1byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:41:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%u", types.u2byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:43:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%d", types.s2byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:45:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%u", types.u4byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:47:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%d", types.s4byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:49:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%llu", (unsigned long long)types.u8byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:51:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%lld", (long long)types.s8byte); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:55:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(str, "%p", types.ptr); data/horst-5.1/ccan/str/test/run.c:27:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *strings[NUM_SUBSTRINGS * NUM_SUBSTRINGS]; data/horst-5.1/channel.c:259:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[32]; data/horst-5.1/conf_options.c:72:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.node_timeout = atoi(value); data/horst-5.1/conf_options.c:77:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.recv_buffer_size = atoi(value); data/horst-5.1/conf_options.c:96:10: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). int n = atoi(value); data/horst-5.1/conf_options.c:127:29: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.channel_scan_rounds = atoi(value); data/horst-5.1/conf_options.c:132:22: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.channel_time = atoi(value) * 1000; data/horst-5.1/conf_options.c:137:21: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.channel_max = atoi(value); data/horst-5.1/conf_options.c:142:26: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.display_interval = atoi(value) * 1000; data/horst-5.1/conf_options.c:173:14: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). conf.port = atoi(value); data/horst-5.1/conf_options.c:377:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[255]; data/horst-5.1/conf_options.c:378:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[MAX_CONF_NAME_STRLEN + 1]; data/horst-5.1/conf_options.c:379:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char value[MAX_CONF_VALUE_STRLEN + 1]; data/horst-5.1/conf_options.c:383:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(filename, "r")) == NULL) { data/horst-5.1/conf_options.c:502:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char getopt_str[(sizeof(conf_options)/sizeof(struct conf_option))*2 + 10]; data/horst-5.1/control.c:41:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). ctlpipe = open(conf.control_pipe, O_RDWR|O_NONBLOCK); data/horst-5.1/control.c:47:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char new[len + 2]; data/horst-5.1/control.c:60:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). ctlpipe = open(conf.control_pipe, O_WRONLY); data/horst-5.1/control.c:107:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_CMD]; data/horst-5.1/display-channel.c:97:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[6]; data/horst-5.1/display-filter.c:126:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[18]; data/horst-5.1/display-main.c:229:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char spin[4] = {'/', '-', '\\', '|'}; data/horst-5.1/display.c:189:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[9]; data/horst-5.1/ieee80211_util.c:60:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char ieee802_1d_to_ac[8] = { 0, 1, 1, 0, 2, 2, 3, 3 }; data/horst-5.1/ieee80211_util.c:62:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char ac_to_aifs[4] = { 3, 7, 2, 2}; data/horst-5.1/ieee80211_util.c:63:23: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const unsigned char ac_to_cwmin[4] = { 4, 4, 3, 2}; data/horst-5.1/main.c:82:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char buffer[2312 + 200]; data/horst-5.1/main.c:86:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static unsigned char cli_buffer[500]; data/horst-5.1/main.c:99:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[128]; data/horst-5.1/main.c:216:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[40]; data/horst-5.1/main.c:553:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char line[255]; data/horst-5.1/main.c:554:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char macs[18]; data/horst-5.1/main.c:555:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[18]; data/horst-5.1/main.c:559:12: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ((fp = fopen(filename, "r")) == NULL) { data/horst-5.1/main.c:665:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mon_ifname[IF_NAMESIZE]; data/horst-5.1/main.c:785:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). DF = fopen(conf.dumpfile, "w"); data/horst-5.1/main.h:115:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_src[MAC_LEN]; /* transmitter (TA) */ data/horst-5.1/main.h:116:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_dst[MAC_LEN]; /* receiver (RA) */ data/horst-5.1/main.h:117:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_bssid[MAC_LEN]; data/horst-5.1/main.h:118:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char wlan_essid[WLAN_MAX_SSID_LEN]; data/horst-5.1/main.h:177:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_bssid[MAC_LEN]; data/horst-5.1/main.h:214:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char essid[WLAN_MAX_SSID_LEN]; data/horst-5.1/main.h:287:12: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char mac[MAC_LEN]; data/horst-5.1/main.h:288:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char name[MAX_NODE_NAME_STRLEN + 1]; data/horst-5.1/main.h:296:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char ifname[IF_NAMESIZE + 1]; data/horst-5.1/main.h:309:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dumpfile[MAX_CONF_VALUE_STRLEN + 1]; data/horst-5.1/main.h:311:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char serveraddr[MAX_CONF_VALUE_STRLEN + 1]; data/horst-5.1/main.h:312:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char control_pipe[MAX_CONF_VALUE_STRLEN + 1]; data/horst-5.1/main.h:313:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mac_name_file[MAX_CONF_VALUE_STRLEN + 1]; data/horst-5.1/main.h:315:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char filtermac[MAX_FILTERMAC][MAC_LEN]; data/horst-5.1/main.h:316:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filtermac_enabled[MAX_FILTERMAC]; data/horst-5.1/main.h:317:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char filterbssid[MAC_LEN]; data/horst-5.1/main.h:337:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char my_mac_addr[MAC_LEN]; data/horst-5.1/network.c:73:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char filtermac[MAX_FILTERMAC][MAC_LEN]; data/horst-5.1/network.c:74:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filtermac_enabled[MAX_FILTERMAC]; data/horst-5.1/network.c:75:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char filterbssid[MAC_LEN]; data/horst-5.1/network.c:121:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_src[MAC_LEN]; data/horst-5.1/network.c:122:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_dst[MAC_LEN]; data/horst-5.1/network.c:123:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char wlan_bssid[MAC_LEN]; data/horst-5.1/network.c:124:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char wlan_essid[WLAN_MAX_SSID_LEN]; data/horst-5.1/network.c:194:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(np.wlan_src, p->wlan_src, MAC_LEN); data/horst-5.1/network.c:195:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(np.wlan_dst, p->wlan_dst, MAC_LEN); data/horst-5.1/network.c:196:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(np.wlan_bssid, p->wlan_bssid, MAC_LEN); data/horst-5.1/network.c:197:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(np.wlan_essid, p->wlan_essid, WLAN_MAX_SSID_LEN); data/horst-5.1/network.c:260:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p.wlan_src, np->wlan_src, MAC_LEN); data/horst-5.1/network.c:261:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p.wlan_dst, np->wlan_dst, MAC_LEN); data/horst-5.1/network.c:262:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p.wlan_bssid, np->wlan_bssid, MAC_LEN); data/horst-5.1/network.c:263:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p.wlan_essid, np->wlan_essid, WLAN_MAX_SSID_LEN); data/horst-5.1/network.c:371:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(nc.filtermac[i], conf.filtermac[i], MAC_LEN); data/horst-5.1/network.c:379:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(nc.filterbssid, conf.filterbssid, MAC_LEN); data/horst-5.1/network.c:402:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(conf.filtermac[i], nc->filtermac[i], MAC_LEN); data/horst-5.1/network.c:410:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(conf.filterbssid, nc->filterbssid, MAC_LEN); data/horst-5.1/network.c:583:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char rport_str[20]; data/horst-5.1/node.c:35:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&(n->last_pkt), p, sizeof(struct packet_info)); data/horst-5.1/node.c:63:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(n->wlan_bssid, p->wlan_bssid, MAC_LEN); data/horst-5.1/util.c:62:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char etherbuf[18]; data/horst-5.1/util.c:70:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char etherbuf[5]; data/horst-5.1/util.c:78:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char ipbuf[18]; data/horst-5.1/util.c:87:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char ipbuf[5]; data/horst-5.1/util.c:108:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char buf[20]; data/horst-5.1/wlan80211.h:148:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char ie[0]; data/horst-5.1/wlan80211.h:174:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. unsigned char var[0]; data/horst-5.1/wlan_parser.c:272:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p->wlan_essid, ie->var, ie->len); data/horst-5.1/wlan_parser.c:275:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p->wlan_essid, ie->var, WLAN_MAX_SSID_LEN-1); data/horst-5.1/wlan_parser.c:551:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p->wlan_src, ta, MAC_LEN); data/horst-5.1/wlan_parser.c:555:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p->wlan_dst, ra, MAC_LEN); data/horst-5.1/wlan_parser.c:559:3: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(p->wlan_bssid, bssid, MAC_LEN); data/horst-5.1/capture.c:45:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(ifr.ifr_name, ifname, IFNAMSIZ - 1); data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:54:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int prep = strlen(printf_buffer) - strlen(expect); data/horst-5.1/ccan/list/test/run-CCAN_LIST_DEBUG.c:54:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int prep = strlen(printf_buffer) - strlen(expect); data/horst-5.1/ccan/str/str.c:6:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). size_t i = 0, nlen = strlen(needle); data/horst-5.1/ccan/str/str.h:32:55: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). #define strstarts(str,prefix) (strncmp((str),(prefix),strlen(prefix)) == 0) data/horst-5.1/ccan/str/str.h:45:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(str) < strlen(postfix)) data/horst-5.1/ccan/str/str.h:45:20: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(str) < strlen(postfix)) data/horst-5.1/ccan/str/str.h:48:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return streq(str + strlen(str) - strlen(postfix), postfix); data/horst-5.1/ccan/str/str.h:48:35: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). return streq(str + strlen(str) - strlen(postfix), postfix); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:28:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u1byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:30:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u2byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:32:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u4byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:34:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u8byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:38:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u1byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:40:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.s1byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:42:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u2byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:44:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.s2byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:46:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u4byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:48:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.s4byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:50:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.u8byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:52:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.s8byte)); data/horst-5.1/ccan/str/test/run-STR_MAX_CHARS.c:56:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ok1(strlen(str) < STR_MAX_CHARS(types.ptr)); data/horst-5.1/ccan/str/test/run.c:19:18: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = 0; i < strlen(s); i++) data/horst-5.1/ccan/str/test/run.c:20:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ret[i] = s[strlen(s) - i - 1]; data/horst-5.1/ccan/str/test/run.c:32:24: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strings[n] = malloc(strlen(substrings[i]) data/horst-5.1/ccan/str/test/run.c:33:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). + strlen(substrings[j]) + 1); data/horst-5.1/ccan/str/test/run.c:47:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (k == strlen(strings[i])) { data/horst-5.1/conf_options.c:52:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.ifname, value, IF_NAMESIZE); data/horst-5.1/conf_options.c:167:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.serveraddr, value, MAX_CONF_VALUE_STRLEN); data/horst-5.1/conf_options.c:187:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.control_pipe, value, MAX_CONF_VALUE_STRLEN); data/horst-5.1/conf_options.c:189:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.control_pipe, DEFAULT_CONTROL_PIPE, MAX_CONF_VALUE_STRLEN); data/horst-5.1/conf_options.c:289:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.mac_name_file, value, MAX_CONF_VALUE_STRLEN); data/horst-5.1/conf_options.c:291:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.mac_name_file, DEFAULT_MAC_NAME_FILE, MAX_CONF_VALUE_STRLEN); data/horst-5.1/conf_options.c:442:41: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (pos < maxlen && (maxlen - pos) >= strlen(add)) data/horst-5.1/conf_options.c:443:4: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buf, add, (maxlen - pos)); data/horst-5.1/control.c:46:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen(cmd); data/horst-5.1/control.c:51:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.control_pipe, DEFAULT_CONTROL_PIPE, MAX_CONF_VALUE_STRLEN); data/horst-5.1/control.c:65:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(new, cmd, len); data/horst-5.1/control.c:112:8: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). len = read(ctlpipe, buf, MAX_CMD); data/horst-5.1/display-main.c:304:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (ssid == NULL || strlen(ssid) < 12) data/horst-5.1/display.c:89:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). mvwprintw(win, line, cols / 2 - strlen(buf) / 2, buf); data/horst-5.1/essid.c:116:3: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(e->essid, p->wlan_essid, WLAN_MAX_SSID_LEN); data/horst-5.1/ifctrl-ioctl.c:20:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(ifreq.ifr_name, interface, IF_NAMESIZE - 1); data/horst-5.1/ifctrl-wext.c:37:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iwr.ifr_name, devname, IFNAMSIZ - 1); data/horst-5.1/ifctrl-wext.c:55:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iwr.ifr_name, devname, IFNAMSIZ - 1); data/horst-5.1/ifctrl-wext.c:78:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(iwr.ifr_name, devname, IFNAMSIZ - 1); data/horst-5.1/main.c:566:7: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. n = sscanf(line, "%*s %17s %*s %17s", macs, name); data/horst-5.1/main.c:568:8: [1] (buffer) sscanf: It's unclear if the %s limit in the format string is small enough (CWE-120). Check that the limit is sufficiently small, or use a different input function. n = sscanf(line, "%17s %17s", macs, name); data/horst-5.1/main.c:571:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(node_names.entry[idx].name, name, MAX_NODE_NAME_STRLEN); data/horst-5.1/main.c:673:4: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.ifname, mon_ifname, IF_NAMESIZE); data/horst-5.1/main.c:777:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (name == NULL || strlen(name) == 0) { data/horst-5.1/main.c:783:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(conf.dumpfile, name, MAX_CONF_VALUE_STRLEN); ANALYSIS SUMMARY: Hits = 185 Lines analyzed = 13989 in approximately 0.98 seconds (14218 lines/second) Physical Source Lines of Code (SLOC) = 9265 Hits@level = [0] 84 [1] 52 [2] 114 [3] 5 [4] 14 [5] 0 Hits@level+ = [0+] 269 [1+] 185 [2+] 133 [3+] 19 [4+] 14 [5+] 0 Hits/KSLOC@level+ = [0+] 29.034 [1+] 19.9676 [2+] 14.3551 [3+] 2.05073 [4+] 1.51106 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.