Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/id3ren-1.1b0/src/id3misc.c Examining data/id3ren-1.1b0/src/id3ren.h Examining data/id3ren-1.1b0/src/id3tag.h Examining data/id3ren-1.1b0/src/id3file.h Examining data/id3ren-1.1b0/src/id3misc.h Examining data/id3ren-1.1b0/src/id3file.c Examining data/id3ren-1.1b0/src/id3genre.h Examining data/id3ren-1.1b0/src/id3tag.c Examining data/id3ren-1.1b0/src/id3ren.c FINAL RESULTS: data/id3ren-1.1b0/src/id3misc.c:70:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s1, in_s1); data/id3ren-1.1b0/src/id3misc.c:71:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(s2, in_s2); data/id3ren-1.1b0/src/id3misc.c:116:3: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, format, msg); data/id3ren-1.1b0/src/id3misc.c:123:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(buf, "%s: %s: %s\n", program_name, buf, strerror(errno)); data/id3ren-1.1b0/src/id3misc.c:136:3: [4] (format) vsprintf: Potential format string problem (CWE-134). Make format string constant. vsprintf(buf, format, msg); data/id3ren-1.1b0/src/id3ren.c:148:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, ptrtag->artist); data/id3ren-1.1b0/src/id3ren.c:150:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:155:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, ptrtag->u.v10.comment); data/id3ren-1.1b0/src/id3ren.c:157:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:161:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, genre_table[ptrtag->genre]); data/id3ren-1.1b0/src/id3ren.c:163:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:168:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, ptrtag->songname); data/id3ren-1.1b0/src/id3ren.c:170:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:175:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, ptrtag->album); data/id3ren-1.1b0/src/id3ren.c:177:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:182:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, ptrtag->year); data/id3ren-1.1b0/src/id3ren.c:184:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:189:13: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, strack); data/id3ren-1.1b0/src/id3ren.c:192:12: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, def_field); data/id3ren-1.1b0/src/id3ren.c:213:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tmpfile, applied_filename); data/id3ren-1.1b0/src/id3ren.c:245:9: [4] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). strcat(applied_filename, replace_spacechar); data/id3ren-1.1b0/src/id3ren.c:341:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cfile, path); data/id3ren-1.1b0/src/id3ren.c:346:5: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(cfile, "%s%c%s", path, PATH_CHAR, filename); data/id3ren-1.1b0/src/id3ren.c:352:7: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(cfile, F_OK) != 0) data/id3ren-1.1b0/src/id3ren.c:400:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(first,p1); data/id3ren-1.1b0/src/id3ren.c:473:6: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(stmp,"%s=",name); data/id3ren-1.1b0/src/id3ren.c:501:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_song, option); data/id3ren-1.1b0/src/id3ren.c:506:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_artist, option); data/id3ren-1.1b0/src/id3ren.c:511:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_album, option); data/id3ren-1.1b0/src/id3ren.c:516:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_year, option); data/id3ren-1.1b0/src/id3ren.c:533:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_comment, option); data/id3ren-1.1b0/src/id3ren.c:546:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_field, option); data/id3ren-1.1b0/src/id3ren.c:617:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(remove_char, option); data/id3ren-1.1b0/src/id3ren.c:628:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(replace_char, option); data/id3ren-1.1b0/src/id3ren.c:686:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_song, copytag.songname); data/id3ren-1.1b0/src/id3ren.c:696:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_artist, copytag.artist); data/id3ren-1.1b0/src/id3ren.c:706:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_album, copytag.album); data/id3ren-1.1b0/src/id3ren.c:716:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_year, copytag.year); data/id3ren-1.1b0/src/id3ren.c:739:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_comment, copytag.u.v10.comment); data/id3ren-1.1b0/src/id3ren.c:758:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_song, copytag.songname); data/id3ren-1.1b0/src/id3ren.c:760:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_artist, copytag.artist); data/id3ren-1.1b0/src/id3ren.c:762:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_album, copytag.album); data/id3ren-1.1b0/src/id3ren.c:764:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_year, copytag.year); data/id3ren-1.1b0/src/id3ren.c:767:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(def_comment, copytag.u.v10.comment); data/id3ren-1.1b0/src/id3ren.c:835:3: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(program_name, p); data/id3ren-1.1b0/src/id3ren.c:884:13: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(arg, F_OK) != 0) data/id3ren-1.1b0/src/id3ren.c:900:17: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(applied_filename, F_OK) == 0) data/id3ren-1.1b0/src/id3ren.c:909:15: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tempname,applied_filename); data/id3ren-1.1b0/src/id3tag.c:355:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(string, def_string); data/id3ren-1.1b0/src/id3tag.c:389:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(tagtmp,tag_template);p=ptagtmp=tagtmp; data/id3ren-1.1b0/src/id3tag.c:390:5: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(fntmp,fn);pfntmp=fntmp; data/id3ren-1.1b0/src/id3misc.c:100:11: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. lines = getenv("LINES"); data/id3ren-1.1b0/src/id3ren.c:790:22: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!read_config(getenv("ID3REN"), "")) data/id3ren-1.1b0/src/id3ren.c:791:24: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (!read_config(getenv("HOME"), CONFIG_HOME)) data/id3ren-1.1b0/src/id3file.c:110:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). *fp = fopen(fn, mode); data/id3ren-1.1b0/src/id3file.c:147:8: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fd = open(fn, O_RDWR); data/id3ren-1.1b0/src/id3file.c:184:3: [2] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant string. strcpy(tag->tag, "TAG"); data/id3ren-1.1b0/src/id3file.h:37:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tag[TAGLEN_TAG+1]; data/id3ren-1.1b0/src/id3file.h:38:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char songname[TAGLEN_SONG+1]; data/id3ren-1.1b0/src/id3file.h:39:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char artist[TAGLEN_ARTIST+1]; data/id3ren-1.1b0/src/id3file.h:40:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char album[TAGLEN_ALBUM+1]; data/id3ren-1.1b0/src/id3file.h:41:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char year[TAGLEN_YEAR+1]; data/id3ren-1.1b0/src/id3file.h:46:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char comment[TAGLEN_COMMENT_V10+1]; data/id3ren-1.1b0/src/id3file.h:50:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char comment[TAGLEN_COMMENT_V11+1]; data/id3ren-1.1b0/src/id3misc.c:102:24: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). if (lines == NULL || atoi(lines) < 1) data/id3ren-1.1b0/src/id3misc.c:105:15: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). return (int)atoi(lines); data/id3ren-1.1b0/src/id3misc.c:112:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/id3ren-1.1b0/src/id3misc.c:132:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[1024]; data/id3ren-1.1b0/src/id3ren.c:79:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename_template[256] = "[$a]-[$s].mp3"; data/id3ren-1.1b0/src/id3ren.c:81:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filename_template[256] = "[%a]-[%s].mp3"; data/id3ren-1.1b0/src/id3ren.c:85:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tag_template[256] = "[$a]-[$s].mp3"; data/id3ren-1.1b0/src/id3ren.c:87:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tag_template[256] = "[%a]-[%s].mp3"; data/id3ren-1.1b0/src/id3ren.c:94:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char replace_spacechar[32] = " "; data/id3ren-1.1b0/src/id3ren.c:100:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char applied_filename[512]; data/id3ren-1.1b0/src/id3ren.c:128:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tmpfile[512]; data/id3ren-1.1b0/src/id3ren.c:128:8: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). char tmpfile[512]; data/id3ren-1.1b0/src/id3ren.c:129:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char strack[10]; data/id3ren-1.1b0/src/id3ren.c:188:13: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. {sprintf(strack,"%02d",ptrtag->u.v11.track); data/id3ren-1.1b0/src/id3ren.c:213:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). strcpy(tmpfile, applied_filename); data/id3ren-1.1b0/src/id3ren.c:217:10: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). while (tmpfile[tcount] != '\0') data/id3ren-1.1b0/src/id3ren.c:221:31: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if ( replace_char[i] == tmpfile[tcount] && data/id3ren-1.1b0/src/id3ren.c:230:43: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (i != 31337 && strchr(remove_char, tmpfile[tcount]) == NULL) data/id3ren-1.1b0/src/id3ren.c:232:19: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). if (isalpha(tmpfile[tcount]) && flags.ulcase == 1) data/id3ren-1.1b0/src/id3ren.c:234:31: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). *ptrNewfile = toupper(tmpfile[tcount]); data/id3ren-1.1b0/src/id3ren.c:237:24: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). else if (isalpha(tmpfile[tcount]) && flags.ulcase == 2) data/id3ren-1.1b0/src/id3ren.c:239:31: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). *ptrNewfile = tolower(tmpfile[tcount]); data/id3ren-1.1b0/src/id3ren.c:242:16: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). else if (tmpfile[tcount] == ' ') data/id3ren-1.1b0/src/id3ren.c:251:23: [2] (tmpfile) tmpfile: Function tmpfile() has a security flaw on some systems (e.g., older System V systems) (CWE-377). *ptrNewfile = tmpfile[tcount]; data/id3ren-1.1b0/src/id3ren.c:327:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[1024]; data/id3ren-1.1b0/src/id3ren.c:331:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char first[1024]; data/id3ren-1.1b0/src/id3ren.c:332:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char second[1024]; data/id3ren-1.1b0/src/id3ren.c:362:8: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(cfile, "rt"); data/id3ren-1.1b0/src/id3ren.c:806:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char arg[256]; data/id3ren-1.1b0/src/id3ren.c:811:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tempname[512],*d,*s; data/id3ren-1.1b0/src/id3tag.c:38:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. extern char tag_template[256]; data/id3ren-1.1b0/src/id3tag.c:108:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). digit = atoi(search_gen); data/id3ren-1.1b0/src/id3tag.c:221:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[64]; data/id3ren-1.1b0/src/id3tag.c:285:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[64]; data/id3ren-1.1b0/src/id3tag.c:381:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char track[20],genre[20],*t,*w,*p,*f,*pfntmp,*ptagtmp; data/id3ren-1.1b0/src/id3tag.c:382:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char tagtmp[256],fntmp[256]; data/id3ren-1.1b0/src/id3file.c:231:16: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). tag->genre = fgetc(fp); data/id3ren-1.1b0/src/id3file.c:248:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(tag->songname) > 0) data/id3ren-1.1b0/src/id3file.c:251:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(tag->artist) > 0) data/id3ren-1.1b0/src/id3file.c:254:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(tag->album) > 0) data/id3ren-1.1b0/src/id3file.c:257:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(tag->year) > 0) data/id3ren-1.1b0/src/id3file.c:260:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(tag->u.v10.comment) > 0) data/id3ren-1.1b0/src/id3misc.c:56:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s1 = (char *)malloc( (strlen(in_s1)+1) ); data/id3ren-1.1b0/src/id3misc.c:62:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). s2 = (char *)malloc( (strlen(in_s2)+1) ); data/id3ren-1.1b0/src/id3misc.c:90:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = 0; i < strlen(lowstr); i++) data/id3ren-1.1b0/src/id3ren.c:120:11: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while(getc(stdin)!='\n') ; data/id3ren-1.1b0/src/id3ren.c:205:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ptrNewfile += strlen(applied_filename); data/id3ren-1.1b0/src/id3ren.c:219:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i = 0; i < strlen(replace_char); i += 2) data/id3ren-1.1b0/src/id3ren.c:222:21: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ((i+1) < strlen(replace_char)) ) data/id3ren-1.1b0/src/id3ren.c:247:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). ptrNewfile += strlen(applied_filename); data/id3ren-1.1b0/src/id3ren.c:266:17: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (i=0; i < strlen(string); i++) data/id3ren-1.1b0/src/id3ren.c:335:23: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (path == NULL || strlen(path) < 1) data/id3ren-1.1b0/src/id3ren.c:338:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (filename == NULL || strlen(filename) < 1) data/id3ren-1.1b0/src/id3ren.c:340:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&cfile, (strlen(path) + 1)); data/id3ren-1.1b0/src/id3ren.c:345:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&cfile, (strlen(path) + strlen(filename) + 2)); data/id3ren-1.1b0/src/id3ren.c:345:42: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&cfile, (strlen(path) + strlen(filename) + 2)); data/id3ren-1.1b0/src/id3ren.c:378:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (buffer[strlen(buffer)-1] == '\n') data/id3ren-1.1b0/src/id3ren.c:379:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/id3ren-1.1b0/src/id3ren.c:401:7: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(second,""); data/id3ren-1.1b0/src/id3ren.c:407:16: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. else strncat(second,p2,1); data/id3ren-1.1b0/src/id3ren.c:411:16: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. else strncat(second,p2,1); data/id3ren-1.1b0/src/id3ren.c:415:26: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. else if(*p2!=' ')strncat(second,p2,1); data/id3ren-1.1b0/src/id3ren.c:472:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&stmp, (strlen(name)+2)); data/id3ren-1.1b0/src/id3ren.c:474:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(strncmp(stmp,arg1,strlen(stmp))==0) data/id3ren-1.1b0/src/id3ren.c:500:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_song, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:505:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_artist, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:510:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_album, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:515:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_year, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:522:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(i=0;i<strlen(option);i++) data/id3ren-1.1b0/src/id3ren.c:532:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_comment, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:545:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_field, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:610:7: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(replace_spacechar, ""); data/id3ren-1.1b0/src/id3ren.c:612:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(replace_spacechar, option, (sizeof(replace_spacechar)-1)); data/id3ren-1.1b0/src/id3ren.c:616:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&remove_char, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:621:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if ( (strlen(option) % 2) != 0 ) data/id3ren-1.1b0/src/id3ren.c:627:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&replace_char, (strlen(option)+1)); data/id3ren-1.1b0/src/id3ren.c:638:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(filename_template, option, (sizeof(filename_template)-1)); data/id3ren-1.1b0/src/id3ren.c:648:7: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(tag_template, option, (sizeof(tag_template)-1)); data/id3ren-1.1b0/src/id3ren.c:685:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_song, strlen(copytag.songname)+1); data/id3ren-1.1b0/src/id3ren.c:695:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_artist, (strlen(copytag.artist)+1)); data/id3ren-1.1b0/src/id3ren.c:705:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_album, (strlen(copytag.album)+1)); data/id3ren-1.1b0/src/id3ren.c:715:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_year, (strlen(copytag.year)+1)); data/id3ren-1.1b0/src/id3ren.c:738:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_comment, (strlen(copytag.u.v10.comment)+1)); data/id3ren-1.1b0/src/id3ren.c:757:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_song, strlen(copytag.songname)+1); data/id3ren-1.1b0/src/id3ren.c:759:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_artist, (strlen(copytag.artist)+1)); data/id3ren-1.1b0/src/id3ren.c:761:31: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_album, (strlen(copytag.album)+1)); data/id3ren-1.1b0/src/id3ren.c:763:30: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_year, (strlen(copytag.year)+1)); data/id3ren-1.1b0/src/id3ren.c:766:33: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&def_comment, (strlen(copytag.u.v10.comment)+1)); data/id3ren-1.1b0/src/id3ren.c:825:5: [1] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). Risk is low because the source is a constant character. strcpy(program_path, "."); data/id3ren-1.1b0/src/id3ren.c:830:34: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&program_path, (strlen(argv[0]) - strlen(p))); data/id3ren-1.1b0/src/id3ren.c:830:52: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&program_path, (strlen(argv[0]) - strlen(p))); data/id3ren-1.1b0/src/id3ren.c:831:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(program_path, argv[0], ((strlen(argv[0]) - strlen(p)) - 1)); data/id3ren-1.1b0/src/id3ren.c:831:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncpy(program_path, argv[0], ((strlen(argv[0]) - strlen(p)) - 1)); data/id3ren-1.1b0/src/id3ren.c:831:56: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). strncpy(program_path, argv[0], ((strlen(argv[0]) - strlen(p)) - 1)); data/id3ren-1.1b0/src/id3ren.c:834:32: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). alloc_string(&program_name, (strlen(p)+1)); data/id3ren-1.1b0/src/id3ren.c:877:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(arg, lpwfd->cFileName, (sizeof(arg)-1)); data/id3ren-1.1b0/src/id3ren.c:882:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(arg, argv[i], (sizeof(arg)-1)); data/id3ren-1.1b0/src/id3tag.c:73:15: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (getc(stdin) != '\n') data/id3ren-1.1b0/src/id3tag.c:74:20: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getc(stdin) != '\n'); data/id3ren-1.1b0/src/id3tag.c:103:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). while (i < strlen(search_gen) && isdigit(search_gen[i])) data/id3ren-1.1b0/src/id3tag.c:106:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (i >= strlen(search_gen)) data/id3ren-1.1b0/src/id3tag.c:179:21: [1] (buffer) getchar: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = tolower(getchar()); data/id3ren-1.1b0/src/id3tag.c:187:18: [1] (buffer) getchar: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getchar() != '\n') ; data/id3ren-1.1b0/src/id3tag.c:211:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(field); data/id3ren-1.1b0/src/id3tag.c:243:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (buffer[strlen(buffer)-1] == '\n') data/id3ren-1.1b0/src/id3tag.c:245:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/id3ren-1.1b0/src/id3tag.c:249:14: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getc(stdin) != '\n'); data/id3ren-1.1b0/src/id3tag.c:254:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). else if (strlen(buffer) < 1) data/id3ren-1.1b0/src/id3tag.c:263:21: [1] (buffer) getchar: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). c = tolower(getchar()); data/id3ren-1.1b0/src/id3tag.c:269:16: [1] (buffer) getchar: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getchar() != '\n') ; data/id3ren-1.1b0/src/id3tag.c:311:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (buffer[strlen(buffer)-1] == '\n') data/id3ren-1.1b0/src/id3tag.c:313:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). buffer[strlen(buffer)-1] = '\0'; data/id3ren-1.1b0/src/id3tag.c:317:13: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getc(stdin) != '\n'); data/id3ren-1.1b0/src/id3tag.c:325:16: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for(i=0;i<strlen(buffer);i++) data/id3ren-1.1b0/src/id3tag.c:353:29: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (def_string != NULL && strlen(def_string) > 0) data/id3ren-1.1b0/src/id3tag.c:360:43: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (flags.edit_tag && string != NULL && strlen(string) > 0) data/id3ren-1.1b0/src/id3tag.c:368:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (string[strlen(string)-1] == '\n') data/id3ren-1.1b0/src/id3tag.c:369:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). string[strlen(string)-1] = '\0'; data/id3ren-1.1b0/src/id3tag.c:371:12: [1] (buffer) getc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while (getc(stdin) != '\n'); data/id3ren-1.1b0/src/id3tag.c:413:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.artist,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:418:15: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.u.v10.comment,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:422:15: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.u.v11.comment,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:427:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.songname,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:431:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.album,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:435:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(fntag.year,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:442:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(genre,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:448:13: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(track,pfntmp,length); data/id3ren-1.1b0/src/id3tag.c:462:10: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). f+=strlen(ptagtmp); data/id3ren-1.1b0/src/id3tag.c:535:7: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(ptrtag->songname) < 1 ) /*|| strlen(ptrtag->artist) < 1)*/ ANALYSIS SUMMARY: Hits = 193 Lines analyzed = 2458 in approximately 0.10 seconds (24470 lines/second) Physical Source Lines of Code (SLOC) = 1878 Hits@level = [0] 26 [1] 93 [2] 46 [3] 3 [4] 51 [5] 0 Hits@level+ = [0+] 219 [1+] 193 [2+] 100 [3+] 54 [4+] 51 [5+] 0 Hits/KSLOC@level+ = [0+] 116.613 [1+] 102.769 [2+] 53.2481 [3+] 28.754 [4+] 27.1565 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.