Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/idesk-0.7.5/src/DesktopIconConfig.cpp
Examining data/idesk-0.7.5/src/AbstractClasses.h
Examining data/idesk-0.7.5/src/Action.cpp
Examining data/idesk-0.7.5/src/Action.h
Examining data/idesk-0.7.5/src/ActionConfig.cpp
Examining data/idesk-0.7.5/src/ActionConfig.h
Examining data/idesk-0.7.5/src/App.cpp
Examining data/idesk-0.7.5/src/App.h
Examining data/idesk-0.7.5/src/Database.cpp
Examining data/idesk-0.7.5/src/Database.h
Examining data/idesk-0.7.5/src/DesktopConfig.h
Examining data/idesk-0.7.5/src/DesktopContainer.h
Examining data/idesk-0.7.5/src/XDesktopContainer.cpp
Examining data/idesk-0.7.5/src/DesktopIconConfig.h
Examining data/idesk-0.7.5/src/Main.cpp
Examining data/idesk-0.7.5/src/Misc.cpp
Examining data/idesk-0.7.5/src/Misc.h
Examining data/idesk-0.7.5/src/Timer.cpp
Examining data/idesk-0.7.5/src/Timer.h
Examining data/idesk-0.7.5/src/Util.h
Examining data/idesk-0.7.5/src/XImlib2Caption.h
Examining data/idesk-0.7.5/src/XIcon.h
Examining data/idesk-0.7.5/src/XDesktopContainer.h
Examining data/idesk-0.7.5/src/XIcon.cpp
Examining data/idesk-0.7.5/src/XImlib2Background.cpp
Examining data/idesk-0.7.5/src/XIconWithShadow.cpp
Examining data/idesk-0.7.5/src/XIconWithShadow.h
Examining data/idesk-0.7.5/src/XImlib2Background.h
Examining data/idesk-0.7.5/src/XImlib2Caption.cpp
Examining data/idesk-0.7.5/src/XImlib2Image.cpp
Examining data/idesk-0.7.5/src/XImlib2Image.h
Examining data/idesk-0.7.5/src/XImlib2Shadow.cpp
Examining data/idesk-0.7.5/src/XImlib2Shadow.h
Examining data/idesk-0.7.5/src/XImlib2ToolTip.cpp
Examining data/idesk-0.7.5/src/XImlib2ToolTip.h
Examining data/idesk-0.7.5/src/cursors.h
Examining data/idesk-0.7.5/src/DesktopConfig.cpp
FINAL RESULTS:
data/idesk-0.7.5/src/App.cpp:103:5: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execvp( argv[0], argv );
data/idesk-0.7.5/src/XDesktopContainer.cpp:599:6: [4] (shell) execl:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
if(execl("/bin/sh", "/bin/sh", "-c", command.c_str(), 0) == -1){
data/idesk-0.7.5/src/DesktopConfig.cpp:132:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string directory(getenv("HOME"));
data/idesk-0.7.5/src/DesktopConfig.cpp:153:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string directory(getenv("HOME"));
data/idesk-0.7.5/src/DesktopConfig.cpp:228:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string directory(getenv("HOME"));
data/idesk-0.7.5/src/DesktopConfig.cpp:272:21: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string ideskicon = getenv("HOME");
data/idesk-0.7.5/src/XDesktopContainer.cpp:141:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
string ideskrcFile = getenv("HOME");
data/idesk-0.7.5/src/XImlib2Background.cpp:53:6: [3] (random) srand:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
srand( (unsigned)time(0) );
data/idesk-0.7.5/src/Database.cpp:37:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
DbFile.open(F.c_str(),ios::in);
data/idesk-0.7.5/src/Database.cpp:44:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
DbFile.open(F.c_str(),ios::in);
data/idesk-0.7.5/src/Database.cpp:78:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
int index = atoi(temp.c_str());
data/idesk-0.7.5/src/DesktopConfig.cpp:110:17: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
snapWidth = atoi(table.Query("SnapWidth").c_str());
data/idesk-0.7.5/src/DesktopConfig.cpp:111:18: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
snapHeight = atoi(table.Query("SnapHeight").c_str());
data/idesk-0.7.5/src/DesktopConfig.cpp:166:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
delayBackground = atoi(table.Query("Background.Delay").c_str());
data/idesk-0.7.5/src/DesktopConfig.cpp:188:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
transparency = atoi(table.Query("Transparency").c_str());
data/idesk-0.7.5/src/DesktopConfig.cpp:195:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
fontSizeTip = atoi(table.Query("ToolTip.FontSize").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:57:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
x = atoi(table.Query("X").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:58:9: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
y = atoi(table.Query("Y").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:59:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
width = atoi(table.Query("Width").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:60:14: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
height = atoi(table.Query("Height").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:185:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
fontSize = atoi(table.Query("FontSize").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:193:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
clickDelay = atoi(table.Query("ClickDelay").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:204:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
shadowX = atoi(table.Query("ShadowX").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:206:19: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
shadowY = atoi(table.Query("ShadowY").c_str());
data/idesk-0.7.5/src/DesktopIconConfig.cpp:221:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
snapShadowTrans = atoi(table.Query("SnapShadowTrans").c_str());
data/idesk-0.7.5/src/Util.h:52:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ifs.open(source.c_str(),ios::in);
data/idesk-0.7.5/src/XImlib2Image.h:67:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char mapZeroAlpha[256];
data/idesk-0.7.5/src/XImlib2Image.h:68:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char mapNone[256];
data/idesk-0.7.5/src/XImlib2Image.h:70:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char defaultTransTable[256];
data/idesk-0.7.5/src/Timer.cpp:61:3: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep( 100 );
data/idesk-0.7.5/src/XDesktopContainer.cpp:104:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop.nitems = strlen(name);
data/idesk-0.7.5/src/XDesktopContainer.cpp:370:20: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
prop.nitems = strlen(current_display_name.c_str());
ANALYSIS SUMMARY:
Hits = 32
Lines analyzed = 6327 in approximately 0.16 seconds (39997 lines/second)
Physical Source Lines of Code (SLOC) = 4211
Hits@level = [0] 3 [1] 3 [2] 21 [3] 6 [4] 2 [5] 0
Hits@level+ = [0+] 35 [1+] 32 [2+] 29 [3+] 8 [4+] 2 [5+] 0
Hits/KSLOC@level+ = [0+] 8.31156 [1+] 7.59915 [2+] 6.88673 [3+] 1.89979 [4+] 0.474947 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.