Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/innoextract-1.8/cmake/check/cxx11-alignof.cpp
Examining data/innoextract-1.8/cmake/check/cxx11-std-codecvt_utf8_utf16.cpp
Examining data/innoextract-1.8/cmake/check/cxx11-std-unique_ptr.cpp
Examining data/innoextract-1.8/src/cli/debug.cpp
Examining data/innoextract-1.8/src/cli/debug.hpp
Examining data/innoextract-1.8/src/cli/extract.cpp
Examining data/innoextract-1.8/src/cli/extract.hpp
Examining data/innoextract-1.8/src/cli/gog.cpp
Examining data/innoextract-1.8/src/cli/gog.hpp
Examining data/innoextract-1.8/src/cli/goggalaxy.cpp
Examining data/innoextract-1.8/src/cli/goggalaxy.hpp
Examining data/innoextract-1.8/src/cli/main.cpp
Examining data/innoextract-1.8/src/crypto/adler32.cpp
Examining data/innoextract-1.8/src/crypto/adler32.hpp
Examining data/innoextract-1.8/src/crypto/arc4.cpp
Examining data/innoextract-1.8/src/crypto/arc4.hpp
Examining data/innoextract-1.8/src/crypto/checksum.cpp
Examining data/innoextract-1.8/src/crypto/checksum.hpp
Examining data/innoextract-1.8/src/crypto/crc32.cpp
Examining data/innoextract-1.8/src/crypto/crc32.hpp
Examining data/innoextract-1.8/src/crypto/hasher.cpp
Examining data/innoextract-1.8/src/crypto/hasher.hpp
Examining data/innoextract-1.8/src/crypto/iteratedhash.hpp
Examining data/innoextract-1.8/src/crypto/md5.cpp
Examining data/innoextract-1.8/src/crypto/md5.hpp
Examining data/innoextract-1.8/src/crypto/sha1.cpp
Examining data/innoextract-1.8/src/crypto/sha1.hpp
Examining data/innoextract-1.8/src/index.hpp
Examining data/innoextract-1.8/src/loader/exereader.cpp
Examining data/innoextract-1.8/src/loader/exereader.hpp
Examining data/innoextract-1.8/src/loader/offsets.cpp
Examining data/innoextract-1.8/src/loader/offsets.hpp
Examining data/innoextract-1.8/src/release.hpp
Examining data/innoextract-1.8/src/setup/component.cpp
Examining data/innoextract-1.8/src/setup/component.hpp
Examining data/innoextract-1.8/src/setup/data.cpp
Examining data/innoextract-1.8/src/setup/data.hpp
Examining data/innoextract-1.8/src/setup/delete.cpp
Examining data/innoextract-1.8/src/setup/delete.hpp
Examining data/innoextract-1.8/src/setup/directory.cpp
Examining data/innoextract-1.8/src/setup/directory.hpp
Examining data/innoextract-1.8/src/setup/expression.cpp
Examining data/innoextract-1.8/src/setup/expression.hpp
Examining data/innoextract-1.8/src/setup/file.cpp
Examining data/innoextract-1.8/src/setup/file.hpp
Examining data/innoextract-1.8/src/setup/filename.cpp
Examining data/innoextract-1.8/src/setup/filename.hpp
Examining data/innoextract-1.8/src/setup/header.cpp
Examining data/innoextract-1.8/src/setup/header.hpp
Examining data/innoextract-1.8/src/setup/icon.cpp
Examining data/innoextract-1.8/src/setup/icon.hpp
Examining data/innoextract-1.8/src/setup/info.cpp
Examining data/innoextract-1.8/src/setup/info.hpp
Examining data/innoextract-1.8/src/setup/ini.cpp
Examining data/innoextract-1.8/src/setup/ini.hpp
Examining data/innoextract-1.8/src/setup/item.cpp
Examining data/innoextract-1.8/src/setup/item.hpp
Examining data/innoextract-1.8/src/setup/language.cpp
Examining data/innoextract-1.8/src/setup/language.hpp
Examining data/innoextract-1.8/src/setup/message.cpp
Examining data/innoextract-1.8/src/setup/message.hpp
Examining data/innoextract-1.8/src/setup/permission.cpp
Examining data/innoextract-1.8/src/setup/permission.hpp
Examining data/innoextract-1.8/src/setup/registry.cpp
Examining data/innoextract-1.8/src/setup/registry.hpp
Examining data/innoextract-1.8/src/setup/run.cpp
Examining data/innoextract-1.8/src/setup/run.hpp
Examining data/innoextract-1.8/src/setup/task.cpp
Examining data/innoextract-1.8/src/setup/task.hpp
Examining data/innoextract-1.8/src/setup/type.cpp
Examining data/innoextract-1.8/src/setup/type.hpp
Examining data/innoextract-1.8/src/setup/version.cpp
Examining data/innoextract-1.8/src/setup/version.hpp
Examining data/innoextract-1.8/src/setup/windows.cpp
Examining data/innoextract-1.8/src/setup/windows.hpp
Examining data/innoextract-1.8/src/stream/block.cpp
Examining data/innoextract-1.8/src/stream/block.hpp
Examining data/innoextract-1.8/src/stream/checksum.hpp
Examining data/innoextract-1.8/src/stream/chunk.cpp
Examining data/innoextract-1.8/src/stream/chunk.hpp
Examining data/innoextract-1.8/src/stream/exefilter.hpp
Examining data/innoextract-1.8/src/stream/file.cpp
Examining data/innoextract-1.8/src/stream/file.hpp
Examining data/innoextract-1.8/src/stream/lzma.cpp
Examining data/innoextract-1.8/src/stream/lzma.hpp
Examining data/innoextract-1.8/src/stream/restrict.hpp
Examining data/innoextract-1.8/src/stream/slice.cpp
Examining data/innoextract-1.8/src/stream/slice.hpp
Examining data/innoextract-1.8/src/util/align.hpp
Examining data/innoextract-1.8/src/util/ansi.hpp
Examining data/innoextract-1.8/src/util/boostfs_compat.hpp
Examining data/innoextract-1.8/src/util/console.cpp
Examining data/innoextract-1.8/src/util/console.hpp
Examining data/innoextract-1.8/src/util/encoding.cpp
Examining data/innoextract-1.8/src/util/encoding.hpp
Examining data/innoextract-1.8/src/util/endian.hpp
Examining data/innoextract-1.8/src/util/enum.hpp
Examining data/innoextract-1.8/src/util/flags.hpp
Examining data/innoextract-1.8/src/util/fstream.hpp
Examining data/innoextract-1.8/src/util/load.cpp
Examining data/innoextract-1.8/src/util/load.hpp
Examining data/innoextract-1.8/src/util/log.cpp
Examining data/innoextract-1.8/src/util/log.hpp
Examining data/innoextract-1.8/src/util/math.hpp
Examining data/innoextract-1.8/src/util/output.hpp
Examining data/innoextract-1.8/src/util/process.cpp
Examining data/innoextract-1.8/src/util/process.hpp
Examining data/innoextract-1.8/src/util/storedenum.hpp
Examining data/innoextract-1.8/src/util/time.cpp
Examining data/innoextract-1.8/src/util/time.hpp
Examining data/innoextract-1.8/src/util/types.hpp
Examining data/innoextract-1.8/src/util/unique_ptr.hpp
Examining data/innoextract-1.8/src/util/windows.cpp
Examining data/innoextract-1.8/src/util/windows.hpp
FINAL RESULTS:
data/innoextract-1.8/src/crypto/arc4.cpp:62:12: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
void arc4::crypt(const char * in, char * out, size_t length) {
data/innoextract-1.8/src/crypto/arc4.hpp:46:7: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
void crypt(const char * in, char * out, size_t length);
data/innoextract-1.8/src/stream/chunk.cpp:79:9: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
arc4.crypt(dest, dest, size_t(n));
data/innoextract-1.8/src/util/process.cpp:156:9: [4] (shell) execvp:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
(void)execvp(argv[0], argv);
data/innoextract-1.8/src/util/process.cpp:184:14: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
return std::system(format_command_line(args).c_str());
data/innoextract-1.8/src/cli/main.cpp:73:26: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
const char * env = std::getenv(var.c_str());
data/innoextract-1.8/src/util/console.cpp:103:22: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char * term = std::getenv("TERM");
data/innoextract-1.8/src/util/console.cpp:126:65: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if(color == disable || (color == automatic && (!is_tty || std::getenv("NO_COLOR") != NULL))) {
data/innoextract-1.8/src/util/console.cpp:183:25: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char * columns = std::getenv("COLUMNS");
data/innoextract-1.8/src/util/time.cpp:136:14: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
char * tz = getenv("TZ");
data/innoextract-1.8/src/cli/extract.cpp:157:13: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
stream_.open(path_, flags);
data/innoextract-1.8/src/cli/extract.cpp:256:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[8192];
data/innoextract-1.8/src/cli/extract.cpp:896:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ifs.open(installer, std::ios_base::in | std::ios_base::binary);
data/innoextract-1.8/src/cli/extract.cpp:1283:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[8192 * 10];
data/innoextract-1.8/src/cli/gog.cpp:303:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hash[16];
data/innoextract-1.8/src/cli/gog.cpp:415:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char magic[4];
data/innoextract-1.8/src/cli/main.cpp:403:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ifs.open(file);
data/innoextract-1.8/src/crypto/checksum.hpp:54:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char md5[16];
data/innoextract-1.8/src/crypto/checksum.hpp:55:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sha1[20];
data/innoextract-1.8/src/crypto/checksum.hpp:76:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[sizeof(T)];
data/innoextract-1.8/src/crypto/iteratedhash.hpp:71:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[block_size];
data/innoextract-1.8/src/crypto/iteratedhash.hpp:93:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer + num, data, block_size - num);
data/innoextract-1.8/src/crypto/iteratedhash.hpp:99:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer + num, data, length);
data/innoextract-1.8/src/crypto/iteratedhash.hpp:112:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, data, length);
data/innoextract-1.8/src/loader/offsets.cpp:45:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char magic[12];
data/innoextract-1.8/src/loader/offsets.cpp:107:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char magic[12];
data/innoextract-1.8/src/setup/header.hpp:47:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char salt[8];
data/innoextract-1.8/src/setup/version.cpp:43:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char stored_legacy_version[12];
data/innoextract-1.8/src/setup/version.cpp:47:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char name[13]; // terminating 0 byte is ignored
data/innoextract-1.8/src/setup/version.cpp:61:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char stored_version[64];
data/innoextract-1.8/src/setup/version.cpp:262:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(version_string, legacy_version, sizeof(legacy_version));
data/innoextract-1.8/src/stream/block.cpp:84:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char temp[sizeof(boost::uint32_t)];
data/innoextract-1.8/src/stream/block.cpp:135:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[4096];
data/innoextract-1.8/src/stream/chunk.cpp:49:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char chunk_id[4] = { 'z', 'l', 'b', 0x1a };
data/innoextract-1.8/src/stream/chunk.cpp:126:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char magic[sizeof(chunk_id)];
data/innoextract-1.8/src/stream/chunk.cpp:150:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char salt[8];
data/innoextract-1.8/src/stream/lzma.hpp:91:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[5];
data/innoextract-1.8/src/stream/slice.cpp:79:2: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
open(slice);
data/innoextract-1.8/src/stream/slice.cpp:93:6: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
ifs.open(file, std::ios_base::in | std::ios_base::binary | std::ios_base::ate);
data/innoextract-1.8/src/stream/slice.cpp:101:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char magic[8];
data/innoextract-1.8/src/stream/slice.cpp:173:20: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void slice_reader::open(size_t slice) {
data/innoextract-1.8/src/stream/slice.hpp:81:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(size_t slice);
data/innoextract-1.8/src/util/encoding.cpp:714:12: [2] (buffer) MultiByteToWideChar:
Requires maximum length in CHARACTERS, not bytes (CWE-120).
int ret = MultiByteToWideChar(codepage, 0, from.data(), int(from.length()), NULL, 0);
data/innoextract-1.8/src/util/encoding.cpp:717:9: [2] (buffer) MultiByteToWideChar:
Requires maximum length in CHARACTERS, not bytes (CWE-120).
ret = MultiByteToWideChar(codepage, 0, from.data(), int(from.length()),
data/innoextract-1.8/src/util/endian.hpp:140:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(values, buffer, sizeof(*values) * count);
data/innoextract-1.8/src/util/endian.hpp:157:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer, &value, sizeof(value));
data/innoextract-1.8/src/util/endian.hpp:174:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer, values, sizeof(*values) * count);
data/innoextract-1.8/src/util/endian.hpp:201:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
std::memcpy(buffer, &value, sizeof(value));
data/innoextract-1.8/src/util/enum.hpp:54:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char * names[1];
data/innoextract-1.8/src/util/fstream.hpp:79:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const path & p) {
data/innoextract-1.8/src/util/fstream.hpp:81:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
base::open(p);
data/innoextract-1.8/src/util/fstream.hpp:84:7: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
void open(const path & p, std::ios_base::openmode mode) {
data/innoextract-1.8/src/util/fstream.hpp:86:9: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
base::open(p, mode);
data/innoextract-1.8/src/util/load.cpp:39:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[10 * 1024];
data/innoextract-1.8/src/util/load.hpp:137:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[sizeof(T)];
data/innoextract-1.8/src/util/load.hpp:182:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/innoextract-1.8/src/util/time.cpp:259:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(int fd, const char *path, const struct timespec times[2], int flag);
data/innoextract-1.8/src/util/windows.cpp:514:14: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
argv = new char *[argc + 1];
data/innoextract-1.8/src/cli/debug.cpp:537:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t n = strlen(magic_numbers[i][0]);
data/innoextract-1.8/src/cli/extract.cpp:257:32: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize n = stream_.read(buffer, sizeof(buffer)).gcount();
data/innoextract-1.8/src/cli/extract.cpp:1285:38: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize n = file_source->read(buffer, buffer_size).gcount();
data/innoextract-1.8/src/cli/gog.cpp:64:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t prefix_length = std::strlen(prefix);
data/innoextract-1.8/src/cli/gog.cpp:416:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(!ifs.read(magic, std::streamsize(boost::size(magic))).fail()) {
data/innoextract-1.8/src/crypto/checksum.hpp:77:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(buffer, std::streamsize(sizeof(buffer)));
data/innoextract-1.8/src/loader/offsets.cpp:108:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(is.read(magic, std::streamsize(sizeof(magic))).fail()) {
data/innoextract-1.8/src/setup/data.cpp:66:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(file.checksum.sha1, std::streamsize(sizeof(file.checksum.sha1)));
data/innoextract-1.8/src/setup/data.cpp:69:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(file.checksum.md5, std::streamsize(sizeof(file.checksum.md5)));
data/innoextract-1.8/src/setup/header.cpp:375:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(password.md5, std::streamsize(sizeof(password.md5)));
data/innoextract-1.8/src/setup/header.cpp:378:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(password.sha1, std::streamsize(sizeof(password.sha1)));
data/innoextract-1.8/src/setup/header.cpp:383:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(&password_salt[0], std::streamsize(password_salt.length()));
data/innoextract-1.8/src/setup/header.cpp:689:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(&license_text[0], license_size);
data/innoextract-1.8/src/setup/header.cpp:694:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(&info_before[0], info_before_size);
data/innoextract-1.8/src/setup/header.cpp:699:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(&info_after[0], info_after_size);
data/innoextract-1.8/src/setup/version.cpp:214:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(legacy_version, std::streamsize(sizeof(legacy_version)));
data/innoextract-1.8/src/setup/version.cpp:263:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(version_string + sizeof(legacy_version),
data/innoextract-1.8/src/stream/block.cpp:86:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize nread = boost::iostreams::read(src, temp, temp_size);
data/innoextract-1.8/src/stream/block.cpp:94:37: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
length = size_t(boost::iostreams::read(src, buffer, std::streamsize(sizeof(buffer))));
data/innoextract-1.8/src/stream/block.cpp:112:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(Source & src, char * dest, std::streamsize n) {
data/innoextract-1.8/src/stream/checksum.hpp:64:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(Source & src, char * dest, std::streamsize n) {
data/innoextract-1.8/src/stream/checksum.hpp:66:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize nread = boost::iostreams::read(src, dest, n);
data/innoextract-1.8/src/stream/chunk.cpp:75:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(Source & src, char * dest, std::streamsize n) {
data/innoextract-1.8/src/stream/chunk.cpp:77:46: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize length = boost::iostreams::read(src, dest, n);
data/innoextract-1.8/src/stream/chunk.cpp:127:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(base.read(magic, 4) != 4 || std::memcmp(magic, chunk_id, sizeof(chunk_id)) != 0) {
data/innoextract-1.8/src/stream/chunk.cpp:151:11: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(base.read(salt, 8) != 8) {
data/innoextract-1.8/src/stream/exefilter.hpp:62:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(Source & src, char * dest, std::streamsize n);
data/innoextract-1.8/src/stream/exefilter.hpp:103:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(Source & src, char * dest, std::streamsize n);
data/innoextract-1.8/src/stream/exefilter.hpp:145:40: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize inno_exe_decoder_4108::read(Source & src, char * dest, std::streamsize n) {
data/innoextract-1.8/src/stream/exefilter.hpp:175:40: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize inno_exe_decoder_5200::read(Source & src, char * dest, std::streamsize n) {
data/innoextract-1.8/src/stream/exefilter.hpp:229:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize nread = boost::iostreams::read(src, dst, -flush_bytes);
data/innoextract-1.8/src/stream/restrict.hpp:51:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(char * buffer, std::streamsize bytes) {
data/innoextract-1.8/src/stream/restrict.hpp:63:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize nread = boost::iostreams::read(base, buffer, bytes);
data/innoextract-1.8/src/stream/slice.cpp:102:9: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(ifs.read(magic, 8).fail()) {
data/innoextract-1.8/src/stream/slice.cpp:222:31: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize slice_reader::read(char * buffer, std::streamsize bytes) {
data/innoextract-1.8/src/stream/slice.cpp:246:10: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if(is->read(buffer, std::streamsize(toread)).fail()) {
data/innoextract-1.8/src/stream/slice.cpp:251:12: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nread += read, buffer += read, bytes -= read;
data/innoextract-1.8/src/stream/slice.cpp:251:28: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nread += read, buffer += read, bytes -= read;
data/innoextract-1.8/src/stream/slice.cpp:251:43: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
nread += read, buffer += read, bytes -= read;
data/innoextract-1.8/src/stream/slice.hpp:146:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
std::streamsize read(char * buffer, std::streamsize bytes);
data/innoextract-1.8/src/util/load.cpp:41:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(buffer, std::streamsize(buf_size));
data/innoextract-1.8/src/util/load.hpp:138:5: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(buffer, std::streamsize(sizeof(buffer)));
data/innoextract-1.8/src/util/load.hpp:185:6: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
is.read(buf, n);
data/innoextract-1.8/src/util/windows.cpp:517:74: [1] (buffer) wcslen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
util::utf16le_to_wtf8(std::string(reinterpret_cast<char *>(wargv[i]), wcslen(wargv[i]) * 2), args[i]);
ANALYSIS SUMMARY:
Hits = 102
Lines analyzed = 19352 in approximately 0.59 seconds (32900 lines/second)
Physical Source Lines of Code (SLOC) = 12038
Hits@level = [0] 0 [1] 44 [2] 48 [3] 5 [4] 5 [5] 0
Hits@level+ = [0+] 102 [1+] 102 [2+] 58 [3+] 10 [4+] 5 [5+] 0
Hits/KSLOC@level+ = [0+] 8.47317 [1+] 8.47317 [2+] 4.81808 [3+] 0.830703 [4+] 0.415351 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.