Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/jalv-1.6.4/src/control.c
Examining data/jalv-1.6.4/src/jack.c
Examining data/jalv-1.6.4/src/jalv.c
Examining data/jalv-1.6.4/src/jalv_console.c
Examining data/jalv-1.6.4/src/jalv_gtk.c
Examining data/jalv-1.6.4/src/jalv_gtkmm2.cpp
Examining data/jalv-1.6.4/src/jalv_internal.h
Examining data/jalv-1.6.4/src/jalv_qt.cpp
Examining data/jalv-1.6.4/src/log.c
Examining data/jalv-1.6.4/src/lv2_evbuf.c
Examining data/jalv-1.6.4/src/lv2_evbuf.h
Examining data/jalv-1.6.4/src/portaudio.c
Examining data/jalv-1.6.4/src/state.c
Examining data/jalv-1.6.4/src/symap.c
Examining data/jalv-1.6.4/src/symap.h
Examining data/jalv-1.6.4/src/worker.c
Examining data/jalv-1.6.4/src/worker.h
Examining data/jalv-1.6.4/src/zix/common.h
Examining data/jalv-1.6.4/src/zix/ring.c
Examining data/jalv-1.6.4/src/zix/ring.h
Examining data/jalv-1.6.4/src/zix/sem.h
Examining data/jalv-1.6.4/src/zix/thread.h
FINAL RESULTS:
data/jalv-1.6.4/src/jack.c:540:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(cmd, load_init);
data/jalv-1.6.4/src/jalv.c:48:13: [4] (format) snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
# define snprintf _snprintf
data/jalv-1.6.4/src/jalv.c:48:22: [4] (format) _snprintf:
If format strings can be influenced by an attacker, they can be exploited,
and note that sprintf variations do not always \0-terminate (CWE-134). Use
a constant for the format specification.
# define snprintf _snprintf
data/jalv-1.6.4/src/log.c:53:17: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
const int st = vfprintf(stderr, fmt, ap);
data/jalv-1.6.4/src/jalv_gtk.c:381:35: [3] (buffer) g_get_home_dir:
This function is synonymous with 'getenv("HOME")';it returns untrustable
input if the environment can beset by an attacker. It can have any content
and length, and the same variable can be set more than once (CWE-807,
CWE-20). Check environment variables carefully before using them.
char* dot_lv2 = g_build_filename(g_get_home_dir(), ".lv2", NULL);
data/jalv-1.6.4/src/jack.c:242:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[sizeof(ControlChange) + sizeof(float)];
data/jalv-1.6.4/src/jack.c:498:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char index_str[16];
data/jalv-1.6.4/src/jack.c:539:2: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(cmd, "jalv ");
data/jalv-1.6.4/src/jalv.c:494:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[sizeof(ControlChange) + buffer_size];
data/jalv-1.6.4/src/jalv.c:499:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ev->body, buffer, buffer_size);
data/jalv-1.6.4/src/jalv.c:514:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char body[ev.size];
data/jalv-1.6.4/src/jalv.c:583:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char evbuf[sizeof(ControlChange) + sizeof(LV2_Atom)];
data/jalv-1.6.4/src/jalv.c:683:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sym[256];
data/jalv-1.6.4/src/jalv.c:1084:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(jalv->feature_list, features, sizeof(features));
data/jalv-1.6.4/src/jalv_console.c:90:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
opts->buffer_size = atoi((*argv)[a]);
data/jalv-1.6.4/src/jalv_console.c:158:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char sym[64];
data/jalv-1.6.4/src/jalv_console.c:265:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[128];
data/jalv-1.6.4/src/jalv_internal.h:503:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(copy, str, len + 1);
data/jalv-1.6.4/src/jalv_internal.h:514:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, a, a_len);
data/jalv-1.6.4/src/jalv_internal.h:515:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out + a_len, b, b_len);
data/jalv-1.6.4/src/lv2_evbuf.c:173:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(LV2_ATOM_BODY(&aev->body), data, size);
data/jalv-1.6.4/src/portaudio.c:91:4: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[sizeof(ControlChange) + sizeof(float)];
data/jalv-1.6.4/src/state.c:167:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[sizeof(ControlChange) + sizeof(fvalue)];
data/jalv-1.6.4/src/symap.c:89:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(copy, str, len + 1);
data/jalv-1.6.4/src/zix/ring.c:161:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, &ring->buf[r], size);
data/jalv-1.6.4/src/zix/ring.c:164:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, &ring->buf[r], first_size);
data/jalv-1.6.4/src/zix/ring.c:165:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char*)dst + first_size, &ring->buf[0], size - first_size);
data/jalv-1.6.4/src/zix/ring.c:216:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&ring->buf[w], src, size);
data/jalv-1.6.4/src/zix/ring.c:221:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&ring->buf[w], src, this_size);
data/jalv-1.6.4/src/zix/ring.c:222:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&ring->buf[0], (const char*)src + this_size, size - this_size);
data/jalv-1.6.4/src/jack.c:343:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(jack_name) >= (unsigned)jack_client_name_size() - 1) {
data/jalv-1.6.4/src/jack.c:517:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t args_len = strlen(load_init);
data/jalv-1.6.4/src/jack.c:537:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t cmd_len = strlen("jalv ") + args_len;
data/jalv-1.6.4/src/jalv_console.c:242:4: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(33333);
data/jalv-1.6.4/src/jalv_gtk.c:184:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t len = strlen(in);
data/jalv-1.6.4/src/jalv_gtk.c:420:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
jalv_save_preset(jalv, dir, (strlen(uri) ? uri : NULL), basename, file);
data/jalv-1.6.4/src/jalv_gtk.c:767:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
set_control(control, strlen(string) + 1, control->jalv->forge.String, string);
data/jalv-1.6.4/src/jalv_gtk.c:779:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
set_control(control, strlen(filename), jalv->forge.Path, filename);
data/jalv-1.6.4/src/jalv_internal.h:501:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t len = strlen(str);
data/jalv-1.6.4/src/jalv_internal.h:510:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t a_len = strlen(a);
data/jalv-1.6.4/src/jalv_internal.h:511:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t b_len = strlen(b);
data/jalv-1.6.4/src/symap.c:87:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
const size_t len = strlen(str);
ANALYSIS SUMMARY:
Hits = 42
Lines analyzed = 7150 in approximately 0.24 seconds (30240 lines/second)
Physical Source Lines of Code (SLOC) = 5407
Hits@level = [0] 99 [1] 12 [2] 25 [3] 1 [4] 4 [5] 0
Hits@level+ = [0+] 141 [1+] 42 [2+] 30 [3+] 5 [4+] 4 [5+] 0
Hits/KSLOC@level+ = [0+] 26.0773 [1+] 7.76771 [2+] 5.54836 [3+] 0.924727 [4+] 0.739782 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.