Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/john-1.8.0/src/AFS_fmt.c
Examining data/john-1.8.0/src/BF_fmt.c
Examining data/john-1.8.0/src/BF_std.c
Examining data/john-1.8.0/src/BF_std.h
Examining data/john-1.8.0/src/BSDI_fmt.c
Examining data/john-1.8.0/src/DES_bs.c
Examining data/john-1.8.0/src/DES_bs.h
Examining data/john-1.8.0/src/DES_bs_b.c
Examining data/john-1.8.0/src/DES_fmt.c
Examining data/john-1.8.0/src/DES_std.c
Examining data/john-1.8.0/src/DES_std.h
Examining data/john-1.8.0/src/LM_fmt.c
Examining data/john-1.8.0/src/MD5_fmt.c
Examining data/john-1.8.0/src/MD5_std.c
Examining data/john-1.8.0/src/MD5_std.h
Examining data/john-1.8.0/src/alpha.h
Examining data/john-1.8.0/src/batch.c
Examining data/john-1.8.0/src/batch.h
Examining data/john-1.8.0/src/bench.c
Examining data/john-1.8.0/src/bench.h
Examining data/john-1.8.0/src/best.c
Examining data/john-1.8.0/src/c3_fmt.c
Examining data/john-1.8.0/src/charset.c
Examining data/john-1.8.0/src/charset.h
Examining data/john-1.8.0/src/common.c
Examining data/john-1.8.0/src/common.h
Examining data/john-1.8.0/src/compiler.c
Examining data/john-1.8.0/src/compiler.h
Examining data/john-1.8.0/src/config.c
Examining data/john-1.8.0/src/config.h
Examining data/john-1.8.0/src/cracker.c
Examining data/john-1.8.0/src/cracker.h
Examining data/john-1.8.0/src/crc32.c
Examining data/john-1.8.0/src/crc32.h
Examining data/john-1.8.0/src/detect.c
Examining data/john-1.8.0/src/dummy.c
Examining data/john-1.8.0/src/external.c
Examining data/john-1.8.0/src/external.h
Examining data/john-1.8.0/src/formats.c
Examining data/john-1.8.0/src/formats.h
Examining data/john-1.8.0/src/getopt.c
Examining data/john-1.8.0/src/getopt.h
Examining data/john-1.8.0/src/ia64.h
Examining data/john-1.8.0/src/idle.c
Examining data/john-1.8.0/src/idle.h
Examining data/john-1.8.0/src/inc.c
Examining data/john-1.8.0/src/inc.h
Examining data/john-1.8.0/src/john.c
Examining data/john-1.8.0/src/john.h
Examining data/john-1.8.0/src/list.c
Examining data/john-1.8.0/src/list.h
Examining data/john-1.8.0/src/loader.c
Examining data/john-1.8.0/src/loader.h
Examining data/john-1.8.0/src/logger.c
Examining data/john-1.8.0/src/logger.h
Examining data/john-1.8.0/src/math.c
Examining data/john-1.8.0/src/math.h
Examining data/john-1.8.0/src/memory.c
Examining data/john-1.8.0/src/memory.h
Examining data/john-1.8.0/src/mips32.h
Examining data/john-1.8.0/src/mips64.h
Examining data/john-1.8.0/src/misc.c
Examining data/john-1.8.0/src/misc.h
Examining data/john-1.8.0/src/nonstd.c
Examining data/john-1.8.0/src/options.c
Examining data/john-1.8.0/src/options.h
Examining data/john-1.8.0/src/os.h
Examining data/john-1.8.0/src/pa-risc.h
Examining data/john-1.8.0/src/params.c
Examining data/john-1.8.0/src/path.c
Examining data/john-1.8.0/src/path.h
Examining data/john-1.8.0/src/ppc32.h
Examining data/john-1.8.0/src/ppc32alt.h
Examining data/john-1.8.0/src/ppc64.h
Examining data/john-1.8.0/src/ppc64alt.h
Examining data/john-1.8.0/src/recovery.c
Examining data/john-1.8.0/src/recovery.h
Examining data/john-1.8.0/src/rpp.c
Examining data/john-1.8.0/src/rpp.h
Examining data/john-1.8.0/src/rules.c
Examining data/john-1.8.0/src/rules.h
Examining data/john-1.8.0/src/sboxes-s.c
Examining data/john-1.8.0/src/sboxes.c
Examining data/john-1.8.0/src/signals.c
Examining data/john-1.8.0/src/signals.h
Examining data/john-1.8.0/src/single.c
Examining data/john-1.8.0/src/single.h
Examining data/john-1.8.0/src/sparc32.h
Examining data/john-1.8.0/src/sparc64.h
Examining data/john-1.8.0/src/status.c
Examining data/john-1.8.0/src/status.h
Examining data/john-1.8.0/src/symlink.c
Examining data/john-1.8.0/src/times.h
Examining data/john-1.8.0/src/trip_fmt.c
Examining data/john-1.8.0/src/tty.c
Examining data/john-1.8.0/src/tty.h
Examining data/john-1.8.0/src/unafs.c
Examining data/john-1.8.0/src/unique.c
Examining data/john-1.8.0/src/unshadow.c
Examining data/john-1.8.0/src/vax.h
Examining data/john-1.8.0/src/wordlist.c
Examining data/john-1.8.0/src/wordlist.h
Examining data/john-1.8.0/src/x86-64.h
Examining data/john-1.8.0/src/x86-any.h
Examining data/john-1.8.0/src/x86-mmx.h
Examining data/john-1.8.0/src/x86-sse.h
Examining data/john-1.8.0/src/params.h
FINAL RESULTS:
data/john-1.8.0/src/dummy.c:228:2: [5] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings. Risk is high; the length parameter
appears to be a constant, instead of computing the number of characters
left.
strncat(p, key, PLAINTEXT_LENGTH);
data/john-1.8.0/src/logger.c:59:6: [5] (race) chmod:
This accepts filename arguments; if an attacker can move those files, a
race condition results. (CWE-362). Use fchmod( ) instead.
if (chmod(path_expand(name), S_IRUSR | S_IWUSR))
data/john-1.8.0/src/AFS_fmt.c:159:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base64, AFS_SALT);
data/john-1.8.0/src/AFS_fmt.c:222:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(base64, AFS_SALT);
data/john-1.8.0/src/LM_fmt.c:81:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(lower, &ciphertext[16]);
data/john-1.8.0/src/bench.c:115:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(s_error, "FAILED (%s)", where);
data/john-1.8.0/src/c3_fmt.c:143:20: [4] (crypto) crypt_r:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
new_ciphertext = crypt_r(pw, ciphertext, *data);
data/john-1.8.0/src/c3_fmt.c:146:19: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
new_ciphertext = crypt(pw, ciphertext);
data/john-1.8.0/src/c3_fmt.c:337:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(saved_salt, salt);
data/john-1.8.0/src/c3_fmt.c:379:11: [4] (crypto) crypt_r:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
hash = crypt_r(saved_key[index], saved_salt, *data);
data/john-1.8.0/src/c3_fmt.c:383:11: [4] (crypto) crypt_r:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
hash = crypt_r(saved_key[index], saved_salt, &data);
data/john-1.8.0/src/c3_fmt.c:410:16: [4] (crypto) crypt:
The crypt functions use a poor one-way hashing algorithm; since they only
accept passwords of 8 characters or fewer and only a two-byte salt, they
are excessively vulnerable to dictionary attacks given today's faster
computing equipment (CWE-327). Use a different algorithm, such as SHA-256,
with a larger, non-repeating salt.
char *hash = crypt(saved_key[index], saved_salt);
data/john-1.8.0/src/compiler.c:311:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((*list)->name = (char *)mem_alloc(strlen(name) + 1), name);
data/john-1.8.0/src/external.c:222:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(rec_word, int_word);
data/john-1.8.0/src/getopt.c:82:10: [4] (buffer) sscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function. If the scanf format is influenceable by an
attacker, it's exploitable.
return sscanf(param, format, buffer) != 1;
data/john-1.8.0/src/john.c:162:3: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(OMP_FALLBACK_PATHNAME, argv);
data/john-1.8.0/src/john.c:346:2: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(s_loaded_counts,
data/john-1.8.0/src/john.c:500:4: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(CPU_FALLBACK_PATHNAME, argv);
data/john-1.8.0/src/john.c:667:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name + 1, argv[1]);
data/john-1.8.0/src/list.c:30:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(entry->data, data);
data/john-1.8.0/src/loader.c:260:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(source, line ? line : "");
data/john-1.8.0/src/loader.c:610:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(current_pw->login, "%s:%d",
data/john-1.8.0/src/loader.c:984:12: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
piece = strcpy(mem_alloc(strlen(piece) + 1), piece);
data/john-1.8.0/src/logger.c:181:17: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
count1 = (int)sprintf(pot.ptr,
data/john-1.8.0/src/logger.c:191:18: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
count2 = (int)sprintf(log.ptr,
data/john-1.8.0/src/logger.c:233:17: [4] (format) vsprintf:
Potential format string problem (CWE-134). Make format string constant.
count2 = (int)vsprintf(log.ptr, format, args);
data/john-1.8.0/src/logger.h:37:26: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format (printf, 1, 2)));
data/john-1.8.0/src/misc.c:35:2: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
vfprintf(stderr, format, args);
data/john-1.8.0/src/misc.h:31:26: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
__attribute__ ((format (printf, 1, 2)));
data/john-1.8.0/src/options.c:132:2: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(JOHN_USAGE, name);
data/john-1.8.0/src/options.c:141:4: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf("\n" JOHN_USAGE_INDENT);
data/john-1.8.0/src/recovery.c:64:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(suffix, ".%u%s", options.node_min, RECOVERY_SUFFIX);
data/john-1.8.0/src/recovery.c:132:2: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
fprintf(rec_file, RECOVERY_V "\n%d\n",
data/john-1.8.0/src/rules.c:497:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(&out[1], in);
data/john-1.8.0/src/rules.c:594:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(out, &in[1]);
data/john-1.8.0/src/rules.c:699:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(p, &in[pos]);
data/john-1.8.0/src/rules.c:722:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(&out[pos], &in[pos + 1]);
data/john-1.8.0/src/rules.c:733:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(out, &in[1]);
data/john-1.8.0/src/rules.c:735:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(out, in);
data/john-1.8.0/src/rules.c:749:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(&out[1], in);
data/john-1.8.0/src/rules.c:898:5: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(in, buffer[2]);
data/john-1.8.0/src/rules.c:905:6: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(out, buffer[2]);
data/john-1.8.0/src/rules.c:906:6: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(out, in);
data/john-1.8.0/src/rules.c:950:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(in, buffer[2]);
data/john-1.8.0/src/rules.c:953:2: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(buffer[2], in);
data/john-1.8.0/src/status.c:197:3: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(buffer, fmt, cps.lo, frac);
data/john-1.8.0/src/status.c:248:6: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
n = sprintf(p, "%.31sC/s%s%.200s%s%.200s\n",
data/john-1.8.0/src/status.c:291:3: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(s_percent, status.pass ? " %d%% %d/3" : " %d%%",
data/john-1.8.0/src/symlink.c:28:22: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
if ((name = strrchr(strcpy(path, argv[0]), '/')))
data/john-1.8.0/src/symlink.c:32:2: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(name, MAIN_NAME);
data/john-1.8.0/src/symlink.c:34:2: [4] (shell) execv:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
execv(path, argv);
data/john-1.8.0/src/unique.c:156:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(&buffer.data[ptr], line);
data/john-1.8.0/src/wordlist.c:162:10: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
return strcpy(last, word);
data/john-1.8.0/src/john.c:159:7: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (!getenv("JOHN_NO_OMP_FALLBACK") && john_omp_threads_new <= 1) {
data/john-1.8.0/src/john.c:170:23: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (options.fork && !getenv("OMP_NUM_THREADS")) {
data/john-1.8.0/src/AFS_fmt.c:87:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/AFS_fmt.c:90:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char cell[SALT_SIZE + 8];
data/john-1.8.0/src/AFS_fmt.c:112:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(AFS_long_KS.data, DES_KS_current, sizeof(DES_KS));
data/john-1.8.0/src/AFS_fmt.c:114:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(block, AFS_long_IV, 8);
data/john-1.8.0/src/AFS_fmt.c:120:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(AFS_long_IV_binary, DES_IV, sizeof(DES_binary));
data/john-1.8.0/src/AFS_fmt.c:153:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char base64[14];
data/john-1.8.0/src/AFS_fmt.c:177:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&out[2], DES_std_get_binary(base64), 16);
data/john-1.8.0/src/AFS_fmt.c:184:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[SALT_SIZE + 1];
data/john-1.8.0/src/AFS_fmt.c:218:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char base64[14];
data/john-1.8.0/src/AFS_fmt.c:293:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char xor[8];
data/john-1.8.0/src/AFS_fmt.c:318:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(xor, cell, 8);
data/john-1.8.0/src/AFS_fmt.c:334:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(space, buffer[index].key, length);
data/john-1.8.0/src/AFS_fmt.c:335:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((char *)space + length, cell, cell_length + 8);
data/john-1.8.0/src/BF_fmt.c:85:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char saved_key[BF_N][PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/BF_fmt.c:128:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
rounds = atoi(ciphertext + 4);
data/john-1.8.0/src/BF_std.c:395:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char BF_atoi64[0x80] = {
data/john-1.8.0/src/BF_std.c:641:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(BF_current INDEX2.S,
data/john-1.8.0/src/BF_std.c:643:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(BF_current INDEX2.P,
data/john-1.8.0/src/BF_std.c:773:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&BF_out[index][2], &BF_magic_w[2], sizeof(BF_word) * 4);
data/john-1.8.0/src/BF_std.c:824:16: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
salt.rounds = atoi(&ciphertext[4]);
data/john-1.8.0/src/BF_std.h:60:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char BF_atoi64[0x80];
data/john-1.8.0/src/BSDI_fmt.c:81:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[PLAINTEXT_LENGTH];
data/john-1.8.0/src/BSDI_fmt.c:265:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chars[8];
data/john-1.8.0/src/BSDI_fmt.c:309:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[index].KS, DES_KS_current, sizeof(DES_KS));
data/john-1.8.0/src/BSDI_fmt.c:316:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/DES_bs.c:39:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_LM_KP[56] = {
data/john-1.8.0/src/DES_bs.c:50:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_LM_reverse[16] = {
data/john-1.8.0/src/DES_bs.c:307:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[17];
data/john-1.8.0/src/DES_bs.h:57:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char u[0x100]; /* Uppercase (for LM) */
data/john-1.8.0/src/DES_bs.h:69:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char c[8][8][sizeof(DES_bs_vector)];
data/john-1.8.0/src/DES_bs.h:72:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char *pxkeys[DES_BS_DEPTH]; /* Pointers into xkeys.c */
data/john-1.8.0/src/DES_fmt.c:75:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[PLAINTEXT_LENGTH];
data/john-1.8.0/src/DES_fmt.c:123:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[14];
data/john-1.8.0/src/DES_fmt.c:126:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, &ciphertext[2], 2);
data/john-1.8.0/src/DES_fmt.c:127:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&out[2], &ciphertext[13], 11);
data/john-1.8.0/src/DES_fmt.c:129:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, ciphertext, 13);
data/john-1.8.0/src/DES_fmt.c:329:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[index].aligned.data.KS, DES_KS_current, sizeof(DES_KS));
data/john-1.8.0/src/DES_fmt.c:330:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[index].key, key, PLAINTEXT_LENGTH);
data/john-1.8.0/src/DES_fmt.c:336:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/DES_fmt.c:351:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, buffer[index].key, PLAINTEXT_LENGTH);
data/john-1.8.0/src/DES_std.c:96:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char DES_key[16];
data/john-1.8.0/src/DES_std.c:125:30: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
(*((ARCH_WORD *)(((unsigned char (*)[2])SPE) + (i))))
data/john-1.8.0/src/DES_std.c:211:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_S[8][4][16] = {
data/john-1.8.0/src/DES_std.c:255:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_P[32] = {
data/john-1.8.0/src/DES_std.c:266:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char DES_E[48] = {
data/john-1.8.0/src/DES_std.c:277:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_IP[64] = {
data/john-1.8.0/src/DES_std.c:288:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_C[64] = {
data/john-1.8.0/src/DES_std.c:299:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char DES_PC1[56] = {
data/john-1.8.0/src/DES_std.c:310:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char DES_ROT[16] = {
data/john-1.8.0/src/DES_std.c:314:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char DES_PC2[48] = {
data/john-1.8.0/src/DES_std.c:423:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char block[64];
data/john-1.8.0/src/DES_std.c:465:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(DES_KS_current, DES_KS_table, sizeof(DES_KS));
data/john-1.8.0/src/DES_std.c:606:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(DES_KS_current,
data/john-1.8.0/src/DES_std.c:655:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(DES_KS_current, DES_KS_table[0][(k = key[0]) & 0x7F],
data/john-1.8.0/src/DES_std.c:962:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char b[8];
data/john-1.8.0/src/DES_std.c:1024:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(DES_KS_copy, KS, sizeof(DES_KS));
data/john-1.8.0/src/DES_std.c:1033:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char DES_atoi64[0x100] = {
data/john-1.8.0/src/DES_std.h:29:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char DES_E[48];
data/john-1.8.0/src/DES_std.h:30:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char DES_PC1[56];
data/john-1.8.0/src/DES_std.h:31:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char DES_ROT[16];
data/john-1.8.0/src/DES_std.h:32:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern unsigned char DES_PC2[48];
data/john-1.8.0/src/LM_fmt.c:67:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char *prepare(char *fields[10], struct fmt_main *self)
data/john-1.8.0/src/LM_fmt.c:67:22: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char *prepare(char *fields[10], struct fmt_main *self)
data/john-1.8.0/src/LM_fmt.c:77:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char lower[CIPHERTEXT_LENGTH - 16 + 1];
data/john-1.8.0/src/LM_fmt.c:99:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[21];
data/john-1.8.0/src/LM_fmt.c:112:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&out[4], &ciphertext[16], 16);
data/john-1.8.0/src/LM_fmt.c:114:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&out[4], ciphertext, 16);
data/john-1.8.0/src/LM_fmt.c:180:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[8];
data/john-1.8.0/src/MD5_fmt.c:52:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char (*saved_key)[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/MD5_fmt.c:175:42: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h = (unsigned char)atoi64[ARCH_INDEX(((char *)salt)[i])];
data/john-1.8.0/src/MD5_fmt.c:176:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= ((unsigned char *)salt)[i + 1];
data/john-1.8.0/src/MD5_fmt.c:178:43: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= (unsigned char)atoi64[ARCH_INDEX(((char *)salt)[i + 1])];
data/john-1.8.0/src/MD5_fmt.c:179:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= ((unsigned char *)salt)[i];
data/john-1.8.0/src/MD5_std.c:26:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char saved_salt[9];
data/john-1.8.0/src/MD5_std.c:284:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char PADDING[56] = {
data/john-1.8.0/src/MD5_std.c:398:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pool[0].s, salt, pool[0].l.s = length);
data/john-1.8.0/src/MD5_std.c:400:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pool[1].s, salt, pool[1].l.s = length);
data/john-1.8.0/src/MD5_std.c:430:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(current->o.p.b, key, current->l.p = length);
data/john-1.8.0/src/MD5_std.c:431:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->o.p.b[length + 16], PADDING, 40 - length);
data/john-1.8.0/src/MD5_std.c:434:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(current->o.pp.b, key, length);
data/john-1.8.0/src/MD5_std.c:435:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->o.pp.b[length], key, length);
data/john-1.8.0/src/MD5_std.c:437:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->o.pp.b[current->l.pp + 16], PADDING,
data/john-1.8.0/src/MD5_std.c:441:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->e.p.b[16], key, length);
data/john-1.8.0/src/MD5_std.c:442:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->e.p.b[16 + length], PADDING, 40 - length);
data/john-1.8.0/src/MD5_std.c:446:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->e.pp.b[16], current->o.pp.b, current->l.pp);
data/john-1.8.0/src/MD5_std.c:447:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(¤t->e.pp.b[16 + current->l.pp], PADDING,
data/john-1.8.0/src/MD5_std.c:783:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(key->o.ps.b, key->o.p.b, key->l.p);
data/john-1.8.0/src/MD5_std.c:784:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->o.ps.b[key->l.p], key->s, key->l.s);
data/john-1.8.0/src/MD5_std.c:786:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->o.ps.b[key->l.ps + 16], PADDING,
data/john-1.8.0/src/MD5_std.c:790:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(key->o.psp.b, key->o.ps.b, key->l.ps);
data/john-1.8.0/src/MD5_std.c:791:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->o.psp.b[key->l.ps], key->o.p.b, key->l.p);
data/john-1.8.0/src/MD5_std.c:793:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->o.psp.b[key->l.psp + 16], PADDING,
data/john-1.8.0/src/MD5_std.c:797:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.sp.b[16], key->s, key->l.s);
data/john-1.8.0/src/MD5_std.c:798:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.sp.b[16 + key->l.s], key->o.p.b,
data/john-1.8.0/src/MD5_std.c:800:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.sp.b[16 + key->l.ps], PADDING,
data/john-1.8.0/src/MD5_std.c:805:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.spp.b[16], key->s, key->l.s);
data/john-1.8.0/src/MD5_std.c:806:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.spp.b[16 + key->l.s], key->o.pp.b,
data/john-1.8.0/src/MD5_std.c:808:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&key->e.spp.b[16 + key->l.psp], PADDING,
data/john-1.8.0/src/MD5_std.c:828:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index], key->o.psp.b, key->l.psp);
data/john-1.8.0/src/MD5_std.c:829:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index].b[key->l.psp], PADDING, 56 - key->l.psp);
data/john-1.8.0/src/MD5_std.c:845:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index], key->o.p.b, key->l.p);
data/john-1.8.0/src/MD5_std.c:846:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index].b[key->l.p], prefix, prelen);
data/john-1.8.0/src/MD5_std.c:847:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index].b[key->l.p + prelen], key->s, key->l.s);
data/john-1.8.0/src/MD5_std.c:848:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index].b[key->l.ps + prelen],
data/john-1.8.0/src/MD5_std.c:856:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&block[index].b[length], PADDING, 56 - length);
data/john-1.8.0/src/MD5_std.c:889:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&line[0].odd->b[line[0].length], MD5_out[0], 16);
data/john-1.8.0/src/MD5_std.c:890:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&line[1].odd->b[line[1].length], MD5_out[1], 16);
data/john-1.8.0/src/MD5_std.c:894:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&line[0].odd->b[line[0].length],
data/john-1.8.0/src/MD5_std.c:920:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&line[0].odd->b[line[0].length], MD5_out[0], 16);
data/john-1.8.0/src/MD5_std.c:922:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&line[1].odd->b[line[1].length], MD5_out[1], 16);
data/john-1.8.0/src/MD5_std.c:939:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(MD5_out[0], line[0].even, 16);
data/john-1.8.0/src/MD5_std.c:941:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(MD5_out[1], line[1].even, 16);
data/john-1.8.0/src/MD5_std.c:972:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[9];
data/john-1.8.0/src/MD5_std.c:1004:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[16];
data/john-1.8.0/src/MD5_std.h:35:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char b[60];
data/john-1.8.0/src/MD5_std.h:44:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[8];
data/john-1.8.0/src/bench.c:97:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char s_error[64];
data/john-1.8.0/src/bench.c:138:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(two_salts[index], salt, format->params.salt_size);
data/john-1.8.0/src/bench.c:226:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%uK", cps_hi / 1000);
data/john-1.8.0/src/bench.c:229:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%u", cps_hi);
data/john-1.8.0/src/bench.c:233:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%u.%u", cps_hi, cps_lo);
data/john-1.8.0/src/bench.c:242:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_real[64], s_virtual[64];
data/john-1.8.0/src/best.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_real[64], s_virtual[64];
data/john-1.8.0/src/c3_fmt.c:62:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char saved_key[MAX_KEYS_PER_CRYPT][PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/c3_fmt.c:63:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char saved_salt[SALT_SIZE];
data/john-1.8.0/src/c3_fmt.c:64:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char crypt_out[MAX_KEYS_PER_CRYPT][BINARY_SIZE];
data/john-1.8.0/src/c3_fmt.c:76:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pw[PLAINTEXT_LENGTH + 1], *new_ciphertext;
data/john-1.8.0/src/c3_fmt.c:78:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char sup_length[BINARY_SIZE], sup_id[0x80];
data/john-1.8.0/src/c3_fmt.c:122:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(pw, ciphertext, pw_length); /* reuse the string, why not? */
data/john-1.8.0/src/c3_fmt.c:172:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[BINARY_SIZE];
data/john-1.8.0/src/c3_fmt.c:179:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[SALT_SIZE];
data/john-1.8.0/src/c3_fmt.c:226:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, ciphertext, ++p - ciphertext);
data/john-1.8.0/src/c3_fmt.c:243:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, ciphertext, cut);
data/john-1.8.0/src/c3_fmt.c:326:41: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h = (unsigned char)atoi64[ARCH_INDEX(((char *)salt)[i])];
data/john-1.8.0/src/c3_fmt.c:327:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= ((unsigned char *)salt)[i - 1];
data/john-1.8.0/src/c3_fmt.c:329:42: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= (unsigned char)atoi64[ARCH_INDEX(((char *)salt)[i - 1])];
data/john-1.8.0/src/c3_fmt.c:330:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
h ^= ((unsigned char *)salt)[i];
data/john-1.8.0/src/c3_fmt.c:434:16: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
if (!strcmp((char *)binary, crypt_out[index]))
data/john-1.8.0/src/c3_fmt.c:442:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
return !strcmp((char *)binary, crypt_out[index]);
data/john-1.8.0/src/charset.c:38:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *ptr, key[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/charset.c:65:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(key, current->data, old_length + 1);
data/john-1.8.0/src/charset.c:99:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(current->data, key, length + 1);
data/john-1.8.0/src/charset.c:160:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char values[4];
data/john-1.8.0/src/charset.c:213:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[CHARSET_SIZE];
data/john-1.8.0/src/charset.c:534:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(order, best_order, end - order);
data/john-1.8.0/src/charset.c:548:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(best_order, order, end - order);
data/john-1.8.0/src/charset.c:639:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(path_expand(charset), "wb")))
data/john-1.8.0/src/charset.h:36:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char version[4];
data/john-1.8.0/src/charset.h:40:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char check[24];
data/john-1.8.0/src/charset.h:52:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char offsets[CHARSET_LENGTH][4];
data/john-1.8.0/src/charset.h:64:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char order
data/john-1.8.0/src/common.c:16:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char itoa64[64] =
data/john-1.8.0/src/common.c:18:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atoi64[0x100];
data/john-1.8.0/src/common.c:20:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char itoa16[16] =
data/john-1.8.0/src/common.c:22:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char atoi16[0x100];
data/john-1.8.0/src/common.h:59:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char itoa64[64], atoi64[0x100];
data/john-1.8.0/src/common.h:60:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char itoa16[16], atoi16[0x100];
data/john-1.8.0/src/compiler.c:76:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char c_unget_buffer[C_UNGET_SIZE];
data/john-1.8.0/src/compiler.c:79:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char c_isident[0x100];
data/john-1.8.0/src/compiler.c:215:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char token[C_TOKEN_SIZE];
data/john-1.8.0/src/config.c:127:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/config.c:132:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(path_expand(name), "r"))) {
data/john-1.8.0/src/cracker.c:39:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char crk_stdout_key[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/cracker.c:89:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&crk_params, &db->format->params, sizeof(struct fmt_params));
data/john-1.8.0/src/cracker.c:90:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&crk_methods, &db->format->methods, sizeof(struct fmt_methods));
data/john-1.8.0/src/cracker.c:385:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/dummy.c:46:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char saved_key[MAX_KEYS_PER_CRYPT][PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/dummy.c:84:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/external.c:28:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char int_word[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/external.c:29:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char rec_word[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/formats.c:53:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char s_size[32];
data/john-1.8.0/src/formats.c:115:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(binary_copy, binary, format->params.binary_size);
data/john-1.8.0/src/formats.c:124:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(salt_copy, salt, format->params.salt_size);
data/john-1.8.0/src/formats.c:151:4: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s_size, "get_hash[%d](%d)", size, index);
data/john-1.8.0/src/formats.c:252:1: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *fmt_default_prepare(char *fields[10], struct fmt_main *self)
data/john-1.8.0/src/formats.c:252:27: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *fmt_default_prepare(char *fields[10], struct fmt_main *self)
data/john-1.8.0/src/formats.h:50:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *fields[10];
data/john-1.8.0/src/formats.h:129:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *(*prepare)(char *fields[10], struct fmt_main *self);
data/john-1.8.0/src/formats.h:129:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *(*prepare)(char *fields[10], struct fmt_main *self);
data/john-1.8.0/src/formats.h:272:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char *fmt_default_prepare(char *fields[10], struct fmt_main *self);
data/john-1.8.0/src/formats.h:272:34: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
extern char *fmt_default_prepare(char *fields[10], struct fmt_main *self);
data/john-1.8.0/src/inc.c:29:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char (*char2_table)
data/john-1.8.0/src/inc.c:31:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
typedef char (*chars_table)
data/john-1.8.0/src/inc.c:35:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char rec_numbers[CHARSET_LENGTH];
data/john-1.8.0/src/inc.c:38:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char numbers[CHARSET_LENGTH];
data/john-1.8.0/src/inc.c:42:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char real_chars[CHARSET_SIZE];
data/john-1.8.0/src/inc.c:81:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(rec_numbers, numbers, length);
data/john-1.8.0/src/inc.c:94:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char present[0x100];
data/john-1.8.0/src/inc.c:224:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char present[CHARSET_SIZE];
data/john-1.8.0/src/inc.c:301:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key_i[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/inc.c:302:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key_e[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/inc.c:381:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char allchars[CHARSET_SIZE + 1];
data/john-1.8.0/src/inc.c:382:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char char1[CHARSET_SIZE + 1];
data/john-1.8.0/src/inc.c:454:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(path_expand(charset), "rb")))
data/john-1.8.0/src/john.c:341:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char s_loaded_counts[80];
data/john-1.8.0/src/list.h:24:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char data[1];
data/john-1.8.0/src/loader.c:39:8: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char issep_map[0x100];
data/john-1.8.0/src/loader.c:49:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/loader.c:60:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(path_expand(name), "r"))) {
data/john-1.8.0/src/loader.c:220:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *fields[10], *uid, *gid, *shell;
data/john-1.8.0/src/loader.c:308:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(source, uid, shift);
data/john-1.8.0/src/loader.c:590:25: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
current_pw->binary = memcpy(¤t_pw->source,
data/john-1.8.0/src/loader.c:945:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char source[LINE_BUFFER_SIZE];
data/john-1.8.0/src/loader.h:96:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1];
data/john-1.8.0/src/logger.c:63:15: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((f->fd = open(path_expand(name),
data/john-1.8.0/src/logger.c:135:17: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
count1 = (int)sprintf(log.ptr, "%u ", options.node_min);
data/john-1.8.0/src/logger.c:142:16: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
count2 = (int)sprintf(log.ptr + count1, "%u:%02u:%02u:%02u ",
data/john-1.8.0/src/memory.c:80:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
return memcpy(mem_alloc_tiny(size, align), src, size);
data/john-1.8.0/src/memory.c:91:17: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
return (char *)memcpy(mem_alloc_tiny(size, MEM_ALIGN_NONE), src, size);
data/john-1.8.0/src/path.c:57:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(user_home_path, pw->pw_dir, user_home_length - 1);
data/john-1.8.0/src/path.c:74:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(john_home_path, argv[0], john_home_length);
data/john-1.8.0/src/path.c:124:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p, session, keep);
data/john-1.8.0/src/path.c:125:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(p + keep, suffix, add);
data/john-1.8.0/src/recovery.c:106:16: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((rec_fd = open(path_expand(rec_name), O_RDWR | O_CREAT, 0600)) < 0)
data/john-1.8.0/src/recovery.c:214:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/recovery.c:220:19: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(rec_file = fopen(path_expand(rec_name), "r+"))) {
data/john-1.8.0/src/rpp.h:40:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char chars[0x100];
data/john-1.8.0/src/rpp.h:62:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char output[RULE_BUFFER_SIZE];
data/john-1.8.0/src/rules.c:58:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char vars[0x100];
data/john-1.8.0/src/rules.c:76:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[3][RULE_WORD_SIZE * 2 + CACHE_BANK_SHIFT];
data/john-1.8.0/src/rules.c:84:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char memory[RULE_WORD_SIZE];
data/john-1.8.0/src/rules.c:85:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *classes[0x100];
data/john-1.8.0/src/rules.c:286:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out_rule[RULE_BUFFER_SIZE];
data/john-1.8.0/src/rules.c:444:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(in + length, in, length);
data/john-1.8.0/src/rules.c:467:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(in, "es");
data/john-1.8.0/src/rules.c:470:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(&in[pos], "ves");
data/john-1.8.0/src/rules.c:474:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(&in[pos - 1], "ves");
data/john-1.8.0/src/rules.c:480:7: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(&in[pos], "ies");
data/john-1.8.0/src/rules.c:686:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, in, pos);
data/john-1.8.0/src/rules.c:721:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, in, pos);
data/john-1.8.0/src/rules.c:786:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(in, "ed");
data/john-1.8.0/src/rules.c:798:6: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(&in[pos], "ing");
data/john-1.8.0/src/rules.c:805:6: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(in, "ing");
data/john-1.8.0/src/rules.c:835:6: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&in[length], mp, count);
data/john-1.8.0/src/rules.c:842:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(inp, mp, count);
data/john-1.8.0/src/rules.c:866:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[2], in, length + 1);
data/john-1.8.0/src/rules.c:873:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(in, word, length);
data/john-1.8.0/src/rules.c:883:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[2], in, length + 1);
data/john-1.8.0/src/single.c:261:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(keys, guessed_keys, size);
data/john-1.8.0/src/single.c:292:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char pair[RULE_WORD_SIZE];
data/john-1.8.0/src/status.c:102:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(buffer, "OVERFLOW");
data/john-1.8.0/src/status.c:163:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%uG", div64by32lo(&cps, 1000000000));
data/john-1.8.0/src/status.c:166:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%uM", div64by32lo(&cps, 1000000));
data/john-1.8.0/src/status.c:169:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%uK", div64by32lo(&cps, 1000));
data/john-1.8.0/src/status.c:172:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buffer, "%u", cps.lo);
data/john-1.8.0/src/status.c:206:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *key1, key2[PLAINTEXT_BUFFER_SIZE];
data/john-1.8.0/src/status.c:208:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_gps[32], s_pps[32], s_crypts_ps[32], s_combs_ps[32];
data/john-1.8.0/src/status.c:209:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s[1024], *p;
data/john-1.8.0/src/status.c:224:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
n = sprintf(p, "%u ", options.node_min);
data/john-1.8.0/src/status.c:230:6: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
n = sprintf(p,
data/john-1.8.0/src/status.c:240:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
n = sprintf(p,
data/john-1.8.0/src/status.c:261:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_pps[32], s_p[32];
data/john-1.8.0/src/status.c:280:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char s_percent[32];
data/john-1.8.0/src/status.c:295:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(s_percent, " %d/3", status.pass);
data/john-1.8.0/src/symlink.c:22:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char path[strlen(argv[0] ? argv[0] : "") + sizeof(MAIN_NAME)];
data/john-1.8.0/src/trip_fmt.c:88:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char key[PLAINTEXT_LENGTH];
data/john-1.8.0/src/trip_fmt.c:91:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char salt_map[0x100];
data/john-1.8.0/src/trip_fmt.c:98:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fake_crypt[14];
data/john-1.8.0/src/trip_fmt.c:175:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fake_crypt[14];
data/john-1.8.0/src/trip_fmt.c:180:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&fake_crypt[3], ciphertext, 11);
data/john-1.8.0/src/trip_fmt.c:236:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, src, n * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:241:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(dst, src, 7 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:242:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[8], &src[8], 7 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:243:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[16], &src[16], 7 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:244:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[24], &src[24], 15 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:245:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[40], &src[40], 7 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:246:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[48], &src[48], 7 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:247:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&dst[56], &src[56], 8 * sizeof(*dst));
data/john-1.8.0/src/trip_fmt.c:335:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char fake_crypt[14];
data/john-1.8.0/src/trip_fmt.c:564:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer[index].key, key, PLAINTEXT_LENGTH);
data/john-1.8.0/src/trip_fmt.c:569:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char out[PLAINTEXT_LENGTH + 1];
data/john-1.8.0/src/trip_fmt.c:571:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(out, buffer[index].key, PLAINTEXT_LENGTH);
data/john-1.8.0/src/tty.c:59:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open("/dev/tty", O_RDONLY | O_NONBLOCK)) < 0) return;
data/john-1.8.0/src/unafs.c:42:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buffer[DB_ENTRY_SIZE];
data/john-1.8.0/src/unafs.c:79:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(argv[1], "rb")))
data/john-1.8.0/src/unique.c:131:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/unique.c:188:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/unique.c:224:12: [2] (misc) open:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fd = open(name, O_RDWR | O_CREAT | O_EXCL, 0600)) < 0)
data/john-1.8.0/src/unshadow.c:86:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/unshadow.c:88:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(file = fopen(name, "r")))
data/john-1.8.0/src/wordlist.c:80:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[LINE_BUFFER_SIZE];
data/john-1.8.0/src/wordlist.c:169:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[2][LINE_BUFFER_SIZE + CACHE_BANK_SHIFT];
data/john-1.8.0/src/wordlist.c:182:21: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(word_file = fopen(path_expand(name), "r")))
data/john-1.8.0/src/AFS_fmt.c:186:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(out, &ciphertext[21], SALT_SIZE);
data/john-1.8.0/src/AFS_fmt.c:276:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memset(&cell[cell_length = strlen(cell)], 0, 8);
data/john-1.8.0/src/AFS_fmt.c:313:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((length = strlen(buffer[index].key)) > 8)
data/john-1.8.0/src/LM_fmt.c:69:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (fields[2] && strlen(fields[2]) == 32)
data/john-1.8.0/src/bench.c:80:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((int)strlen(plaintext) > length) break;
data/john-1.8.0/src/bench.c:83:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((int)strlen(plaintext) <= length) break;
data/john-1.8.0/src/c3_fmt.c:149:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (new_ciphertext && strlen(new_ciphertext) == length &&
data/john-1.8.0/src/c3_fmt.c:173:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(out, ciphertext, sizeof(out)); /* NUL padding is required */
data/john-1.8.0/src/c3_fmt.c:184:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = strlen(ciphertext);
data/john-1.8.0/src/c3_fmt.c:252:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i = strlen(s) - 2; \
data/john-1.8.0/src/c3_fmt.c:255:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i = strlen(s) - 2; \
data/john-1.8.0/src/c3_fmt.c:258:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i = strlen(s) - 2; \
data/john-1.8.0/src/c3_fmt.c:261:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i = strlen(s) - 2; \
data/john-1.8.0/src/c3_fmt.c:265:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int i = strlen(s) - 2; \
data/john-1.8.0/src/c3_fmt.c:323:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
i = strlen((char *)salt) - 1;
data/john-1.8.0/src/charset.c:55:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
old_length = strlen(current->data);
data/john-1.8.0/src/charset.c:666:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(header->version, CHARSET_V, sizeof(header->version));
data/john-1.8.0/src/compiler.c:311:43: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strcpy((*list)->name = (char *)mem_alloc(strlen(name) + 1), name);
data/john-1.8.0/src/compiler.c:336:38: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!memcmp(c_ops[op].name, token, strlen(c_ops[op].name)))
data/john-1.8.0/src/compiler.c:338:7: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(c_ops[op].name) > strlen(c_ops[best].name))
data/john-1.8.0/src/compiler.c:338:32: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(c_ops[op].name) > strlen(c_ops[best].name))
data/john-1.8.0/src/compiler.c:568:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(c_ops[op].name) < 3) {
data/john-1.8.0/src/compiler.c:699:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos = token + strlen(token);
data/john-1.8.0/src/config.c:34:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
e = s + strlen(s) - 1;
data/john-1.8.0/src/formats.c:97:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (!ciphertext || strlen(ciphertext) < 7)
data/john-1.8.0/src/getopt.c:43:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(name);
data/john-1.8.0/src/getopt.c:47:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (length <= strlen(list->name))
data/john-1.8.0/src/inc.c:147:15: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) != EOF)
data/john-1.8.0/src/inc.c:171:20: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
while ((value = getc(file)) != EOF) {
data/john-1.8.0/src/inc.c:183:16: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) == EOF)
data/john-1.8.0/src/inc.c:187:17: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) != (int)length)
data/john-1.8.0/src/inc.c:189:17: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) == EOF)
data/john-1.8.0/src/inc.c:198:17: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) == EOF)
data/john-1.8.0/src/inc.c:203:17: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((value = getc(file)) == EOF)
data/john-1.8.0/src/inc.c:211:11: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
value = getc(file);
data/john-1.8.0/src/john.c:360:2: [1] (access) umask:
Ensure that umask is given most restrictive possible setting (e.g., 066 or
077) (CWE-732).
umask(077);
data/john-1.8.0/src/john.c:683:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(name) > 4 && !strcmp(name + strlen(name) - 4, ".exe"))
data/john-1.8.0/src/john.c:683:41: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(name) > 4 && !strcmp(name + strlen(name) - 4, ".exe"))
data/john-1.8.0/src/john.c:684:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
name[strlen(name) - 4] = 0;
data/john-1.8.0/src/list.c:28:53: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
entry = mem_alloc_tiny(sizeof(struct list_entry) + strlen(data),
data/john-1.8.0/src/loader.c:228:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(*ciphertext) < 10 && strncmp(*ciphertext, "$dummy$", 7))
data/john-1.8.0/src/loader.c:237:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
p += strlen(p) - 1;
data/john-1.8.0/src/loader.c:306:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int shift = strlen(uid);
data/john-1.8.0/src/loader.c:307:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(source + shift + 1, source, strlen(source) + 1);
data/john-1.8.0/src/loader.c:609:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(login) + 3, MEM_ALIGN_NONE);
data/john-1.8.0/src/loader.c:984:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
piece = strcpy(mem_alloc(strlen(piece) + 1), piece);
data/john-1.8.0/src/loader.c:1012:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
(int)strlen(current->plaintext) != chars)
data/john-1.8.0/src/logger.c:180:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(ciphertext) + strlen(plaintext) <= LINE_BUFFER_SIZE - 3) {
data/john-1.8.0/src/logger.c:180:27: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(ciphertext) + strlen(plaintext) <= LINE_BUFFER_SIZE - 3) {
data/john-1.8.0/src/logger.c:187:6: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(login) < LINE_BUFFER_SIZE - 64) {
data/john-1.8.0/src/logger.c:229:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
count1 + strlen(format) < LINE_BUFFER_SIZE - 500 - 1) {
data/john-1.8.0/src/memory.c:90:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size = strlen(src) + 1;
data/john-1.8.0/src/misc.c:74:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos = res + strlen(res) - 1;
data/john-1.8.0/src/misc.c:80:12: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if ((c = getc(stream)) == '\n') {
data/john-1.8.0/src/misc.c:84:8: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = getc(stream);
data/john-1.8.0/src/options.c:138:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int length = strlen(label) + (format->next != NULL);
data/john-1.8.0/src/options.c:142:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
column = strlen(JOHN_USAGE_INDENT) + length;
data/john-1.8.0/src/path.c:46:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
john_home_length = strlen(john_home_path);
data/john-1.8.0/src/path.c:53:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
user_home_length = strlen(pw->pw_dir) + 1;
data/john-1.8.0/src/path.c:83:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
john_home_length + strlen(name) - 6 < PATH_BUFFER_SIZE) {
data/john-1.8.0/src/path.c:94:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
user_home_length + strlen(name) - 2 < PATH_BUFFER_SIZE) {
data/john-1.8.0/src/path.c:111:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
keep = strlen(session);
data/john-1.8.0/src/path.c:122:8: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
add = strlen(suffix) + 1;
data/john-1.8.0/src/recovery.c:63:37: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *suffix = mem_alloc(1 + 20 + strlen(RECOVERY_SUFFIX) + 1);
data/john-1.8.0/src/rules.c:389:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
memmove(rule - 1, rule, strlen(rule) + 1);
data/john-1.8.0/src/rules.c:478:7: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(in, "s");
data/john-1.8.0/src/rules.c:482:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(in, "s");
data/john-1.8.0/src/rules.c:484:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in);
data/john-1.8.0/src/rules.c:513:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in = out);
data/john-1.8.0/src/rules.c:784:6: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(in, "d");
data/john-1.8.0/src/rules.c:788:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in);
data/john-1.8.0/src/rules.c:808:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in);
data/john-1.8.0/src/rules.c:891:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in);
data/john-1.8.0/src/rules.c:914:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(in);
data/john-1.8.0/src/single.c:323:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if ((split = strlen(first->data)) < length) {
data/john-1.8.0/src/symlink.c:22:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char path[strlen(argv[0] ? argv[0] : "") + sizeof(MAIN_NAME)];
data/john-1.8.0/src/tty.c:97:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read(tty_fd, &c, 1) > 0) return c;
data/john-1.8.0/src/unique.c:157:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
ptr += strlen(line) + 1;
data/john-1.8.0/src/unique.c:175:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
length = strlen(&buffer.data[ptr]);
data/john-1.8.0/src/unshadow.c:150:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pos2 = pos1 + strlen(pos1);
ANALYSIS SUMMARY:
Hits = 418
Lines analyzed = 30039 in approximately 0.81 seconds (37035 lines/second)
Physical Source Lines of Code (SLOC) = 22652
Hits@level = [0] 138 [1] 80 [2] 283 [3] 2 [4] 51 [5] 2
Hits@level+ = [0+] 556 [1+] 418 [2+] 338 [3+] 55 [4+] 53 [5+] 2
Hits/KSLOC@level+ = [0+] 24.5453 [1+] 18.4531 [2+] 14.9214 [3+] 2.42804 [4+] 2.33975 [5+] 0.0882924
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.