Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/kildclient-3.2.0/src/ansitextview.c
Examining data/kildclient-3.2.0/src/sound.c
Examining data/kildclient-3.2.0/src/proxy.c
Examining data/kildclient-3.2.0/src/we_generic_guied.c
Examining data/kildclient-3.2.0/src/prefs.c
Examining data/kildclient-3.2.0/src/we_advanced.c
Examining data/kildclient-3.2.0/src/we_general.c
Examining data/kildclient-3.2.0/src/worldeditor.c
Examining data/kildclient-3.2.0/src/we_scripting.c
Examining data/kildclient-3.2.0/src/worldselector.c
Examining data/kildclient-3.2.0/src/multilinesend.c
Examining data/kildclient-3.2.0/src/kcwin.c
Examining data/kildclient-3.2.0/src/simocombobox.h
Examining data/kildclient-3.2.0/src/simocombobox.c
Examining data/kildclient-3.2.0/src/plugins.c
Examining data/kildclient-3.2.0/src/we_logging.c
Examining data/kildclient-3.2.0/src/we_vars.c
Examining data/kildclient-3.2.0/src/mainwindow.c
Examining data/kildclient-3.2.0/src/we_statusbar.c
Examining data/kildclient-3.2.0/src/we_input.c
Examining data/kildclient-3.2.0/src/parser.c
Examining data/kildclient-3.2.0/src/net.h
Examining data/kildclient-3.2.0/src/kcircularqueue.c
Examining data/kildclient-3.2.0/src/we_timers.c
Examining data/kildclient-3.2.0/src/process_line_thread.c
Examining data/kildclient-3.2.0/src/worlds.c
Examining data/kildclient-3.2.0/src/we_colors.c
Examining data/kildclient-3.2.0/src/we_macros.c
Examining data/kildclient-3.2.0/src/timers.c
Examining data/kildclient-3.2.0/src/we_mainwindow.c
Examining data/kildclient-3.2.0/src/we_protocols.c
Examining data/kildclient-3.2.0/src/perlscript.h
Examining data/kildclient-3.2.0/src/ansiparse_thread.c
Examining data/kildclient-3.2.0/src/aliases.c
Examining data/kildclient-3.2.0/src/macros.c
Examining data/kildclient-3.2.0/src/permanentvariables.c
Examining data/kildclient-3.2.0/src/triggers.c
Examining data/kildclient-3.2.0/src/cmdhistory.c
Examining data/kildclient-3.2.0/src/telnet.c
Examining data/kildclient-3.2.0/src/we_triggers.c
Examining data/kildclient-3.2.0/src/mainthread_operations.c
Examining data/kildclient-3.2.0/src/libintl-wrapper.h
Examining data/kildclient-3.2.0/src/we_plugins.c
Examining data/kildclient-3.2.0/src/we_hooks.c
Examining data/kildclient-3.2.0/src/we_aliases.c
Examining data/kildclient-3.2.0/src/util.c
Examining data/kildclient-3.2.0/src/perlscript.c
Examining data/kildclient-3.2.0/src/ansi.h
Examining data/kildclient-3.2.0/src/kildclient.h
Examining data/kildclient-3.2.0/src/main.c
Examining data/kildclient-3.2.0/src/kcircularqueue.h
Examining data/kildclient-3.2.0/src/worldgui.c
Examining data/kildclient-3.2.0/src/hooks.c
Examining data/kildclient-3.2.0/src/log.c
Examining data/kildclient-3.2.0/src/net.c
FINAL RESULTS:
data/kildclient-3.2.0/src/ansitextview.c:429:5: [4] (format) sprintf:
Potential format string problem (CWE-134). Make format string constant.
sprintf(msg, ngettext("%d line", "%d lines", totallines), totallines);
data/kildclient-3.2.0/src/libintl-wrapper.h:27:10: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# undef printf
data/kildclient-3.2.0/src/libintl-wrapper.h:28:10: [4] (format) vprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# undef vprintf
data/kildclient-3.2.0/src/libintl-wrapper.h:29:10: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
# undef vfprintf
data/kildclient-3.2.0/src/log.c:137:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(timestr, ctime(&curr_time));
data/kildclient-3.2.0/src/log.c:202:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(timestr, ctime(&curr_time));
data/kildclient-3.2.0/src/main.c:107:5: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
printf(PACKAGE_NAME " " PACKAGE_VERSION "\n");
data/kildclient-3.2.0/src/main.c:285:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(path, PKGDATADIR "/");
data/kildclient-3.2.0/src/main.c:286:3: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(path, file);
data/kildclient-3.2.0/src/main.c:325:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(pos + 1, file);
data/kildclient-3.2.0/src/perlscript.h:49:8: [4] (format) fprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#undef fprintf
data/kildclient-3.2.0/src/perlscript.h:54:8: [4] (buffer) fscanf:
The scanf() family's %s operation, without a limit specification, permits
buffer overflows (CWE-120, CWE-20). Specify a limit to %s, or use a
different input function.
#undef fscanf
data/kildclient-3.2.0/src/perlscript.h:65:8: [4] (shell) popen:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
#undef popen
data/kildclient-3.2.0/src/perlscript.h:74:8: [4] (format) vfprintf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#undef vfprintf
data/kildclient-3.2.0/src/perlscript.h:75:8: [4] (format) printf:
If format strings can be influenced by an attacker, they can be exploited
(CWE-134). Use a constant for the format specification.
#undef printf
data/kildclient-3.2.0/src/proxy.c:255:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy((gchar *) request + 8, world->proxy_used.user);
data/kildclient-3.2.0/src/sound.c:52:3: [4] (shell) system:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
system(to_run);
data/kildclient-3.2.0/src/we_advanced.c:452:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(file, "%s/%s_%d.wrl", kilddir, name, i);
data/kildclient-3.2.0/src/worldgui.c:1165:3: [4] (shell) ShellExecute:
This causes a new program to execute and is difficult to use safely
(CWE-78). try using a library call that implements the same functionality
if available.
ShellExecute(NULL, "open", url, NULL, NULL, SW_SHOWNORMAL);
data/kildclient-3.2.0/src/worlds.c:272:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(world->command_separator, default_world->command_separator);
data/kildclient-3.2.0/src/worlds.c:1136:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(parser->world->command_separator, *attribute_values);
data/kildclient-3.2.0/src/worldselector.c:758:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(otherfile, file);
data/kildclient-3.2.0/src/worldselector.c:762:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(otherfile, file);
data/kildclient-3.2.0/src/main.c:271:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
homedir = getenv("HOME");
data/kildclient-3.2.0/src/ansiparse_thread.c:495:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctext, text, len);
data/kildclient-3.2.0/src/ansiparse_thread.c:572:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
val = atoi(*curr_seq);
data/kildclient-3.2.0/src/kcircularqueue.c:60:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(q->data + q->first_free*q->el_size, val, q->el_size);
data/kildclient-3.2.0/src/kcircularqueue.c:72:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(q->data + q->first_free*q->el_size, val, q->el_size);
data/kildclient-3.2.0/src/kcircularqueue.c:107:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newdata, q->data + q->first*q->el_size, till_end*q->el_size);
data/kildclient-3.2.0/src/kcircularqueue.c:109:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(newdata + till_end*q->el_size,
data/kildclient-3.2.0/src/log.c:55:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char timestr[MAX_TIME_STR];
data/kildclient-3.2.0/src/log.c:117:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char actualfile[PATH_MAX+1];
data/kildclient-3.2.0/src/log.c:118:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char timestr[MAX_TIME_STR];
data/kildclient-3.2.0/src/log.c:131:26: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((world->log_file = fopen(actualfile, "a")) != NULL) {
data/kildclient-3.2.0/src/log.c:198:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char timestr[MAX_TIME_STR];
data/kildclient-3.2.0/src/main.c:112:22: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(dumpFile = fopen(dumpfile, "w"))) {
data/kildclient-3.2.0/src/main.c:119:23: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if (!(rdumpFile = fopen(rdumpfile, "w"))) {
data/kildclient-3.2.0/src/main.c:283:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char path[PATH_MAX];
data/kildclient-3.2.0/src/main.c:294:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char appdatadir[MAX_PATH];
data/kildclient-3.2.0/src/main.c:319:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char path[PATH_MAX];
data/kildclient-3.2.0/src/mainwindow.c:833:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, _(": Not yet active"));
data/kildclient-3.2.0/src/mainwindow.c:838:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(buf, _(": Expired"));
data/kildclient-3.2.0/src/mainwindow.c:844:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(mval, "%.2X:", (unsigned char) digest[i]);
data/kildclient-3.2.0/src/multilinesend.c:249:14: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(context->file, "r");
data/kildclient-3.2.0/src/multilinesend.c:426:10: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static char line[MAX_BUFFER];
data/kildclient-3.2.0/src/net.c:903:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->dbuffer, world->inbuffer, nread);
data/kildclient-3.2.0/src/net.c:1048:7: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->inbuffer, world->dbuffer + pos + 1, end - pos - 1);
data/kildclient-3.2.0/src/parser.c:205:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char cmd[MAX_BUFFER + 1];
data/kildclient-3.2.0/src/parser.c:216:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(cmd, cmdline + start, len);
data/kildclient-3.2.0/src/perlscript.c:1158:15: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
if ((fp = fopen(file, "r")) == NULL) {
data/kildclient-3.2.0/src/perlscript.c:1338:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char telnet_code[3];
data/kildclient-3.2.0/src/perlscript.h:48:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
#undef fopen
data/kildclient-3.2.0/src/perlscript.h:72:8: [2] (tmpfile) tmpfile:
Function tmpfile() has a security flaw on some systems (e.g., older System
V systems) (CWE-377).
#undef tmpfile
data/kildclient-3.2.0/src/prefs.c:309:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(filepath, "r");
data/kildclient-3.2.0/src/prefs.c:343:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[MAX_BUFFER];
data/kildclient-3.2.0/src/prefs.c:344:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char first_word[MAX_BUFFER];
data/kildclient-3.2.0/src/prefs.c:351:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(first_word, line, pos);
data/kildclient-3.2.0/src/prefs.c:355:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.idxInfoMsgColor = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:357:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.idxCmdEchoColor = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:359:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.idxInfoMsgColor = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:364:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.idxCmdEchoColor = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:369:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.tab_position = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:371:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.hide_single_tab = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:373:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.urgency_hint = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:380:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.multi_cmd_group_size = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:392:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.no_plugin_help_msg = atoi(line + pos + 1);
data/kildclient-3.2.0/src/prefs.c:395:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
globalPrefs.proxy.type = atoi(line + pos + 1);
data/kildclient-3.2.0/src/proxy.c:205:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(&(world->real_ip_for_socks4),
data/kildclient-3.2.0/src/proxy.c:252:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = htons((uint16_t) atoi(world->port));
data/kildclient-3.2.0/src/proxy.c:253:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 2, &port, 2);
data/kildclient-3.2.0/src/proxy.c:254:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 4, &world->real_ip_for_socks4, 4);
data/kildclient-3.2.0/src/proxy.c:600:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 2, world->proxy_used.user, user_len);
data/kildclient-3.2.0/src/proxy.c:602:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 2 + user_len + 1, world->proxy_used.password, pass_len);
data/kildclient-3.2.0/src/proxy.c:639:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 5, world->host, host_name_len);
data/kildclient-3.2.0/src/proxy.c:640:27: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
port = htons((uint16_t) atoi(world->port));
data/kildclient-3.2.0/src/proxy.c:641:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(request + 5 + host_name_len, &port, 2);
data/kildclient-3.2.0/src/telnet.c:50:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char iac_response[4];
data/kildclient-3.2.0/src/telnet.c:382:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer + bsize, &size, sizeof(size));
data/kildclient-3.2.0/src/telnet.c:398:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer + bsize, &size, sizeof(size));
data/kildclient-3.2.0/src/we_advanced.c:440:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char file[PATH_MAX];
data/kildclient-3.2.0/src/we_colors.c:57:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(btnname, "colorBtnAnsi[%d]", i);
data/kildclient-3.2.0/src/we_colors.c:129:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->deffore, &deffore, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/we_colors.c:132:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defbold, &defbold, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/we_colors.c:135:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defback, &defback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/we_colors.c:138:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defboldback, &defboldback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/we_colors.c:141:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->ansicolors, &defansi, 16*sizeof(GdkRGBA));
data/kildclient-3.2.0/src/we_colors.c:143:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(btnname, "colorBtnAnsi[%d]", i);
data/kildclient-3.2.0/src/worlds.c:249:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->deffore, default_world->deffore, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:250:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defbold, default_world->defbold, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:251:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defback, default_world->defback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:252:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->defboldback, default_world->defboldback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:253:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(world->ansicolors, default_world->ansicolors, 16*sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:332:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(default_world->deffore, &deffore, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:333:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(default_world->defbold, &defbold, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:334:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(default_world->defback, &defback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:335:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(default_world->defboldback, &defboldback, sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:336:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(default_world->ansicolors, &defansi, 16*sizeof(GdkRGBA));
data/kildclient-3.2.0/src/worlds.c:353:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(default_world->command_separator, "%;");
data/kildclient-3.2.0/src/worlds.c:820:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[MAX_BUFFER];
data/kildclient-3.2.0/src/worlds.c:825:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(file, "r");
data/kildclient-3.2.0/src/worlds.c:909:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->use_tls = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:931:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->proxy.type = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:956:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->scrollOutput = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:958:41: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->buffer_lines = atol(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:973:47: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->name_display_style = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:990:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->log_autostart = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:992:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->log_add_time = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1007:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->connection_style = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1025:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->flood_prevention = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1027:47: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->max_equal_commands = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1042:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->repeat_commands = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1057:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->cmd_echo = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1072:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->never_hide_input = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1087:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->store_commands = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1102:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->commands_to_save = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1104:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->ignore_up_down_keys = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1119:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->autocompletion = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1121:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->autocompl_minprefix = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1166:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->input_n_lines = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1168:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->input_n_lines_saved = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1183:34: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->spell = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1202:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->confirm_delete = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1217:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->show_plugin_items = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1232:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->keep_alive = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1282:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->wrap = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1284:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->wrap_indent = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1300:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->use_tooltips = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1320:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->ctime_type = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1322:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->itime_type = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1324:49: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->itime_reset_activate = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1364:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->use_wrap_column = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1366:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->wrap_column = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1424:45: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->gag_output = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1426:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->gag_log = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1428:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->enabled = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1430:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->keepexecuting = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1432:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->rewriter = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1434:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->ignore_case = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1459:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currAlias->perl_eval = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1461:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currAlias->enabled = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1463:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currAlias->ignore_case = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1492:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTimer->count = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1494:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTimer->enabled = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1496:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTimer->temporary = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1521:40: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currMacro->enabled = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1575:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currHookEnabled = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1605:44: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->highlight = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1607:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_target = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1609:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_fg_color = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1611:48: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_bg_color = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1613:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_italic = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1615:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_strike = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1617:49: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->currTrigger->high_underline = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:1663:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
parser->world->mccp_behavior = atoi(*attribute_values);
data/kildclient-3.2.0/src/worlds.c:2005:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(*dest, orig, len);
data/kildclient-3.2.0/src/worlds.c:2371:8: [2] (misc) fopen:
Check when opening files - can an attacker redirect it (via symlinks),
force the opening of special file type (e.g., device files), move things
around to create a race condition, control its ancestors, or change its
contents? (CWE-362).
fp = fopen(path, "r");
data/kildclient-3.2.0/src/worldselector.c:759:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(otherfile, ".hst");
data/kildclient-3.2.0/src/worldselector.c:763:5: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(otherfile, ".var");
data/kildclient-3.2.0/src/ansitextview.c:614:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
str_length = strlen(str);
data/kildclient-3.2.0/src/log.c:80:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/kildclient-3.2.0/src/log.c:139:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
timestr[strlen(timestr) - 1] = '\0';
data/kildclient-3.2.0/src/log.c:204:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
timestr[strlen(timestr) - 1] = '\0';
data/kildclient-3.2.0/src/mainwindow.c:847:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
mval[strlen(mval) - 1] = 0; /* Remove last : */
data/kildclient-3.2.0/src/multilinesend.c:430:7: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
c = fgetc(fp);
data/kildclient-3.2.0/src/multilinesend.c:449:9: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(line);
data/kildclient-3.2.0/src/multilinesend.c:460:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
context->textStart, strlen(context->textStart),
data/kildclient-3.2.0/src/multilinesend.c:470:44: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
context->textEnd, strlen(context->textEnd),
data/kildclient-3.2.0/src/net.c:282:5: [1] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant character.
strcpy(world->host_ip, "?");
data/kildclient-3.2.0/src/net.c:1139:34: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(world->flood_prevention_command),
data/kildclient-3.2.0/src/net.c:1266:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
write_escaped(world, command, strlen(command));
data/kildclient-3.2.0/src/parser.c:133:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
totallen = strlen(cmdline);
data/kildclient-3.2.0/src/parser.c:134:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
cmdseplen = strlen(world->command_separator);
data/kildclient-3.2.0/src/parser.c:164:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int len = strlen(cmdline);
data/kildclient-3.2.0/src/parser.c:166:25: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
int cmdseplen = strlen(world->command_separator);
data/kildclient-3.2.0/src/perlscript.h:43:8: [1] (buffer) fgetc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#undef fgetc
data/kildclient-3.2.0/src/perlscript.h:61:8: [1] (buffer) getc:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#undef getc
data/kildclient-3.2.0/src/perlscript.h:92:8: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
#undef read
data/kildclient-3.2.0/src/prefs.c:349:10: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
line[strlen(line) - 1] = '\0'; /* Remove newline at end */
data/kildclient-3.2.0/src/proxy.c:248:40: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
request_size = SOCKS4_REQUEST_SIZE + strlen(world->proxy_used.user);
data/kildclient-3.2.0/src/proxy.c:594:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
user_len = MIN(strlen(world->proxy_used.user), 255);
data/kildclient-3.2.0/src/proxy.c:595:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
pass_len = MIN(strlen(world->proxy_used.password), 255);
data/kildclient-3.2.0/src/proxy.c:631:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
host_name_len = MIN(strlen(world->host), 255);
data/kildclient-3.2.0/src/proxy.c:672:30: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
send(world->sock, request, strlen(request), 0);
data/kildclient-3.2.0/src/proxy.c:750:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(auth_string));
data/kildclient-3.2.0/src/triggers.c:327:31: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
stripped = strip_ansi(line, strlen(line));
data/kildclient-3.2.0/src/we_advanced.c:448:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
startpos = strlen(kilddir) + 1;
data/kildclient-3.2.0/src/worldgui.c:849:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strncmp(key, case_normalized_command, strlen(key)) == 0) {
data/kildclient-3.2.0/src/worldgui.c:1332:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
len = strlen(tip);
data/kildclient-3.2.0/src/worlds.c:851:46: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen(buffer),
data/kildclient-3.2.0/src/worlds.c:2381:13: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
command[strlen(command) - 1] = '\0'; /* Strip final newline */
data/kildclient-3.2.0/src/worldselector.c:757:24: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
otherfile = malloc(strlen(file) + 5);
ANALYSIS SUMMARY:
Hits = 191
Lines analyzed = 32639 in approximately 0.70 seconds (46516 lines/second)
Physical Source Lines of Code (SLOC) = 24830
Hits@level = [0] 32 [1] 33 [2] 134 [3] 1 [4] 23 [5] 0
Hits@level+ = [0+] 223 [1+] 191 [2+] 158 [3+] 24 [4+] 23 [5+] 0
Hits/KSLOC@level+ = [0+] 8.98107 [1+] 7.69231 [2+] 6.36327 [3+] 0.966573 [4+] 0.926299 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.