Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/kio-extras-20.08.3/network/network/netservice_p.cpp Examining data/kio-extras-20.08.3/network/network/netdevice_p.cpp Examining data/kio-extras-20.08.3/network/network/netservice.cpp Examining data/kio-extras-20.08.3/network/network/network_p.h Examining data/kio-extras-20.08.3/network/network/netservice.h Examining data/kio-extras-20.08.3/network/network/netdevice.cpp Examining data/kio-extras-20.08.3/network/network/netdevice.h Examining data/kio-extras-20.08.3/network/network/network.h Examining data/kio-extras-20.08.3/network/network/network.cpp Examining data/kio-extras-20.08.3/network/network/network_p.cpp Examining data/kio-extras-20.08.3/network/network/builder/abstractnetworkbuilder.h Examining data/kio-extras-20.08.3/network/network/builder/abstractnetworkbuilder.cpp Examining data/kio-extras-20.08.3/network/network/builder/simpleitemfactory.h Examining data/kio-extras-20.08.3/network/network/builder/abstractnetsystemfactory.cpp Examining data/kio-extras-20.08.3/network/network/builder/dnssd/dnssdnetsystemable.h Examining data/kio-extras-20.08.3/network/network/builder/dnssd/dnssdnetworkbuilder.cpp Examining data/kio-extras-20.08.3/network/network/builder/dnssd/dnssdnetworkbuilder.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/upnpnetworkbuilder.cpp Examining data/kio-extras-20.08.3/network/network/builder/upnp/cagibidevice.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/cagibidevice_p.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/cagibidbuscodec.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/upnpnetsystemable.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/upnpnetworkbuilder.h Examining data/kio-extras-20.08.3/network/network/builder/upnp/cagibidevice.cpp Examining data/kio-extras-20.08.3/network/network/builder/upnp/cagibidbuscodec.cpp Examining data/kio-extras-20.08.3/network/network/builder/simpleitemfactory.cpp Examining data/kio-extras-20.08.3/network/network/builder/abstractnetsystemfactory.h Examining data/kio-extras-20.08.3/network/network/netservice_p.h Examining data/kio-extras-20.08.3/network/network/molletnetwork_export.h Examining data/kio-extras-20.08.3/network/network/networkdbus.h Examining data/kio-extras-20.08.3/network/network/networkdbus.cpp Examining data/kio-extras-20.08.3/network/network/netdevice_p.h Examining data/kio-extras-20.08.3/network/ioslave/networkuri.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkdbusinterface.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkinitwatcher.cpp Examining data/kio-extras-20.08.3/network/ioslave/mimetypes.h Examining data/kio-extras-20.08.3/network/ioslave/networkinitwatcher.h Examining data/kio-extras-20.08.3/network/ioslave/networkslave.h Examining data/kio-extras-20.08.3/network/ioslave/main.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkthread.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkslave.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkthread.h Examining data/kio-extras-20.08.3/network/ioslave/mimetypes.cpp Examining data/kio-extras-20.08.3/network/ioslave/networkdbusinterface.h Examining data/kio-extras-20.08.3/network/ioslave/networkuri.h Examining data/kio-extras-20.08.3/network/kded/networkwatcher.h Examining data/kio-extras-20.08.3/network/kded/kioslavenotifier.h Examining data/kio-extras-20.08.3/network/kded/kioslavenotifier.cpp Examining data/kio-extras-20.08.3/network/kded/networkdbusadaptor.cpp Examining data/kio-extras-20.08.3/network/kded/networkwatcher.cpp Examining data/kio-extras-20.08.3/network/kded/networkdbusadaptor.h Examining data/kio-extras-20.08.3/recentlyused/recentlyused.cpp Examining data/kio-extras-20.08.3/recentlyused/recentlyused.h Examining data/kio-extras-20.08.3/filter/filter.cc Examining data/kio-extras-20.08.3/filter/filter.h Examining data/kio-extras-20.08.3/mtp/shared/kmtpfile.h Examining data/kio-extras-20.08.3/mtp/shared/kmtpstorageinterface.cpp Examining data/kio-extras-20.08.3/mtp/shared/kmtpdeviceinterface.cpp Examining data/kio-extras-20.08.3/mtp/shared/kmtpdeviceinterface.h Examining data/kio-extras-20.08.3/mtp/shared/kmtpfile.cpp Examining data/kio-extras-20.08.3/mtp/shared/kmtpdinterface.cpp Examining data/kio-extras-20.08.3/mtp/shared/kmtpdinterface.h Examining data/kio-extras-20.08.3/mtp/shared/kmtpstorageinterface.h Examining data/kio-extras-20.08.3/mtp/kio_mtp.h Examining data/kio-extras-20.08.3/mtp/kio_mtp.cpp Examining data/kio-extras-20.08.3/mtp/kiod_module/mtpstorage.cpp Examining data/kio-extras-20.08.3/mtp/kiod_module/mtpdevice.h Examining data/kio-extras-20.08.3/mtp/kiod_module/kmtpd.h Examining data/kio-extras-20.08.3/mtp/kiod_module/mtpstorage.h Examining data/kio-extras-20.08.3/mtp/kiod_module/kmtpd.cpp Examining data/kio-extras-20.08.3/mtp/kiod_module/mtpdevice.cpp Examining data/kio-extras-20.08.3/kfileaudiopreview/kfileaudiopreview.h Examining data/kio-extras-20.08.3/kfileaudiopreview/mediacontrols_p.h Examining data/kio-extras-20.08.3/kfileaudiopreview/mediacontrols.h Examining data/kio-extras-20.08.3/kfileaudiopreview/mediacontrols.cpp Examining data/kio-extras-20.08.3/kfileaudiopreview/kfileaudiopreview.cpp Examining data/kio-extras-20.08.3/thumbnail/icoutils_win.cpp Examining data/kio-extras-20.08.3/thumbnail/windowsimagecreator.cpp Examining data/kio-extras-20.08.3/thumbnail/windowsimagecreator.h Examining data/kio-extras-20.08.3/thumbnail/imagefilter.cpp Examining data/kio-extras-20.08.3/thumbnail/opendocumentcreator.h Examining data/kio-extras-20.08.3/thumbnail/svgcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/comiccreator.cpp Examining data/kio-extras-20.08.3/thumbnail/icoutils_wrestool.cpp Examining data/kio-extras-20.08.3/thumbnail/imagecreator.h Examining data/kio-extras-20.08.3/thumbnail/windowsexecreator.h Examining data/kio-extras-20.08.3/thumbnail/appimagecreator.cpp Examining data/kio-extras-20.08.3/thumbnail/jpegcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/comiccreator.h Examining data/kio-extras-20.08.3/thumbnail/textcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/windowsexecreator.cpp Examining data/kio-extras-20.08.3/thumbnail/icoutils.h Examining data/kio-extras-20.08.3/thumbnail/cursorcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/kritacreator.h Examining data/kio-extras-20.08.3/thumbnail/imagecreator.cpp Examining data/kio-extras-20.08.3/thumbnail/ebookcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/exrcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/jpegcreator.h Examining data/kio-extras-20.08.3/thumbnail/cursorcreator.h Examining data/kio-extras-20.08.3/thumbnail/imagefilter.h Examining data/kio-extras-20.08.3/thumbnail/opendocumentcreator.cpp Examining data/kio-extras-20.08.3/thumbnail/svgcreator.h Examining data/kio-extras-20.08.3/thumbnail/textcreator.h Examining data/kio-extras-20.08.3/thumbnail/djvucreator.h Examining data/kio-extras-20.08.3/thumbnail/audiocreator.cpp Examining data/kio-extras-20.08.3/thumbnail/thumbnail.cpp Examining data/kio-extras-20.08.3/thumbnail/djvucreator.cpp Examining data/kio-extras-20.08.3/thumbnail/appimagecreator.h Examining data/kio-extras-20.08.3/thumbnail/icoutils_common.cpp Examining data/kio-extras-20.08.3/thumbnail/ebookcreator.h Examining data/kio-extras-20.08.3/thumbnail/thumbnail.h Examining data/kio-extras-20.08.3/thumbnail/exrcreator.h Examining data/kio-extras-20.08.3/thumbnail/audiocreator.h Examining data/kio-extras-20.08.3/thumbnail/kritacreator.cpp Examining data/kio-extras-20.08.3/activities/utils/d_ptr_implementation.h Examining data/kio-extras-20.08.3/activities/utils/qsqlquery_iterator.cpp Examining data/kio-extras-20.08.3/activities/utils/qsqlquery_iterator.h Examining data/kio-extras-20.08.3/activities/utils/d_ptr.h Examining data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPlugin.h Examining data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPlugin.cpp Examining data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPlugin_p.h Examining data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp Examining data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPluginActionLoader.h Examining data/kio-extras-20.08.3/activities/KioActivities.h Examining data/kio-extras-20.08.3/activities/common/database/schema/ResourcesDatabaseSchema.h Examining data/kio-extras-20.08.3/activities/common/database/schema/ResourcesDatabaseSchema.cpp Examining data/kio-extras-20.08.3/activities/common/database/Database.h Examining data/kio-extras-20.08.3/activities/common/database/Database.cpp Examining data/kio-extras-20.08.3/activities/common/dbus/common.h Examining data/kio-extras-20.08.3/activities/common/specialvalues.h Examining data/kio-extras-20.08.3/activities/KioActivities.cpp Examining data/kio-extras-20.08.3/sftp/kio_sftp.cpp Examining data/kio-extras-20.08.3/sftp/kio_sftp.h Examining data/kio-extras-20.08.3/settings/kio_settings.cpp Examining data/kio-extras-20.08.3/about/kio_about.cpp Examining data/kio-extras-20.08.3/about/kio_about.h Examining data/kio-extras-20.08.3/filenamesearch/kio_filenamesearch.cpp Examining data/kio-extras-20.08.3/filenamesearch/kio_filenamesearch.h Examining data/kio-extras-20.08.3/filenamesearch/kded/filenamesearchmodule.h Examining data/kio-extras-20.08.3/filenamesearch/kded/filenamesearchmodule.cpp Examining data/kio-extras-20.08.3/nfs/rpc_nfs3_prot_xdr.c Examining data/kio-extras-20.08.3/nfs/rpc_nfs2_prot.h Examining data/kio-extras-20.08.3/nfs/kio_nfs.h Examining data/kio-extras-20.08.3/nfs/rpc_nfs2_prot_xdr.c Examining data/kio-extras-20.08.3/nfs/kio_nfs.cpp Examining data/kio-extras-20.08.3/nfs/nfsv3.h Examining data/kio-extras-20.08.3/nfs/nfsv2.cpp Examining data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h Examining data/kio-extras-20.08.3/nfs/nfsv2.h Examining data/kio-extras-20.08.3/nfs/nfsv3.cpp Examining data/kio-extras-20.08.3/bookmarks/kio_bookmarks_pixmap.cpp Examining data/kio-extras-20.08.3/bookmarks/kio_bookmarks_html.cpp Examining data/kio-extras-20.08.3/bookmarks/kio_bookmarks.h Examining data/kio-extras-20.08.3/bookmarks/kio_bookmarks.cpp Examining data/kio-extras-20.08.3/man/request_hash.h Examining data/kio-extras-20.08.3/man/tests/kio_man_test.cpp Examining data/kio-extras-20.08.3/man/man2html.cpp Examining data/kio-extras-20.08.3/man/kio_man.h Examining data/kio-extras-20.08.3/man/kio_man.cpp Examining data/kio-extras-20.08.3/man/man2html.h Examining data/kio-extras-20.08.3/man/kio_man_debug.h Examining data/kio-extras-20.08.3/man/kio_man_debug.cpp Examining data/kio-extras-20.08.3/man/request_hash.cpp Examining data/kio-extras-20.08.3/recentdocuments/recentdocuments.cpp Examining data/kio-extras-20.08.3/recentdocuments/recentdocumentsnotifier.cpp Examining data/kio-extras-20.08.3/recentdocuments/recentdocumentsnotifier.h Examining data/kio-extras-20.08.3/recentdocuments/recentdocuments.h Examining data/kio-extras-20.08.3/fish/fish.cpp Examining data/kio-extras-20.08.3/fish/fish.h Examining data/kio-extras-20.08.3/fish/tests/copytester.h Examining data/kio-extras-20.08.3/fish/tests/main.cpp Examining data/kio-extras-20.08.3/fish/tests/copytester.cpp Examining data/kio-extras-20.08.3/info/info.h Examining data/kio-extras-20.08.3/info/info.cc Examining data/kio-extras-20.08.3/archive/kio_archive_debug.h Examining data/kio-extras-20.08.3/archive/kio_archive.cpp Examining data/kio-extras-20.08.3/archive/autotests/testkioarchive.cpp Examining data/kio-extras-20.08.3/archive/autotests/testkioarchive.h Examining data/kio-extras-20.08.3/archive/kio_archive.h Examining data/kio-extras-20.08.3/archive/kio_archivebase.cpp Examining data/kio-extras-20.08.3/archive/kio_archivebase.h Examining data/kio-extras-20.08.3/smb/smburl.cpp Examining data/kio-extras-20.08.3/smb/kio_smb_mount.cpp Examining data/kio-extras-20.08.3/smb/transfer.cpp Examining data/kio-extras-20.08.3/smb/autotests/transfertest.cpp Examining data/kio-extras-20.08.3/smb/autotests/smburltest.cpp Examining data/kio-extras-20.08.3/smb/discovery.cpp Examining data/kio-extras-20.08.3/smb/kio_smb_file.cpp Examining data/kio-extras-20.08.3/smb/smbcdiscoverer.h Examining data/kio-extras-20.08.3/smb/smbcdiscoverer.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/autotests/test_wsdiscoveryclient.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/examples/onvif-discover/main.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.h Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/examples/onvif-discover/onvifdiscover.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.h Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryserviceaggrigator.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryserviceaggrigator.h Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoverytargetservice.h Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryserviceaggrigator_p.h Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryprobejob.cpp Examining data/kio-extras-20.08.3/smb/kdsoap-ws-discovery-client/src/wsdiscoveryclient.h Examining data/kio-extras-20.08.3/smb/discovery.h Examining data/kio-extras-20.08.3/smb/kio_smb_auth.cpp Examining data/kio-extras-20.08.3/smb/main.cpp Examining data/kio-extras-20.08.3/smb/kio_smb.cpp Examining data/kio-extras-20.08.3/smb/kio_smb_dir.cpp Examining data/kio-extras-20.08.3/smb/wsdiscoverer.cpp Examining data/kio-extras-20.08.3/smb/kio_smb_config.cpp Examining data/kio-extras-20.08.3/smb/smburl.h Examining data/kio-extras-20.08.3/smb/kio_smb_browse.cpp Examining data/kio-extras-20.08.3/smb/dnssddiscoverer.h Examining data/kio-extras-20.08.3/smb/wsdiscoverer.h Examining data/kio-extras-20.08.3/smb/dnssddiscoverer.cpp Examining data/kio-extras-20.08.3/smb/transfer.h Examining data/kio-extras-20.08.3/smb/kio_smb.h FINAL RESULTS: data/kio-extras-20.08.3/fish/fish.cpp:1622:20: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void fishProtocol::chmod(const QUrl& u, int permissions){ data/kio-extras-20.08.3/fish/fish.h:68:8: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void chmod(const QUrl& url, int permissions) override; data/kio-extras-20.08.3/nfs/kio_nfs.cpp:232:16: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void NFSSlave::chmod(const QUrl& url, int permissions) data/kio-extras-20.08.3/nfs/kio_nfs.cpp:237:21: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. m_protocol->chmod(url, permissions); data/kio-extras-20.08.3/nfs/kio_nfs.h:62:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void chmod(const QUrl& url, int permissions) override; data/kio-extras-20.08.3/nfs/kio_nfs.h:165:18: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. virtual void chmod(const QUrl& url, int permissions) = 0; data/kio-extras-20.08.3/nfs/nfsv2.cpp:605:21: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void NFSProtocolV2::chmod(const QUrl& url, int permissions) data/kio-extras-20.08.3/nfs/nfsv2.h:53:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void chmod(const QUrl& url, int permissions) override; data/kio-extras-20.08.3/nfs/nfsv3.cpp:802:21: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void NFSProtocolV3::chmod(const QUrl& url, int permissions) data/kio-extras-20.08.3/nfs/nfsv3.h:53:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void chmod(const QUrl& url, int permissions) override; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2359:33: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. const auto result = chmod(url, permissions); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2454:22: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. Result SFTPInternal::chmod(const QUrl& url, int permissions) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2743:17: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void SFTPSlave::chmod(const QUrl &url, int permissions) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2745:17: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. finalize(d->chmod(url, permissions)); data/kio-extras-20.08.3/sftp/kio_sftp.h:86:30: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. Q_REQUIRED_RESULT Result chmod(const QUrl &url, int permissions); data/kio-extras-20.08.3/sftp/kio_sftp.h:260:10: [5] (race) chmod: This accepts filename arguments; if an attacker can move those files, a race condition results. (CWE-362). Use fchmod( ) instead. void chmod(const QUrl &url, int permissions) override; data/kio-extras-20.08.3/fish/fish.cpp:469:13: [4] (shell) execl: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execl(suPath, "su", "-", connectionUser.toLatin1().constData(), "-c", "cd ~;echo FISH:;exec /bin/sh -c \"if env true 2>/dev/null; then env PS1= PS2= TZ=UTC LANG=C LC_ALL=C LOCALE=C /bin/sh; else PS1= PS2= TZ=UTC LANG=C LC_ALL=C LOCALE=C /bin/sh; fi\"", (void *)nullptr); data/kio-extras-20.08.3/fish/fish.cpp:478:17: [4] (shell) execl: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execl(sshPath, "ssh", "-p", qPrintable(QString::number(connectionPort)), common_args); data/kio-extras-20.08.3/fish/fish.cpp:480:17: [4] (shell) execl: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execl(sshPath, "ssh", common_args); data/kio-extras-20.08.3/info/info.cc:9:9: [4] (shell) popen: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. #define popen _popen data/kio-extras-20.08.3/info/info.cc:121:18: [4] (shell) popen: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. FILE *file = popen( QFile::encodeName(cmd), "r" ); data/kio-extras-20.08.3/man/man2html.cpp:765:18: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (!access(str.data(), R_OK)) data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h:343:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. uint32 access; data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h:349:9: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. uint32 access; data/kio-extras-20.08.3/nfs/rpc_nfs3_prot_xdr.c:686:33: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (!xdr_uint32 (xdrs, &objp->access)) data/kio-extras-20.08.3/nfs/rpc_nfs3_prot_xdr.c:698:33: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (!xdr_uint32 (xdrs, &objp->access)) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:423:12: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. mode_t access; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:490:49: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. entry.fastInsert(KIO::UDSEntry::UDS_ACCESS, access); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2234:16: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. mode_t access; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2300:53: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. entry.fastInsert(KIO::UDSEntry::UDS_ACCESS, access); data/kio-extras-20.08.3/thumbnail/djvucreator.cpp:76:7: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(argv[0], const_cast<char *const *>(argv)); data/kio-extras-20.08.3/thumbnail/icoutils_win.cpp:84:9: [4] (buffer) lstrcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using a function version that stops copying at the end of the buffer. lstrcpy(copyString, lpszName); data/kio-extras-20.08.3/fish/fish.cpp:716:32: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if (user.isEmpty()) user = getenv("LOGNAME"); data/kio-extras-20.08.3/man/kio_man.cpp:785:30: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const QString sectList = getenv("MANSECT"); data/kio-extras-20.08.3/man/kio_man.cpp:921:12: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. if ( ::getenv("PATH") ) { data/kio-extras-20.08.3/man/kio_man.cpp:923:41: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. QString::fromLocal8Bit( ::getenv("PATH") ).split( ':', QString::SkipEmptyParts ); data/kio-extras-20.08.3/man/kio_man.cpp:978:59: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. const QString manpath_env = QString::fromLocal8Bit( ::getenv("MANPATH") ); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:257:44: [3] (buffer) getenv: Environment variables are untrustable input if they can be set by an attacker. They can have any content and length, and the same variable can be set more than once (CWE-807, CWE-20). Check environment variables carefully before using them. qCDebug(KIO_SFTP_LOG) << "debug = " << getenv("KIO_SFTP_LOG_VERBOSITY"); data/kio-extras-20.08.3/thumbnail/icoutils_win.cpp:103:15: [3] (misc) LoadLibraryEx: Ensure that the full path to the library is specified, or current directory may be used (CWE-829, CWE-20). Use registry entry or GetWindowsDirectory to find library path, if you aren't already. hModule = LoadLibraryEx ( fileName, 0, LOAD_LIBRARY_AS_DATAFILE ); data/kio-extras-20.08.3/activities/common/database/Database.cpp:92:29: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). m_open = m_database.open(); data/kio-extras-20.08.3/activities/fileitemplugin/FileItemLinkingPluginActionLoader.cpp:98:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (database.open()) { data/kio-extras-20.08.3/archive/autotests/testkioarchive.cpp:61:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). bool ok = tar.open( QIODevice::WriteOnly ); data/kio-extras-20.08.3/archive/kio_archivebase.cpp:165:26: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( !m_archiveFile->open( QIODevice::ReadOnly ) ) data/kio-extras-20.08.3/archive/kio_archivebase.cpp:506:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( !io->open( QIODevice::ReadOnly ) ) data/kio-extras-20.08.3/bookmarks/kio_bookmarks_pixmap.cpp:72:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). buffer.open(QIODevice::WriteOnly); data/kio-extras-20.08.3/filenamesearch/kio_filenamesearch.cpp:159:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) { data/kio-extras-20.08.3/filenamesearch/kio_filenamesearch.cpp:178:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (tempFile.open()) { data/kio-extras-20.08.3/filter/filter.cc:84:20: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!localFile.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/fish/fish.cpp:322:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). master = open("/dev/ptmx", O_RDWR); data/kio-extras-20.08.3/fish/fish.cpp:331:13: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). slave = open(name, O_RDWR); data/kio-extras-20.08.3/fish/fish.cpp:465:28: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (dev) ::close(::open(dev, O_WRONLY, 0)); data/kio-extras-20.08.3/fish/fish.cpp:494:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32768]; data/kio-extras-20.08.3/fish/fish.cpp:841:18: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static const char * const monthNames[12] = { data/kio-extras-20.08.3/fish/fish.cpp:1269:17: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(mimeBuffer.data()+dataRead,buffer,mimeSize); data/kio-extras-20.08.3/fish/fish.cpp:1423:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[32768]; data/kio-extras-20.08.3/info/info.cc:128:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buffer[ 4096 ]; data/kio-extras-20.08.3/man/kio_man.cpp:175:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!f.open(QIODevice::ReadOnly)) data/kio-extras-20.08.3/man/kio_man.cpp:432:24: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). m_outputBuffer.open(QIODevice::WriteOnly); data/kio-extras-20.08.3/man/kio_man.cpp:505:23: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). m_outputBuffer.open(QIODevice::WriteOnly); data/kio-extras-20.08.3/man/kio_man.cpp:594:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( !fd.open(QIODevice::ReadOnly)) data/kio-extras-20.08.3/man/kio_man.cpp:852:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (mc.open(QIODevice::ReadOnly)) data/kio-extras-20.08.3/man/man2html.cpp:187:7: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char NEWLINE[2] = "\n"; data/kio-extras-20.08.3/man/man2html.cpp:676:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. const char temp[3] = { char(nr / 256), char(nr % 256), 0 }; data/kio-extras-20.08.3/man/man2html.cpp:682:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char outbuffer[NULL_TERMINATED(HUGE_STR_MAX)]; data/kio-extras-20.08.3/man/man2html.cpp:729:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *idtest[numtests]; // url, mailto, www, ftp, manpage, C header file data/kio-extras-20.08.3/man/man2html.cpp:1075:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(h, buffer, buffmax); data/kio-extras-20.08.3/man/man2html.cpp:2416:8: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. static char itemreset[20] = "\\fR\\s0"; data/kio-extras-20.08.3/man/man2html.cpp:3455:56: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). static char* process_quote(char* c, int j, const char* open, const char* close) data/kio-extras-20.08.3/man/man2html.cpp:3460:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). out_html(open); data/kio-extras-20.08.3/man/man2html.cpp:5053:11: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buff[NULL_TERMINATED(MED_STR_MAX)]; data/kio-extras-20.08.3/man/man2html.cpp:5752:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[4] = { c[0], c[1], ' ', 0 }; data/kio-extras-20.08.3/man/man2html.cpp:6250:12: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( !fd.open(QIODevice::ReadOnly) ) data/kio-extras-20.08.3/mtp/kio_mtp.cpp:454:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (temp.open()) { data/kio-extras-20.08.3/mtp/kio_mtp.cpp:573:30: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!srcFile.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/mtp/kio_mtp.cpp:640:31: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!destFile.open(QIODevice::Truncate | QIODevice::WriteOnly)) { data/kio-extras-20.08.3/nfs/kio_nfs.cpp:351:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(fh.data, m_handle, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:362:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(fh.data, m_linkHandle, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:375:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_handle, src.m_handle, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:385:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_linkHandle, src.m_linkHandle, m_linkSize); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:402:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_handle, src.fhandle3_val, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:416:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_handle, src, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:430:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_handle, src.data.data_val, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:444:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_handle, src.data, m_size); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:458:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_linkHandle, src.data.data_val, m_linkSize); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:471:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(m_linkHandle, src.data, m_linkSize); data/kio-extras-20.08.3/nfs/kio_nfs.cpp:617:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&server_addr.sin_addr, hp->h_addr, hp->h_length); data/kio-extras-20.08.3/nfs/nfsv2.cpp:160:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dataBuffer[NFS_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:351:13: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(listargs.cookie, lastEntry->cookie, NFS_COOKIESIZE); data/kio-extras-20.08.3/nfs/nfsv2.cpp:391:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:488:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:651:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[NFS_MAXDATA]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:842:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:919:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[NFS_MAXDATA]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:1065:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:1116:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!destFile.open(openMode)) { data/kio-extras-20.08.3/nfs/nfsv2.cpp:1135:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[NFS_MAXDATA]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:1309:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!srcFile.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/nfs/nfsv2.cpp:1345:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[NFS_MAXDATA]; data/kio-extras-20.08.3/nfs/nfsv2.cpp:1747:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&sAttrArgs.attributes, &attributes, sizeof(attributes)); data/kio-extras-20.08.3/nfs/nfsv3.cpp:173:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dataBuffer[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:408:17: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:573:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:673:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:1087:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:1316:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char nameBuf[NFS3_MAXPATHLEN]; data/kio-extras-20.08.3/nfs/nfsv3.cpp:1374:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!destFile.open(openMode)) { data/kio-extras-20.08.3/nfs/nfsv3.cpp:1563:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!srcFile.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/nfs/nfsv3.cpp:2055:5: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(&setAttrArgs.new_attributes, &attributes, sizeof(attributes)); data/kio-extras-20.08.3/nfs/rpc_nfs2_prot.h:105:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char data[NFS_FHSIZE]; data/kio-extras-20.08.3/nfs/rpc_nfs2_prot.h:251:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char nfscookie[NFS_COOKIESIZE]; data/kio-extras-20.08.3/nfs/rpc_nfs2_prot.h:302:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char fhandle[FHSIZE]; data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h:50:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char cookieverf3[NFS3_COOKIEVERFSIZE]; data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h:52:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char createverf3[NFS3_CREATEVERFSIZE]; data/kio-extras-20.08.3/nfs/rpc_nfs3_prot.h:54:9: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. typedef char writeverf3[NFS3_WRITEVERFSIZE]; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:1334:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). Result SFTPInternal::open(const QUrl &url, QIODevice::OpenMode mode) { data/kio-extras-20.08.3/sftp/kio_sftp.cpp:1568:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char mimeTypeBuf[1024]; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:1745:13: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_XFER_BUF_SIZE]; // data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2084:35: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!receivedFile.open(QIODevice::ReadWrite | QIODevice::Text)) { data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2182:25: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). const auto result = open(url, QIODevice::ReadOnly); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2610:5: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[MAX_XFER_BUF_SIZE]; data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2778:17: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). void SFTPSlave::open(const QUrl &url, QIODevice::OpenMode mode) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2780:28: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). const auto result = d->open(url, mode); data/kio-extras-20.08.3/sftp/kio_sftp.h:93:30: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). Q_REQUIRED_RESULT Result open(const QUrl &url, QIODevice::OpenMode mode); data/kio-extras-20.08.3/sftp/kio_sftp.h:268:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). void open(const QUrl &url, QIODevice::OpenMode mode) override; data/kio-extras-20.08.3/smb/kio_smb.h:218:10: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). void open(const QUrl &kurl, QIODevice::OpenMode mode) override; data/kio-extras-20.08.3/smb/kio_smb_dir.cpp:226:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!file.open(mode)) { data/kio-extras-20.08.3/smb/kio_smb_dir.cpp:403:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!srcFile.open(QFile::ReadOnly)) { data/kio-extras-20.08.3/smb/kio_smb_file.cpp:119:16: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). void SMBSlave::open(const QUrl &kurl, QIODevice::OpenMode mode) data/kio-extras-20.08.3/thumbnail/comiccreator.cpp:134:20: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!cArchive->open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/thumbnail/ebookcreator.cpp:54:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!file.open(QIODevice::ReadOnly | QIODevice::Text)) { data/kio-extras-20.08.3/thumbnail/ebookcreator.cpp:62:18: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!zip.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/thumbnail/ebookcreator.cpp:91:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!zip.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/thumbnail/icoutils_common.cpp:53:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( ! inputFile.open() ) data/kio-extras-20.08.3/thumbnail/icoutils_common.cpp:68:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!iconData.open(QIODevice::ReadWrite)) { data/kio-extras-20.08.3/thumbnail/icoutils_win.cpp:141:19: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). outBuffer.open(QIODevice::ReadWrite); data/kio-extras-20.08.3/thumbnail/kritacreator.cpp:52:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!zip.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/thumbnail/opendocumentcreator.cpp:47:14: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!zip.open(QIODevice::ReadOnly)) { data/kio-extras-20.08.3/thumbnail/textcreator.cpp:115:15: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if ( file.open( QIODevice::ReadOnly )) data/kio-extras-20.08.3/thumbnail/thumbnail.cpp:316:22: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!buf.open(QIODevice::WriteOnly)) { data/kio-extras-20.08.3/thumbnail/thumbnail.cpp:356:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(shmaddr, img.bits(), img.sizeInBytes()); data/kio-extras-20.08.3/thumbnail/thumbnail.cpp:358:9: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(shmaddr, img.bits(), img.byteCount()); data/kio-extras-20.08.3/thumbnail/thumbnail.cpp:734:35: [2] (misc) open: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (thumbnailfile.open(QIODevice::WriteOnly | QIODevice::Truncate)) { data/kio-extras-20.08.3/archive/kio_archivebase.cpp:542:33: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). const qint64 read = io->read( buffer.data(), buffer.size() ); // Avoid to use bufferSize here, in case something went wrong. data/kio-extras-20.08.3/archive/kio_archivebase.cpp:543:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( read != bufferSize ) data/kio-extras-20.08.3/archive/kio_archivebase.cpp:545:53: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). qCWarning(KIO_ARCHIVE_LOG) << "Read" << read << "bytes but expected" << bufferSize ; data/kio-extras-20.08.3/archive/kio_archivebase.cpp:561:22: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). processed += read; data/kio-extras-20.08.3/filter/filter.cc:119:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). result = localFile.read(inputBuffer.data(), inputBuffer.size()); data/kio-extras-20.08.3/filter/filter.cc:179:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). result = localFile.read(inputBuffer.data(), inputBuffer.size()); data/kio-extras-20.08.3/fish/fish.cpp:266:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). fishCodeLen = strlen(fishCode); data/kio-extras-20.08.3/fish/fish.cpp:531:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = ::read(childFd, buf + offset, sizeof(buf) - offset); data/kio-extras-20.08.3/fish/fish.cpp:1480:24: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = ::read(childFd, buf + offset, sizeof(buf) - offset); data/kio-extras-20.08.3/fish/fish.cpp:1483:32: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). rc = childPid->read(buf + offset, sizeof(buf) - offset); data/kio-extras-20.08.3/man/kio_man.cpp:425:37: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). m_outputBuffer.write(insert,strlen(insert)); data/kio-extras-20.08.3/man/kio_man.cpp:1203:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). int len = strlen( begin ); data/kio-extras-20.08.3/nfs/nfsv2.cpp:1365:29: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytesRead = srcFile.read(writeArgs.data.data_val, NFS_MAXDATA); data/kio-extras-20.08.3/nfs/nfsv3.cpp:882:71: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). readBuffer.setRawData(readRes.READ3res_u.resok.data.data_val, read); data/kio-extras-20.08.3/nfs/nfsv3.cpp:892:28: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). readArgs.offset += read; data/kio-extras-20.08.3/nfs/nfsv3.cpp:893:13: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if (read > 0) { data/kio-extras-20.08.3/nfs/nfsv3.cpp:900:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). } while (read > 0); data/kio-extras-20.08.3/nfs/nfsv3.cpp:1623:29: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). bytesRead = srcFile.read(writeArgs.data.data_val, m_writeBufferSize); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:239:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(buf, mPublicKeyAuthInfo->password.toUtf8().constData(), len - 1); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:1427:22: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). Result SFTPInternal::read(KIO::filesize_t bytes) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:1746:24: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). result = ::read(fd, buf, sizeof(buf)); data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2788:17: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). void SFTPSlave::read(filesize_t size) data/kio-extras-20.08.3/sftp/kio_sftp.cpp:2790:19: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). maybeError(d->read(size)); data/kio-extras-20.08.3/sftp/kio_sftp.h:94:30: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). Q_REQUIRED_RESULT Result read(KIO::filesize_t size); data/kio-extras-20.08.3/sftp/kio_sftp.h:269:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). void read(KIO::filesize_t size) override; data/kio-extras-20.08.3/smb/kio_smb.h:219:10: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). void read(KIO::filesize_t bytesRequested) override; data/kio-extras-20.08.3/smb/kio_smb_auth.cpp:89:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(username, info.username.toUtf8(), static_cast<size_t>(unmaxlen - 1)); data/kio-extras-20.08.3/smb/kio_smb_auth.cpp:90:5: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(password, info.password.toUtf8(), static_cast<size_t>(pwmaxlen - 1)); data/kio-extras-20.08.3/smb/kio_smb_auth.cpp:97:9: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). strncpy(workgroup, domain.toUtf8(), static_cast<size_t>(wgmaxlen - 1)); data/kio-extras-20.08.3/smb/kio_smb_dir.cpp:499:47: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). const ssize_t bytesRead = srcFile.read(segment.buf.data(), segment.buf.size()); data/kio-extras-20.08.3/smb/kio_smb_file.cpp:219:16: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). void SMBSlave::read(KIO::filesize_t bytesRequested) data/kio-extras-20.08.3/thumbnail/djvucreator.cpp:96:23: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int count = read(output[0], data.data() + offset, 1024); data/kio-extras-20.08.3/thumbnail/icoutils_common.cpp:91:24: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). do icons << reader.read(); data/kio-extras-20.08.3/thumbnail/imagecreator.cpp:38:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). img = ir.read(); data/kio-extras-20.08.3/thumbnail/jpegcreator.cpp:56:24: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). return imageReader.read(&image); data/kio-extras-20.08.3/thumbnail/textcreator.cpp:124:25: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). int read = file.read( m_data, bytesToRead ); data/kio-extras-20.08.3/thumbnail/textcreator.cpp:125:14: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). if ( read > 0 ) data/kio-extras-20.08.3/thumbnail/textcreator.cpp:128:20: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). m_data[read] = '\0'; data/kio-extras-20.08.3/thumbnail/textcreator.cpp:129:54: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). QString text = codecFromContent( m_data, read )->toUnicode( m_data, read ).trimmed(); data/kio-extras-20.08.3/thumbnail/textcreator.cpp:129:81: [1] (buffer) read: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). QString text = codecFromContent( m_data, read )->toUnicode( m_data, read ).trimmed(); ANALYSIS SUMMARY: Hits = 182 Lines analyzed = 47032 in approximately 3.60 seconds (13066 lines/second) Physical Source Lines of Code (SLOC) = 33647 Hits@level = [0] 11 [1] 40 [2] 103 [3] 7 [4] 16 [5] 16 Hits@level+ = [0+] 193 [1+] 182 [2+] 142 [3+] 39 [4+] 32 [5+] 16 Hits/KSLOC@level+ = [0+] 5.73602 [1+] 5.4091 [2+] 4.22029 [3+] 1.15909 [4+] 0.951051 [5+] 0.475525 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.