Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/FileUtils.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/Socket.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/Socket.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/Buffer.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/Buffer.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/ClientTimeshift.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/ClientTimeshift.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/DummyBuffer.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/DummyBuffer.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/Seeker.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/Seeker.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/buffers/session.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/client.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/client.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/md5.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/os-dependent.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.h
Examining data/kodi-pvr-nextpvr-3.3.18/src/uri.cpp
Examining data/kodi-pvr-nextpvr-3.3.18/src/uri.h
FINAL RESULTS:
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.h:42:34: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
void setSID(char *newsid) {strcpy(m_sid,newsid);};
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.cpp:90:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(strDirectory,recording.strDirectory);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.cpp:121:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(recording.strDirectory, m_activeFilename.c_str());
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.cpp:126:5: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(strURL,TESTURL);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:244:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request, "/service?method=session.login&sid=%s&md5=%s", m_sid, md5.c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:940:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tag.strGroupName,group.c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:986:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request, "/service?method=channel.list&group_id=%s", encodedGroupName.c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1174:7: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tag->strIconPath,GetChannelIconFileName(tag->iChannelUid).c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1233:11: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(tag->strEpisodeName,base_sub_match.str().c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1251:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request, "/service?method=recording.delete&recording_id=%s", recording.strRecordingId);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1273:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request, "/service?method=recording.watched.set&recording_id=%s&position=%d", recording.strRecordingId, lastplayedposition);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1299:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(request, "/service?method=recording.edl&recording_id=%s", recording.strRecordingId);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2134:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(line, "GET /live?channeloid=%d&mode=liveshift&client=XBMC-%s HTTP/1.0\r\n", channelinfo.iUniqueId, m_sid);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2139:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(line, "http://%s:%d/live?channeloid=%d&client=XBMC-%s&epgmode=true", g_szHostname.c_str(), g_iPort, channelinfo.iUniqueId, m_sid);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2144:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(line, "http://%s:%d/live?channeloid=%d&client=%s&sid=%s", g_szHostname.c_str(), g_iPort, channelinfo.iUniqueId, m_sid,m_sid);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2150:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(line, "http://%s:%d/live?channeloid=%d&client=XBMC-%s", g_szHostname.c_str(), g_iPort, channelinfo.iUniqueId, m_sid);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2253:3: [4] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused).
strcpy(copyRecording.strDirectory,m_hostFilenames[recording.strRecordingId].c_str());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2438:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s%s: value=[%s]", pIndent, pAttrib->Name(), pAttrib->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2466:3: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf, "%s", getIndent(indent));
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2478:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf + strlen(buf), "Element [%s]", pParent->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2488:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf + strlen(buf), "%s1 attribute", getIndentAlt(indent));
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2492:9: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf + strlen(buf), "%s%d attributes", getIndentAlt(indent), num);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2499:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf + strlen(buf), "Comment: [%s]", pParent->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2510:5: [4] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf.
sprintf(buf + strlen(buf), "Text: [%s]", pText->Value());
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp:34:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[1024];
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp:46:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp:69:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[1024];
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp:82:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.cpp:103:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[1024];
data/kodi-pvr-nextpvr-3.3.18/src/BackendRequest.h:50:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_sid[64];
data/kodi-pvr-nextpvr-3.3.18/src/Socket.cpp:328:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[2048];
data/kodi-pvr-nextpvr-3.3.18/src/Socket.cpp:417:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[MAXRECV + 1];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:41:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m_cBuffer + m_iWritePos, buffer, chunk);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:42:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m_cBuffer, buffer + chunk, length - chunk);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:47:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(m_cBuffer + m_iWritePos, buffer, length);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:62:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, m_cBuffer + m_iReadPos, chunk);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:63:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer + chunk, m_cBuffer, length - chunk);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/CircularBuffer.cpp:68:5: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(buffer, m_cBuffer + m_iReadPos, length);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.cpp:89:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strDirectory [PVR_ADDON_URL_STRING_LENGTH];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.cpp:99:11: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(strDirectory,"smb://");
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.cpp:124:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[1024];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RollingFile.cpp:132:7: [2] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant string.
strcat(strURL,"&bufsize=32768&wait=true");
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:92:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:94:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(line, "Connection: close\r\n");
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:97:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(line, "\r\n");
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:103:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:120:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char header[256];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:124:9: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(header, buf, i);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:341:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[48];
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:391:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char response[128];
data/kodi-pvr-nextpvr-3.3.18/src/client.cpp:143:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buffer[1024];
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:52:44: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void PVRXBMC::XBMC_MD5::getDigest(unsigned char digest[16])
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:59:12: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char szBuf[16] = {'\0'};
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:158:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((md5byte *)ctx->in + 64 - t, buf, len);
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:162:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy((md5byte *)ctx->in + 64 - t, buf, t);
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:170:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, 64);
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:178:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(ctx->in, buf, len);
data/kodi-pvr-nextpvr-3.3.18/src/md5.cpp:213:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(digest, ctx->buf, 16);
data/kodi-pvr-nextpvr-3.3.18/src/md5.h:43:29: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
void getDigest(unsigned char digest[16]);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:78:7: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char SAFE[256] =
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:104:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
const char DEC2HEX[16 + 1] = "0123456789ABCDEF";
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:220:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char salt[64];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:243:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:268:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
version = atoi(versionNode->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:299:46: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
g_timeShiftBufferSeconds = atoi(settingsDoc.RootElement()->FirstChildElement("SlipSeconds")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:334:42: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_iDefaultPrePadding = atoi(settingsDoc.RootElement()->FirstChildElement("PrePadding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:335:43: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
m_iDefaultPostPadding = atoi( settingsDoc.RootElement()->FirstChildElement("PostPadding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:348:56: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
g_ServerTimeOffset = time(nullptr) - atoi(settingsDoc.RootElement()->FirstChildElement("TimeEpoch")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:353:19: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char rawMAC[13];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:357:21: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char mac[18];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:358:21: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(mac,"%2.2s:%2.2s:%2.2s:%2.2s:%2.2s:%2.2s",rawMAC,&rawMAC[2],&rawMAC[4],&rawMAC[6],&rawMAC[8],&rawMAC[10]);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:411:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:412:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(request, "/service?method=recording.lastupdated");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:568:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:575:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(request, "/service?method=channel.listings&channel_id=%d&start=%d&end=%d", channel.iUniqueId, (int)iStart, (int)iEnd);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:619:29: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iYear = atoi(pListingNode->FirstChildElement("year")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:627:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char start[32];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:631:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char end[32];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:635:41: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iUniqueBroadcastId = atoi(pListingNode->FirstChildElement("id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:639:41: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.startTime = atol(start);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:640:41: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.endTime = atol(end);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:650:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char artworkPath[128];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:658:9: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char genre[128];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:671:36: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iGenreType = atoi(pListingNode->FirstChildElement("genre_type")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:677:39: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iGenreSubType = atoi(pListingNode->FirstChildElement("genre_subtype")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:683:37: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iSeriesNumber = atoi(pListingNode->FirstChildElement("season")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:692:38: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
broadcast.iEpisodeNumber = atoi(pListingNode->FirstChildElement("episode")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:755:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[256];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:756:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(strURL, "/service?method=channel.icon&channel_id=%d", channelID);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:767:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char filename[64];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:776:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char strURL[256];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:777:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(strURL, "/public/LiveStreams.xml");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:836:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iUniqueId = atoi(pChannelNode->FirstChildElement("id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:851:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iChannelNumber = atoi(pChannelNode->FirstChildElement("number")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:856:35: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iSubChannelNumber = atoi(pChannelNode->FirstChildElement("minor")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:985:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1002:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iChannelUniqueId = atoi(pChannelNode->FirstChildElement("id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1003:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iChannelNumber = atoi(pChannelNode->FirstChildElement("number")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1089:24: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->recordingTime = atol(pRecordingNode->FirstChildElement("start_time_ticks")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1097:20: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iDuration = atoi(pRecordingNode->FirstChildElement("duration_seconds")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1134:11: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
if (atoi(pRecordingNode->FirstChildElement("recurring_parent")->FirstChild()->Value()) != 0 && pRecordingNode->FirstChildElement("epg_event_oid") != NULL && pRecordingNode->FirstChildElement("epg_event_oid")->FirstChild() != NULL)
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1136:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iEpgEventId = atoi(pRecordingNode->FirstChildElement("epg_event_oid")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1141:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iEpgEventId = atoi(pRecordingNode->FirstChildElement("epg_event_oid")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1162:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iLastPlayedPosition = atoi(pRecordingNode->FirstChildElement("playback_position")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1167:24: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iChannelUid = atoi(pRecordingNode->FirstChildElement("channel_id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1207:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char artworkPath[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1247:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1272:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1298:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1315:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
entry.start = atoi(pCommercialNode->FirstChildElement("start")->FirstChild()->Value()) * 1000;
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1316:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
entry.end = atoi(pCommercialNode->FirstChildElement("end")->FirstChild()->Value()) * 1000 ;
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1409:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iClientIndex = atoi(pRecurringNode->FirstChildElement("id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1410:33: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iClientChannelUid = atoi(pRulesNode->FirstChildElement("ChannelOID")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1417:27: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.startTime = atol(pRulesNode->FirstChildElement("StartTimeTicks")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1424:27: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.endTime = atol(pRulesNode->FirstChildElement("EndTimeTicks")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1468:30: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iMarginStart = atoi(pRulesNode->FirstChildElement("PrePadding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1469:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iMarginEnd = atoi(pRulesNode->FirstChildElement("PostPadding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1475:32: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag.iMaxRecordings = atoi(pRulesNode->FirstChildElement("Keep")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1574:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iClientIndex = atoi(pRecordingNode->FirstChildElement("id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1575:28: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iClientChannelUid = atoi(pRecordingNode->FirstChildElement("channel_id")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1579:31: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iParentClientIndex = atoi(pRecordingNode->FirstChildElement("recurring_parent")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1593:22: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iEpgUid = atoi(pRecordingNode->FirstChildElement("epg_event_oid")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1601:25: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iMarginStart = atoi(pRecordingNode->FirstChildElement("pre_padding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1607:23: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->iMarginEnd = atoi(pRecordingNode->FirstChildElement("post_padding")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1620:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char start[32];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1623:30: [2] (integer) atol:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->startTime = atol(start);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1624:47: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
tag->endTime = tag->startTime + atoi(pRecordingNode->FirstChildElement("duration_seconds")->FirstChild()->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1950:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[1024];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1952:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char preventDuplicates[16];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1955:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(preventDuplicates, "true");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1957:5: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(preventDuplicates, "false");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2080:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char request[512];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2082:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(request, "/service?method=recording.delete&recording_id=%d", timer.iClientIndex);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2087:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(request, "/service?method=recording.recurring.delete&recurring_id=%d", timer.iClientIndex);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2117:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[256];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2251:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char line[1024];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2437:5: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[1024];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2443:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), " int=%d", ival);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2448:7: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), " d=%1.1f", dval);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2462:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char buf[2048];
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2473:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), "Document");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2484:9: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), " (No attributes)");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2504:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), "Unknown");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2515:5: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf(buf + strlen(buf), "Declaration");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.h:189:3: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char m_sid[64];
data/kodi-pvr-nextpvr-3.3.18/src/Socket.cpp:461:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(50000);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/Buffer.h:38:19: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
#define SLEEP(ms) usleep(ms*1000)
data/kodi-pvr-nextpvr-3.3.18/src/buffers/RecordingBuffer.cpp:93:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for(; i <= strlen(recording.strDirectory); i++, j++)
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:90:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m_streamingclient->send(inputUrl.c_str(), strlen(inputUrl.c_str()));
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:95:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m_streamingclient->send(line, strlen(line));
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:98:33: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
m_streamingclient->send(line, strlen(line));
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:106:7: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (read < 0)
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:109:19: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
for (int i=0; i<read; i++)
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:412:9: [1] (obsolete) usleep:
This C routine is considered obsolete (as opposed to the shell command by
the same name). The interaction of this function with SIGALRM and other
timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is
unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead.
usleep(50000);
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:549:14: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
uint32_t read;
data/kodi-pvr-nextpvr-3.3.18/src/buffers/TimeshiftBuffer.cpp:554:29: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
if (WriteData(buffer, read, blockNo))
data/kodi-pvr-nextpvr-3.3.18/src/client.h:85:39: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
#define PVR_STRCPY(dest, source) do { strncpy(dest, source, sizeof(dest)-1); dest[sizeof(dest)-1] = '\0'; } while(0)
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:355:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (strlen(rawMAC)==12)
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:628:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(start, pListingNode->FirstChildElement("start")->FirstChild()->Value(), sizeof start);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:632:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(end, pListingNode->FirstChildElement("end")->FirstChild()->Value(), sizeof end);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:961:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(properties[0].strName, PVR_STREAM_PROPERTY_STREAMURL, sizeof(properties[0].strName) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:962:5: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(properties[0].strValue,m_liveStreams[channel.iUniqueId].c_str(), sizeof(properties[0].strValue) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1001:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tag.strGroupName, group.strGroupName, sizeof(tag.strGroupName));
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1439:13: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(tag.strEpgSearchString, &advancedRulesText.c_str()[9], sizeof(tag.strEpgSearchString) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1621:3: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(start, pRecordingNode->FirstChildElement("start_time_ticks")->FirstChild()->Value(), sizeof start);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1668:7: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(strDescription, description.c_str(), sizeof(strDescription)-1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1674:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(maxRecordings[i].strDescription, it->second.c_str(), sizeof(maxRecordings[i].strDescription) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1681:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(preventDuplicateEpisodes[i].strDescription, it->second.c_str(), sizeof(preventDuplicateEpisodes[i].strDescription) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:1688:9: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy(recordingGroup[i].strDescription, it->second.c_str(), sizeof(recordingGroup[i].strDescription) - 1);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2407:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
static const unsigned int LENGTH=strlen( pINDENT );
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2418:36: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
static const unsigned int LENGTH=strlen( pINDENT );
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2443:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), " int=%d", ival);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2448:21: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), " d=%1.1f", dval);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2473:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Document");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2478:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Element [%s]", pParent->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2484:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), " (No attributes)");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2488:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "%s1 attribute", getIndentAlt(indent));
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2492:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "%s%d attributes", getIndentAlt(indent), num);
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2499:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Comment: [%s]", pParent->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2504:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Unknown");
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2510:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Text: [%s]", pText->Value());
data/kodi-pvr-nextpvr-3.3.18/src/pvrclient-nextpvr.cpp:2515:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
sprintf(buf + strlen(buf), "Declaration");
ANALYSIS SUMMARY:
Hits = 182
Lines analyzed = 8358 in approximately 0.68 seconds (12341 lines/second)
Physical Source Lines of Code (SLOC) = 6105
Hits@level = [0] 26 [1] 37 [2] 121 [3] 0 [4] 24 [5] 0
Hits@level+ = [0+] 208 [1+] 182 [2+] 145 [3+] 24 [4+] 24 [5+] 0
Hits/KSLOC@level+ = [0+] 34.0704 [1+] 29.8116 [2+] 23.751 [3+] 3.9312 [4+] 3.9312 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.