Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/kuvert-2.2.2/kuvert_submit.c FINAL RESULTS: data/kuvert-2.2.2/kuvert_submit.c:41:57: [4] (format) fprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. #define BAILOUT(a,...) {fprintf(stderr,"%s: ",argv[0]); fprintf(stderr, a "\n",##__VA_ARGS__);syslog(LOG_ERR,a,##__VA_ARGS__); exit(1);} data/kuvert-2.2.2/kuvert_submit.c:41:95: [4] (format) syslog: If syslog's format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant format string for syslog. #define BAILOUT(a,...) {fprintf(stderr,"%s: ",argv[0]); fprintf(stderr, a "\n",##__VA_ARGS__);syslog(LOG_ERR,a,##__VA_ARGS__); exit(1);} data/kuvert-2.2.2/kuvert_submit.c:145:7: [4] (shell) execv: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execv(FALLBACKMTA,argv); data/kuvert-2.2.2/kuvert_submit.c:203:14: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((c=getopt(argc,argv,"f:t"))!=-1) data/kuvert-2.2.2/kuvert_submit.c:47:4: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char filen[256],buffer[BUFLEN],dirn[256]; data/kuvert-2.2.2/kuvert_submit.c:81:16: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(cf=fopen(filen,"r"))) data/kuvert-2.2.2/kuvert_submit.c:190:14: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). if (!(out=fopen(filen,"a"))) data/kuvert-2.2.2/kuvert_submit.c:116:13: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(dirnp)<2) data/kuvert-2.2.2/kuvert_submit.c:136:15: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). spaceleft-=strlen(argv[c++])) data/kuvert-2.2.2/kuvert_submit.c:140:3: [1] (buffer) strncat: Easily used incorrectly (e.g., incorrectly computing the correct maximum size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf, or automatically resizing strings. strncat(buffer,argv[c],spaceleft); data/kuvert-2.2.2/kuvert_submit.c:141:30: [1] (buffer) strcat: Does not check for buffer overflows when concatenating to destination [MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or snprintf (warning: strncat is easily misused). Risk is low because the source is a constant character. --spaceleft && c<argc-1 && strcat(buffer," "); data/kuvert-2.2.2/kuvert_submit.c:184:4: [1] (access) umask: Ensure that umask is given most restrictive possible setting (e.g., 066 or 077) (CWE-732). umask(066); /* absolutely no access for group/others... */ ANALYSIS SUMMARY: Hits = 12 Lines analyzed = 249 in approximately 0.04 seconds (6149 lines/second) Physical Source Lines of Code (SLOC) = 177 Hits@level = [0] 11 [1] 5 [2] 3 [3] 1 [4] 3 [5] 0 Hits@level+ = [0+] 23 [1+] 12 [2+] 7 [3+] 4 [4+] 3 [5+] 0 Hits/KSLOC@level+ = [0+] 129.944 [1+] 67.7966 [2+] 39.548 [3+] 22.5989 [4+] 16.9492 [5+] 0 Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.