Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/lcab-1.0b12/cdata.c Examining data/lcab-1.0b12/cdata.h Examining data/lcab-1.0b12/cfile.c Examining data/lcab-1.0b12/cfile.h Examining data/lcab-1.0b12/cfolder.c Examining data/lcab-1.0b12/cfolder.h Examining data/lcab-1.0b12/cheader.c Examining data/lcab-1.0b12/cheader.h Examining data/lcab-1.0b12/checksum.c Examining data/lcab-1.0b12/checksum.h Examining data/lcab-1.0b12/cstruct.h Examining data/lcab-1.0b12/cwrite.c Examining data/lcab-1.0b12/cwrite.h Examining data/lcab-1.0b12/main.c Examining data/lcab-1.0b12/warn.c Examining data/lcab-1.0b12/warn.h Examining data/lcab-1.0b12/mytypes.h FINAL RESULTS: data/lcab-1.0b12/cfile.c:42:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy(cf->name, filename); data/lcab-1.0b12/main.c:271:2: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy( outputfile, argv[argc - 1]); data/lcab-1.0b12/warn.c:15:9: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, fmt, ap); data/lcab-1.0b12/main.c:214:16: [3] (buffer) getopt: Some older implementations do not protect against internal buffer overflows (CWE-120, CWE-20). Check implementation on installation, or limit the size of all string inputs. while ((opt = getopt(argc, argv, "nrhq")) != EOF) { data/lcab-1.0b12/main.c:43:1: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *inputfiles[MAXINPUTFILES]; data/lcab-1.0b12/main.c:55:20: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). FILE *fp = fopen(filename,"rb"); data/lcab-1.0b12/main.c:117:9: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp2 = fopen( inputfiles[i], "rb" ); data/lcab-1.0b12/main.c:158:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char buf[FILENAME_MAX]; data/lcab-1.0b12/main.c:378:10: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fptmp = fopen( "lcab.tmp", "wb" ); data/lcab-1.0b12/main.c:386:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen( outputfile, "wb" ); data/lcab-1.0b12/main.c:406:11: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fptmp = fopen( "lcab.tmp", "rb" ); data/lcab-1.0b12/cfile.c:43:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). cf->name[strlen(filename)] = STRINGTERM; data/lcab-1.0b12/cwrite.c:70:40: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if(!fwrite((char *) &cf->name, strlen(cf->name)+1, 1, fpout)) error=1; data/lcab-1.0b12/main.c:61:15: [1] (buffer) fgetc: Check buffer boundaries if used in a loop including recursive loops (CWE-120, CWE-20). while(fgetc(fp)!=EOF) data/lcab-1.0b12/main.c:97:25: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). tmp = (char *) calloc( strlen(filename)+1, sizeof(char) ); data/lcab-1.0b12/main.c:98:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for( i=0; i<strlen(filename); ++i ) data/lcab-1.0b12/main.c:291:14: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). mysize2 += strlen( makenopath? strippath( inputfiles[i] ) : changepath( inputfiles[i] ) ) + 1; /* + 1 for \0 ! */ data/lcab-1.0b12/main.c:298:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). offsetdata += 16 + strlen( makenopath ? strippath( inputfiles[i] ) : changepath( inputfiles[i] ) ) + 1; ANALYSIS SUMMARY: Hits = 18 Lines analyzed = 1162 in approximately 0.06 seconds (19860 lines/second) Physical Source Lines of Code (SLOC) = 680 Hits@level = [0] 50 [1] 7 [2] 7 [3] 1 [4] 3 [5] 0 Hits@level+ = [0+] 68 [1+] 18 [2+] 11 [3+] 4 [4+] 3 [5+] 0 Hits/KSLOC@level+ = [0+] 100 [1+] 26.4706 [2+] 16.1765 [3+] 5.88235 [4+] 4.41176 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.