Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libavc1394-0.5.4/common/raw1394util.c Examining data/libavc1394-0.5.4/common/raw1394util.h Examining data/libavc1394-0.5.4/librom1394/rom1394_main.c Examining data/libavc1394-0.5.4/librom1394/rom1394_internal.h Examining data/libavc1394-0.5.4/librom1394/rom1394.h Examining data/libavc1394-0.5.4/librom1394/rom1394_internal.c Examining data/libavc1394-0.5.4/libavc1394/avc1394_vcr.c Examining data/libavc1394-0.5.4/libavc1394/avc1394_internal.h Examining data/libavc1394-0.5.4/libavc1394/avc1394_vcr.h Examining data/libavc1394-0.5.4/libavc1394/avc1394.h Examining data/libavc1394-0.5.4/libavc1394/avc1394_simple.c Examining data/libavc1394-0.5.4/libavc1394/avc1394_internal.c Examining data/libavc1394-0.5.4/test/avc_vcr.c Examining data/libavc1394-0.5.4/test/mkrfc2734.c Examining data/libavc1394-0.5.4/test/setrom.c Examining data/libavc1394-0.5.4/test/dvcont.c Examining data/libavc1394-0.5.4/test/panelctl.c Examining data/libavc1394-0.5.4/test/romtest.c Examining data/libavc1394-0.5.4/acconfig.h FINAL RESULTS: data/libavc1394-0.5.4/librom1394/rom1394_main.c:135:7: [4] (buffer) strcpy: Does not check for buffer overflows when copying to destination [MS-banned] (CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy easily misused). strcpy ( p, dir->textual_leafs[i]); data/libavc1394-0.5.4/test/avc_vcr.c:383:4: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf( not_compatible ); data/libavc1394-0.5.4/test/avc_vcr.c:388:4: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf( not_loaded ); data/libavc1394-0.5.4/test/mkrfc2734.c:44:5: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(not_compatible); data/libavc1394-0.5.4/test/mkrfc2734.c:47:5: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(not_loaded); data/libavc1394-0.5.4/test/setrom.c:44:5: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(not_compatible); data/libavc1394-0.5.4/test/setrom.c:47:5: [4] (format) printf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. printf(not_loaded); data/libavc1394-0.5.4/libavc1394/avc1394_internal.c:97:4: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(fr->data, data, length); data/libavc1394-0.5.4/libavc1394/avc1394_simple.c:501:2: [2] (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. memcpy(r, data, length); data/libavc1394-0.5.4/libavc1394/avc1394_vcr.c:289:3: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(output, "%2.2x:%2.2x:%2.2x:%2.2x", data/libavc1394-0.5.4/libavc1394/avc1394_vcr.c:316:2: [2] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. Risk is low because the source has a constant maximum length. sprintf(output, "%2.2x:%2.2x:%2.2x:%2.2x", data/libavc1394-0.5.4/test/dvcont.c:86:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char timecode[12]; data/libavc1394-0.5.4/test/dvcont.c:164:25: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). speed = atoi(argv[(i+1)]); data/libavc1394-0.5.4/test/dvcont.c:226:13: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). device = atoi(argv[(i+1)]); data/libavc1394-0.5.4/test/mkrfc2734.c:38:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char *(leaf[2]); data/libavc1394-0.5.4/test/panelctl.c:323:12: [2] (integer) atoi: Unless checked, the resulting number can exceed the expected range (CWE-190). If source untrusted, check both minimum and maximum, even if the input had no minus sign (large numbers can roll over into negative number; consider saving to an unsigned value if that is intended). channel = atoi(input); data/libavc1394-0.5.4/librom1394/rom1394_internal.c:276:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length = (strlen(s) + 3) /4; data/libavc1394-0.5.4/librom1394/rom1394_internal.c:302:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). length = (strlen(s) + 3) /4; data/libavc1394-0.5.4/librom1394/rom1394_main.c:131:38: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (dir->textual_leafs[i]) j += (strlen(dir->textual_leafs[i]) + 1); data/libavc1394-0.5.4/librom1394/rom1394_main.c:136:12: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(dir->textual_leafs[i]); data/libavc1394-0.5.4/test/panelctl.c:223:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(desc)) { data/libavc1394-0.5.4/test/panelctl.c:226:27: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). for (n = 16; n > strlen(cmd); --n) { printf(" "); } data/libavc1394-0.5.4/test/panelctl.c:346:5: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(100000); // small delay for button to register data/libavc1394-0.5.4/test/panelctl.c:371:5: [1] (obsolete) usleep: This C routine is considered obsolete (as opposed to the shell command by the same name). The interaction of this function with SIGALRM and other timer functions such as sleep(), alarm(), setitimer(), and nanosleep() is unspecified (CWE-676). Use nanosleep(2) or setitimer(2) instead. usleep(100000); // small delay for button to register data/libavc1394-0.5.4/test/setrom.c:72:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). i = strlen(dir.textual_leafs[0]); data/libavc1394-0.5.4/test/setrom.c:73:2: [1] (buffer) strncpy: Easily used incorrectly; doesn't always \0-terminate or check for invalid pointers [MS-banned] (CWE-120). Risk is low because the source is a constant string. strncpy(dir.textual_leafs[0], "Kino Rocks! ", i); ANALYSIS SUMMARY: Hits = 26 Lines analyzed = 4023 in approximately 0.21 seconds (19567 lines/second) Physical Source Lines of Code (SLOC) = 2945 Hits@level = [0] 183 [1] 10 [2] 9 [3] 0 [4] 7 [5] 0 Hits@level+ = [0+] 209 [1+] 26 [2+] 16 [3+] 7 [4+] 7 [5+] 0 Hits/KSLOC@level+ = [0+] 70.9677 [1+] 8.82852 [2+] 5.43294 [3+] 2.37691 [4+] 2.37691 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.