Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler.
Number of rules (primarily dangerous function names) in C/C++ ruleset: 223
Examining data/libdmapsharing-2.9.41/tests/vala-dmap-db.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-server.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-container-record.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-db.h
Examining data/libdmapsharing-2.9.41/tests/vala-dpap-record.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-container-record.h
Examining data/libdmapsharing-2.9.41/tests/vala-dmap-container-db.c
Examining data/libdmapsharing-2.9.41/tests/dpapview.c
Examining data/libdmapsharing-2.9.41/tests/unit-test.c
Examining data/libdmapsharing-2.9.41/tests/dacplisten.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-client.c
Examining data/libdmapsharing-2.9.41/tests/dmapserve.c
Examining data/libdmapsharing-2.9.41/tests/dmapcopy.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-db.c
Examining data/libdmapsharing-2.9.41/tests/test-dmap-container-db.h
Examining data/libdmapsharing-2.9.41/tests/test-dmap-container-db.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-wav-input-stream.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-qt-input-stream.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-connection.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-db.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-container-db.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/gst-util.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-dpap-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-connection.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-qt-input-stream.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-input-stream.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-utils.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-avahi.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-daap-record-factory.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-connection.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-utils.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-share.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-container-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-enums.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-player.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-connection.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-daap-record.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/gst-util.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-player.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-connection.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-dpap-record-factory.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-avahi.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-input-stream.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-share.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-db.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-daap-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-record-factory.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-record-factory.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-mp3-input-stream.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-private-utils.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-share.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-share.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dpap-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-dpap-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/daap-connection.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-dpap-record-factory.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-mp3-input-stream.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-share.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-avahi.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-dnssd.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-container-db.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-avahi.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-connection.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/test-daap-record-factory.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-config.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-container-record.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-enums.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-gst-wav-input-stream.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.h
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-share.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dmap-private-utils.c
Examining data/libdmapsharing-2.9.41/libdmapsharing/dacp-connection.h
FINAL RESULTS:
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-dnssd.c:147:4: [4] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused).
strcat(name, dns_name);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-avahi.c:491:15: [3] (buffer) getenv:
Environment variables are untrustable input if they can be set by an
attacker. They can have any content and length, and the same variable can
be set more than once (CWE-807, CWE-20). Check environment variables
carefully before using them.
if (local && getenv ("LIBDMAPSHARING_ENABLE_LOCAL") == NULL) {
data/libdmapsharing-2.9.41/libdmapsharing/dmap-share.c:827:7: [3] (random) g_random_int:
This function is not sufficiently random for security-related functions
such as key and nonce creation (CWE-327). Use a more secure technique for
acquiring random values.
id = g_random_int ();
data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.c:808:26: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
gint revision_number = atoi (revision);
data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.c:845:12: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
width = atoi (g_hash_table_lookup (query, "mw"));
data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.c:847:13: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
height = atoi (g_hash_table_lookup (query, "mh"));
data/libdmapsharing-2.9.41/libdmapsharing/dacp-share.c:919:5: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
atoi (g_hash_table_lookup (query, "index"));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-connection.c:1579:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char hash[33] = { 0 };
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:116:4: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (p, buf, len);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:119:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (p, buf, t);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:128:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ctx->in, buf, 64);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:137:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (ctx->in, buf, len);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:141:48: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
DMAP_MD5Final (DMAPHashContext * ctx, unsigned char digest[16])
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:180:2: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy (digest, ctx->buf, 16);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:298:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char staticHash_42[256 * 65] = { 0 };
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:299:17: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
static unsigned char staticHash_45[256 * 65] = { 0 };
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:324:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[16];
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:384:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[16];
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:444:11: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char buf[16];
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:474:3: [2] (buffer) sprintf:
Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or
vsnprintf. Risk is low because the source has a constant maximum length.
sprintf (scribble, "%u", request_id);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:505:44: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char digest[16])
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.h:34:18: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char in[64];
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.h:45:48: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
unsigned char digest[16]);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:96:3: [2] (buffer) memcpy:
Does not check for buffer overflows when copying to destination (CWE-120).
Make sure destination can always hold the source data.
memcpy(txt_record + i, *txt_records, len);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:102:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(txt_record + i, "Password=true");
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:104:3: [2] (buffer) strcpy:
Does not check for buffer overflows when copying to destination [MS-banned]
(CWE-120). Consider using snprintf, strcpy_s, or strlcpy (warning: strncpy
easily misused). Risk is low because the source is a constant string.
strcpy(txt_record + i, "Password=false");
data/libdmapsharing-2.9.41/tests/test-dmap-client.c:77:2: [2] (buffer) char:
Statically-sized arrays can be improperly restricted, leading to potential
overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use
functions that limit length, or ensure that the size is larger than the
maximum possible length.
char *username, password[BUFSIZ + 1], *rc;
data/libdmapsharing-2.9.41/tests/test-dmap-client.c:135:21: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn_type = atoi (argv[1]);
data/libdmapsharing-2.9.41/tests/test-dmap-server.c:109:15: [2] (integer) atoi:
Unless checked, the resulting number can exceed the expected range
(CWE-190). If source untrusted, check both minimum and maximum, even if the
input had no minus sign (large numbers can roll over into negative number;
consider saving to an unsigned value if that is intended).
conn_type = atoi (argv[1]);
data/libdmapsharing-2.9.41/libdmapsharing/daap-connection.c:257:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->size = strlen(value);
data/libdmapsharing-2.9.41/libdmapsharing/daap-record.c:236:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return DAAP_RECORD_GET_INTERFACE (record)->read (record, err);
data/libdmapsharing-2.9.41/libdmapsharing/daap-record.h:73:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
GInputStream *(*read) (DAAPRecord * record, GError ** err);
data/libdmapsharing-2.9.41/libdmapsharing/daap-share.c:862:23: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
s = range_header + strlen ("bytes="); /* bytes= */
data/libdmapsharing-2.9.41/libdmapsharing/dmap-db.c:139:14: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
if (token[strlen (token) - 1] == '\\') {
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:329:77: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define MD5_STRUPDATE(str) DMAP_MD5Update(&ctx, (unsigned char const *)str, strlen(str))
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:389:77: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
#define MD5_STRUPDATE(str) DMAP_MD5Update(&ctx, (unsigned char const *)str, strlen(str))
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:459:29: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
DMAP_MD5Update (&ctx, url, strlen ((const gchar *) url));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:461:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen (ac); i++) {
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:467:45: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
DMAP_MD5Update (&ctx, (const guchar *) ac, strlen (ac));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:476:5: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen (scribble));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:514:19: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
for (i = 0; i < strlen (ac); i++) {
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:520:48: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
DMAP_MD5Update (context, (const guchar *) ac, strlen (ac));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-md5.c:536:67: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
fail_unless (! memcmp (hash, "798A9D80B6F08E339603BE83E0FEAD03", strlen ("798A9D80B6F08E339603BE83E0FEAD03")));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-dnssd.c:135:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
char *name = calloc(strlen(dns_name) + 1, sizeof(char));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-dnssd.c:144:4: [1] (buffer) strncat:
Easily used incorrectly (e.g., incorrectly computing the correct maximum
size to add) [MS-banned] (CWE-120). Consider strcat_s, strlcat, snprintf,
or automatically resizing strings.
strncat(name, dns_name, space - dns_name);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-browser-dnssd.c:145:4: [1] (buffer) strcat:
Does not check for buffer overflows when concatenating to destination
[MS-banned] (CWE-120). Consider using strcat_s, strncat, strlcat, or
snprintf (warning: strncat is easily misused). Risk is low because the
source is a constant character.
strcat(name, " ");
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:74:15: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
*txt_len += strlen(*_txt_records) + 1; // + 1 for req. len.
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:80:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
password_size = (char) strlen("Password=true") + 1;
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:82:26: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
password_size = (char) strlen("Password=false") + 1;
data/libdmapsharing-2.9.41/libdmapsharing/dmap-mdns-publisher-dnssd.c:90:16: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
size_t len = strlen(*txt_records);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:471:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
strlen (s));
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:646:18: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->size = strlen (s);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:808:17: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
item->size = strlen (s);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:917:2: [1] (buffer) strncpy:
Easily used incorrectly; doesn't always \0-terminate or check for invalid
pointers [MS-banned] (CWE-120).
strncpy (u.str, str, 4);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:966:12: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
g_assert (strlen(cc_defs[item->content_code].string) == 4);
data/libdmapsharing-2.9.41/libdmapsharing/dmap-structure.c:969:22: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
return item->size + strlen(cc_defs[item->content_code].string) + sizeof(item->size);
data/libdmapsharing-2.9.41/libdmapsharing/dpap-record.c:163:45: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
return DPAP_RECORD_GET_INTERFACE (record)->read (record, err);
data/libdmapsharing-2.9.41/libdmapsharing/dpap-record.h:71:18: [1] (buffer) read:
Check buffer boundaries if used in a loop including recursive loops
(CWE-120, CWE-20).
GInputStream *(*read) (DPAPRecord * record, GError ** err);
data/libdmapsharing-2.9.41/tests/test-dmap-client.c:86:11: [1] (buffer) strlen:
Does not handle strings that are not \0-terminated; if given one it may
perform an over-read (it could cause a crash if unprotected) (CWE-126).
password[strlen(password) - 1] = 0x00; // Remove newline.
ANALYSIS SUMMARY:
Hits = 59
Lines analyzed = 22010 in approximately 0.55 seconds (40330 lines/second)
Physical Source Lines of Code (SLOC) = 15742
Hits@level = [0] 14 [1] 30 [2] 26 [3] 2 [4] 1 [5] 0
Hits@level+ = [0+] 73 [1+] 59 [2+] 29 [3+] 3 [4+] 1 [5+] 0
Hits/KSLOC@level+ = [0+] 4.63728 [1+] 3.74794 [2+] 1.84221 [3+] 0.190573 [4+] 0.0635243 [5+] 0
Dot directories skipped = 1 (--followdotdir overrides)
Minimum risk level = 1
Not every hit is necessarily a security vulnerability.
There may be other security vulnerabilities; review your code!
See 'Secure Programming HOWTO'
(https://dwheeler.com/secure-programs) for more information.