Flawfinder version 2.0.10, (C) 2001-2019 David A. Wheeler. Number of rules (primarily dangerous function names) in C/C++ ruleset: 223 Examining data/libdockapp-0.7.3/examples/rectangles/rectangles.c Examining data/libdockapp-0.7.3/examples/basic/basic.c Examining data/libdockapp-0.7.3/src/misc.h Examining data/libdockapp-0.7.3/src/wmgeneral.c Examining data/libdockapp-0.7.3/src/darect.c Examining data/libdockapp-0.7.3/src/misc.c Examining data/libdockapp-0.7.3/src/damain.c Examining data/libdockapp-0.7.3/src/list.h Examining data/libdockapp-0.7.3/src/dapixmap.c Examining data/libdockapp-0.7.3/src/wmgeneral.h Examining data/libdockapp-0.7.3/src/dockapp.h Examining data/libdockapp-0.7.3/src/daargs.h Examining data/libdockapp-0.7.3/src/dautil.c Examining data/libdockapp-0.7.3/src/daevent.c Examining data/libdockapp-0.7.3/src/dacolor.c Examining data/libdockapp-0.7.3/src/dacallback.c Examining data/libdockapp-0.7.3/src/dautil.h Examining data/libdockapp-0.7.3/src/dashaped.c Examining data/libdockapp-0.7.3/src/daargs.c Examining data/libdockapp-0.7.3/src/list.c FINAL RESULTS: data/libdockapp-0.7.3/src/dapixmap.c:139:6: [4] (race) access: This usually indicates a security flaw. If an attacker can change anything along the path between the call to access() and the file's actual use (e.g., by moving files), the attacker can exploit the race condition (CWE-362/CWE-367!). Set up the correct permissions (e.g., using setuid()) and try to open the file directly. if (access(filename, R_OK) < 0) data/libdockapp-0.7.3/src/dautil.c:188:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(w_fmt, "%s: %s: %s\n", _daContext->programName, label, fmt); data/libdockapp-0.7.3/src/dautil.c:191:3: [4] (buffer) sprintf: Does not check for buffer overflows (CWE-120). Use sprintf_s, snprintf, or vsnprintf. sprintf(w_fmt, "%s\n", fmt); data/libdockapp-0.7.3/src/dautil.c:195:2: [4] (format) vfprintf: If format strings can be influenced by an attacker, they can be exploited (CWE-134). Use a constant for the format specification. vfprintf(stderr, w_fmt, args); data/libdockapp-0.7.3/src/misc.c:167:9: [4] (shell) execvp: This causes a new program to execute and is difficult to use safely (CWE-78). try using a library call that implements the same functionality if available. execvp(argv[0], args); data/libdockapp-0.7.3/examples/basic/basic.c:112:2: [3] (random) srandom: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. srandom(time(NULL)); data/libdockapp-0.7.3/examples/basic/basic.c:167:19: [3] (random) random: This function is not sufficiently random for security-related functions such as key and nonce creation (CWE-327). Use a more secure technique for acquiring random values. signed int var = random() % 3 - 1; data/libdockapp-0.7.3/examples/rectangles/rectangles.c:246:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char dashList[2] = {3, 1}; data/libdockapp-0.7.3/examples/rectangles/rectangles.c:594:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char label[3]; data/libdockapp-0.7.3/src/daargs.c:302:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char blank[30]; data/libdockapp-0.7.3/src/damain.c:137:2: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char class[100]; data/libdockapp-0.7.3/src/wmgeneral.c:124:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(filename, "r"); data/libdockapp-0.7.3/src/wmgeneral.c:126:3: [2] (buffer) char: Statically-sized arrays can be improperly restricted, leading to potential overflows or other issues (CWE-119!/CWE-120). Perform bounds checking, use functions that limit length, or ensure that the size is larger than the maximum possible length. char temp[128]; data/libdockapp-0.7.3/src/wmgeneral.c:166:7: [2] (misc) fopen: Check when opening files - can an attacker redirect it (via symlinks), force the opening of special file type (e.g., device files), move things around to create a race condition, control its ancestors, or change its contents? (CWE-362). fp = fopen(filename, "r"); data/libdockapp-0.7.3/src/daargs.c:122:6: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). if (strlen(needle) == 2 && needle[0] == '-') { data/libdockapp-0.7.3/src/dautil.c:187:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). w_fmt = malloc((strlen(_daContext->programName) + strlen(fmt) + 13) * sizeof(char)); data/libdockapp-0.7.3/src/dautil.c:187:53: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). w_fmt = malloc((strlen(_daContext->programName) + strlen(fmt) + 13) * sizeof(char)); data/libdockapp-0.7.3/src/dautil.c:190:19: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). w_fmt = malloc((strlen(fmt) + 1) * sizeof(char)); data/libdockapp-0.7.3/src/misc.c:68:22: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). t = ret = malloc(strlen(word)+1); data/libdockapp-0.7.3/src/wmgeneral.c:143:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(keys[key].label); data/libdockapp-0.7.3/src/wmgeneral.c:177:11: [1] (buffer) strlen: Does not handle strings that are not \0-terminated; if given one it may perform an over-read (it could cause a crash if unprotected) (CWE-126). p += strlen(keys[key].label); ANALYSIS SUMMARY: Hits = 21 Lines analyzed = 3876 in approximately 0.15 seconds (25025 lines/second) Physical Source Lines of Code (SLOC) = 2168 Hits@level = [0] 26 [1] 7 [2] 7 [3] 2 [4] 5 [5] 0 Hits@level+ = [0+] 47 [1+] 21 [2+] 14 [3+] 7 [4+] 5 [5+] 0 Hits/KSLOC@level+ = [0+] 21.679 [1+] 9.68635 [2+] 6.45756 [3+] 3.22878 [4+] 2.30627 [5+] 0 Dot directories skipped = 1 (--followdotdir overrides) Minimum risk level = 1 Not every hit is necessarily a security vulnerability. There may be other security vulnerabilities; review your code! See 'Secure Programming HOWTO' (https://dwheeler.com/secure-programs) for more information.